HappenLee commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1107166746
##########
be/src/exec/data_sink.cpp:
##########
@@ -177,6 +177,146 @@ Status DataSink::create_data_sink(ObjectPool* pool, const
TDataSink& thrift_sink
return Status::OK();
}
+Status DataSink::create_data_sink(ObjectPool* pool, const TDataSink&
thrift_sink,
+ const std::vector<TExpr>& output_exprs,
+ const TPipelineParams& params, const size_t&
local_param_idx,
+ const RowDescriptor& row_desc, RuntimeState*
state,
+ std::unique_ptr<DataSink>* sink,
DescriptorTbl& desc_tbl) {
+ DataSink* tmp_sink = nullptr;
+ TPipelineLocalParams local_params = params.local_params[local_param_idx];
Review Comment:
here may be do copy？ use `const auto&`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
