xy720 commented on code in PR #16776:
URL: https://github.com/apache/doris/pull/16776#discussion_r1106747039
##########
be/src/vec/data_types/data_type_map.cpp:
##########
@@ -21,13 +21,22 @@
#include "vec/columns/column_array.h"
#include "vec/columns/column_map.h"
#include "vec/common/assert_cast.h"
-#include "vec/data_types/data_type_factory.hpp"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_nullable.h"
namespace doris::vectorized {
DataTypeMap::DataTypeMap(const DataTypePtr& keys_, const DataTypePtr& values_)
{
- key_type = keys_;
- value_type = values_;
+ if (!keys_->is_nullable()) {
Review Comment:
use make_nullable directly here
##########
be/src/vec/data_types/data_type_factory.cpp:
##########
@@ -170,8 +170,8 @@ DataTypePtr DataTypeFactory::create_data_type(const
TypeDescriptor& col_desc, bo
case TYPE_MAP:
DCHECK(col_desc.children.size() == 2);
nested = std::make_shared<vectorized::DataTypeMap>(
- create_data_type(col_desc.children[0],
col_desc.contains_nulls[0]),
- create_data_type(col_desc.children[1],
col_desc.contains_nulls[1]));
+ create_data_type(col_desc.children[0], false),
Review Comment:
Why false? It seems should be true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
