[GitHub] [incubator-doris] yangzhg merged pull request #6538: [BUG] fix bugs with string type
yangzhg merged pull request #6538: URL: https://github.com/apache/incubator-doris/pull/6538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [BUG] fix bugs with string type (#6538)
This is an automated email from the ASF dual-hosted git repository.
yangzhg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 9f7d4cf [BUG] fix bugs with string type (#6538)
9f7d4cf is described below
commit 9f7d4cf741ea92db96a182c918f22ec404507a19
Author: Zhengguo Yang
AuthorDate: Wed Sep 1 15:59:55 2021 +0800
[BUG] fix bugs with string type (#6538)
* fix bugs with string type
1. not support string with agg type min/max
2. agg_update with large string may coredump
3. stringval with large string may coredump
4. not support string as partition key
---
be/src/olap/field.h | 9 +
be/src/runtime/free_pool.hpp | 12 ++--
be/src/runtime/row_batch.cpp | 8
.../src/main/java/org/apache/doris/analysis/LiteralExpr.java | 1 +
.../main/java/org/apache/doris/catalog/AggregateType.java| 2 ++
.../java/org/apache/doris/catalog/ListPartitionInfo.java | 2 +-
.../src/main/java/org/apache/doris/catalog/PartitionKey.java | 1 +
.../org/apache/doris/analysis/CreateRoutineLoadStmtTest.java | 8
8 files changed, 32 insertions(+), 11 deletions(-)
diff --git a/be/src/olap/field.h b/be/src/olap/field.h
index 60cd4c1..f2f1129 100644
--- a/be/src/olap/field.h
+++ b/be/src/olap/field.h
@@ -85,6 +85,15 @@ public:
inline void agg_update(RowCursorCell* dest, const RowCursorCell& src,
MemPool* mem_pool = nullptr) const {
+if (type() == OLAP_FIELD_TYPE_STRING && mem_pool == nullptr) {
+auto dst_slice =
reinterpret_cast(dest->mutable_cell_ptr());
+auto src_slice = reinterpret_cast(src.cell_ptr());
+if (dst_slice->size < src_slice->size) {
+*_long_text_buf = static_cast(realloc(*_long_text_buf,
src_slice->size));
+dst_slice->data = *_long_text_buf;
+dst_slice->size = src_slice->size;
+}
+}
_agg_info->update(dest, src, mem_pool);
}
diff --git a/be/src/runtime/free_pool.hpp b/be/src/runtime/free_pool.hpp
old mode 100755
new mode 100644
index 0f4aad3..379d254
--- a/be/src/runtime/free_pool.hpp
+++ b/be/src/runtime/free_pool.hpp
@@ -20,7 +20,9 @@
#include
#include
+
#include
+
#include "common/logging.h"
#include "runtime/mem_pool.h"
#include "util/bit_util.h"
@@ -44,9 +46,7 @@ class FreePool {
public:
// C'tor, initializes the FreePool to be empty. All allocations come from
the
// 'mem_pool'.
-FreePool(MemPool* mem_pool) : _mem_pool(mem_pool) {
-memset(&_lists, 0, sizeof(_lists));
-}
+FreePool(MemPool* mem_pool) : _mem_pool(mem_pool) { memset(&_lists, 0,
sizeof(_lists)); }
virtual ~FreePool() {}
@@ -65,9 +65,9 @@ public:
if (allocation == NULL) {
// There wasn't an existing allocation of the right size, allocate
a new one.
-size = 1 << free_list_idx;
+size = 1L << free_list_idx;
allocation = reinterpret_cast(
- _mem_pool->allocate(size + sizeof(FreeListNode)));
+_mem_pool->allocate(size + sizeof(FreeListNode)));
} else {
// Remove this allocation from the list.
_lists[free_list_idx].next = allocation->next;
@@ -158,6 +158,6 @@ private:
FreeListNode _lists[NUM_LISTS];
};
-}
+} // namespace doris
#endif
diff --git a/be/src/runtime/row_batch.cpp b/be/src/runtime/row_batch.cpp
index bf2ee39..41b303d 100644
--- a/be/src/runtime/row_batch.cpp
+++ b/be/src/runtime/row_batch.cpp
@@ -20,14 +20,14 @@
#include
#include // for intptr_t
+#include "gen_cpp/Data_types.h"
+#include "gen_cpp/data.pb.h"
#include "runtime/buffered_tuple_stream2.inline.h"
+#include "runtime/collection_value.h"
#include "runtime/exec_env.h"
#include "runtime/runtime_state.h"
#include "runtime/string_value.h"
#include "runtime/tuple_row.h"
-#include "gen_cpp/Data_types.h"
-#include "gen_cpp/data.pb.h"
-#include "runtime/collection_value.h"
//#include "vec/columns/column_vector.h"
//#include "vec/core/block.h"
@@ -478,7 +478,7 @@ int RowBatch::serialize(PRowBatch* output_batch) {
if (config::compress_rowbatches && size > 0) {
// Try compressing tuple_data to _compression_scratch, swap if
compressed data is
// smaller
-int max_compressed_size = snappy::MaxCompressedLength(size);
+uint32_t max_compressed_size = snappy::MaxCompressedLength(size);
if (_compression_scratch.size() < max_compressed_size) {
_compression_scratch.resize(max_compressed_size);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/LiteralExpr.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/LiteralExpr.java
index 1665a4b..6e435c
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6504: [Feature]support three functions of json
yangzhg commented on a change in pull request #6504:
URL: https://github.com/apache/incubator-doris/pull/6504#discussion_r699980646
##
File path: be/src/exprs/json_functions.cpp
##
@@ -108,6 +109,96 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext*
context, const StringV
}
}
+StringVal JsonFunctions::json_array(FunctionContext* context, int num_args,
+const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Value array_obj(rapidjson::kArrayType);
+rapidjson::Document document;
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+//flag: The number it contains represents the type of previous parameters
+StringVal flag(json_str[num_args - 1].ptr, json_str[num_args - 1].len);
Review comment:
```suggestion
StringVal* flag = json_str[num_args - 1];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6504: [Feature]support three functions of json
yangzhg commented on a change in pull request #6504:
URL: https://github.com/apache/incubator-doris/pull/6504#discussion_r699981146
##
File path: be/src/exprs/json_functions.cpp
##
@@ -108,6 +109,96 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext*
context, const StringV
}
}
+StringVal JsonFunctions::json_array(FunctionContext* context, int num_args,
+const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Value array_obj(rapidjson::kArrayType);
+rapidjson::Document document;
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+//flag: The number it contains represents the type of previous parameters
+StringVal flag(json_str[num_args - 1].ptr, json_str[num_args - 1].len);
+DCHECK_EQ(num_args - 1, flag.len);
+for (int i = 0; i < num_args - 1; ++i) {
+StringVal arg(json_str[i].ptr, json_str[i].len);
+rapidjson::Value val = parse_str_with_flag(arg, flag, i, allocator);
Review comment:
```suggestion
rapidjson::Value val = parse_str_with_flag(arg, *flag, i, allocator);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
qzsee commented on pull request #6526: URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910058088 > This bug has been fixed in new version Yesterday, I tested the latest master branch and did not have this problem. However, version 0.14 still has this problem. Aren't we going to fix this bug in 0.14? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
qzsee commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910064230
> ```c++
> Status ExprContext::prepare(RuntimeState* state, const RowDescriptor&
row_desc,
> const std::shared_ptr& tracker) {
> _prepared = true;
> ...
> }
>
> Status ExprContext::open(RuntimeState* state) {
> DCHECK(_prepared);
> ...
> }
> ```
>
> Maybe you can refer to the `ExprContext` method to avoid repeatedly
calling prepare by mistake?
The process of preparing is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6539: Support concurrent export of query results
EmmyMiao87 commented on a change in pull request #6539:
URL: https://github.com/apache/incubator-doris/pull/6539#discussion_r68628
##
File path: be/src/runtime/file_result_writer.cpp
##
@@ -39,13 +42,36 @@ namespace doris {
const size_t FileResultWriter::OUTSTREAM_BUFFER_SIZE_BYTES = 1024 * 1024;
+// deprecated
FileResultWriter::FileResultWriter(const ResultFileOptions* file_opts,
const std::vector&
output_expr_ctxs,
RuntimeProfile* parent_profile,
BufferControlBlock* sinker)
: _file_opts(file_opts),
_output_expr_ctxs(output_expr_ctxs),
_parent_profile(parent_profile),
- _sinker(sinker) {}
+ _sinker(sinker) {
+if (_file_opts->is_local_file) {
+_storage_type = TStorageBackendType::LOCAL;
+} else {
+_storage_type = TStorageBackendType::BROKER;
+}
+_fragment_instance_id.hi = 12345678987654321;
Review comment:
In order to be compatible with the old version of Fe and the new version
of be
##
File path: be/src/runtime/file_result_writer.h
##
@@ -31,6 +32,7 @@ class RuntimeProfile;
class TupleRow;
struct ResultFileOptions {
+// deprecated
bool is_local_file;
Review comment:
For compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee edited a comment on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
qzsee edited a comment on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910064230
> ```c++
> Status ExprContext::prepare(RuntimeState* state, const RowDescriptor&
row_desc,
> const std::shared_ptr& tracker) {
> _prepared = true;
> ...
> }
>
> Status ExprContext::open(RuntimeState* state) {
> DCHECK(_prepared);
> ...
> }
> ```
>
> Maybe you can refer to the `ExprContext` method to avoid repeatedly
calling prepare by mistake?
The prepare method is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on issue #6525: [BUG] Join query result is unstable when the predicate is pushed down to exchange node
qzsee commented on issue #6525: URL: https://github.com/apache/incubator-doris/issues/6525#issuecomment-910067507 > 新版本的 runtime filter 取消了这部分逻辑了。所以新版本没问题。 > 旧版本的 runtime filter 确实有可能有你这个问题。 是的，但是新版本的runtime filter，也有IN类型的过滤，这部分同样有复制谓词的过程，如果_tuple_idx不清空，不太清楚有些特别的查询是否继续命中这种bug。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6539: Support concurrent export of query results
EmmyMiao87 commented on a change in pull request #6539:
URL: https://github.com/apache/incubator-doris/pull/6539#discussion_r68628
##
File path: be/src/runtime/file_result_writer.cpp
##
@@ -39,13 +42,36 @@ namespace doris {
const size_t FileResultWriter::OUTSTREAM_BUFFER_SIZE_BYTES = 1024 * 1024;
+// deprecated
FileResultWriter::FileResultWriter(const ResultFileOptions* file_opts,
const std::vector&
output_expr_ctxs,
RuntimeProfile* parent_profile,
BufferControlBlock* sinker)
: _file_opts(file_opts),
_output_expr_ctxs(output_expr_ctxs),
_parent_profile(parent_profile),
- _sinker(sinker) {}
+ _sinker(sinker) {
+if (_file_opts->is_local_file) {
+_storage_type = TStorageBackendType::LOCAL;
+} else {
+_storage_type = TStorageBackendType::BROKER;
+}
+_fragment_instance_id.hi = 12345678987654321;
Review comment:
In order to be compatible with the old version of Fe and the new version
of be
##
File path: be/src/runtime/file_result_writer.h
##
@@ -31,6 +32,7 @@ class RuntimeProfile;
class TupleRow;
struct ResultFileOptions {
+// deprecated
bool is_local_file;
Review comment:
For compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6416: #6386 Enforce null check at Catalog.getDb and Database.getTable
caiconghui commented on a change in pull request #6416: URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r699112144 ## File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java ## @@ -260,17 +251,11 @@ private void processModifyColumnComment(Database db, OlapTable tbl, List
[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #6540: fe
zbtzbtzbt commented on pull request #6540: URL: https://github.com/apache/incubator-doris/pull/6540#issuecomment-909908624 you can add some descriptions about this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zhao447131724 closed issue #6537: Connect to doris failed.
zhao447131724 closed issue #6537: URL: https://github.com/apache/incubator-doris/issues/6537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on issue #6535: doris中的建立的前缀索引限定36byte，和遇到varchar截断
caiconghui commented on issue #6535: URL: https://github.com/apache/incubator-doris/issues/6535#issuecomment-909949619 you can put this question to github discussion https://github.com/apache/incubator-doris/discussions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] crazy2323 closed issue #6530: Build failed in centos
crazy2323 closed issue #6530: URL: https://github.com/apache/incubator-doris/issues/6530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
BiteThet commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-909937505
```cpp
Status ExprContext::prepare(RuntimeState* state, const RowDescriptor&
row_desc,
const std::shared_ptr& tracker) {
_prepared = true;
...
}
Status ExprContext::open(RuntimeState* state) {
DCHECK(_prepared);
...
}
```
Maybe you can refer to the `ExprContext` method to avoid repeatedly calling
prepare by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6455: [CodeRefactor]Remove useless code for Segment V2
github-actions[bot] commented on pull request #6455: URL: https://github.com/apache/incubator-doris/pull/6455#issuecomment-909818793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on issue #6498: Uniq 模型支持REPLACE外，能否支持 abandon
yangzhg commented on issue #6498: URL: https://github.com/apache/incubator-doris/issues/6498#issuecomment-909805608 I will evaluate this feature later, and you are welcome to contribute to this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #6540: fe
EmmyMiao87 commented on pull request #6540: URL: https://github.com/apache/incubator-doris/pull/6540#issuecomment-909917654 Your pr contains more than 30,000 lines of code, but there is no commit msg, so this won't work. And the title is too big. It is best to submit them separately, or write clearly detailed pr changes. Each pr also needs to have a separate issue. Explain the background, function, and detailed design -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6102: WIP: Support create table as select
morningman commented on a change in pull request #6102:
URL: https://github.com/apache/incubator-doris/pull/6102#discussion_r699283182
##
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##
@@ -3096,6 +3104,48 @@ public void createTableLike(CreateTableLikeStmt stmt)
throws DdlException {
}
}
+public void createTableAsSelect(CreateTableAsSelectStmt stmt) throws
DdlException {
+try {
+QueryStmt tmpStmt = stmt.getQueryStmt().clone();
+List columnNames = stmt.getColumnNames();
+CreateTableStmt createTableStmt = stmt.getCreateTableStmt();
+Analyzer dummyRootAnalyzer = new Analyzer(this,
ConnectContext.get());
+tmpStmt.analyze(dummyRootAnalyzer);
+// Check columnNames
+if (columnNames != null && columnNames.size() !=
tmpStmt.getColLabels().size()) {
+ErrorReport.report(ErrorCode.ERR_COL_NUMBER_NOT_MATCH);
+} else {
+for (int i = 0; i < tmpStmt.getColLabels().size(); ++i) {
+String name;
+Expr expr = tmpStmt.getResultExprs().get(i);
+if (columnNames != null) {
+name = columnNames.get(i);
+} else {
+name = expr.toColumnLabel().replaceAll("'", "");
Review comment:
How about decimal type
##
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##
@@ -3096,6 +3104,48 @@ public void createTableLike(CreateTableLikeStmt stmt)
throws DdlException {
}
}
+public void createTableAsSelect(CreateTableAsSelectStmt stmt) throws
DdlException {
+try {
+QueryStmt tmpStmt = stmt.getQueryStmt().clone();
Review comment:
Why not put this logic in `analyze()` of `CreateTableAsSelectStmt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6504: [Feature]support three functions of json
yangzhg commented on a change in pull request #6504:
URL: https://github.com/apache/incubator-doris/pull/6504#discussion_r699800543
##
File path: be/src/exprs/json_functions.cpp
##
@@ -108,6 +108,96 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext*
context, const StringV
}
}
+StringVal JsonFunctions::json_array(FunctionContext* context, int num_args,
+const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Value array_obj(rapidjson::kArrayType);
+rapidjson::Document document;
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+//flag: The number it contains represents the type of previous parameters
+std::string flag((char*)json_str[num_args - 1].ptr, json_str[num_args -
1].len);
+DCHECK(num_args-1==flag.length());
Review comment:
```suggestion
DCHECK_EQ(num_args - 1, flag.length());
```
##
File path: be/src/exprs/json_functions.cpp
##
@@ -108,6 +108,96 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext*
context, const StringV
}
}
+StringVal JsonFunctions::json_array(FunctionContext* context, int num_args,
+const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Value array_obj(rapidjson::kArrayType);
+rapidjson::Document document;
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+//flag: The number it contains represents the type of previous parameters
+std::string flag((char*)json_str[num_args - 1].ptr, json_str[num_args -
1].len);
+DCHECK(num_args-1==flag.length());
+for (int i = 0; i < num_args - 1; ++i) {
+std::string arg((char*)json_str[i].ptr, json_str[i].len);
+rapidjson::Value val = parse_str_with_flag(arg, flag, i, allocator);
+array_obj.PushBack(val, allocator);
+}
+rapidjson::StringBuffer buf;
+rapidjson::Writer writer(buf);
+array_obj.Accept(writer);
+return AnyValUtil::from_string_temp(context, std::string(buf.GetString()));
+}
+
+StringVal JsonFunctions::json_object(FunctionContext* context, int num_args,
+ const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Document document(rapidjson::kObjectType);
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+std::string flag((char*)json_str[num_args - 1].ptr, json_str[num_args -
1].len);
Review comment:
use stringVal
##
File path: be/src/exprs/json_functions.cpp
##
@@ -108,6 +109,96 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext*
context, const StringV
}
}
+StringVal JsonFunctions::json_array(FunctionContext* context, int num_args,
+const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Value array_obj(rapidjson::kArrayType);
+rapidjson::Document document;
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+//flag: The number it contains represents the type of previous parameters
+StringVal flag(json_str[num_args - 1].ptr, json_str[num_args - 1].len);
Review comment:
```suggestion
StringVal* flag = json_str[num_args - 1];
```
##
File path: be/src/exprs/json_functions.cpp
##
@@ -108,6 +109,96 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext*
context, const StringV
}
}
+StringVal JsonFunctions::json_array(FunctionContext* context, int num_args,
+const StringVal* json_str) {
+if (json_str->is_null) {
+return StringVal::null();
+}
+rapidjson::Value array_obj(rapidjson::kArrayType);
+rapidjson::Document document;
+rapidjson::Document::AllocatorType& allocator = document.GetAllocator();
+//flag: The number it contains represents the type of previous parameters
+StringVal flag(json_str[num_args - 1].ptr, json_str[num_args - 1].len);
+DCHECK_EQ(num_args - 1, flag.len);
+for (int i = 0; i < num_args - 1; ++i) {
+StringVal arg(json_str[i].ptr, json_str[i].len);
+rapidjson::Value val = parse_str_with_flag(arg, flag, i, allocator);
Review comment:
```suggestion
rapidjson::Value val = parse_str_with_flag(arg, *flag, i, allocator);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsub
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6538: [BUG] fix bugs with string type
github-actions[bot] commented on pull request #6538: URL: https://github.com/apache/incubator-doris/pull/6538#issuecomment-909808383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #6540: fe
EmmyMiao87 commented on a change in pull request #6540:
URL: https://github.com/apache/incubator-doris/pull/6540#discussion_r699864015
##
File path: manage/www/.babelrc
##
@@ -0,0 +1,25 @@
+{
Review comment:
The code needs to meet development specifications. Such as license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
yangzhg commented on pull request #6526: URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-909935262 This bug has been fixed in new version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6524: [Doc] Update stream-load-manual.md
github-actions[bot] commented on pull request #6524: URL: https://github.com/apache/incubator-doris/pull/6524#issuecomment-909801267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6506: [Feature] Support for storage layer benchmark
github-actions[bot] commented on pull request #6506: URL: https://github.com/apache/incubator-doris/pull/6506#issuecomment-909876498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on issue #6536: doris耗资源 问题怎么配置可以解决
caiconghui commented on issue #6536: URL: https://github.com/apache/incubator-doris/issues/6536#issuecomment-909950312 you can tell more details about this issue in github discussion. https://github.com/apache/incubator-doris/discussions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee edited a comment on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
qzsee edited a comment on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910064230
> ```c++
> Status ExprContext::prepare(RuntimeState* state, const RowDescriptor&
row_desc,
> const std::shared_ptr& tracker) {
> _prepared = true;
> ...
> }
>
> Status ExprContext::open(RuntimeState* state) {
> DCHECK(_prepared);
> ...
> }
> ```
>
> Maybe you can refer to the `ExprContext` method to avoid repeatedly
calling prepare by mistake?
The prepare method is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on issue #6525: [BUG] Join query result is unstable when the predicate is pushed down to exchange node
EmmyMiao87 commented on issue #6525: URL: https://github.com/apache/incubator-doris/issues/6525#issuecomment-909941736 新版本的 runtime filter 取消了这部分逻辑了。所以新版本没问题。 旧版本的 runtime filter 确实有可能有你这个问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg edited a comment on issue #6530: Build failed in centos
yangzhg edited a comment on issue #6530: URL: https://github.com/apache/incubator-doris/issues/6530#issuecomment-909949369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on a change in pull request #6416: #6386 Enforce null check at Catalog.getDb and Database.getTable
ccoffline commented on a change in pull request #6416:
URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r699104541
##
File path:
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
##
@@ -218,9 +215,9 @@ protected void runPendingJob() throws AlterCancelException {
}
MarkedCountDownLatch countDownLatch = new
MarkedCountDownLatch<>(totalReplicaNum);
-OlapTable tbl = null;
+OlapTable tbl;
try {
-tbl = (OlapTable) db.getTableOrThrowException(tableId,
TableType.OLAP);
+tbl = db.getTableOrMetaException(tableId, TableType.OLAP);
Review comment:
This checks if the table exists and if the table is OLAP, so it might be
easier to code this way.
##
File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
##
@@ -260,17 +251,11 @@ private void processModifyColumnComment(Database db,
OlapTable tbl, List
[GitHub] [incubator-doris] zbtzbtzbt edited a comment on pull request #6540: fe
zbtzbtzbt edited a comment on pull request #6540: URL: https://github.com/apache/incubator-doris/pull/6540#issuecomment-909908624 you can add some descriptions about this pr, the title is so ambiguous -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6532: [Bug] Fix dataTables bootstrap js version differ.
yangzhg commented on a change in pull request #6532: URL: https://github.com/apache/incubator-doris/pull/6532#discussion_r699840263 ## File path: fe/fe-core/src/main/java/org/apache/doris/http/action/WebBaseAction.java ## @@ -67,12 +67,12 @@ + " rel=\"stylesheet\" media=\"screen\"/>" + " " -+ "
[GitHub] [incubator-doris] morningman commented on a change in pull request #6539: Support concurrent export of query results
morningman commented on a change in pull request #6539:
URL: https://github.com/apache/incubator-doris/pull/6539#discussion_r699833595
##
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/OutFileClause.java
##
@@ -45,6 +48,8 @@
import java.util.Set;
import java.util.stream.Collectors;
+import static org.apache.doris.backup.S3Storage.S3_PROPERTIES_PREFIX;
Review comment:
remove static import
##
File path: be/src/exec/data_sink.cpp
##
@@ -78,14 +80,29 @@ Status DataSink::create_data_sink(ObjectPool* pool, const
TDataSink& thrift_sink
}
sink->reset(tmp_sink);
break;
-case TDataSinkType::MEMORY_SCRATCH_SINK:
+}
+case TDataSinkType::RESULT_FILE_SINK: {
+if (!thrift_sink.__isset.result_file_sink) {
+return Status::InternalError("Missing result file sink.");
+}
+if (params.__isset.destinations && params.destinations.size() > 0) {
Review comment:
Add comments
##
File path: fe/fe-core/src/main/java/org/apache/doris/planner/Planner.java
##
@@ -298,9 +285,76 @@ private PlanNode addUnassignedConjuncts(Analyzer analyzer,
PlanNode root)
return selectNode;
}
+private void pushDownResultFileSink(Analyzer analyzer) {
Review comment:
Add some comments?
##
File path: fe/fe-core/src/main/java/org/apache/doris/planner/ExchangeNode.java
##
@@ -78,6 +78,13 @@ public ExchangeNode(PlanNodeId id, PlanNode inputNode,
boolean copyConjuncts) {
computeTupleIds();
}
+public boolean isMergingExchange() {
+if (planNodeName.equals(MERGING_EXCHANGE_NODE)) {
Review comment:
Use `mergeInfo` to check it better?
##
File path: be/src/runtime/file_result_writer.h
##
@@ -31,6 +32,7 @@ class RuntimeProfile;
class TupleRow;
struct ResultFileOptions {
+// deprecated
bool is_local_file;
Review comment:
Why not delete it?
##
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##
@@ -771,12 +774,17 @@ public boolean isExtractWideRangeExpr() {
return extractWideRangeExpr;
}
+<<< HEAD
Review comment:
??
##
File path: be/src/runtime/file_result_writer.cpp
##
@@ -392,7 +454,8 @@ Status FileResultWriter::close() {
// so does the profile in RuntimeState.
COUNTER_SET(_written_rows_counter, _written_rows);
SCOPED_TIMER(_writer_close_timer);
-return _close_file_writer(true);
+RETURN_IF_ERROR(_close_file_writer(true, false));
Review comment:
just return
##
File path: fe/fe-core/src/main/java/org/apache/doris/planner/Planner.java
##
@@ -298,9 +285,76 @@ private PlanNode addUnassignedConjuncts(Analyzer analyzer,
PlanNode root)
return selectNode;
}
+private void pushDownResultFileSink(Analyzer analyzer) {
+if (fragments.size() < 1) {
+return;
+}
+if (!(fragments.get(0).getSink() instanceof ResultFileSink)) {
+return;
+}
+if
(!ConnectContext.get().getSessionVariable().isEnableParallelOutfile()) {
+return;
+}
+if (!(fragments.get(0).getPlanRoot() instanceof ExchangeNode)) {
+return;
+}
+PlanFragment topPlanFragment = fragments.get(0);
+ExchangeNode topPlanNode = (ExchangeNode)
topPlanFragment.getPlanRoot();
+// try to push down result file sink
+if (topPlanNode.isMergingExchange()) {
+return;
+}
+PlanFragment secondPlanFragment = fragments.get(1);
+ResultFileSink resultFileSink = (ResultFileSink)
topPlanFragment.getSink();
+if (resultFileSink.getStorageType() ==
StorageBackend.StorageType.BROKER) {
+return;
+}
+if (secondPlanFragment.getOutputExprs() != null) {
+return;
+}
+// create result file sink desc
+TupleDescriptor fileStatusDesc =
constructFileStatusTupleDesc(analyzer);
+resultFileSink.resetByDataStreamSink((DataStreamSink)
secondPlanFragment.getSink());
+resultFileSink.setOutputTupleId(fileStatusDesc.getId());
+secondPlanFragment.setOutputExprs(topPlanFragment.getOutputExprs());
+secondPlanFragment.resetSink(resultFileSink);
+ResultSink resultSink = new ResultSink(topPlanNode.getId());
+topPlanFragment.resetSink(resultSink);
+topPlanFragment.resetOutputExprs(fileStatusDesc);
+
topPlanFragment.getPlanRoot().resetTupleIds(Lists.newArrayList(fileStatusDesc.getId()));
+}
+
+private TupleDescriptor constructFileStatusTupleDesc(Analyzer analyzer) {
Review comment:
Add some comments
##
File path: be/src/runtime/file_result_writer.cpp
##
@@ -39,13 +42,36 @@ namespace doris {
const size_t FileResultWriter::OUTSTREAM_BUFFER_SIZE_BYTES = 1024 * 1024;
+// deprecated
FileResultWriter::F
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6534: [Community] Add new template for issues
github-actions[bot] commented on pull request #6534: URL: https://github.com/apache/incubator-doris/pull/6534#issuecomment-909124987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #6534: [Community] Add new template for issues
yangzhg merged pull request #6534: URL: https://github.com/apache/incubator-doris/pull/6534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zhao447131724 removed a comment on issue #6537: Connect to doris failed.
zhao447131724 removed a comment on issue #6537: URL: https://github.com/apache/incubator-doris/issues/6537#issuecomment-908985808 直接使用mysql客户端连接是可以的，但是使用flink sql会报这个错误 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6475: [Proposal] create table like clause support copy rollup
morningman merged pull request #6475: URL: https://github.com/apache/incubator-doris/pull/6475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on issue #6535: doris中的建立的前缀索引限定36byte，和遇到varchar截断
yangzhg commented on issue #6535: URL: https://github.com/apache/incubator-doris/issues/6535#issuecomment-909948112 36字节是个经验值，varchar 截断是因为不好判断varchar 的长度 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #6538: [BUG] fix bugs with string type
yangzhg merged pull request #6538: URL: https://github.com/apache/incubator-doris/pull/6538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on issue #6530: Build failed in centos
yangzhg commented on issue #6530: URL: https://github.com/apache/incubator-doris/issues/6530#issuecomment-909949369 you shoud post all more build log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on issue #6525: [BUG] Join query result is unstable when the predicate is pushed down to exchange node
qzsee commented on issue #6525: URL: https://github.com/apache/incubator-doris/issues/6525#issuecomment-910067507 > 新版本的 runtime filter 取消了这部分逻辑了。所以新版本没问题。 > 旧版本的 runtime filter 确实有可能有你这个问题。 是的，但是新版本的runtime filter，也有IN类型的过滤，这部分同样有复制谓词的过程，如果_tuple_idx不清空，不太清楚有些特别的查询是否继续命中这种bug。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
qzsee commented on pull request #6526: URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910058088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui merged pull request #6524: [Doc] Update stream-load-manual.md
caiconghui merged pull request #6524: URL: https://github.com/apache/incubator-doris/pull/6524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6480: fix(sparkload): bitmap deep copy in `or` operator
github-actions[bot] commented on pull request #6480: URL: https://github.com/apache/incubator-doris/pull/6480#issuecomment-909083588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] crazy2323 commented on issue #6530: Build failed in centos
crazy2323 commented on issue #6530: URL: https://github.com/apache/incubator-doris/issues/6530#issuecomment-909950031 upgrade gcc version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6475: [Proposal] create table like clause support copy rollup
github-actions[bot] commented on pull request #6475: URL: https://github.com/apache/incubator-doris/pull/6475#issuecomment-909189880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6416: #6386 Enforce null check at Catalog.getDb and Database.getTable
morningman commented on a change in pull request #6416:
URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r699260553
##
File path: fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
##
@@ -667,22 +638,26 @@ private void replayCancelled(RollupJobV2 replayedJob) {
@Override
public void replay(AlterJobV2 replayedJob) {
-RollupJobV2 replayedRollupJob = (RollupJobV2) replayedJob;
-switch (replayedJob.jobState) {
-case PENDING:
-replayCreateJob(replayedRollupJob);
-break;
-case WAITING_TXN:
-replayPendingJob(replayedRollupJob);
-break;
-case FINISHED:
-replayRunningJob(replayedRollupJob);
-break;
-case CANCELLED:
-replayCancelled(replayedRollupJob);
-break;
-default:
-break;
+try {
+RollupJobV2 replayedRollupJob = (RollupJobV2) replayedJob;
+switch (replayedJob.jobState) {
+case PENDING:
+replayCreateJob(replayedRollupJob);
+break;
+case WAITING_TXN:
+replayPendingJob(replayedRollupJob);
+break;
+case FINISHED:
+replayRunningJob(replayedRollupJob);
+break;
+case CANCELLED:
+replayCancelled(replayedRollupJob);
+break;
+default:
+break;
+}
+} catch (MetaNotFoundException e) {
+LOG.warn("[INCONSISTENT META] replay rollup job failed {}",
replayedJob.getJobId(), e);
Review comment:
It is ok to add `throws MetaNotFoundException` to this method.
It is only used in replay logic
##
File path: fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
##
@@ -1048,11 +1049,17 @@ private boolean downloadAndDeserializeMetaInfo() {
}
private void replayCheckAndPrepareMeta() {
-Database db = catalog.getDb(dbId);
+Database db;
+try {
+db = catalog.getDbOrMetaException(dbId);
Review comment:
ok
##
File path: fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
##
@@ -812,10 +787,14 @@ public void gsonPostProcess() throws IOException {
return;
}
// parse the define stmt to schema
-SqlParser parser = new SqlParser(new SqlScanner(new
StringReader(origStmt.originStmt),
-
SqlModeHelper.MODE_DEFAULT));
+SqlParser parser = new SqlParser(new SqlScanner(new
StringReader(origStmt.originStmt), SqlModeHelper.MODE_DEFAULT));
ConnectContext connectContext = new ConnectContext();
-Database db = Catalog.getCurrentCatalog().getDb(dbId);
+Database db;
+try {
+db = Catalog.getCurrentCatalog().getDbOrMetaException(dbId);
+} catch (MetaNotFoundException e) {
+throw new IOException("error happens when parsing create
materialized view stmt: " + origStmt, e);
Review comment:
OK, just keep it as before.
##
File path: fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
##
@@ -667,22 +638,26 @@ private void replayCancelled(RollupJobV2 replayedJob) {
@Override
public void replay(AlterJobV2 replayedJob) {
-RollupJobV2 replayedRollupJob = (RollupJobV2) replayedJob;
-switch (replayedJob.jobState) {
-case PENDING:
-replayCreateJob(replayedRollupJob);
-break;
-case WAITING_TXN:
-replayPendingJob(replayedRollupJob);
-break;
-case FINISHED:
-replayRunningJob(replayedRollupJob);
-break;
-case CANCELLED:
-replayCancelled(replayedRollupJob);
-break;
-default:
-break;
+try {
+RollupJobV2 replayedRollupJob = (RollupJobV2) replayedJob;
+switch (replayedJob.jobState) {
+case PENDING:
+replayCreateJob(replayedRollupJob);
+break;
+case WAITING_TXN:
+replayPendingJob(replayedRollupJob);
+break;
+case FINISHED:
+replayRunningJob(replayedRollupJob);
+break;
+case CANCELLED:
+replayCancelled(replayedRollupJob);
+break;
+default:
+break;
+}
+} catch (MetaNotFoundException e) {
+LOG.warn("[INCONSISTENT META] replay rollup job failed {}",
replayedJob.getJobId(), e);
Review comment:
ok
--
This is an a
[GitHub] [incubator-doris] ccoffline closed issue #6432: [Bug] HTTP v1 GetStreamLoadState PathVariable wildcard mismatch
ccoffline closed issue #6432: URL: https://github.com/apache/incubator-doris/issues/6432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on issue #6432: [Bug] HTTP v1 GetStreamLoadState PathVariable wildcard mismatch
ccoffline commented on issue #6432: URL: https://github.com/apache/incubator-doris/issues/6432#issuecomment-910146278 fixed by #4081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
yangzhg commented on pull request #6526: URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910165007 > > This bug has been fixed in new version > > Yesterday, I tested the latest master branch and did not have this problem. However, version 0.14 still has this problem. Aren't we going to fix this bug in 0.14? you should use https://github.com/baidu/palo/releases/tag/PALO-0.14.12.4-release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] dh-cloud opened a new pull request #6544: fix bug colocate join table can't repaired
dh-cloud opened a new pull request #6544: URL: https://github.com/apache/incubator-doris/pull/6544 cluster info: 4 hosts (10.35.15.164,165,206,207), 8 bes , table with colocate_with, 3 replicas version: 0.14 we found colocate join table replica can't repaired. the tablet status is "COLOCATE_MISMATCH", schedule failed log is "unable to find dest path for new replica" show can't repaired tablet info is : 703694100081010-10-100NORMAL false-1-1http://10.35.25.165:8040/api/meta/header/703691/-1 http://10.35.25.165:8040/api/compaction/show?tablet_id=703691&schema_hash=-1 729811100041010-10-100NORMAL false-1-1http://10.35.25.207:8040/api/meta/header/703691/-1 http://10.35.25.207:8040/api/compaction/show?tablet_id=703691&schema_hash=-1 735553100031010-10-100NORMAL false-1-1http://10.35.25.206:8140/api/meta/header/703691/-1 http://10.35.25.206:8140/api/compaction/show?tablet_id=703691&schema_hash=-1 740612100061010-10-100NORMAL false-1-1http://10.35.25.164:8040/api/meta/header/703691/-1 http://10.35.25.164:8040/api/compaction/show?tablet_id=703691&schema_hash=-1 repair mis_match status tablet, need clone replica to other host , but each host already have replica, so it always schedule failed. so we set should set tablet status to COLOCATE_REDUNDANT, delete one replica, then we can repair mis_match tablet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6504: [Feature]support three functions of json
github-actions[bot] commented on pull request #6504: URL: https://github.com/apache/incubator-doris/pull/6504#issuecomment-910212271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #6518: [Enhance] Add a rewrite rule of compoundPredicate 'OR' 'AND' to hit prefix index
zbtzbtzbt commented on pull request #6518: URL: https://github.com/apache/incubator-doris/pull/6518#issuecomment-910255419 here is the final version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6416: #6386 Enforce null check at Catalog.getDb and Database.getTable
morningman commented on a change in pull request #6416:
URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r700266994
##
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
##
@@ -330,17 +329,12 @@ public void analyze(Analyzer analyzer) throws
UserException {
if (dataDescription.isLoadFromTable()) {
isLoadFromTable = true;
}
-Database db = Catalog.getCurrentCatalog().getDb(label.getDbName());
-if (db == null) {
-throw new AnalysisException("database: " + label.getDbName() +
"not found.");
-}
-Table table = db.getTable(dataDescription.getTableName());
-if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND &&
-(!(table instanceof OlapTable) || ((OlapTable)
table).getKeysType() != KeysType.UNIQUE_KEYS)) {
+Database db =
Catalog.getCurrentCatalog().getDbOrAnalysisException(label.getDbName());
+OlapTable table =
db.getOlapTableOrAnalysisException(dataDescription.getTableName());
+if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND &&
table.getKeysType() != KeysType.UNIQUE_KEYS) {
throw new AnalysisException("load by MERGE or DELETE is only
supported in unique tables.");
}
-if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND
-&& !((table instanceof OlapTable) && ((OlapTable)
table).hasDeleteSign()) ) {
+if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND &&
table.hasDeleteSign()) {
Review comment:
```suggestion
if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND
&& !table.hasDeleteSign()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] Skysheepwang opened a new issue #6545: [Feature] Discussion of Histogram Metric in Doris and a Suggestion of Improvement
Skysheepwang opened a new issue #6545: URL: https://github.com/apache/incubator-doris/issues/6545 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description http://schemas.microsoft.com/office/2004/12/omml"; xmlns="http://www.w3.org/TR/REC-html40";>