morningman commented on a change in pull request #6539:
URL: https://github.com/apache/incubator-doris/pull/6539#discussion_r700356119
##########
File path: be/src/runtime/file_result_writer.cpp
##########
@@ -39,13 +42,36 @@ namespace doris {
const size_t FileResultWriter::OUTSTREAM_BUFFER_SIZE_BYTES = 1024 * 1024;
+// deprecated
FileResultWriter::FileResultWriter(const ResultFileOptions* file_opts,
const std::vector<ExprContext*>&
output_expr_ctxs,
RuntimeProfile* parent_profile,
BufferControlBlock* sinker)
: _file_opts(file_opts),
_output_expr_ctxs(output_expr_ctxs),
_parent_profile(parent_profile),
- _sinker(sinker) {}
+ _sinker(sinker) {
+ if (_file_opts->is_local_file) {
+ _storage_type = TStorageBackendType::LOCAL;
+ } else {
+ _storage_type = TStorageBackendType::BROKER;
+ }
+ _fragment_instance_id.hi = 12345678987654321;
Review comment:
Add comment to explain.
BTW, I suggest to add `FileNamePrefix` column in the result of outfile
operation. For easy to get full name of exported files. Such as:
```
+------------+-----------+-----------+-------------+------------------------------------------+
| FileNumber | TotalRows | FileSize | URL |FileNamePrefix
|
+------------+-----------+-----------+-------------+------------------------------------------+
| 1 | 123605 | 361061014 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10325|
| 1 | 128180 | 374334318 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10326|
| 1 | 125156 | 365569023 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10327|
| 1 | 124096 | 362395588 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10328|
| 1 | 124862 | 364727515 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10329|
| 1 | 124520 | 363649600 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10330|
| 1 | 124447 | 363479285 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10331|
| 1 | 125134 | 365490611 | 127.0.0.1
|my_file2_46e9ef9b66924a79-92f887d43be10332|
+------------+-----------+-----------+-------------+------------------------------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
