morningman commented on a change in pull request #6416:
URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r700266994
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
##########
@@ -330,17 +329,12 @@ public void analyze(Analyzer analyzer) throws
UserException {
if (dataDescription.isLoadFromTable()) {
isLoadFromTable = true;
}
- Database db = Catalog.getCurrentCatalog().getDb(label.getDbName());
- if (db == null) {
- throw new AnalysisException("database: " + label.getDbName() +
"not found.");
- }
- Table table = db.getTable(dataDescription.getTableName());
- if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND &&
- (!(table instanceof OlapTable) || ((OlapTable)
table).getKeysType() != KeysType.UNIQUE_KEYS)) {
+ Database db =
Catalog.getCurrentCatalog().getDbOrAnalysisException(label.getDbName());
+ OlapTable table =
db.getOlapTableOrAnalysisException(dataDescription.getTableName());
+ if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND &&
table.getKeysType() != KeysType.UNIQUE_KEYS) {
throw new AnalysisException("load by MERGE or DELETE is only
supported in unique tables.");
}
- if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND
- && !((table instanceof OlapTable) && ((OlapTable)
table).hasDeleteSign()) ) {
+ if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND &&
table.hasDeleteSign()) {
Review comment:
```suggestion
if (dataDescription.getMergeType() != LoadTask.MergeType.APPEND
&& !table.hasDeleteSign()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
