Re: [PR] UI: List host OOBM details when enabled and configured [cloudstack]
blueorangutan commented on PR #10472: URL: https://github.com/apache/cloudstack/pull/10472#issuecomment-2687208689 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: List host OOBM details when enabled and configured [cloudstack]
DaanHoogland commented on PR #10472: URL: https://github.com/apache/cloudstack/pull/10472#issuecomment-2687207539 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
DaanHoogland commented on code in PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#discussion_r1973097770
##
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##
@@ -1577,11 +1592,18 @@ protected void
validateAndUpdateUsernameIfNeeded(UpdateUserCmd updateUserCmd, Us
if (duplicatedUser.getId() == user.getId()) {
continue;
}
-Account duplicatedUserAccountWithUserThatHasTheSameUserName =
_accountDao.findById(duplicatedUser.getAccountId());
-if
(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId() ==
account.getDomainId()) {
-DomainVO domain =
_domainDao.findById(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId());
-throw new
InvalidParameterValueException(String.format("Username [%s] already exists in
domain [id=%s,name=%s]", duplicatedUser.getUsername(), domain.getUuid(),
domain.getName()));
+
+// duplicate usernames cannot exist in same domain unless
explicitly configured
+if
(!userAllowMultipleAccounts.valueInDomain(account.getDomainId())) {
+Account duplicatedUserAccountWithUserThatHasTheSameUserName =
_accountDao.findById(duplicatedUser.getAccountId());
+if
(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId() ==
account.getDomainId()) {
+DomainVO domain =
_domainDao.findById(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId());
+throw new
InvalidParameterValueException(String.format("Username [%s] already exists in
domain [id=%s,name=%s]", duplicatedUser.getUsername(), domain.getUuid(),
domain.getName()));
+}
Review Comment:
new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
DaanHoogland commented on code in PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#discussion_r1973097159
##
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java:
##
@@ -316,13 +303,38 @@ public static void setupSamlUserCookies(final
LoginCmdResponse loginResponse, fi
} catch (URISyntaxException ex) {
throw new CloudRuntimeException("Invalid URI: " + redirectUrl);
}
+
+resp.addCookie(newCookie(domain, path, "userid",
URLEncoder.encode(loginResponse.getUserId(), HttpUtils.UTF_8)));
+resp.addCookie(newCookie(domain, path,"domainid",
URLEncoder.encode(loginResponse.getDomainId(), HttpUtils.UTF_8)));
+resp.addCookie(newCookie(domain, path,"role",
URLEncoder.encode(loginResponse.getType(), HttpUtils.UTF_8)));
+resp.addCookie(newCookie(domain, path,"username",
URLEncoder.encode(loginResponse.getUsername(), HttpUtils.UTF_8)));
+resp.addCookie(newCookie(domain, path,"account",
URLEncoder.encode(loginResponse.getAccount(), HttpUtils.UTF_8)));
+resp.addCookie(newCookie(domain, path,"isSAML",
URLEncoder.encode("true", HttpUtils.UTF_8)));
+resp.addCookie(newCookie(domain, path,"twoFaEnabled",
URLEncoder.encode(loginResponse.is2FAenabled(), HttpUtils.UTF_8)));
+String providerFor2FA = loginResponse.getProviderFor2FA();
+if (StringUtils.isNotEmpty(providerFor2FA)) {
+resp.addCookie(newCookie(domain, path,"twoFaProvider",
URLEncoder.encode(loginResponse.getProviderFor2FA(), HttpUtils.UTF_8)));
+}
+String timezone = loginResponse.getTimeZone();
+if (timezone != null) {
+resp.addCookie(newCookie(domain, path,"timezone",
URLEncoder.encode(timezone, HttpUtils.UTF_8)));
+}
+resp.addCookie(newCookie(domain, path,"userfullname",
URLEncoder.encode(loginResponse.getFirstName() + " " +
loginResponse.getLastName(), HttpUtils.UTF_8).replace("+", "%20")));
Review Comment:
could be a method as well, but so could the older bit above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
DaanHoogland commented on code in PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#discussion_r1973093624
##
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java:
##
@@ -168,28 +168,33 @@ public static String buildAuthnRequestUrl(final String
authnId, final SAMLProvid
return redirectUrl;
}
-public static AuthnRequest buildAuthnRequestObject(final String authnId,
final String spId, final String idpUrl, final String consumerUrl) {
+public static AuthnRequest buildAuthnRequestObject(final String authnId,
final String spId, final String idpUrl, final String consumerUrl, boolean
requirePasswordAuthentication) {
// Issuer object
IssuerBuilder issuerBuilder = new IssuerBuilder();
Issuer issuer = issuerBuilder.buildObject();
issuer.setValue(spId);
-// AuthnContextClass
-AuthnContextClassRefBuilder authnContextClassRefBuilder = new
AuthnContextClassRefBuilder();
-AuthnContextClassRef authnContextClassRef =
authnContextClassRefBuilder.buildObject(
-SAMLConstants.SAML20_NS,
-"AuthnContextClassRef", "saml");
-
authnContextClassRef.setAuthnContextClassRef(AuthnContext.PPT_AUTHN_CTX);
-
-// AuthnContext
-RequestedAuthnContextBuilder requestedAuthnContextBuilder = new
RequestedAuthnContextBuilder();
-RequestedAuthnContext requestedAuthnContext =
requestedAuthnContextBuilder.buildObject();
-
requestedAuthnContext.setComparison(AuthnContextComparisonTypeEnumeration.EXACT);
-
requestedAuthnContext.getAuthnContextClassRefs().add(authnContextClassRef);
-
// Creation of AuthRequestObject
AuthnRequestBuilder authRequestBuilder = new AuthnRequestBuilder();
AuthnRequest authnRequest = authRequestBuilder.buildObject();
+
+// AuthnContextClass. When this is false, the authentication
requirements are defered to the SAML IDP and its default or configured workflow
+if (requirePasswordAuthentication) {
+AuthnContextClassRefBuilder authnContextClassRefBuilder = new
AuthnContextClassRefBuilder();
+AuthnContextClassRef authnContextClassRef =
authnContextClassRefBuilder.buildObject(
+SAMLConstants.SAML20_NS,
+"AuthnContextClassRef", "saml");
+
authnContextClassRef.setAuthnContextClassRef(AuthnContext.PPT_AUTHN_CTX);
+
+// AuthnContext
+RequestedAuthnContextBuilder requestedAuthnContextBuilder = new
RequestedAuthnContextBuilder();
+RequestedAuthnContext requestedAuthnContext =
requestedAuthnContextBuilder.buildObject();
+
requestedAuthnContext.setComparison(AuthnContextComparisonTypeEnumeration.EXACT);
+
requestedAuthnContext.getAuthnContextClassRefs().add(authnContextClassRef);
+authnRequest.setRequestedAuthnContext(requestedAuthnContext);
+}
+
Review Comment:
no critisism of your PR , but some modularisation is possible. For instance
this bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
DaanHoogland commented on code in PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#discussion_r1973097770
##
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##
@@ -1577,11 +1592,18 @@ protected void
validateAndUpdateUsernameIfNeeded(UpdateUserCmd updateUserCmd, Us
if (duplicatedUser.getId() == user.getId()) {
continue;
}
-Account duplicatedUserAccountWithUserThatHasTheSameUserName =
_accountDao.findById(duplicatedUser.getAccountId());
-if
(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId() ==
account.getDomainId()) {
-DomainVO domain =
_domainDao.findById(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId());
-throw new
InvalidParameterValueException(String.format("Username [%s] already exists in
domain [id=%s,name=%s]", duplicatedUser.getUsername(), domain.getUuid(),
domain.getName()));
+
+// duplicate usernames cannot exist in same domain unless
explicitly configured
+if
(!userAllowMultipleAccounts.valueInDomain(account.getDomainId())) {
+Account duplicatedUserAccountWithUserThatHasTheSameUserName =
_accountDao.findById(duplicatedUser.getAccountId());
+if
(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId() ==
account.getDomainId()) {
+DomainVO domain =
_domainDao.findById(duplicatedUserAccountWithUserThatHasTheSameUserName.getDomainId());
+throw new
InvalidParameterValueException(String.format("Username [%s] already exists in
domain [id=%s,name=%s]", duplicatedUser.getUsername(), domain.getUuid(),
domain.getName()));
+}
Review Comment:
new methos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] UI: List host OOBM details when enabled and configured [cloudstack]
blueorangutan commented on PR #10472: URL: https://github.com/apache/cloudstack/pull/10472#issuecomment-2687246181 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10472 (QA-JID-561) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
DaanHoogland commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2687277201 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
tpodowd commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2687283322 Hi @DaanHoogland - yes. I am done with this particular PR so it would be great to move forward. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
DaanHoogland commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2687273430 > Please let me know if you have any questions or comments. thanks @tpodowd , this means you are done with this PR, for now? (so we run regression tests and merge ..) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
weizhouapache commented on code in PR #10257:
URL: https://github.com/apache/cloudstack/pull/10257#discussion_r1973467999
##
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##
@@ -1902,7 +1902,7 @@ protected void mtuCheckForVpcNetwork(Long vpcId,
Pair interfac
}
s_logger.warn(String.format("VPC public MTU already set at VPC
creation phase to: %s. Ignoring public MTU " +
"passed during VPC network tier creation ",
vpc.getPublicMtu()));
-interfaceMTUs.set(vpc.getPublicMtu(), privateMtu);
+interfaceMTUs.set(vpc.getPublicMtu(), interfaceMTUs.second());
Review Comment:
@DaanHoogland
`publicMtu` is the public MTU passed by API
the pair `interfaceMTUs` is the final public/private MTUs to be used
`privateMtu` is the MTU private passed by API, it is not used in this
method, I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
weizhouapache commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2687797129 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
blueorangutan commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2687800712 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] VEEAM Backup integration - CloudStack 4.20 [cloudstack]
miko-meos opened a new issue, #10478: URL: https://github.com/apache/cloudstack/issues/10478 ### problem Hello, i have problems with VEEAM integration. Error log is: 2025-02-27 10:49:09,483 ERROR [o.a.c.b.v.VeeamClient] (BackgroundTaskPollManager-1:[ctx-73af4556]) (logid:0a2a6480) Failed to process response to get VM restore points via Veeam B&R API due to: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "SqlInfo" (class org.apache.cloudstack.backup.veeam.api.VmRestorePoint), not marked as ignorable (11 known properties: "UID", "HierarchyObjRef", "VmName", "VmDisplayName", "CreationTimeUTC", "Links", "Type", "Href", "Algorithm", "Name", "PointType"]) at [Source: (org.apache.http.conn.EofSensorInputStream); line: 1, column: 64970] (through reference chain: org.apache.cloudstack.backup.veeam.api.VmRestorePoints["VmRestorePoint"]->java.util.ArrayList[36]->org.apache.cloudstack.backup.veeam.api.VmRestorePoint["SqlInfo"]) at com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61) at com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1127) at com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:2023) at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1700) at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1678) at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:319) at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:176) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:355) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28) at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:138) at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:313) at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:176) at com.fasterxml.jackson.dataformat.xml.deser.WrapperHandlingDeserializer.deserialize(WrapperHandlingDeserializer.java:122) at com.fasterxml.jackson.dataformat.xml.deser.XmlDeserializationContext.readRootValue(XmlDeserializationContext.java:91) at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4674) at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3666) at org.apache.cloudstack.backup.veeam.VeeamClient.processHttpResponseForVmRestorePoints(VeeamClient.java:889) at org.apache.cloudstack.backup.veeam.VeeamClient.listVmRestorePointsViaVeeamAPI(VeeamClient.java:877) at org.apache.cloudstack.backup.veeam.VeeamClient.listRestorePoints(VeeamClient.java:867) at org.apache.cloudstack.backup.VeeamBackupProvider.listRestorePoints(VeeamBackupProvider.java:327) at org.apache.cloudstack.backup.VeeamBackupProvider.syncBackups(VeeamBackupProvider.java:349) at org.apache.cloudstack.backup.BackupManagerImpl$BackupSyncTask.tryToSyncVMBackups(BackupManagerImpl.java:1261) at org.apache.cloudstack.backup.BackupManagerImpl$BackupSyncTask.syncBackupMetrics(BackupManagerImpl.java:1251) at org.apache.cloudstack.backup.BackupManagerImpl$BackupSyncTask.runInContext(BackupManagerImpl.java:1239) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at
Re: [I] VEEAM Backup integration - CloudStack 4.20 [cloudstack]
boring-cyborg[bot] commented on issue #10478: URL: https://github.com/apache/cloudstack/issues/10478#issuecomment-2687585897 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
Pearl1594 commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2687939682 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
blueorangutan commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2687940942 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] How to integrate cloustack with physical network devices to replace system virtual machines [cloudstack]
wangwei0537 opened a new issue, #10479: URL: https://github.com/apache/cloudstack/issues/10479 ### The required feature described as a wish CloudStack's network functions and management are usually implemented through System Virtual Machines (SVMs), especially network-related functions such as routing, NAT, VPN, DHCP, etc. How can we integrate with physical network devices to replace system virtual machines? Are there any relevant configuration cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
blueorangutan commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2687971738 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] How to integrate cloustack with physical network devices to replace system virtual machines [cloudstack]
weizhouapache commented on issue #10479: URL: https://github.com/apache/cloudstack/issues/10479#issuecomment-2687991946 @wangwei0537 what physical network devices do you have ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: fix volume migration across cluster-scope pools [cloudstack]
Pearl1594 merged PR #10266: URL: https://github.com/apache/cloudstack/pull/10266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: fix volume migration across cluster-scope pools (#10266)
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new f992ebb52a5 fix volume migration across cluster-scope pools (#10266)
f992ebb52a5 is described below
commit f992ebb52a5760bf7fe1714c162bada4de463ef8
Author: Wei Zhou
AuthorDate: Thu Feb 27 14:50:22 2025 +0100
fix volume migration across cluster-scope pools (#10266)
---
.../java/com/cloud/storage/MigrationOptions.java | 11 +--
.../KvmNonManagedStorageDataMotionStrategy.java | 2 +-
.../motion/StorageSystemDataMotionStrategy.java | 20 ++--
.../kvm/resource/LibvirtComputingResource.java | 4
.../hypervisor/kvm/storage/KVMStorageProcessor.java | 6 ++
5 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/api/src/main/java/com/cloud/storage/MigrationOptions.java
b/api/src/main/java/com/cloud/storage/MigrationOptions.java
index a39a2a7c827..8b642d09e29 100644
--- a/api/src/main/java/com/cloud/storage/MigrationOptions.java
+++ b/api/src/main/java/com/cloud/storage/MigrationOptions.java
@@ -24,6 +24,7 @@ public class MigrationOptions implements Serializable {
private String srcPoolUuid;
private Storage.StoragePoolType srcPoolType;
+private Long srcPoolClusterId;
private Type type;
private ScopeType scopeType;
private String srcBackingFilePath;
@@ -38,21 +39,23 @@ public class MigrationOptions implements Serializable {
public MigrationOptions() {
}
-public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType
srcPoolType, String srcBackingFilePath, boolean copySrcTemplate, ScopeType
scopeType) {
+public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType
srcPoolType, String srcBackingFilePath, boolean copySrcTemplate, ScopeType
scopeType, Long srcPoolClusterId) {
this.srcPoolUuid = srcPoolUuid;
this.srcPoolType = srcPoolType;
this.type = Type.LinkedClone;
this.scopeType = scopeType;
this.srcBackingFilePath = srcBackingFilePath;
this.copySrcTemplate = copySrcTemplate;
+this.srcPoolClusterId = srcPoolClusterId;
}
-public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType
srcPoolType, String srcVolumeUuid, ScopeType scopeType) {
+public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType
srcPoolType, String srcVolumeUuid, ScopeType scopeType, Long srcPoolClusterId) {
this.srcPoolUuid = srcPoolUuid;
this.srcPoolType = srcPoolType;
this.type = Type.FullClone;
this.scopeType = scopeType;
this.srcVolumeUuid = srcVolumeUuid;
+this.srcPoolClusterId = srcPoolClusterId;
}
public String getSrcPoolUuid() {
@@ -63,6 +66,10 @@ public class MigrationOptions implements Serializable {
return srcPoolType;
}
+public Long getSrcPoolClusterId() {
+return srcPoolClusterId;
+}
+
public ScopeType getScopeType() { return scopeType; }
public String getSrcBackingFilePath() {
diff --git
a/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
b/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
index f2ccce75690..7059b32f9b7 100644
---
a/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
+++
b/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
@@ -217,7 +217,7 @@ public class KvmNonManagedStorageDataMotionStrategy extends
StorageSystemDataMot
}
VMTemplateStoragePoolVO sourceVolumeTemplateStoragePoolVO =
vmTemplatePoolDao.findByPoolTemplate(destStoragePool.getId(),
srcVolumeInfo.getTemplateId(), null);
-if (sourceVolumeTemplateStoragePoolVO == null &&
(isStoragePoolTypeInList(destStoragePool.getPoolType(),
StoragePoolType.Filesystem, StoragePoolType.SharedMountPoint))) {
+if (sourceVolumeTemplateStoragePoolVO == null &&
(isStoragePoolTypeInList(destStoragePool.getPoolType(),
StoragePoolType.NetworkFilesystem, StoragePoolType.Filesystem,
StoragePoolType.SharedMountPoint))) {
DataStore sourceTemplateDataStore =
dataStoreManagerImpl.getRandomImageStore(srcVolumeInfo.getDataCenterId());
if (sourceTemplateDataStore != null) {
TemplateInfo sourceTemplateInfo =
templateDataFactory.getTemplate(srcVolumeInfo.getTemplateId(),
sourceTemplateDataStore);
diff --git
a/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
b/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
Re: [I] VM cross cluster migration not working [cloudstack]
Pearl1594 commented on issue #10078: URL: https://github.com/apache/cloudstack/issues/10078#issuecomment-2688025886 Fixed with: https://github.com/apache/cloudstack/pull/10266 - this should be available in the upcoming 4.20.1 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM cross cluster migration not working [cloudstack]
Pearl1594 closed issue #10078: VM cross cluster migration not working URL: https://github.com/apache/cloudstack/issues/10078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] schema: add XS 8.3, 8.4 hypervisor capabilities [cloudstack]
DaanHoogland commented on PR #10483: URL: https://github.com/apache/cloudstack/pull/10483#issuecomment-2689848388 this is double to #10470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Distributed Table-Based Lock [cloudstack]
rohityadavcloud closed pull request #9955: Distributed Table-Based Lock URL: https://github.com/apache/cloudstack/pull/9955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
sonarqubecloud[bot] commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2689791844 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10149) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10149&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10149&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10149&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10149&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10149&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10149) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
weizhouapache commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2689819122 > Sorry missed your comment @weizhouapache if there are further changes you could review if this needs to be reverted or you want to raise a new PR? @rohityadavcloud no worries, I will address it in another PR #10431 btw, actually I missed a word in my previous comment. :man_facepalming: This does **NOT** work in my testing on ubuntu 24. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
blueorangutan commented on PR #10311: URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2689821904 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Distributed Table-Based Lock [cloudstack]
blueorangutan commented on PR #9955: URL: https://github.com/apache/cloudstack/pull/9955#issuecomment-2689821911 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Distributed Table-Based Lock [cloudstack]
rohityadavcloud commented on PR #9955: URL: https://github.com/apache/cloudstack/pull/9955#issuecomment-2689698448 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Distributed Table-Based Lock [cloudstack]
rohityadavcloud opened a new pull request, #9955:
URL: https://github.com/apache/cloudstack/pull/9955
This introduces an experimental MySQL Db-table based locking mechanism
instead of using GET_LOCK/RELEASE_LOCK which is documented as limitation for
many Mysql-clustering solutions such as
https://docs.percona.com/percona-xtradb-cluster/8.0/limitation.html
This needs to be reviewed and tested against such mysql-clustering solutions
and whether active-active or active-backup setup can work with CloudStack mgmt
server(s) with these changes.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [x] Major
- [ ] Minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump elliptic from 6.5.4 to 6.6.1 in /ui [cloudstack]
rohityadavcloud closed pull request #10395: Bump elliptic from 6.5.4 to 6.6.1 in /ui URL: https://github.com/apache/cloudstack/pull/10395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump elliptic from 6.5.4 to 6.6.1 in /ui [cloudstack]
dependabot[bot] commented on PR #10395: URL: https://github.com/apache/cloudstack/pull/10395#issuecomment-2689703332 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
blueorangutan commented on PR #10311: URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2689705350 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
rohityadavcloud commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2689705742 Sorry missed your comment @weizhouapache if there are further changes you could review if this needs to be reverted or you want to raise a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
rohityadavcloud commented on PR #10311: URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2689704738 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump elliptic from 6.5.4 to 6.6.1 in /ui [cloudstack]
rohityadavcloud commented on PR #10395: URL: https://github.com/apache/cloudstack/pull/10395#issuecomment-2689704224 Any changes in dependencies for the UI need to be in package.json and not just the lock file. This is why build will fail and dependabot is unreliable. We also have issues working with latest npm & some dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: add use of virsh domifaddr to get VM external DHCP IP (#10376)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new f0179855f54 add use of virsh domifaddr to get VM external DHCP IP
(#10376)
f0179855f54 is described below
commit f0179855f54c4396e90d4ba49c21ba5249cc170a
Author: Rene Glover
AuthorDate: Thu Feb 27 22:43:53 2025 -0600
add use of virsh domifaddr to get VM external DHCP IP (#10376)
* add use of virsh domifaddr to get VM external DHCP IP
* updates to modularize LibvirtGetVmIpAddressCommandWrapper per comments;
added test cases to cover 90%+ scenarios
* updates to modularize LibvirtGetVmIpAddressCommandWrapper per comments;
added test cases to cover 90%+ scenarios
* updates to modularize LibvirtGetVmIpAddressCommandWrapper per comments;
added test cases to cover 90%+ scenarios
---
.../LibvirtGetVmIpAddressCommandWrapper.java | 167 +++
.../LibvirtGetVmIpAddressCommandWrapperTest.java | 320 +
2 files changed, 438 insertions(+), 49 deletions(-)
diff --git
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
index d65b6907eeb..0dd52ddfb10 100644
---
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
+++
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java
@@ -29,6 +29,7 @@ import com.cloud.agent.api.GetVmIpAddressCommand;
import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
import com.cloud.resource.CommandWrapper;
import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.Pair;
import com.cloud.utils.net.NetUtils;
import com.cloud.utils.script.Script;
@@ -37,6 +38,26 @@ public final class LibvirtGetVmIpAddressCommandWrapper
extends CommandWrapper commands = new ArrayList<>();
-final String virt_ls_path =
Script.getExecutableAbsolutePath("virt-ls");
-final String virt_cat_path =
Script.getExecutableAbsolutePath("virt-cat");
-final String virt_win_reg_path =
Script.getExecutableAbsolutePath("virt-win-reg");
-final String tail_path = Script.getExecutableAbsolutePath("tail");
-final String grep_path = Script.getExecutableAbsolutePath("grep");
-final String awk_path = Script.getExecutableAbsolutePath("awk");
-final String sed_path = Script.getExecutableAbsolutePath("sed");
-if(!command.isWindows()) {
-//List all dhcp lease files inside guestVm
-commands.add(new String[]{virt_ls_path, sanitizedVmName,
"/var/lib/dhclient/"});
-commands.add(new String[]{grep_path, ".*\\*.leases"});
-String leasesList = Script.executePipedCommands(commands,
0).second();
-if(leasesList != null) {
-String[] leasesFiles = leasesList.split("\n");
-for(String leaseFile : leasesFiles){
-//Read from each dhclient lease file inside guest Vm using
virt-cat libguestfs utility
-commands = new ArrayList<>();
-commands.add(new String[]{virt_cat_path, sanitizedVmName,
"/var/lib/dhclient/" + leaseFile});
-commands.add(new String[]{tail_path, "-16"});
-commands.add(new String[]{grep_path, "fixed-address"});
-commands.add(new String[]{awk_path, "{print $2}"});
-commands.add(new String[]{sed_path, "-e", "s/;//"});
-String ipAddr = Script.executePipedCommands(commands,
0).second();
-// Check if the IP belongs to the network
-if((ipAddr != null) &&
NetUtils.isIpWithInCidrRange(ipAddr, networkCidr)) {
-ip = ipAddr;
-break;
+commands.add(new String[]{virsh_path, "domifaddr", sanitizedVmName,
"--source", "agent"});
+Pair response = executePipedCommands(commands, 0);
+if (response != null) {
+String output = response.second();
+String[] lines = output.split("\n");
+for (String line : lines) {
+if (line.contains("ipv4")) {
+String[] parts = line.split(" ");
+String[] ipParts = parts[parts.length-1].split("/");
+if (ipParts.length > 1) {
+if (NetUtils.isIpWithInCidrRange(ipParts[0],
networkCidr)) {
+ip = ipParts[0];
+break;
+}
}
-s_logger.debug("GetVmIp: "+ vmName + " Ip: "+ipAddr+" does
Re: [PR] Fix hv_ss_reserve value for volumes on migration [cloudstack]
rohityadavcloud commented on PR #6078: URL: https://github.com/apache/cloudstack/pull/6078#issuecomment-2689707065 @nvazquez any update on this? cc @Pearl1594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 [cloudstack]
rohityadavcloud merged PR #10462: URL: https://github.com/apache/cloudstack/pull/10462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add change host password [cloudstack]
blueorangutan commented on PR #10337: URL: https://github.com/apache/cloudstack/pull/10337#issuecomment-2689709917 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Remove allocated snapshots / vm snapshots on start [cloudstack]
rohityadavcloud commented on PR #8452: URL: https://github.com/apache/cloudstack/pull/8452#issuecomment-2689710299 @sureshanaparti are you working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support to resize volume during upload [cloudstack]
rohityadavcloud commented on PR #6005: URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-2689706560 @Pearl1594 any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add change host password [cloudstack]
rohityadavcloud commented on PR #10337: URL: https://github.com/apache/cloudstack/pull/10337#issuecomment-2689708581 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't allow host (KVM) addition without PowerFlex SDC installed/connected [cloudstack]
rohityadavcloud commented on PR #8628: URL: https://github.com/apache/cloudstack/pull/8628#issuecomment-2689710584 @sureshanaparti any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
rohityadavcloud commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2689712968 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
rohityadavcloud closed pull request #8756: pom.xml: Upgrade gson version to 2.10.1 URL: https://github.com/apache/cloudstack/pull/8756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
rohityadavcloud closed pull request #8951: [Draft] KVM: enable no-mac-spoofing on virtual nics URL: https://github.com/apache/cloudstack/pull/8951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [Draft] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
weizhouapache opened a new pull request, #8951:
URL: https://github.com/apache/cloudstack/pull/8951
### Description
In shared, isolated networks and vpcs in advanced zone, user vms can easily
perform ip/arp/mac spoofing by pretending to be another vm in the same network.
- change mac
```
ip link set dev eth0 down
ip link set dev eth0 address
ip link set dev eth0 up
```
- change IP
```
ip addr add dev eth0
ip addr del dev eth0
```
- these can also be done by netplan/network-scripts configurations.
libvirt has a network traffic filtering subsystem which can be used to
prevent spoofing. (https://libvirt.org/formatnwfilter.html#concepts)
- It provides some pre-existing network filters
(https://libvirt.org/formatnwfilter.html#pre-existing-network-filters),
no-mac-spoofing is missed in the table.
- Ideally we should use `clean-traffic`, however, the `IP/ARP anti-spoofing
does not work` in our testing, as the IP is not specified in the libvirt vm
definition XML by cloudstack.
- libvirt can auto-detect the IP but the auto-detected IP is not always
correct, for example, when user configures (wrong) static IP inside the user VM.
This PR adds `no-mac-spoofing` for each nic to prevent mac spoofing.
It could be an improvement PR to support all MAC/IP/ARP spoofing
- it might lead to some overhead.
- it is better to be configurable for guest network, network offering or
account
- IP/network information needs to be added to the InterfaceDef for each type
of interface (bridge, direct, network, vhostuser, etc).
- it might be not needed in advanced zone with security groups, as there are
already iptables/ebtables/ipset rules to prevent the spoofings
- it needs some discussion and testing. `clean-traffic` is good, but it
might not be what we want. we need to evaluate the pre-existing network filters
and probably consider creating customized filters. refer to
https://libvirt.org/firewall.html#the-network-filter-driver
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
weizhouapache opened a new pull request, #8756:
URL: https://github.com/apache/cloudstack/pull/8756
### Description
This PR upgrades gson from 1.7.2 to 2.10.1
gson versions are listed at
https://mvnrepository.com/artifact/com.google.code.gson/gson
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2689715063 @rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
rohityadavcloud closed pull request #10006: [HEALTH] 4.20 Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/10006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2689716912 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
rohityadavcloud commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2689716513 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
rohityadavcloud commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2689711919 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
rohityadavcloud commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2689712691 @weizhouapache when you've bandwidth can you check why the github actions are/were failing (I've rekicked them now) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
blueorangutan commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2689713059 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 (#10462)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 2d00933d65e systemvmtemplate: bump version Debian 12.9.0 and ACS
4.20.1 (#10462)
2d00933d65e is described below
commit 2d00933d65e0e33c9c394a8379c02775c84626b5
Author: Rohit Yadav
AuthorDate: Fri Feb 28 10:05:50 2025 +0530
systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 (#10462)
This bumps the version of the base OS ISO to Debian 12.9.0 and use
ACS version identifier to be 4.20.1 (next release).
Signed-off-by: Rohit Yadav
---
.../appliance/systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +-
.../systemvmtemplate/template-base_aarch64-target_aarch64.json| 4 ++--
.../systemvmtemplate/template-base_x86_64-target_aarch64.json | 4 ++--
.../systemvmtemplate/template-base_x86_64-target_x86_64.json | 4 ++--
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git
a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
index 077cabf8d93..2629eba92e9 100644
--- a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
+++ b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
@@ -19,7 +19,7 @@
set -e
set -x
-CLOUDSTACK_RELEASE=4.20.0
+CLOUDSTACK_RELEASE=4.20.1
function configure_apache2() {
# Enable ssl, rewrite and auth
diff --git
a/tools/appliance/systemvmtemplate/template-base_aarch64-target_aarch64.json
b/tools/appliance/systemvmtemplate/template-base_aarch64-target_aarch64.json
index 67493c7c635..e2b4d3bce92 100644
--- a/tools/appliance/systemvmtemplate/template-base_aarch64-target_aarch64.json
+++ b/tools/appliance/systemvmtemplate/template-base_aarch64-target_aarch64.json
@@ -32,8 +32,8 @@
"format": "qcow2",
"headless": true,
"http_directory": "http",
- "iso_checksum":
"sha512:fc3560bb586af14b1d77ab7c2806616916926afcbd5cb3fd5a04a5633dfd91cfbbccada1a123f1ea14c480153b731cbee72a230cea17fd9116b9df8444d8df1c",
- "iso_url":
"https://cdimage.debian.org/mirror/cdimage/release/12.7.0/arm64/iso-cd/debian-12.7.0-arm64-netinst.iso";,
+ "iso_checksum":
"sha512:04a2a128852c2dff8bb71779ad325721385051eb1264d897bdb5918ab207a9b1de636ded149c56c61a09eb8c7f428496815e70d3be31b1b1cf4c70bf6427cedd",
+ "iso_url":
"https://cdimage.debian.org/mirror/cdimage/release/12.9.0/arm64/iso-cd/debian-12.9.0-arm64-netinst.iso";,
"net_device": "virtio-net",
"output_directory": "../dist",
"qemu_binary": "qemu-system-aarch64",
diff --git
a/tools/appliance/systemvmtemplate/template-base_x86_64-target_aarch64.json
b/tools/appliance/systemvmtemplate/template-base_x86_64-target_aarch64.json
index ed03fd74942..b1cd7c69e2c 100644
--- a/tools/appliance/systemvmtemplate/template-base_x86_64-target_aarch64.json
+++ b/tools/appliance/systemvmtemplate/template-base_x86_64-target_aarch64.json
@@ -31,8 +31,8 @@
"format": "qcow2",
"headless": true,
"http_directory": "http",
- "iso_checksum":
"sha512:fc3560bb586af14b1d77ab7c2806616916926afcbd5cb3fd5a04a5633dfd91cfbbccada1a123f1ea14c480153b731cbee72a230cea17fd9116b9df8444d8df1c",
- "iso_url":
"https://cdimage.debian.org/mirror/cdimage/release/12.7.0/arm64/iso-cd/debian-12.7.0-arm64-netinst.iso";,
+ "iso_checksum":
"sha512:04a2a128852c2dff8bb71779ad325721385051eb1264d897bdb5918ab207a9b1de636ded149c56c61a09eb8c7f428496815e70d3be31b1b1cf4c70bf6427cedd",
+ "iso_url":
"https://cdimage.debian.org/mirror/cdimage/release/12.9.0/arm64/iso-cd/debian-12.9.0-arm64-netinst.iso";,
"net_device": "virtio-net",
"output_directory": "../dist",
"qemu_binary": "qemu-system-aarch64",
diff --git
a/tools/appliance/systemvmtemplate/template-base_x86_64-target_x86_64.json
b/tools/appliance/systemvmtemplate/template-base_x86_64-target_x86_64.json
index e209d480334..322d1620e03 100644
--- a/tools/appliance/systemvmtemplate/template-base_x86_64-target_x86_64.json
+++ b/tools/appliance/systemvmtemplate/template-base_x86_64-target_x86_64.json
@@ -27,8 +27,8 @@
"format": "qcow2",
"headless": true,
"http_directory": "http",
- "iso_checksum":
"sha512:e0bd9ba03084a6fd42413b425a2d20e3731678a31fe5fb2cc84f79332129afca2ad4ec897b4224d6a833afaf28a5d938b0fe5d680983182944162c6825b135ce",
- "iso_url":
"https://cdimage.debian.org/mirror/cdimage/release/12.7.0/amd64/iso-cd/debian-12.7.0-amd64-netinst.iso";,
+ "iso_checksum":
"sha512:9ebe405c3404a005ce926e483bc6c6841b405c4d85e0c8a7b1707a7fe4957c617ae44bd807a57ec3e5c2d3e99f2101dfb26ef36b3720896906bdc3aaeec4cd80",
+ "iso_url":
"https://cdimage.debian.org/mirror/cdimage/release/12.9.0/amd64/iso-cd/debian-12.9.0-amd64-netinst.iso";,
"net_device": "virtio-net",
[PR] schema: add XS 8.3, 8.4 hypervisor capabilities [cloudstack]
rohityadavcloud opened a new pull request, #10483:
URL: https://github.com/apache/cloudstack/pull/10483
This aims to add support for XenServer 8.4 and XCP-ng 8.3.
https://www.xenserver.com/downloads
https://mirrors.xcp-ng.org/isos/8.3/xcp-ng-8.3.0.iso?https=1
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [x] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
Testing by developing support for hypervisor template with mbx, also later
on with Trillian.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [DB] Exceptions logged on fresh management server start [cloudstack]
shwstppr commented on issue #10480: URL: https://github.com/apache/cloudstack/issues/10480#issuecomment-2689776471 @abh1sar could it be related to scope column type change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Draft] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
codecov[bot] commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2689777065 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8951?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. > Project coverage is 17.00%. Comparing base [(`cadbb56`)](https://app.codecov.io/gh/apache/cloudstack/commit/cadbb563afaa907a45e8931cb8a95e8ca5b8f034?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5e0aa25`)](https://app.codecov.io/gh/apache/cloudstack/commit/5e0aa25e078e3f70e3a2846d9121786fbe2e6a20?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 921 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/apache/cloudstack/pull/8951?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://app.codecov.io/gh/apache/cloudstack/pull/8951?src=pr&el=tree&filepath=plugins%2Fhypervisors%2Fkvm%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhypervisor%2Fkvm%2Fresource%2FLibvirtVMDef.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#8951 +/- ## = + Coverage 15.13% 17.00%+1.87% + Complexity1346913275 -194 = Files 4863 5270 +407 Lines326031 465547 +139516 Branches 4583854500 +8662 = + Hits 4934979184+29835 - Misses 270066 377497 +107431 - Partials 6616 8866 +2250 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8951/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `17.00% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8951?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2689783156 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10006) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10006&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10006&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10006&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10006&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10006&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10006) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] schema: add XS 8.3, 8.4 hypervisor capabilities [cloudstack]
codecov[bot] commented on PR #10483: URL: https://github.com/apache/cloudstack/pull/10483#issuecomment-2689782778 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.01%. Comparing base [(`2d00933`)](https://app.codecov.io/gh/apache/cloudstack/commit/2d00933d65e0e33c9c394a8379c02775c84626b5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`73e5576`)](https://app.codecov.io/gh/apache/cloudstack/commit/73e557619f48085fa92ea846b0c868b6831d9863?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (2d00933) and HEAD (73e5576). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (2d00933) | HEAD (73e5576) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #10483 +/- ## = - Coverage 15.98%4.01% -11.98% = Files 5649 395 -5254 Lines49573932438 -463301 Branches 60021 5751-54270 = - Hits 79252 1301-77951 + Misses 40763330988 -376645 + Partials 8854 149 -8705 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.01% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10483?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: cloudstack-setup-databases: fix mode and group of key file (#10466)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new f50de8981af cloudstack-setup-databases: fix mode and group of key file (#10466) f50de8981af is described below commit f50de8981afd157ceb8f9b1bfa2248c5d1c339d1 Author: Wei Zhou AuthorDate: Fri Feb 28 06:14:31 2025 +0100 cloudstack-setup-databases: fix mode and group of key file (#10466) --- setup/bindir/cloud-setup-databases.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/setup/bindir/cloud-setup-databases.in b/setup/bindir/cloud-setup-databases.in index 41b54b07e60..317acd22216 100755 --- a/setup/bindir/cloud-setup-databases.in +++ b/setup/bindir/cloud-setup-databases.in @@ -402,6 +402,8 @@ for example: except IOError as e: msg = "Failed to save management server secret key file %s due to %s, also please check the default umask"%(self.encryptionKeyFile, e.strerror) self.errorAndExit(msg) +os.chmod(self.encryptionKeyFile, 0o640) +shutil.chown(self.encryptionKeyFile, user=None, group="cloud") def formatEncryptResult(value): return 'ENC(%s)'%value
(cloudstack) branch healthcheck-4.20 updated (5cca988fc38 -> 249a3e296fc)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch healthcheck-4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
discard 5cca988fc38 4.20 Health Check, please don't merge this!
add c121d5bb6db usage: use runtime scope when running maven usage profile
(#10331)
add 6a3314c40b9 Fixup alerting and logging error in BGPServiceImpl (#10252)
add 21b5e4dcae5 Veeam: set backed_volumes for each backup (#9898)
add c0e05c4a6d7 Fix Usage inconsistencies (#9888)
add ee32f4cfe8c Add cpu speed detection methods (#9762)
add 4b432c82ca0 List only those hosts matching source host arch in
multi-arch zones (#10369)
add c80b8860e49 Fix hostId verification on unsuccessful expunge operation
(#10418)
add 7bef25666fd UI: Fix Apache CloudStack description on the onboarding
page (#10373)
add 212f2a3898c UI: Fix `docHelp` links for Add Hosts, Add Clusters,
Disable Clusters and Enable Clusters forms (#10394)
add b6cebe22f9e Fixed VMware import issue - check and update pools in the
order of the disks (do not update by position) (#10409)
add b9ebc7b721b VMware Import - Support external VMs in any
folders/subfolders other than the root folder ('vm') of datacenter (#10411)
add 66f8a351dd5 migrate Vmware to KVM ui issues (#10413)
add e196275d5a6 ipmi: extra log sanitation (#10428)
add 08ad1c70ba3 Merge branch '4.19' into 4.20
add e8ac477e9f8 engine/orchestration: fix missing vm powerstate update vm
state (#10407)
add 37c4df9ada1 fix: enforce the cpu shares within allowed range (#10221)
add 4e321d43565 Updating pom.xml version numbers for release 4.19.2.0
add 4a3686297dc Updating pom.xml version numbers for release
4.19.3.0-SNAPSHOT
add 5526ef0168c spurious versions
add 91db905659d Merge commit '5526ef0168c' into 4.20
add 1f092667641 UI: Fix filtering of templates by account (#10425)
add a09c579b5b2 UI: Fixes and minor enhacements to the Public IP Addresses
section (#10351)
add f992ebb52a5 fix volume migration across cluster-scope pools (#10266)
add 88916dcf2bb Merge branch '4.19' into 4.20
add 2d00933d65e systemvmtemplate: bump version Debian 12.9.0 and ACS
4.20.1 (#10462)
add 249a3e296fc 4.20 Health Check, please don't merge this!
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (5cca988fc38)
\
N -- N -- N refs/heads/healthcheck-4.20 (249a3e296fc)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../com/cloud/agent/api/to/RemoteInstanceTO.java | 8 +-
.../java/com/cloud/storage/MigrationOptions.java | 11 ++-
.../java/com/cloud/storage/VolumeApiService.java | 22 +++--
.../apache/cloudstack/vm/UnmanagedInstanceTO.java | 10 ++
.../com/cloud/vm/VirtualMachineManagerImpl.java| 2 +-
.../cloud/vm/VirtualMachinePowerStateSyncImpl.java | 10 +-
.../vm/VirtualMachinePowerStateSyncImplTest.java | 107 +
.../com/cloud/usage/dao/UsageNetworksDaoImpl.java | 10 +-
.../java/com/cloud/usage/dao/UsageVpcDaoImpl.java | 10 +-
.../KvmNonManagedStorageDataMotionStrategy.java| 2 +-
.../motion/StorageSystemDataMotionStrategy.java| 20 ++--
.../cloudstack/backup/VeeamBackupProvider.java | 4 +
.../kvm/resource/LibvirtComputingResource.java | 36 +--
.../LibvirtConvertInstanceCommandWrapper.java | 7 +-
.../kvm/storage/KVMStorageProcessor.java | 6 ++
.../apache/cloudstack/utils/linux/KVMHostInfo.java | 37 ---
.../IpmitoolOutOfBandManagementDriver.java | 8 +-
.../driver/ipmitool/IpmitoolWrapper.java | 55 ++-
.../java/com/cloud/alert/AlertManagerImpl.java | 5 +-
.../main/java/com/cloud/bgp/BGPServiceImpl.java| 6 +-
.../com/cloud/server/ManagementServerImpl.java | 9 ++
.../com/cloud/storage/VolumeApiServiceImpl.java| 36 +++
.../volume/VolumeImportUnmanageManagerImpl.java| 8 +-
.../cloudstack/vm/UnmanagedVMsManagerImpl.java | 76 ++-
.../java/com/cloud/alert/AlertManagerImplTest.java | 71 +++---
.../cloud/storage/VolumeApiServiceImplTest.java| 20 ++--
.../VolumeImportUnmanageManagerImplTest.java | 2 +-
.../cloudstack/vm/UnmanagedVMsManagerImplTest.java | 68 ++---
.../scripts/configure_systemvm_services.sh | 2 +-
.../template-base_a
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2689925771 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Distributed Table-Based Lock [cloudstack]
blueorangutan commented on PR #9955: URL: https://github.com/apache/cloudstack/pull/9955#issuecomment-2689925829 @weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-main updated (6ab927c2414 -> 1c174e76441)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch healthcheck-main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
discard 6ab927c2414 4.20/main Health Check, please don't merge this!
add a8b18a53942 Add nicoschmdt as a project collaborator (#10422)
add 59e054396a8 UI: Fix all list items appearing twice in search view
(#10365)
add 8c4a085a16d Validate the direct downloaded template file format
(QCOW2) if the template file exists (#10332)
add 42a77c76461 LinstorStorageAdaptor: fix lint error (#10378)
add 8e1f5b1e49b Fill fields in login, forgotPassword and resetPassword
from url (#10291)
add 07564b7933e Enable multiple services on configdrive network service
provider (#10372)
add 69285a62c94 UI: Fix selection of domain filters in the `SearchView`
component (#10386)
add 5204960bac8 made id parameter required (#10338)
add 789f94b664a VR: fix duplicated lines in .htaccess (#10254)
add c121d5bb6db usage: use runtime scope when running maven usage profile
(#10331)
add 6a3314c40b9 Fixup alerting and logging error in BGPServiceImpl (#10252)
add 21b5e4dcae5 Veeam: set backed_volumes for each backup (#9898)
add c0e05c4a6d7 Fix Usage inconsistencies (#9888)
add ee32f4cfe8c Add cpu speed detection methods (#9762)
add 4b432c82ca0 List only those hosts matching source host arch in
multi-arch zones (#10369)
add c80b8860e49 Fix hostId verification on unsuccessful expunge operation
(#10418)
add 7bef25666fd UI: Fix Apache CloudStack description on the onboarding
page (#10373)
add 212f2a3898c UI: Fix `docHelp` links for Add Hosts, Add Clusters,
Disable Clusters and Enable Clusters forms (#10394)
add b6cebe22f9e Fixed VMware import issue - check and update pools in the
order of the disks (do not update by position) (#10409)
add b9ebc7b721b VMware Import - Support external VMs in any
folders/subfolders other than the root folder ('vm') of datacenter (#10411)
add 66f8a351dd5 migrate Vmware to KVM ui issues (#10413)
add e196275d5a6 ipmi: extra log sanitation (#10428)
add 08ad1c70ba3 Merge branch '4.19' into 4.20
add 24b7c662519 Merge branch '4.20'
add 48f890a6931 resolve merge problems in the backup framework (#10457)
add e8ac477e9f8 engine/orchestration: fix missing vm powerstate update vm
state (#10407)
add 37c4df9ada1 fix: enforce the cpu shares within allowed range (#10221)
add 4e321d43565 Updating pom.xml version numbers for release 4.19.2.0
add 4a3686297dc Updating pom.xml version numbers for release
4.19.3.0-SNAPSHOT
add 5526ef0168c spurious versions
add 91db905659d Merge commit '5526ef0168c' into 4.20
add 1f092667641 UI: Fix filtering of templates by account (#10425)
add a09c579b5b2 UI: Fixes and minor enhacements to the Public IP Addresses
section (#10351)
add f992ebb52a5 fix volume migration across cluster-scope pools (#10266)
add 88916dcf2bb Merge branch '4.19' into 4.20
add 3a28a87483e Merge branch '4.20' of https://github.com/apache/cloudstack
add 2d00933d65e systemvmtemplate: bump version Debian 12.9.0 and ACS
4.20.1 (#10462)
add 69cf299c62a Merge remote-tracking branch 'origin/4.20'
add 1c174e76441 4.20/main Health Check, please don't merge this!
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (6ab927c2414)
\
N -- N -- N refs/heads/healthcheck-main (1c174e76441)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.asf.yaml | 3 +-
.../com/cloud/agent/api/to/RemoteInstanceTO.java | 8 +-
.../java/com/cloud/storage/MigrationOptions.java | 11 ++-
.../java/com/cloud/storage/VolumeApiService.java | 22 +++--
...AccountAllowedToCreateOfferingsWithTagsCmd.java | 2 +-
.../apache/cloudstack/backup/BackupProvider.java | 37 ---
.../apache/cloudstack/vm/UnmanagedInstanceTO.java | 10 ++
.../com/cloud/vm/VirtualMachineManagerImpl.java| 2 +-
.../cloud/vm/VirtualMachinePowerStateSyncImpl.java | 10 +-
.../vm/VirtualMachinePowerStateSyncImplTest.java | 107 +
.../com/cloud/usage/dao/UsageNetworksDaoImpl.java | 10 +-
.../java/com/cloud/usage/dao/UsageVpcDaoImpl.java | 10 +-
.../KvmNonManagedStorageDataMotionStrategy.java| 2 +-
.../motion/StorageSystem
Re: [PR] server: fetch IP of VMs on L2 networks [cloudstack]
github-actions[bot] commented on PR #10431: URL: https://github.com/apache/cloudstack/pull/10431#issuecomment-2689931002 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: support skipGroupAction [cloudstack]
weizhouapache commented on PR #10250: URL: https://github.com/apache/cloudstack/pull/10250#issuecomment-2689931451 closing this PR as the issue seems to be fixed by #10351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: support skipGroupAction [cloudstack]
weizhouapache closed pull request #10250: UI: support skipGroupAction URL: https://github.com/apache/cloudstack/pull/10250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Distributed Table-Based Lock [cloudstack]
blueorangutan commented on PR #9955: URL: https://github.com/apache/cloudstack/pull/9955#issuecomment-2689934890 [SF] Trillian Build Failed (tid-12515) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
DaanHoogland commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2689933928 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [DB] Exceptions logged on fresh management server start [cloudstack]
abh1sar commented on issue #10480: URL: https://github.com/apache/cloudstack/issues/10480#issuecomment-2689933627 Will test and fix @shwstppr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
blueorangutan commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2689935374 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VEEAM Backup integration - CloudStack 4.20 [cloudstack]
winterhazel commented on issue #10478: URL: https://github.com/apache/cloudstack/issues/10478#issuecomment-2689035263 > `SqlInfo` might be a new property of vm restore point, introduced in recent veeam releases It may be good to add a `objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);` to ignore these on `org.apache.cloudstack.backup.veeam.VeeamClient#processHttpResponseForVmRestorePoints` so that the backup sync does not break whenever a new property that we don't use is added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VEEAM Backup integration - CloudStack 4.20 [cloudstack]
weizhouapache commented on issue #10478: URL: https://github.com/apache/cloudstack/issues/10478#issuecomment-2689050279 > > `SqlInfo` might be a new property of vm restore point, introduced in recent veeam releases > > It may be good to add a `objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);` to ignore these on `org.apache.cloudstack.backup.veeam.VeeamClient#processHttpResponseForVmRestorePoints` so that the backup sync does not break whenever a new property that we don't use is added. Makes sense Maybe can add a static objectMapper which replaces all new objectmapper instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
weizhouapache commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2689054288 This does work in my testing on ubuntu 24. I will give a suggestion tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 02/02: Merge branch '4.19' into 4.20
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 88916dcf2bb55dd33d7e163bea8618fc69ac27a9
Merge: 91db905659d f992ebb52a5
Author: Daan Hoogland
AuthorDate: Thu Feb 27 17:10:54 2025 +0100
Merge branch '4.19' into 4.20
.../java/com/cloud/storage/MigrationOptions.java | 11 +--
.../KvmNonManagedStorageDataMotionStrategy.java | 2 +-
.../motion/StorageSystemDataMotionStrategy.java | 20 ++--
.../kvm/resource/LibvirtComputingResource.java | 4
.../hypervisor/kvm/storage/KVMStorageProcessor.java | 6 ++
ui/src/components/view/InfoCard.vue | 5 +
ui/src/components/view/ListView.vue | 8 ++--
ui/src/config/section/network.js | 12 +---
8 files changed, 54 insertions(+), 14 deletions(-)
diff --cc ui/src/components/view/ListView.vue
index 9b5d226289b,8f4e58e93c7..060e09488f3
--- a/ui/src/components/view/ListView.vue
+++ b/ui/src/components/view/ListView.vue
@@@ -412,8 -382,8 +416,8 @@@
{{ record.enabled ? 'Enabled' : 'Disabled' }}
-
- {{ $toLocaleDate(text) }}
-
++
+ {{ text && $toLocaleDate(text) }}
{{ getDateAtTimeZone(text, record.timezone) }}
Re: [I] Can't upload iso from local [cloudstack]
jibingl commented on issue #7568: URL: https://github.com/apache/cloudstack/issues/7568#issuecomment-2688664406 > [@HtainL](https://github.com/HtainL) > > Please find global settings at this path configuration > global settings , you disable the setting and > > 1. Restart mgmt service > > service cloudstack-managment restart > > 2. Restart the ssvm > >  In my case, got the same issue on uploading ISO locally. By following above solution, I re-generate the ssvm, not just restart it. Then the issue fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 [cloudstack]
rohityadavcloud commented on PR #10462: URL: https://github.com/apache/cloudstack/pull/10462#issuecomment-2689695694 I'll merge this based on the builds, for actual testing, these templates can be used. Around mid-march I'm happy to do new sets of builds and move them to download.cloudstack.org server and update root & engine/schema pom.xml with the systemvmtemplate version. For now, the scope of the PR was to ensure builds work with the corrected ISO urls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 [cloudstack]
rohityadavcloud commented on PR #10462: URL: https://github.com/apache/cloudstack/pull/10462#issuecomment-2689694218 @DaanHoogland * Yes, I've been copying the systemvmtemplate builds + logs near the release (can do sometime early-mid March) * Yes, I've been also testing the arm64 systemvmtemplates Builds from the PR: https://build.yadav.cloud/systemvm/10462-x86_64/ https://build.yadav.cloud/systemvm/10462-aarch64/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
rohityadavcloud closed pull request #10149: [HEALTH] 4.21/main Health Check, please don't merge this URL: https://github.com/apache/cloudstack/pull/10149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add change host password [cloudstack]
blueorangutan commented on PR #10337: URL: https://github.com/apache/cloudstack/pull/10337#issuecomment-2689728862 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10337 (QA-JID-562) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
rohityadavcloud commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2689727229 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Distributed Table-Based Lock [cloudstack]
blueorangutan commented on PR #9955: URL: https://github.com/apache/cloudstack/pull/9955#issuecomment-2689703411 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't allow host (KVM) addition without PowerFlex SDC installed/connected [cloudstack]
sureshanaparti closed pull request #8628: Don't allow host (KVM) addition without PowerFlex SDC installed/connected URL: https://github.com/apache/cloudstack/pull/8628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
blueorangutan commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2689728528 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't allow host (KVM) addition without PowerFlex SDC installed/connected [cloudstack]
sureshanaparti commented on PR #8628: URL: https://github.com/apache/cloudstack/pull/8628#issuecomment-2689739880 > @sureshanaparti any update on this? @rohityadavcloud this is not valid any more (after introducing on-demand connections to powerflex) . closed this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
rohityadavcloud merged PR #10466: URL: https://github.com/apache/cloudstack/pull/10466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (3a28a87483e -> 69cf299c62a)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3a28a87483e Merge branch '4.20' of https://github.com/apache/cloudstack add 2d00933d65e systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 (#10462) new 69cf299c62a Merge remote-tracking branch 'origin/4.20' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../appliance/systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +- .../systemvmtemplate/template-base_aarch64-target_aarch64.json| 4 ++-- .../systemvmtemplate/template-base_x86_64-target_aarch64.json | 4 ++-- .../systemvmtemplate/template-base_x86_64-target_x86_64.json | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-)
(cloudstack) 01/01: Merge remote-tracking branch 'origin/4.20'
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 69cf299c62a01166b94ceff8cc48ab110c30382c
Merge: 3a28a87483e 2d00933d65e
Author: Rohit Yadav
AuthorDate: Fri Feb 28 10:41:07 2025 +0530
Merge remote-tracking branch 'origin/4.20'
Signed-off-by: Rohit Yadav
.../appliance/systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +-
.../systemvmtemplate/template-base_aarch64-target_aarch64.json| 4 ++--
.../systemvmtemplate/template-base_x86_64-target_aarch64.json | 4 ++--
.../systemvmtemplate/template-base_x86_64-target_x86_64.json | 4 ++--
4 files changed, 7 insertions(+), 7 deletions(-)
diff --cc
tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
index 077cabf8d93,2629eba92e9..4467e2fff78
--- a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
+++ b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
@@@ -19,7 -19,7 +19,7 @@@
set -e
set -x
- CLOUDSTACK_RELEASE=4.20.0
-CLOUDSTACK_RELEASE=4.20.1
++CLOUDSTACK_RELEASE=4.21.0
function configure_apache2() {
# Enable ssl, rewrite and auth
(cloudstack) branch dependabot/npm_and_yarn/ui/elliptic-6.6.1 deleted (was ebbc2e1558f)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/ui/elliptic-6.6.1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git was ebbc2e1558f Bump elliptic from 6.5.4 to 6.6.1 in /ui The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2689840022 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
blueorangutan commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2689843412 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
blueorangutan commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2689796536 [SF] Trillian test result (tid-12505) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52930 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9666-t12505-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 391.44 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Launch RESIZE event on volume snapshot revert [cloudstack]
DaanHoogland commented on code in PR #10482:
URL: https://github.com/apache/cloudstack/pull/10482#discussion_r1974885170
##
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##
@@ -390,10 +390,19 @@ public Snapshot revertSnapshot(Long snapshotId) {
boolean result = snapshotStrategy.revertSnapshot(snapshotInfo);
if (result) {
+Long differenceBetweenVolumeAndSnapshotSize = new
Long(volume.getSize() - snapshot.getSize());
// update volume size and primary storage count
-_resourceLimitMgr.decrementResourceCount(snapshot.getAccountId(),
ResourceType.primary_storage, new Long(volume.getSize() - snapshot.getSize()));
-volume.setSize(snapshot.getSize());
-_volsDao.update(volume.getId(), volume);
+if (differenceBetweenVolumeAndSnapshotSize != 0) {
+if (differenceBetweenVolumeAndSnapshotSize > 0) {
+
_resourceLimitMgr.decrementResourceCount(snapshot.getAccountId(),
ResourceType.primary_storage, differenceBetweenVolumeAndSnapshotSize);
+} else if (differenceBetweenVolumeAndSnapshotSize < 0) {
+
_resourceLimitMgr.incrementResourceCount(snapshot.getAccountId(),
ResourceType.primary_storage, differenceBetweenVolumeAndSnapshotSize * -1L);
+}
+volume.setSize(snapshot.getSize());
+_volsDao.update(volume.getId(), volume);
+
UsageEventUtils.publishUsageEvent(EventTypes.EVENT_VOLUME_RESIZE,
volume.getAccountId(), volume.getDataCenterId(), volume.getId(),
volume.getName(),
+volume.getDiskOfferingId(), volume.getTemplateId(),
volume.getSize(), Volume.class.getName(), volume.getUuid());
+}
Review Comment:
can this go in a new method @julien-vaz ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Github Action: Add action to auto close issues/PRs after a certain time [cloudstack]
DaanHoogland commented on PR #8667: URL: https://github.com/apache/cloudstack/pull/8667#issuecomment-2689873072 > LGTM - are we doing this @vishesh92 @Pearl1594 @DaanHoogland ? ha, this PR was stale ;), I think we should merge though. Fromality: did we discuss on dev@? also @vishesh92 i would have [gsoc](https://github.com/apache/cloudstack/issues?q=is%3Aopen+label%3Agsoc) be an [exempt-issue-labels](https://github.com/actions/stale#exempt-issue-labels) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add xcpng 8.3 support data [cloudstack]
DaanHoogland closed pull request #10470: add xcpng 8.3 support data URL: https://github.com/apache/cloudstack/pull/10470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
