weizhouapache commented on code in PR #10257:
URL: https://github.com/apache/cloudstack/pull/10257#discussion_r1973467999
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1902,7 +1902,7 @@ protected void mtuCheckForVpcNetwork(Long vpcId,
Pair<Integer, Integer> interfac
}
s_logger.warn(String.format("VPC public MTU already set at VPC
creation phase to: %s. Ignoring public MTU " +
"passed during VPC network tier creation ",
vpc.getPublicMtu()));
- interfaceMTUs.set(vpc.getPublicMtu(), privateMtu);
+ interfaceMTUs.set(vpc.getPublicMtu(), interfaceMTUs.second());
Review Comment:
@DaanHoogland
`publicMtu` is the public MTU passed by API
the pair `interfaceMTUs` is the final public/private MTUs to be used
`privateMtu` is the MTU private passed by API, it is not used in this
method, I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
