DaanHoogland commented on code in PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#discussion_r1973097159
##########
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java:
##########
@@ -316,13 +303,38 @@ public static void setupSamlUserCookies(final
LoginCmdResponse loginResponse, fi
} catch (URISyntaxException ex) {
throw new CloudRuntimeException("Invalid URI: " + redirectUrl);
}
+
+ resp.addCookie(newCookie(domain, path, "userid",
URLEncoder.encode(loginResponse.getUserId(), HttpUtils.UTF_8)));
+ resp.addCookie(newCookie(domain, path,"domainid",
URLEncoder.encode(loginResponse.getDomainId(), HttpUtils.UTF_8)));
+ resp.addCookie(newCookie(domain, path,"role",
URLEncoder.encode(loginResponse.getType(), HttpUtils.UTF_8)));
+ resp.addCookie(newCookie(domain, path,"username",
URLEncoder.encode(loginResponse.getUsername(), HttpUtils.UTF_8)));
+ resp.addCookie(newCookie(domain, path,"account",
URLEncoder.encode(loginResponse.getAccount(), HttpUtils.UTF_8)));
+ resp.addCookie(newCookie(domain, path,"isSAML",
URLEncoder.encode("true", HttpUtils.UTF_8)));
+ resp.addCookie(newCookie(domain, path,"twoFaEnabled",
URLEncoder.encode(loginResponse.is2FAenabled(), HttpUtils.UTF_8)));
+ String providerFor2FA = loginResponse.getProviderFor2FA();
+ if (StringUtils.isNotEmpty(providerFor2FA)) {
+ resp.addCookie(newCookie(domain, path,"twoFaProvider",
URLEncoder.encode(loginResponse.getProviderFor2FA(), HttpUtils.UTF_8)));
+ }
+ String timezone = loginResponse.getTimeZone();
+ if (timezone != null) {
+ resp.addCookie(newCookie(domain, path,"timezone",
URLEncoder.encode(timezone, HttpUtils.UTF_8)));
+ }
+ resp.addCookie(newCookie(domain, path,"userfullname",
URLEncoder.encode(loginResponse.getFirstName() + " " +
loginResponse.getLastName(), HttpUtils.UTF_8).replace("+", "%20")));
Review Comment:
could be a method as well, but so could the older bit above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
