Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2634147038 [SF] Trillian Build Failed (tid-12305) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634217419 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Remove allocated snapshots / vm snapshots on start [cloudstack]
blueorangutan commented on PR #8452: URL: https://github.com/apache/cloudstack/pull/8452#issuecomment-2634217417 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failures while assigning public IP via enableStaticNat [cloudstack]
akrasnov-drv commented on issue #10313: URL: https://github.com/apache/cloudstack/issues/10313#issuecomment-2634222643 First of all thanks for the attention and care. @DaanHoogland I tried using webhooks in the past, but when started getting different issues I recreated the cluster without webhooks. Here is my agent config ``` #Storage #Thu Jan 30 15:31:01 UTC 2025 cluster=1 pod=1 resource=com.cloud.hypervisor.kvm.resource.LibvirtComputingResource private.network.device=private icluster=1 domr.scripts.dir=scripts/network/domr/kvm guest.cpu.mode=host-passthrough guest.network.device=private keystore.passphrase=X hypervisor.type=kvm port=8250 zone=1 public.network.device=public local.storage.uuid=07db5346-58e2-4a8c-9b6f-08b3b57800a7 host=10.10.67.1@static guid=1ce2f60a-5455-3f8a-846c-86b9413d2a76 LibvirtComputingResource.id=8 workers=5 iscsi.session.cleanup.enabled=false vm.migrate.wait=3600 ``` Nevertheless (I believe I reported it before) there is `/etc/libvirt/hooks/qemu` brought by cloudstack-agent package ``` md5sum /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu 5eb81c675b4caf8c5cb538e19673f29e /usr/share/cloudstack-agent/lib/libvirtqemuhook 5eb81c675b4caf8c5cb538e19673f29e /etc/libvirt/hooks/qemu ``` and I had some doubts about it. Though I do not see how it can be related to the current nat issue. I created 100 VMs via api without a problem, only this call fails with timeout. @weizhouapache I have workers in global config set to 50, but as you see above, agent has it set to 5, and it's not something I set. I can increase that, no problem, but I really doubt number of workers should be relevant to a failure in single api call. As to VR HA - yes, currently I have a pair, but I believe it failed also with a single one. I'll change setup to make sure and provide info on that. @shwstppr I'll clean the env and start it again to provide a wider log, covering both successful executions and then failure. In the meantime, has anybody tried my flow? Did it work (and then the failure is just in my env)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
DaanHoogland commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2634230910 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (55e8eaab89c -> 90c960eeed9)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 55e8eaab89c Linstor: encryption support (#10126) add 90c960eeed9 VPC VR: fix ACL between tier and private gateway (#10268) No new revisions were added by this update. Summary of changes: systemvm/debian/opt/cloud/bin/cs/CsAddress.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Re: [PR] VPC VR: fix ACL between tier and private gateway [cloudstack]
DaanHoogland merged PR #10268: URL: https://github.com/apache/cloudstack/pull/10268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (c1bc57b844b -> 238d0c5e30a)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from c1bc57b844b List default network offerings when multiple physical networks for guest traffic type exists (#10222) add 238d0c5e30a Fix NPE while checking for user data provider (#10255) No new revisions were added by this update. Summary of changes: .../main/java/com/cloud/network/NetworkModelImpl.java | 6 +- .../network/element/ConfigDriveNetworkElement.java| 19 --- .../cloud/network/element/VirtualRouterElement.java | 7 ++- 3 files changed, 27 insertions(+), 5 deletions(-)
Re: [PR] Fix NPE while checking for user data provider [cloudstack]
DaanHoogland merged PR #10255: URL: https://github.com/apache/cloudstack/pull/10255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (238d0c5e30a -> 37c29f82eda)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 238d0c5e30a Fix NPE while checking for user data provider (#10255) add 37c29f82eda server: fix snapshot physical size (#10216) No new revisions were added by this update. Summary of changes: .../java/com/cloud/api/query/QueryManagerImpl.java | 76 +++--- .../com/cloud/api/query/dao/SnapshotJoinDao.java | 6 +- .../cloud/api/query/dao/SnapshotJoinDaoImpl.java | 34 +-- .../api/query/dao/SnapshotJoinDaoImplTest.java | 109 + 4 files changed, 171 insertions(+), 54 deletions(-) create mode 100644 server/src/test/java/com/cloud/api/query/dao/SnapshotJoinDaoImplTest.java
Re: [PR] server: fix snapshot physical size [cloudstack]
DaanHoogland merged PR #10216: URL: https://github.com/apache/cloudstack/pull/10216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2634390732 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
DaanHoogland commented on code in PR #10183:
URL: https://github.com/apache/cloudstack/pull/10183#discussion_r1941462968
##
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh:
##
@@ -115,6 +115,8 @@ setup_vpcrouter() {
sed -i "s#^OnCalendar=.*#OnCalendar=$LOGROTATE_FREQUENCY#g"
/usr/lib/systemd/system/logrotate.timer
sed -i 's#^AccuracySec=.*#AccuracySec=5m#g'
/usr/lib/systemd/system/logrotate.timer
+ sed -i 's/^#\(dhcp-leasefile=\/var\/lib\/misc\/dnsmasq.leases\)/\1/'
/etc/dnsmasq.conf
Review Comment:
note that after expunging the second VM both entries disappeared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2635443913 [SF] Trillian test result (tid-12293) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 50472 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12293-kvm-ubuntu22.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_12_start_vm_multiple_volumes_allocated | `Error` | 14.38 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2635502846 [SF] Trillian test result (tid-12296) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48426 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12296-kvm-ol8.zip Smoke tests completed. 86 look OK, 47 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 68.64 | test_accounts.py test_DeleteDomain | `Error` | 78.97 | test_accounts.py test_forceDeleteDomain | `Failure` | 84.85 | test_accounts.py test_01_user_remove_VM_running | `Error` | 55.83 | test_accounts.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 61.16 | test_affinity_groups_projects.py ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py test_query_async_job_result | `Error` | 68.05 | test_async_job.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 63.13 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 63.13 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 123.07 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 123.08 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 64.17 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 64.17 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 125.65 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 125.66 | test_internal_lb.py test_deploy_vm_from_iso | `Error` | 78.24 | test_deploy_vm_iso.py test_deploy_more_vms_than_limit_allows | `Error` | 57.69 | test_deploy_vms_in_parallel.py test_01_1_create_iso_with_checksum_sha1_negative | `Failure` | 6.33 | test_iso.py test_02_1_create_iso_with_checksum_sha256_negative | `Failure` | 6.31 | test_iso.py test_03_1_create_iso_with_checksum_md5_negative | `Failure` | 6.29 | test_iso.py test_04_extract_Iso | `Failure` | 2.10 | test_iso.py test_deployvm_firstfit | `Error` | 55.88 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userconcentrated | `Error` | 15.78 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdispersing | `Error` | 12.64 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdata | `Error` | 55.04 | test_deploy_vm_with_userdata.py test_deployvm_userdata_post | `Error` | 15.84 | test_deploy_vm_with_userdata.py test_03_deploy_vm_domain_service_offering | `Error` | 77.69 | test_domain_service_offerings.py test_01_browser_migrate_template | `Error` | 5.51 | test_image_store_object_migration.py test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 123.14 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 127.96 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 115.78 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 120.73 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 123.82 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 125.26 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 188.83 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 138.52 | test_kubernetes_clusters.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_list_vms_metrics_admin | `Error` | 58.17 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 13.35 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 55.95 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 12.04 | test_metrics_api.py test_nic_secondaryip_add_remove | `Error` | 64.53 | test_multipleips_per_nic.py test_network_acl | `Error` | 75.30 | test_network_acl.py test_01_verify_ipv6_network | `Error` | 59.01 | test_network_ipv6.py test_01_verify_ipv6_network | `Error` | 59.01 | test_network_ipv6.py test_delete_account | `Error` | 66.50 | test_network.py test_delete_network_while_vm_on_it | `Error` | 5.56 | test_network.py test_delete_network_while_vm_on_it | `Error` | 5.57 | test_network.py test_deploy_vm_l2network | `Error` | 6.92 | test_netw
Re: [PR] Revert test of #10267 [cloudstack]
blueorangutan commented on PR #10323: URL: https://github.com/apache/cloudstack/pull/10323#issuecomment-2635504759 [SF] Trillian test result (tid-12297) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48224 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12297-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix NPE during kubernetes cluster creation when network has rules with ports saved as null on DB [cloudstack]
winterhazel commented on PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#issuecomment-2635559101 > If the network state is implemented and has an existing firewall rule. > > The network already has a running state router > > CKS cluster fails with the following exception > That's the expected behavior, isn't it? ACS will block cluster creation because it needs to add firewall rules that will conflict with the existing one. What we could do is remove this limitation and, before adding the necessary rules, check if there is already a rule covering them; if there is, we do not add the rules. This would be a separate enhancement though. > There is no issue with CKS cluster creation if the network state is allocated and has an existing firewall rule. > > The network does not have a running router Also the current expected behavior. No validation is performed if the network's state is `Allocated`. https://github.com/apache/cloudstack/blob/22c71928dd28dc3217e59c9d4d7dacc56621a02f/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java#L403-L409 I haven't looked deeper into whether there is a better reason for this, but it seems to me that we could remove this so that the rules get validated for `Allocated` networks. Again, also a separate enhancement. > @kiranchavala , I think @GaOrtiga left the community (for now) can you assess the state of this PR for us? ie, > > * can it be merged > > * if yes is there work remaining for new issues / PRs > > * if no, what needs to be done? > most specifically; when you talk about " the scenario where the network state is implemented and has an existing firewall rule", is this a regression or a secondary finding? It seems to me not to have anything to do with the NPE fix the subject is about. @DaanHoogland I think that it can be merged, what @kiranchavala's pointed out seems like issues that can be addressed separately for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
blueorangutan commented on PR #10317: URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2635429886 [SF] Trillian test result (tid-12295) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 47219 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10317-t12295-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_12_start_vm_multiple_volumes_allocated | `Error` | 15.21 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2635483913 [SF] Trillian test result (tid-12301) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46562 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10322-t12301-kvm-ol8.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 122.51 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 123.45 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 132.11 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 133.97 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 121.19 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 128.81 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 187.27 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 136.96 | test_kubernetes_clusters.py test_01_secure_vm_migration | `Error` | 135.75 | test_vm_life_cycle.py test_01_secure_vm_migration | `Error` | 135.75 | test_vm_life_cycle.py test_10_attachAndDetach_iso | `Error` | 6.44 | test_vm_life_cycle.py test_12_start_vm_multiple_volumes_allocated | `Error` | 17.29 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix NPE during kubernetes cluster creation when network has rules with ports saved as null on DB [cloudstack]
winterhazel commented on code in PR #9223:
URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1942161780
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java:
##
@@ -105,6 +105,7 @@ public class KubernetesClusterActionWorker {
public static final int DEFAULT_SSH_PORT = 22;
public static final int CLUSTER_NODES_DEFAULT_START_SSH_PORT = ;
public static final int CLUSTER_NODES_DEFAULT_SSH_PORT_SG =
DEFAULT_SSH_PORT;
+public static final int MAX_PORT = 65535;
Review Comment:
There's already an equivalent in
NetUtils,`com.cloud.utils.net.NetUtils#PORT_RANGE_MAX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
github-actions[bot] commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2635569180 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Fix using multiple primary storage with same linstor-controller [cloudstack]
github-actions[bot] commented on PR #10280: URL: https://github.com/apache/cloudstack/pull/10280#issuecomment-2635569159 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2635585592 [SF] Trillian test result (tid-12303) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52728 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10322-t12303-vmware-70u3.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 538.07 | test_internal_lb.py test_12_start_vm_multiple_volumes_allocated | `Error` | 17.08 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
bernardodemarco commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2634761381 @nicoschmdt, apparently the `ManagementServerImpl.java` file has conflicts. Could you resolve them, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
weizhouapache commented on PR #10183: URL: https://github.com/apache/cloudstack/pull/10183#issuecomment-2634726410 @Pearl1594 @DaanHoogland Can we configure it in CsDhcp.py ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
bernardodemarco commented on code in PR #10325:
URL: https://github.com/apache/cloudstack/pull/10325#discussion_r1941695645
##
api/src/main/java/org/apache/cloudstack/api/command/admin/management/RemoveMgmtCmd.java:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.management;
+
+import com.cloud.event.EventTypes;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.response.ManagementServerResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+
+@APICommand(name = "removeManagementServer", description = "Removes a
management server.", responseObject = SuccessResponse.class,
Review Comment:
```suggestion
@APICommand(name = "removeManagementServer", description = "Removes a
Management Server.", responseObject = SuccessResponse.class,
```
##
api/src/main/java/org/apache/cloudstack/api/command/admin/management/RemoveMgmtCmd.java:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.management;
+
+import com.cloud.event.EventTypes;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.response.ManagementServerResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+
+@APICommand(name = "removeManagementServer", description = "Removes a
management server.", responseObject = SuccessResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = RoleType.Admin)
+public class RemoveMgmtCmd extends BaseCmd {
+
+@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
ManagementServerResponse.class, required = true, description = "the id of the
management server")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
ManagementServerResponse.class, required = true, description = "the ID of the
Management Server")
```
##
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##
@@ -5495,4 +5502,24 @@ public void setLockControllerListener(final
LockControllerListener
Re: [PR] List only untagged offerings for Shared networks when tag isn't passed [cloudstack]
Pearl1594 commented on PR #10320: URL: https://github.com/apache/cloudstack/pull/10320#issuecomment-2635732428 @weizhouapache I've added the isTagged=false if no tags are present on the physical network. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch list-non-tagged updated (078625675d2 -> e07820f3f19)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch list-non-tagged in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 078625675d2 List only untagged offerings for Shared networks when tag isn't passed add e07820f3f19 only ui change No new revisions were added by this update. Summary of changes: .../java/com/cloud/configuration/ConfigurationManagerImpl.java | 9 + ui/src/views/network/CreateSharedNetworkForm.vue | 4 2 files changed, 9 insertions(+), 4 deletions(-)
Re: [PR] Revert test of #10267 [cloudstack]
shwstppr commented on PR #10323: URL: https://github.com/apache/cloudstack/pull/10323#issuecomment-2635771349 @DaanHoogland I think we can proceed with this. Though I feel #10267 probably wasn't the reason for whole test suite failure but based on https://github.com/apache/cloudstack/pull/10324#issuecomment-2635662972 I think there is a behavioural change which is causing `test_12_start_vm_multiple_volumes_allocated` failure. I'll check and fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List only untagged offerings for Shared networks when tag isn't passed [cloudstack]
sonarqubecloud[bot] commented on PR #10320: URL: https://github.com/apache/cloudstack/pull/10320#issuecomment-2635795940 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10320) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10320&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10320&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10320&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10320&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10320&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10320) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Delete edge vr showing internal server error. [cloudstack]
sureshanaparti commented on issue #9847: URL: https://github.com/apache/cloudstack/issues/9847#issuecomment-2635738124 Fix PR is merged, closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Delete edge vr showing internal server error. [cloudstack]
sureshanaparti closed issue #9847: Delete edge vr showing internal server error. URL: https://github.com/apache/cloudstack/issues/9847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2635846040 [SF] Trillian test result (tid-12304) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 68023 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10322-t12304-xcpng82.zip Smoke tests completed. 129 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 173.70 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 159.44 | test_cluster_drs.py test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 232.33 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 220.21 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 238.54 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 216.95 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 234.70 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 231.96 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 352.32 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 256.30 | test_kubernetes_clusters.py test_01_non_strict_host_anti_affinity | `Error` | 220.82 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 117.54 | test_nonstrict_affinity_group.py test_10_attachAndDetach_iso | `Error` | 9.46 | test_vm_life_cycle.py test_12_start_vm_multiple_volumes_allocated | `Error` | 16.24 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert test of #10267 [cloudstack]
blueorangutan commented on PR #10323: URL: https://github.com/apache/cloudstack/pull/10323#issuecomment-2635924239 [SF] Trillian test result (tid-12300) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 70487 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12300-xcpng82.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 171.06 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 185.36 | test_cluster_drs.py test_01_non_strict_host_anti_affinity | `Error` | 231.73 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 132.23 | test_nonstrict_affinity_group.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add IOPS and bytes preset variables to `VOLUME` usage type [cloudstack]
DaanHoogland commented on code in PR #10326:
URL: https://github.com/apache/cloudstack/pull/10326#discussion_r1942386336
##
framework/quota/src/main/java/org/apache/cloudstack/quota/activationrule/presetvariables/DiskOffering.java:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.quota.activationrule.presetvariables;
+
+public class DiskOffering extends GenericPresetVariable {
Review Comment:
would a name like `DiskOfferingPresetVariables` be more appropriate?
##
framework/quota/src/main/java/org/apache/cloudstack/quota/activationrule/presetvariables/DiskOffering.java:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.quota.activationrule.presetvariables;
+
+public class DiskOffering extends GenericPresetVariable {
+
+@PresetVariableDefinition(description = "A long informing the bytes read
rate of the disk offering.")
+private Long bytesReadRate;
+
+@PresetVariableDefinition(description = "A long informing the burst bytes
read rate of the disk offering.")
+private Long bytesReadBurst;
+
+@PresetVariableDefinition(description = "The length (in seconds) of the
bytes read burst.")
+private Long bytesReadBurstLength;
+
+@PresetVariableDefinition(description = "A long informing the bytes write
rate of the disk offering.")
+private Long bytesWriteRate;
+
+@PresetVariableDefinition(description = "A long informing the burst bytes
write rate of the disk offering.")
+private Long bytesWriteBurst;
+
+@PresetVariableDefinition(description = "The length (in seconds) of the
bytes write burst.")
+private Long bytesWriteBurstLength;
+
+@PresetVariableDefinition(description = "A long informing the I/O requests
read rate of the disk offering.")
+private Long iopsReadRate;
+
+@PresetVariableDefinition(description = "A long informing the burst I/O
requests read rate of the disk offering.")
+private Long iopsReadBurst;
+
+@PresetVariableDefinition(description = "The length (in seconds) of the
IOPS read burst.")
+private Long iopsReadBurstLength;
+
+@PresetVariableDefinition(description = "A long informing the I/O requests
write rate of the disk offering.")
+private Long iopsWriteRate;
+
+@PresetVariableDefinition(description = "A long informing the burst I/O
requests write rate of the disk offering.")
+private Long iopsWriteBurst;
+
+@PresetVariableDefinition(description = "The length (in seconds) of the
IOPS write burst.")
+private Long iopsWriteBurstLength;
+
+public Long getBytesReadRate() {
+return bytesReadRate;
+}
+
+public void setBytesReadRate(Long bytesReadRate) {
+this.bytesReadRate = bytesReadRate;
+fieldNamesToIncludeInToString.add("bytesReadRate");
+}
+
+public Long getBytesReadBurst() {
+return bytesReadBurst;
+}
+
+public void setBytesReadBurst(Long bytesReadBurst) {
+this.bytesReadBurst = bytesReadBurst;
+fieldNamesToIncludeInToString.add("bytesReadBurst");
+}
+
+public Long getBytesReadBurstLength() {
+return bytesReadBurstLength;
+}
+
+public void setBytesReadBurstLength(Long bytesReadBurstLength) {
+this.bytesReadBurstLength = bytesReadBurstLength;
+fieldNamesToIncludeInToString.add("bytesReadBurstLength");
+}
+
+public Long ge
Re: [PR] linstor: Fix using multiple primary storage with same linstor-controller [cloudstack]
DaanHoogland commented on PR #10280: URL: https://github.com/apache/cloudstack/pull/10280#issuecomment-2635991364 @rp- can you have another look? (conflicts) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2635997034 for test_12_start_vm_multiple_volumes_allocated #10324 is out. The rest seems to particularly hit the systems with el management servers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List only untagged offerings for Shared networks when tag isn't passed [cloudstack]
weizhouapache commented on PR #10320: URL: https://github.com/apache/cloudstack/pull/10320#issuecomment-2635997157 > @weizhouapache I've added the isTagged=false if no tags are present on the physical network. thanks @Pearl1594 code lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Fix using multiple primary storage with same linstor-controller [cloudstack]
rp- commented on PR #10280: URL: https://github.com/apache/cloudstack/pull/10280#issuecomment-2635994484 > @rp- can you have another look? (conflicts) already on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List only untagged offerings for Shared networks when tag isn't passed [cloudstack]
weizhouapache commented on code in PR #10320:
URL: https://github.com/apache/cloudstack/pull/10320#discussion_r1942395849
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -6973,6 +6973,11 @@ public Pair, Integer>
searchForNetworkOfferings(
sc.addAnd("tags", SearchCriteria.Op.EQ, tags);
}
}
+//else {
Review Comment:
remove this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
weizhouapache commented on PR #10317: URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633313713 > > @rp- this seems to be an issue with the script `cloud-install-sys-tmplt` , right ? > > not directly, as the script only updates the `vm_template` table and before cloudstack-management hasn't upgraded all the sql, there isn't even a table `template_store_ref` yet. So you can only fix that issue within the code. > > There is this code here: > > https://github.com/apache/cloudstack/blob/cd81398cb7176698196f72002df5d6088befbaed/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java#L1242 > > Which does add the seeded entries, but at that time, no secondary storage is mounted, so you can't get the correct sizes. thanks @rp- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List only untagged offerings for Shared networks when tag isn't passed [cloudstack]
weizhouapache commented on PR #10320: URL: https://github.com/apache/cloudstack/pull/10320#issuecomment-2633321221 to be frank, I am a bit confused what is expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Tagged network offerings are not displayed [cloudstack]
DaanHoogland commented on issue #10316: URL: https://github.com/apache/cloudstack/issues/10316#issuecomment-2633323119 @rajujith , does that mean we can close both #9673 and this (#10316)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] server: fix pod retrieval during volume attach [cloudstack]
shwstppr opened a new pull request, #10324:
URL: https://github.com/apache/cloudstack/pull/10324
### Description
Fixes issue highlighted in
https://github.com/apache/cloudstack/pull/9315#issuecomment-2633353671
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix pod retrieval during volume attach [cloudstack]
blueorangutan commented on PR #10324: URL: https://github.com/apache/cloudstack/pull/10324#issuecomment-2633512403 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2633519947 [SF] Trillian Build Failed (tid-12294) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix pod retrieval during volume attach [cloudstack]
codecov[bot] commented on PR #10324: URL: https://github.com/apache/cloudstack/pull/10324#issuecomment-2633525973 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10324?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.29%. Comparing base [(`97be6f2`)](https://app.codecov.io/gh/apache/cloudstack/commit/97be6f2e5d13c4fd2941f30522deebae0ab71827?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`25f7494`)](https://app.codecov.io/gh/apache/cloudstack/commit/25f7494a961181023106ba50cbeabdffc3fa3f8c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 9 commits behind head on 4.19. Additional details and impacted files ```diff @@Coverage Diff@@ ##4.19 #10324 +/- ## = - Coverage 4.29%4.29% -0.01% = Files366 366 Lines 2960229605 +3 Branches5193 5194 +1 = Hits1272 1272 - Misses 2818528188 +3 Partials 145 145 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10324/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10324?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix pod retrieval during volume attach [cloudstack]
shwstppr commented on PR #10324: URL: https://github.com/apache/cloudstack/pull/10324#issuecomment-2633510439 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2633524231 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hide register template, create/upload volume and create vpc buttons when zone is not created. [cloudstack]
blueorangutan commented on PR #10243: URL: https://github.com/apache/cloudstack/pull/10243#issuecomment-2633537956 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634026341 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634046488 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634047885 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix pod retrieval during volume attach [cloudstack]
DaanHoogland commented on PR #10324: URL: https://github.com/apache/cloudstack/pull/10324#issuecomment-2634068017 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Linstor: encryption support [cloudstack]
DaanHoogland commented on PR #10126: URL: https://github.com/apache/cloudstack/pull/10126#issuecomment-2634065717 @rg9975 you want to test as well? Smoke tests (i.e. NFS) looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add check befor fencing [cloudstack]
DaanHoogland commented on PR #10059: URL: https://github.com/apache/cloudstack/pull/10059#issuecomment-2634102078 @slavkap @rp- , I am moving this forward. I had re-based the code out of courtesy , but don't understand the issue beyond what I read in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Primera pure patches & various small fixes [cloudstack]
DaanHoogland commented on PR #10132: URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2634126067 > I have worked out a possible fix #10317 will regression test #10317 and merge it together with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
DaanHoogland commented on code in PR #10183:
URL: https://github.com/apache/cloudstack/pull/10183#discussion_r1941319276
##
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh:
##
@@ -115,6 +115,8 @@ setup_vpcrouter() {
sed -i "s#^OnCalendar=.*#OnCalendar=$LOGROTATE_FREQUENCY#g"
/usr/lib/systemd/system/logrotate.timer
sed -i 's#^AccuracySec=.*#AccuracySec=5m#g'
/usr/lib/systemd/system/logrotate.timer
+ sed -i 's/^#\(dhcp-leasefile=\/var\/lib\/misc\/dnsmasq.leases\)/\1/'
/etc/dnsmasq.conf
Review Comment:
this fails for isolated and shared network VRs :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2634233020 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634284674 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634286664 @DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634297775 [SF] Trillian Build Failed (tid-12309) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634299670 [SF] Trillian Build Failed (tid-12308) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634322307 [SF] Trillian Build Failed (tid-12310) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2634310837 [SF] Trillian Build Failed (tid-12311) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add API command remove management server [cloudstack]
nicoschmdt opened a new pull request, #10325:
URL: https://github.com/apache/cloudstack/pull/10325
### Description
This PR adds a command to mark a Management Server as removed on the
database only if its status is marked as `Down`. To execute the command, it is
obligatory to inform the `id` of the targeted MS.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
In a local lab, I added an MS through the database.
- With State="Down" I executed through CMK `remove managementserver
id=` and verified that the MS wasn't being listed on the UI and was
marked as `Removed` on the database.
- With State="Up" I executed the same command and verified an error was
returned informing it wasn't possible to remove an MS which state was marked as
"Up".
- With State="Down" I executed through a URL
`http://:8080/client/api?command=removeManagementServer&response=json&id=`
and verified the MS was marked as removed and wasn't being listed on the UI.
- With State="Up" I executed the same URL and received an error informing it
wasn't possible to remove an MS which state was marked as "Up".
- Trying to execute the command with a non-existent _id_ returns an error
warning the request format may be invalid, the entity may not exist, or the
parameter annotation may be wrong.
- Trying to execute the command without an _id_, both in CMK and with a URL,
returns an error informing the _id_ parameter is obligatory and it is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
DaanHoogland commented on PR #10183: URL: https://github.com/apache/cloudstack/pull/10183#issuecomment-2634433195 @weizhouapache @Pearl1594 , I think we can merge this as it does improve it for the issue reporter, but we are not done for redundant isolated networks, after this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
DaanHoogland commented on code in PR #10183:
URL: https://github.com/apache/cloudstack/pull/10183#discussion_r1941459403
##
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh:
##
@@ -115,6 +115,8 @@ setup_vpcrouter() {
sed -i "s#^OnCalendar=.*#OnCalendar=$LOGROTATE_FREQUENCY#g"
/usr/lib/systemd/system/logrotate.timer
sed -i 's#^AccuracySec=.*#AccuracySec=5m#g'
/usr/lib/systemd/system/logrotate.timer
+ sed -i 's/^#\(dhcp-leasefile=\/var\/lib\/misc\/dnsmasq.leases\)/\1/'
/etc/dnsmasq.conf
Review Comment:
so to specify, it does not fail for shared networks, it fails for redundant
isolated networks.
backup router:
primary:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
DaanHoogland commented on code in PR #10183:
URL: https://github.com/apache/cloudstack/pull/10183#discussion_r1941319276
##
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh:
##
@@ -115,6 +115,8 @@ setup_vpcrouter() {
sed -i "s#^OnCalendar=.*#OnCalendar=$LOGROTATE_FREQUENCY#g"
/usr/lib/systemd/system/logrotate.timer
sed -i 's#^AccuracySec=.*#AccuracySec=5m#g'
/usr/lib/systemd/system/logrotate.timer
+ sed -i 's/^#\(dhcp-leasefile=\/var\/lib\/misc\/dnsmasq.leases\)/\1/'
/etc/dnsmasq.conf
Review Comment:
this fails for isolated VRs :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Updated setup-sysvm-tmplt script, to run cmds without sudo [cloudstack]
blueorangutan commented on PR #10263: URL: https://github.com/apache/cloudstack/pull/10263#issuecomment-2634403043 [SF] Trillian Build Failed (tid-12307) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failures while assigning public IP via enableStaticNat [cloudstack]
shwstppr commented on issue #10313:
URL: https://github.com/apache/cloudstack/issues/10313#issuecomment-2633290172
@DaanHoogland I don't think webhooks is the cause here. The logs shared are
for the API call that finished in around 10s. I see multiple agent-server
Command-Answer communication taking few seconds. Also, multiple errors like,
```
2025-02-03 16:32:46,464 DEBUG [c.c.a.t.Request] (AgentManager-Handler-58:[])
(logid:) Seq 1-1529253548469028850: Processing: { Ans: , MgmtId:
108380656826451, via: 1, Ver: v1, Flags: 0,
[{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success:
Creating file in VR, with ip: 169.254.100.174, file:
staticnat_rules.json.ec8854ec-ec69-46e8-8192-60cbb8333222","null - success:
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
Error: Nexthop has invalid gateway.
```
Maybe the API needs optimization or there is underlying network issue
@akrasnov-drv do you also have logs where API calls started failing with
timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Tagged network offerings are not displayed [cloudstack]
rajujith commented on issue #10316: URL: https://github.com/apache/cloudstack/issues/10316#issuecomment-2633278128 @Pearl1594 looks like you fixed two issues with one PR 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
vishesh92 commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2633357041 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2633360455 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hide register template, create/upload volume and create vpc buttons when zone is not created. [cloudstack]
borisstoyanov commented on PR #10243: URL: https://github.com/apache/cloudstack/pull/10243#issuecomment-2633368881 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2633676624 [SF] Trillian test result (tid-12285) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 78949 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12285-xcpng82.zip Smoke tests completed. 133 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 161.44 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 185.47 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.31 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.44 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.44 | test_ipv4_routing.py test_01_prepare_and_cancel_maintenance | `Error` | 0.10 | test_ms_maintenance_and_safe_shutdown.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 10.66 | test_network.py test_01_non_strict_host_anti_affinity | `Error` | 219.41 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 113.39 | test_nonstrict_affinity_group.py test_02_create_volume | `Error` | 4.26 | test_resource_names.py test_05_scale_vm_dont_allow_disk_offering_change | `Failure` | 72.58 | test_scale_vm.py test_12_start_vm_multiple_volumes_allocated | `Error` | 19.05 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert #10240 [cloudstack]
DaanHoogland closed pull request #10314: Revert #10240 URL: https://github.com/apache/cloudstack/pull/10314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failures while assigning public IP via enableStaticNat [cloudstack]
weizhouapache commented on issue #10313:
URL: https://github.com/apache/cloudstack/issues/10313#issuecomment-260606
> Nexthop has invalid gateway.
it looks @akrasnov-drv uses redundant VRs, the error happens in the BACKUP
VR which do not have default route as the public nic is DOWN.
```
mgmt.log:2025-02-03 16:32:46,485 DEBUG [c.c.a.t.Request]
(qtp1438988851-11443:[ctx-5bff4776, ctx-109acf86, ctx-c08147b9])
(logid:d6760df6) Seq 9-1265230020314433522: Sending { Cmd , MgmtId:
108380656826451, via: 9(kvm23), Ver: v1, Flags: 100011,
[{"com.cloud.agent.api.routing.VmDataCommand":{"vmIpAddress":"10.10.240.223","vmName":"tiny-test206","executeInSequence":"false","accessDetails":{"router.name":"r-1055-VM","router.guest.ip":"10.10.250.155","router.ip":"169.254.158.18","zone.network.type":"Advanced"},"wait":"0","bypassHostMaintenance":"false"}}]
}
mgmt.log:2025-02-03 16:32:48,944 DEBUG [c.c.a.t.Request]
(AgentManager-Handler-2:[]) (logid:) Seq 9-1265230020314433522: Processing: {
Ans: , MgmtId: 108380656826451, via: 9, Ver: v1, Flags: 10,
[{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success:
Creating file in VR, with ip: 169.254.158.18, file:
vm_metadata.json.aff5bcbb-6aa2-44a8-bd2d-8100c26a1095","null - success: Invalid
unit name "cloud-password-server@10.10.240.1,10.10.250.155" escaped as
"cloud-password-server@10.10.240.1\x2c10.10.250.155" (maybe you should use
systemd-escape?).
mgmt.log:2025-02-03 16:32:48,955 DEBUG [c.c.a.t.Request]
(qtp1438988851-11443:[ctx-5bff4776, ctx-109acf86, ctx-c08147b9])
(logid:d6760df6) Seq 1-1529253548469028851: Sending { Cmd , MgmtId:
108380656826451, via: 1(h239), Ver: v1, Flags: 100011,
[{"com.cloud.agent.api.routing.VmDataCommand":{"vmIpAddress":"10.10.240.223","vmName":"tiny-test206","executeInSequence":"false","accessDetails":{"router.name":"r-1056-VM","router.guest.ip":"10.10.248.182","router.ip":"169.254.100.174","zone.network.type":"Advanced"},"wait":"0","bypassHostMaintenance":"false"}}]
}
mgmt.log:2025-02-03 16:32:50,667 DEBUG [c.c.a.t.Request]
(AgentManager-Handler-4:[]) (logid:) Seq 1-1529253548469028851: Processing: {
Ans: , MgmtId: 108380656826451, via: 1, Ver: v1, Flags: 10,
[{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success:
Creating file in VR, with ip: 169.254.100.174, file:
vm_metadata.json.f026f90b-9aa8-4e05-ae39-21c2b3113891","null - success: Error:
Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
mgmt.log:Error: Nexthop has invalid gateway.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2633722338 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failures while assigning public IP via enableStaticNat [cloudstack]
DaanHoogland commented on issue #10313: URL: https://github.com/apache/cloudstack/issues/10313#issuecomment-2633238735 @akrasnov-drv , do you have webhooks enabled? it seems like the issue is not in enableStaticNat itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2633243428 [SF] Trillian test result (tid-12283) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 67593 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12283-vmware-70u3.zip Smoke tests completed. 132 look OK, 9 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.29 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.41 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.41 | test_ipv4_routing.py test_deploy_more_vms_than_limit_allows | `Error` | 163.26 | test_deploy_vms_in_parallel.py test_01_prepare_and_cancel_maintenance | `Error` | 0.11 | test_ms_maintenance_and_safe_shutdown.py test_01_deployVMInSharedNetwork | `Failure` | 3.42 | test_network.py ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown | `Error` | 4.49 | test_network.py test_01_restore_vm | `Error` | 7.55 | test_restore_vm.py test_02_restore_vm_with_disk_offering | `Error` | 4.50 | test_restore_vm.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 7.50 | test_restore_vm.py test_04_restore_vm_allocated_root | `Error` | 8.73 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 20.23 | test_restore_vm.py test_01_deploy_vm_on_specific_host | `Error` | 4.35 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 4.32 | test_vm_deployment_planner.py test_03_deploy_vm_on_specific_pod | `Error` | 4.37 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.38 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.29 | test_vm_deployment_planner.py test_12_start_vm_multiple_volumes_allocated | `Error` | 16.97 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 8.86 | test_vm_strict_host_tags.py test_02_migrate_vm_strict_tags_failure | `Error` | 5.74 | test_vm_strict_host_tags.py test_01_restore_vm_strict_tags_success | `Error` | 8.80 | test_vm_strict_host_tags.py test_02_restore_vm_strict_tags_failure | `Error` | 8.84 | test_vm_strict_host_tags.py test_01_scale_vm_strict_tags_success | `Error` | 8.81 | test_vm_strict_host_tags.py test_02_scale_vm_strict_tags_failure | `Error` | 5.71 | test_vm_strict_host_tags.py test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 8.85 | test_vm_strict_host_tags.py test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 11.80 | test_vm_strict_host_tags.py test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 8.85 | test_vm_strict_host_tags.py test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 8.81 | test_vm_strict_host_tags.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 29.66 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 226.28 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
codecov[bot] commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2633380860 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10322?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.29%. Comparing base [(`238d0c5`)](https://app.codecov.io/gh/apache/cloudstack/commit/238d0c5e30a8445082050c9f35ff00f1cc9d096f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b1af099`)](https://app.codecov.io/gh/apache/cloudstack/commit/b1af09931a79ea02e0ba597dc72c8194f21fdaac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (238d0c5) and HEAD (b1af099). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (238d0c5) | HEAD (b1af099) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10322 +/- ## = - Coverage 15.16%4.29% -10.88% = Files 5408 366 -5042 Lines47394829605 -444343 Branches 57851 5194-52657 = - Hits 71883 1272-70611 + Misses 39402928188 -365841 + Partials 8036 145 -7891 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10322/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10322/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10322/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10322?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hide register template, create/upload volume and create vpc buttons when zone is not created. [cloudstack]
borisstoyanov commented on PR #10243: URL: https://github.com/apache/cloudstack/pull/10243#issuecomment-2633377793 just noticed it hasn't been built in a while. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hide register template, create/upload volume and create vpc buttons when zone is not created. [cloudstack]
blueorangutan commented on PR #10243: URL: https://github.com/apache/cloudstack/pull/10243#issuecomment-2633372576 @borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add allocation and disable thresholds per storage pool [cloudstack]
blueorangutan commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2633394737 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
DaanHoogland commented on PR #10317: URL: https://github.com/apache/cloudstack/pull/10317#issuecomment-2633303239 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (01f44b78939 -> 67ef397438e)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch healthcheck-4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
omit 01f44b78939 DO NOT MERGE
add 1b2f6c99985 Hide register template, create/upload volume and create
vpc buttons when zone is not created. (#10243)
add 67ef397438e DO NOT MERGE
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (01f44b78939)
\
N -- N -- N refs/heads/healthcheck-4.19 (67ef397438e)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
ui/src/config/section/compute.js | 5 +
ui/src/config/section/image.js | 8 ++--
ui/src/config/section/network.js | 17 +
ui/src/config/section/storage.js | 5 -
ui/src/{style/frame/content.less => utils/zone.js} | 12 +---
5 files changed, 29 insertions(+), 18 deletions(-)
copy ui/src/{style/frame/content.less => utils/zone.js} (83%)
Re: [I] Launching system vms fails during installation [cloudstack]
weizhouapache commented on issue #10319: URL: https://github.com/apache/cloudstack/issues/10319#issuecomment-2633829904 @SammyOina can you upload the logs of another system vm ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Launching system vms fails during installation [cloudstack]
SammyOina commented on issue #10319: URL: https://github.com/apache/cloudstack/issues/10319#issuecomment-2633838257 > [@SammyOina](https://github.com/SammyOina) can you upload the logs of another system vm ?  Both system vms keep starting and stopping soon after. Not sure I can get logs from them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: Add direct download option to Users GUI (#10193)
This is an automated email from the ASF dual-hosted git repository. joao pushed a commit to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.20 by this push: new 986ec81b664 Add direct download option to Users GUI (#10193) 986ec81b664 is described below commit 986ec81b664496cd0372e0e9d668122f968115a7 Author: Lucas Martins <56271185+lucas-a-mart...@users.noreply.github.com> AuthorDate: Tue Feb 4 14:36:29 2025 -0300 Add direct download option to Users GUI (#10193) Co-authored-by: Lucas Martins --- ui/src/views/image/RegisterOrUploadTemplate.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/views/image/RegisterOrUploadTemplate.vue b/ui/src/views/image/RegisterOrUploadTemplate.vue index 9523351ffd0..fb1a584b11f 100644 --- a/ui/src/views/image/RegisterOrUploadTemplate.vue +++ b/ui/src/views/image/RegisterOrUploadTemplate.vue @@ -214,7 +214,7 @@ - +
Re: [PR] Add direct download option to users in register template form [cloudstack]
JoaoJandre merged PR #10193: URL: https://github.com/apache/cloudstack/pull/10193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2635592481 [SF] Trillian test result (tid-12292) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 59335 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12292-xcpng82.zip Smoke tests completed. 76 look OK, 57 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 136.55 | test_accounts.py test_DeleteDomain | `Error` | 149.44 | test_accounts.py test_forceDeleteDomain | `Failure` | 147.38 | test_accounts.py test_01_user_remove_VM_running | `Error` | 119.28 | test_accounts.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 118.61 | test_affinity_groups_projects.py ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py test_01_events_resource | `Error` | 116.90 | test_events_resource.py test_01_events_resource | `Error` | 116.91 | test_events_resource.py ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py test_query_async_job_result | `Error` | 143.26 | test_async_job.py ContextSuite context=TestMultipleVolumeAttach>:setup | `Error` | 0.00 | test_attach_multiple_volumes.py test_01_condensed_drs_algorithm | `Failure` | 156.56 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 172.47 | test_cluster_drs.py test_deploy_vm_from_iso | `Error` | 159.18 | test_deploy_vm_iso.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 133.05 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 133.06 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 269.91 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 269.93 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 129.55 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 129.56 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 275.71 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 275.73 | test_internal_lb.py test_deploy_more_vms_than_limit_allows | `Error` | 125.39 | test_deploy_vms_in_parallel.py test_deployvm_firstfit | `Error` | 119.61 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userconcentrated | `Error` | 34.30 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdispersing | `Error` | 30.14 | test_deploy_vms_with_varied_deploymentplanners.py test_01_1_create_iso_with_checksum_sha1_negative | `Failure` | 6.30 | test_iso.py test_02_1_create_iso_with_checksum_sha256_negative | `Failure` | 6.29 | test_iso.py test_03_1_create_iso_with_checksum_md5_negative | `Failure` | 6.28 | test_iso.py test_04_extract_Iso | `Failure` | 1.09 | test_iso.py test_deployvm_userdata | `Error` | 121.72 | test_deploy_vm_with_userdata.py test_deployvm_userdata_post | `Error` | 33.27 | test_deploy_vm_with_userdata.py test_03_deploy_vm_domain_service_offering | `Error` | 148.53 | test_domain_service_offerings.py test_01_browser_migrate_template | `Error` | 5.44 | test_image_store_object_migration.py test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 205.19 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 214.98 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 207.01 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 205.83 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 211.21 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 220.14 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 292.04 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 235.66 | test_kubernetes_clusters.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py ContextSuite context=TestListVolumes>:setup | `Error` | 0.00 | test_list_volumes.py test_09_project_suspend | `Error` | 119.74 | test_projects.py test_10_project_activation | `Error` | 32.44 | test_projects.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_list_vms_metrics_admin | `Error` | 128.67 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 34.55 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 123.56 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 34.45 | test_metrics_api.py test_n
Re: [PR] Revert test of #10267 [cloudstack]
blueorangutan commented on PR #10323: URL: https://github.com/apache/cloudstack/pull/10323#issuecomment-2635644723 [SF] Trillian test result (tid-12299) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57017 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12299-vmware-70u3.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 482.57 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 482.60 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 590.05 | test_internal_lb.py test_12_destroy_cpvm | `Error` | 6.38 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2635651295 [SF] Trillian test result (tid-12302) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 57154 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10322-t12302-kvm-ubuntu22.zip Smoke tests completed. 130 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 142.90 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 142.14 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 140.50 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 143.91 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 145.23 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 144.79 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 223.96 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 161.56 | test_kubernetes_clusters.py test_10_attachAndDetach_iso | `Error` | 6.44 | test_vm_life_cycle.py test_12_start_vm_multiple_volumes_allocated | `Error` | 14.09 | test_vm_life_cycle.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 423.97 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert test of #10267 [cloudstack]
blueorangutan commented on PR #10323: URL: https://github.com/apache/cloudstack/pull/10323#issuecomment-2635654237 [SF] Trillian test result (tid-12298) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 57948 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12298-kvm-ubuntu22.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_unsecure_vm_migration | `Error` | 249.03 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 164.85 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 160.83 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix pod retrieval during volume attach [cloudstack]
blueorangutan commented on PR #10324: URL: https://github.com/apache/cloudstack/pull/10324#issuecomment-2635662972 [SF] Trillian test result (tid-12306) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48183 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10324-t12306-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_unsecure_vm_migration | `Error` | 499.08 | test_vm_life_cycle.py test_12_start_vm_multiple_volumes_allocated | `Error` | 17.37 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add IOPS and bytes preset variables to `VOLUME` usage type [cloudstack]
lucas-a-martins opened a new pull request, #10326:
URL: https://github.com/apache/cloudstack/pull/10326
### Description
This PR adds the following preset variables to the activation rules of
`VOLUME` Quota tariffs:
Disk Offering:
- `value.diskOffering.bytesReadRate`: returns a `long` with the bytes read
rate of the disk offering;
- `value.diskOffering.bytesReadBurst`: returns a `long` with the burst bytes
read rate of the disk offering;
- `value.diskOffering.bytesReadBurstLength`: returns the length, in seconds,
of the bytes read rate burst;
- `value.diskOffering.bytesWriteRate`: returns a `long` with the bytes write
rate of the disk offering;
- `value.diskOffering.bytesWriteBurst`: returns a `long` with the burst
bytes write rate of the disk offering;
- `value.diskOffering.bytesWriteBurstLength`: returns the length, in
seconds, of the bytes write rate burst;
- `value.diskOffering.iopsReadRate`: returns a `long` with the I/O requests
read rate of the disk offering;
- `value.diskOffering.iopsReadBurst`: returns a `long` with the burst I/O
requests read rate of the disk offering;
- `value.diskOffering.iopsReadBurstLength`: returns the length, in seconds,
of the IOPS read burst in seconds;
- `value.diskOffering.iopsWriteRate`: returns a `long` with the I/O requests
write rate of the disk offering;
- `value.diskOffering.iopsWriteBurst`: returns a `long` with the burst I/O
requests write rate of the disk offering;
- `value.diskOffering.iopsWriteBurstLength`: returns the length, in seconds,
of the IOPS write burst.
Volume:
- `value.volumeType`: the volume type. Values can be: `UNKNOWN`, `ROOT`,
`SWAP`, `DATADISK` and `ISO`.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
First, I executed the `quotaPresetVariablesList` API using the parameter
`usagetype=6`, and it listed all the new preset variables.
Then, in the `Create Quota Tariff` form, I checked if the presets were
available for different usage types by using them in an activation rule and
pressing the `Validate activation rule` button. As expected, the `VOLUME` usage
type was the only one that didn't result in an error.
Finally, for each preset variable, I created a tariff using them, and the
tariff was applied in every case, as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add IOPS and bytes preset variables to `VOLUME` usage type [cloudstack]
codecov[bot] commented on PR #10326: URL: https://github.com/apache/cloudstack/pull/10326#issuecomment-2635120748 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10326?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.01%. Comparing base [(`cd81398`)](https://app.codecov.io/gh/apache/cloudstack/commit/cd81398cb7176698196f72002df5d6088befbaed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5138512`)](https://app.codecov.io/gh/apache/cloudstack/commit/5138512c7805f0d9805c2e76758710c099a3ceaa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (cd81398) and HEAD (5138512). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (cd81398) | HEAD (5138512) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10326 +/- ## = - Coverage 16.02%4.01% -12.02% = Files 5658 395 -5263 Lines49631232441 -463871 Branches 60109 5741-54368 = - Hits 79527 1302-78225 + Misses 40794330990 -376953 + Partials 8842 149 -8693 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10326/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10326/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.01% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10326/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10326?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
DaanHoogland commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2633253494 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failures while assigning public IP via enableStaticNat [cloudstack]
weizhouapache commented on issue #10313: URL: https://github.com/apache/cloudstack/issues/10313#issuecomment-2633258201 > What's interesting, after releasing all IPs I was able to assign IPs again, but even with delays between executions it started failing after 3 assigned IP, each time enableStaticNat took longer: @akrasnov-drv have you increase the setting `workers` and restart mgmt server ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
