Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]

[via GitHub]

DaanHoogland commented on code in PR #10183:
URL: https://github.com/apache/cloudstack/pull/10183#discussion_r1941459403


##########
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh:
##########
@@ -115,6 +115,8 @@ setup_vpcrouter() {
   sed -i "s#^OnCalendar=.*#OnCalendar=$LOGROTATE_FREQUENCY#g" 
/usr/lib/systemd/system/logrotate.timer
   sed -i 's#^AccuracySec=.*#AccuracySec=5m#g' 
/usr/lib/systemd/system/logrotate.timer
 
+  sed -i 's/^#\(dhcp-leasefile=\/var\/lib\/misc\/dnsmasq.leases\)/\1/' 
/etc/dnsmasq.conf

Review Comment:
   so to specify, it does not fail for shared networks, it fails for redundant 
isolated networks. 
   backup router:
   
![image](https://github.com/user-attachments/assets/35beb902-6735-42d8-b09c-3f10e6a5229d)
   primary:
   
![image](https://github.com/user-attachments/assets/5f703322-af66-4280-93bf-ee7e680ba7a1)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org