lucas-a-martins opened a new pull request, #10326: URL: https://github.com/apache/cloudstack/pull/10326
### Description This PR adds the following preset variables to the activation rules of `VOLUME` Quota tariffs: <details> <summary>Disk Offering:</summary> - `value.diskOffering.bytesReadRate`: returns a `long` with the bytes read rate of the disk offering; - `value.diskOffering.bytesReadBurst`: returns a `long` with the burst bytes read rate of the disk offering; - `value.diskOffering.bytesReadBurstLength`: returns the length, in seconds, of the bytes read rate burst; - `value.diskOffering.bytesWriteRate`: returns a `long` with the bytes write rate of the disk offering; - `value.diskOffering.bytesWriteBurst`: returns a `long` with the burst bytes write rate of the disk offering; - `value.diskOffering.bytesWriteBurstLength`: returns the length, in seconds, of the bytes write rate burst; - `value.diskOffering.iopsReadRate`: returns a `long` with the I/O requests read rate of the disk offering; - `value.diskOffering.iopsReadBurst`: returns a `long` with the burst I/O requests read rate of the disk offering; - `value.diskOffering.iopsReadBurstLength`: returns the length, in seconds, of the IOPS read burst in seconds; - `value.diskOffering.iopsWriteRate`: returns a `long` with the I/O requests write rate of the disk offering; - `value.diskOffering.iopsWriteBurst`: returns a `long` with the burst I/O requests write rate of the disk offering; - `value.diskOffering.iopsWriteBurstLength`: returns the length, in seconds, of the IOPS write burst. </details> <details> <summary>Volume:</summary> - `value.volumeType`: the volume type. Values can be: `UNKNOWN`, `ROOT`, `SWAP`, `DATADISK` and `ISO`. </details> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? First, I executed the `quotaPresetVariablesList` API using the parameter `usagetype=6`, and it listed all the new preset variables. Then, in the `Create Quota Tariff` form, I checked if the presets were available for different usage types by using them in an activation rule and pressing the `Validate activation rule` button. As expected, the `VOLUME` usage type was the only one that didn't result in an error. Finally, for each preset variable, I created a tariff using them, and the tariff was applied in every case, as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
