Re: [PR] fix nat table by getting the fitting device for an address [cloudstack]
blueorangutan commented on PR #9552: URL: https://github.com/apache/cloudstack/pull/9552#issuecomment-2446335917 @DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
DaanHoogland commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446314340 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix nat table by getting the fitting device for an address [cloudstack]
DaanHoogland commented on PR #9552: URL: https://github.com/apache/cloudstack/pull/9552#issuecomment-2446334901 @blueorangutan LLpackage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
slavkap commented on code in PR #9852:
URL: https://github.com/apache/cloudstack/pull/9852#discussion_r1822324487
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -504,7 +504,7 @@ public boolean isLocalStorageActiveOnHost(Long hostId) {
List storagePoolHostRefs =
_storagePoolHostDao.listByHostId(hostId);
for (StoragePoolHostVO storagePoolHostRef : storagePoolHostRefs) {
StoragePoolVO PrimaryDataStoreVO =
_storagePoolDao.findById(storagePoolHostRef.getPoolId());
Review Comment:
```suggestion
StoragePoolVO primaryDataStoreVO =
_storagePoolDao.findById(storagePoolHostRef.getPoolId());
```
code LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Cloudstack Doesn't check if the ISO is Bootable or not [cloudstack]
andrijapanicsb commented on issue #9842: URL: https://github.com/apache/cloudstack/issues/9842#issuecomment-2446443577 Makes no sense to even think about this improvement. The user should (and currently does) tick the box if its bootable or not. I would close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
DaanHoogland commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446432851 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Certificate error when downloading ISO (keystore not set up correctly) [cloudstack]
weizhouapache commented on issue #9086: URL: https://github.com/apache/cloudstack/issues/9086#issuecomment-2446466568 > > > > @tdtmusic2 > > it looks like the certs have been imported into the realhostip.keystore maybe an operation has overwritten the keystore file with the original keystore, need investigation > > Is it possible for you to upload the /var/log/cloud.log and .1/.2 files ? > > Here you go. [logs.zip](https://github.com/user-attachments/files/17568219/logs.zip) @tdtmusic2 it looks like you have patched the SSVM after upgrade from 4.19.1.1 to 4.19.1.2 ``` cloud.log.2:2024-09-25 12:27:06,222 INFO [cloud.agent.AgentShell] (main:null) Implementation Version is 4.19.1.1 cloud.log.2:2024-09-25 12:27:13,588 INFO [cloud.agent.AgentShell] (main:null) Implementation Version is 4.19.1.1 ... cloud.log:2024-10-22 08:04:57,736 INFO [cloud.agent.AgentShell] (main:null) Implementation Version is 4.19.1.2 cloud.log:2024-10-29 07:49:54,902 INFO [cloud.agent.AgentShell] (main:null) Implementation Version is 4.19.1.2 ``` @salfers just to confirm , did you patch the system vm after upgrade as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
blueorangutan commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446437535 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
DaanHoogland commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446197859 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
blueorangutan commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446209832 UI build failed: :heavy_multiplication_x: (SL-JID-473) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
blueorangutan commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446200171 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Certificate error when downloading ISO (keystore not set up correctly) [cloudstack]
tdtmusic2 commented on issue #9086: URL: https://github.com/apache/cloudstack/issues/9086#issuecomment-2446127514 > > > > > > > @tdtmusic2 good to know it works. > > > > > > > If the SSVM has been running for some days, the cloud.log might be rotated as cloud.log.*.gz > > > > > > > > > > > > > > > > > > There are only cloud.log, cloud.log.1 and cloud.log.2 in /var/log, yet nothing in them like you mentioned.. > > > > > > > > > > > > > > > @tdtmusic2 oh, I thought they are compressed... then please check `cloud.log.2` > > > > > > > > > > > > See above, I edited the ips where they were showing, hope that's ok. > > > > > > > > > everything looks ok > > > can you run one more command ? > > > zgrep realhostip /var/log/daemon.log* > > > > > > Here's the output: > > ``` > > /var/log/daemon.log.2.gz:Sep 12 11:42:50 systemvm cloud-early-config[1009]: + keytool -importkeystore -srckeystore /etc/ssl/certs/java/cacerts -destkeystore /usr/local/cloud/systemvm/certs/realhostip.keystore -srcstorepass changeit -deststorepass vmops.com -noprompt > > /var/log/daemon.log.2.gz:Sep 12 11:42:51 systemvm cloud-early-config[1043]: Importing keystore /etc/ssl/certs/java/cacerts to /usr/local/cloud/systemvm/certs/realhostip.keystore... > > /var/log/daemon.log.2.gz:Sep 12 11:42:51 systemvm cloud-early-config[1043]: The JKS keystore uses a proprietary format. It is recommended to migrate to PKCS12 which is an industry standard format using "keytool -importkeystore -srckeystore /usr/local/cloud/systemvm/certs/realhostip.keystore -destkeystore /usr/local/cloud/systemvm/certs/realhostip.keystore -deststoretype pkcs12". > > ``` > > @tdtmusic2 > > it looks like the certs have been imported into the realhostip.keystore maybe an operation has overwritten the keystore file with the original keystore, need investigation > > Is it possible for you to upload the /var/log/cloud.log and .1/.2 files ? Here you go. [logs.zip](https://github.com/user-attachments/files/17568219/logs.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI improvements [cloudstack]
sureshanaparti commented on code in PR #9773:
URL: https://github.com/apache/cloudstack/pull/9773#discussion_r1822360345
##
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##
@@ -425,3 +425,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,
hypervisor_type, hypervi
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance', 'delete_protection',
'boolean DEFAULT FALSE COMMENT "delete protection for vm" ');
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'delete_protection',
'boolean DEFAULT FALSE COMMENT "delete protection for volumes" ');
+
+-- Create a new group for Usage Server related configurations
+INSERT INTO `cloud`.`configuration_group` (`name`, `description`,
`precedence`) VALUES ('Usage Server', 'Usage Server related configuration', 9);
Review Comment:
yes, the config keys will be discover group and sub-group if they doesn't
have (so, mostly for the new configs added after this new group & subgroup). If
the config keys already have (all existing configs) and need to be re-discover
to this, then schema path needs to remove group and sub-group for the configs
Or update configs with group and sub-group ids with the new group and sub-group
ids added here.
cc @abh1sar @borisstoyanov @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] fix nat table by getting the fitting device for an address [cloudstack]
blueorangutan commented on PR #9552: URL: https://github.com/apache/cloudstack/pull/9552#issuecomment-2446521512 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: el9 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 6213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Certificate error when downloading ISO (keystore not set up correctly) [cloudstack]
salfers commented on issue #9086: URL: https://github.com/apache/cloudstack/issues/9086#issuecomment-2446488217 I don't remember exactly but it's likely that we did that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
sureshanaparti commented on code in PR #9852:
URL: https://github.com/apache/cloudstack/pull/9852#discussion_r1822497745
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -504,7 +504,7 @@ public boolean isLocalStorageActiveOnHost(Long hostId) {
List storagePoolHostRefs =
_storagePoolHostDao.listByHostId(hostId);
for (StoragePoolHostVO storagePoolHostRef : storagePoolHostRefs) {
StoragePoolVO PrimaryDataStoreVO =
_storagePoolDao.findById(storagePoolHostRef.getPoolId());
Review Comment:
good catch @slavkap , addressed few others as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
sureshanaparti commented on PR #9852: URL: https://github.com/apache/cloudstack/pull/9852#issuecomment-2446953559 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Certificate error when downloading ISO (keystore not set up correctly) [cloudstack]
weizhouapache commented on issue #9086: URL: https://github.com/apache/cloudstack/issues/9086#issuecomment-2447075021 thanks @salfers @tdtmusic2 I am able to reproduce the issue by patching the system vm with force=true I will create a fix for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StorPool: fix of delete snapshot [cloudstack]
slavkap commented on code in PR #9855:
URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1822667046
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java:
##
@@ -117,10 +116,11 @@ public boolean deleteSnapshot(Long snapshotId, Long
zoneId) {
if (resp.getError() != null) {
final String err = String.format("Failed to clean-up
Storpool snapshot %s. Error: %s", name, resp.getError());
StorPoolUtil.spLog(err);
-markSnapshotAsDestroyedIfAlreadyRemoved(snapshotId, resp);
+markSnapshotAsDestroyedIfAlreadyRemoved(snapshotId,
resp.getError().getName().equals("objectDoesNotExist"));
Review Comment:
Thanks @sureshanaparti, I made the change as you suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch python3-vr deleted (was eb2ae84dfe2)
This is an automated email from the ASF dual-hosted git repository. gabriel pushed a change to branch python3-vr in repository https://gitbox.apache.org/repos/asf/cloudstack.git was eb2ae84dfe2 pip3 install pycodestyle The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] UI improvements [cloudstack]
sureshanaparti commented on code in PR #9773:
URL: https://github.com/apache/cloudstack/pull/9773#discussion_r1822360345
##
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##
@@ -425,3 +425,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,
hypervisor_type, hypervi
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance', 'delete_protection',
'boolean DEFAULT FALSE COMMENT "delete protection for vm" ');
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'delete_protection',
'boolean DEFAULT FALSE COMMENT "delete protection for volumes" ');
+
+-- Create a new group for Usage Server related configurations
+INSERT INTO `cloud`.`configuration_group` (`name`, `description`,
`precedence`) VALUES ('Usage Server', 'Usage Server related configuration', 9);
Review Comment:
yes, the config keys will be discover group and sub-group if they doesn't
have. If config keys already have and need to be re-discover to this, then
schema path needs to remove group and sub-group for the configs Or update
configs with group and sub-group ids with the new config group and sub-group
ids.
cc @abh1sar @borisstoyanov @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] ui: Allow font-awesome icon usage and optimise icon size inconsistency [cloudstack]
GutoVeronezi commented on code in PR #9744:
URL: https://github.com/apache/cloudstack/pull/9744#discussion_r1823089256
##
ui/src/components/header/ProjectMenu.vue:
##
@@ -81,7 +81,7 @@ export default {
const projects = []
const getNextPage = () => {
this.loading = true
-api('listProjects', { listAll: true, page: page, pageSize: 500,
showIcon: true }).then(json => {
+api('listProjects', { listAll: true, page: page, pageSize: 500,
details: 'min', showIcon: true }).then(json => {
Review Comment:
@rohityadavcloud, how this line is related to the issue and the PR's
proposal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
blueorangutan commented on PR #9852: URL: https://github.com/apache/cloudstack/pull/9852#issuecomment-2447280096 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HTTP ERROR 503 Service Unavailable [cloudstack]
purteppers commented on issue #9815: URL: https://github.com/apache/cloudstack/issues/9815#issuecomment-2447642588 > > I was having the exact same issue on AlmaLinux 9.3 and this resolved the problem as well. > > @purteppers do you use mysql 8.0 as well ? Yes, specifically 8.0.36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HTTP ERROR 503 Service Unavailable [cloudstack]
gobiursus commented on issue #9815: URL: https://github.com/apache/cloudstack/issues/9815#issuecomment-2447806556 I suggest we shouldn't use MySQL from its official repo, we should use MariaDB from repo of Debian Stable. On October 30, 2024 4:02:10 PM UTC, purteppers ***@***.***> wrote: >> > I was having the exact same issue on AlmaLinux 9.3 and this resolved the problem as well. >> >> @purteppers do you use mysql 8.0 as well ? > >Yes, specifically 8.0.36 > > >-- >Reply to this email directly or view it on GitHub: >https://github.com/apache/cloudstack/issues/9815#issuecomment-2447642588 >You are receiving this because you were mentioned. > >Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] extraconfig issue after upgrade cloudstack [cloudstack]
shulemmosko opened a new issue, #9875: URL: https://github.com/apache/cloudstack/issues/9875 # ISSUE TYPE * Bug Report # COMPONENT NAME KVM Extraconfig # CLOUDSTACK VERSION 4.18.2.4 # CONFIGURATION extraconfig-1 # OS / ENVIRONMENT N/A # SUMMARY I had a VM with a vTPM configured in the settings as follow **extraconfig-1** it was working fine untill i upgraded cloudstack to 4.18.2.4 after i upgraded cloudstack i cant start the VM im getting the following error  and the extraconfig is graied out i cannot remove it or edit it.  # STEPS TO REPRODUCE # EXPECTED RESULTS the extraconfig device to work properly after upgrading cloudstack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HTTP ERROR 503 Service Unavailable [cloudstack]
purteppers commented on issue #9815: URL: https://github.com/apache/cloudstack/issues/9815#issuecomment-2447590179 > I have the same issue after upgrading from 4.19.0.0 to 4.19.1.2 on Ubuntu 22.04. MySQL and the management server are running on the same node. After the following steps, the management console works now (although it may not be a good solution since the password is saved in plaintext). The problem may be related to somewhere around encryption / decryption logic? > > 1. downgrade Java version from 17 to 11 > > 2. edit `/etc/cloudstack/management/db.properties` > > > ```diff > --- db.properties.bak 2024-10-25 08:51:07.179157143 +0900 > +++ db.properties 2024-10-25 08:50:10.391852007 +0900 > @@ -22,7 +22,7 @@ > > # CloudStack database settings > db.cloud.username=cloud > -db.cloud.password=ENC() > +db.cloud.password=plain_password_text > db.cloud.host=localhost > db.cloud.driver=jdbc:mysql > db.cloud.port=3306 > @@ -53,7 +53,7 @@ > > # usage database settings > db.usage.username=cloud > -db.usage.password=ENC() > +db.usage.password=plain_password_text > db.usage.host=localhost > db.usage.driver=jdbc:mysql > db.usage.port=3306 > @@ -100,4 +100,4 @@ > db.usage.secondsBeforeRetrySource=3600 > db.usage.queriesBeforeRetrySource=5000 > db.usage.initialTimeout=3600 > -db.cloud.encryptor.version=V2 > +#db.cloud.encryptor.version=V2 > ``` > > ``` > $ java -version > openjdk version "11.0.24" 2024-07-16 > OpenJDK Runtime Environment (build 11.0.24+8-post-Ubuntu-1ubuntu322.04) > OpenJDK 64-Bit Server VM (build 11.0.24+8-post-Ubuntu-1ubuntu322.04, mixed mode, sharing) > > $ mysqld --version > /usr/sbin/mysqld Ver 8.0.39-0ubuntu0.22.04.1 for Linux on x86_64 ((Ubuntu)) > > $ cat /etc/lsb-release > DISTRIB_ID=Ubuntu > DISTRIB_RELEASE=22.04 > DISTRIB_CODENAME=jammy > DISTRIB_DESCRIPTION="Ubuntu 22.04.5 LTS" > ``` I was having the exact same issue on AlmaLinux 9.3 and this resolved the problem as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
sureshanaparti commented on PR #9852: URL: https://github.com/apache/cloudstack/pull/9852#issuecomment-2446938291 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] HTTP ERROR 503 Service Unavailable [cloudstack]
weizhouapache commented on issue #9815: URL: https://github.com/apache/cloudstack/issues/9815#issuecomment-2447623340 > I was having the exact same issue on AlmaLinux 9.3 and this resolved the problem as well. @purteppers do you use mysql 8.0 as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
blueorangutan commented on PR #9852: URL: https://github.com/apache/cloudstack/pull/9852#issuecomment-2447135738 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Kubernetes cluster view when user is unable to scale [cloudstack]
blueorangutan commented on PR #9867: URL: https://github.com/apache/cloudstack/pull/9867#issuecomment-2446315769 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] OVS Netplan yaml config Ubuntu 22.04 documentation [cloudstack]
rohityadavcloud commented on issue #8983: URL: https://github.com/apache/cloudstack/issues/8983#issuecomment-2446834116 Thanks @Agility0493 so that does seem an issue with Netplan https://askubuntu.com/questions/1333570/is-there-a-way-to-create-an-open-vswitch-internal-port-with-netplan - have you tested the latest Ubuntu 22.04 or 24.04 if it works with openvswitch config works with netplan now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logging to include more identifiable information [cloudstack]
codecov[bot] commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2446720891 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9873?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.04%. Comparing base [(`019f2c6`)](https://app.codecov.io/gh/apache/cloudstack/commit/019f2c60ceb7a7c15c670a98280bd5764a5fcf5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`17329b1`)](https://app.codecov.io/gh/apache/cloudstack/commit/17329b1b2c2f89a84bcc6718a6a5d4bdd969ea8f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (019f2c6) and HEAD (17329b1). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (019f2c6) | HEAD (17329b1) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9873 +/- ## - Coverage 15.78% 4.04% -11.75% Files 5627 392 -5235 Lines492250 32171 -460079 Branches 614055677-55728 - Hits 777101301-76409 + Misses 406066 30722 -375344 + Partials 8474 148 -8326 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9873/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9873?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloudstack Doesn't check if the ISO is Bootable or not [cloudstack]
DaanHoogland commented on issue #9842: URL: https://github.com/apache/cloudstack/issues/9842#issuecomment-2446393649 @kiranchavala , this does not seem a bug to me. If ACS could or would check for bootability we would not need the checkbox in the first place. and next, at what time would this check happen if we automate it (which I'm all for btw). I can only think we can after fully downloading on the ssvm at which time it doesn't really make sense anymore to refuse to download it. We could mark it appropriately at that moment, but than we ga against the users express command? TBD, I'd say. cc @rajujith @andrijapanicsb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StorPool: fix of delete snapshot [cloudstack]
sureshanaparti commented on code in PR #9855:
URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1822475183
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java:
##
@@ -117,10 +116,11 @@ public boolean deleteSnapshot(Long snapshotId, Long
zoneId) {
if (resp.getError() != null) {
final String err = String.format("Failed to clean-up
Storpool snapshot %s. Error: %s", name, resp.getError());
StorPoolUtil.spLog(err);
-markSnapshotAsDestroyedIfAlreadyRemoved(snapshotId, resp);
+markSnapshotAsDestroyedIfAlreadyRemoved(snapshotId,
resp.getError().getName().equals("objectDoesNotExist"));
Review Comment:
@slavkap maybe, you can define these string constants in StorPoolUtil and
use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]
JoaoJandre commented on code in PR #9844:
URL: https://github.com/apache/cloudstack/pull/9844#discussion_r1822432093
##
server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java:
##
@@ -622,9 +628,35 @@ private Pair
performCapacityChecksBeforeHostInMaintenance(Host
for (VMInstanceVO runningVM : vmsRunning) {
boolean canMigrateVm = false;
ServiceOfferingVO serviceOffering =
serviceOfferingDao.findById(runningVM.getServiceOfferingId());
+Integer cpu = serviceOffering.getCpu();
+Integer speed = serviceOffering.getSpeed();
+Integer ramSize = serviceOffering.getRamSize();
+if (serviceOffering.isDynamic()) {
+List vmDetails =
userVmDetailsDao.listDetails(runningVM.getId());
+if (CollectionUtils.isNotEmpty(vmDetails)) {
+for (UserVmDetailVO vmDetail : vmDetails) {
+if (vmDetail.getName() != null &&vmDetail.getValue()
!= null) {
+if (cpu == null &&
VmDetailConstants.CPU_NUMBER.equals(vmDetail.getName())) {
+cpu = Integer.valueOf(vmDetail.getValue());
+}
+if (speed == null &&
VmDetailConstants.CPU_SPEED.equals(vmDetail.getName())) {
+speed = Integer.valueOf(vmDetail.getValue());
+}
+if (ramSize == null &&
VmDetailConstants.MEMORY.equals(vmDetail.getName())) {
+ramSize = Integer.valueOf(vmDetail.getValue());
+}
+}
+}
+}
+}
+if (cpu == null || speed == null || ramSize == null) {
Review Comment:
Could use `ObjectUtils.anyNull()`
##
server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java:
##
@@ -622,9 +628,35 @@ private Pair
performCapacityChecksBeforeHostInMaintenance(Host
for (VMInstanceVO runningVM : vmsRunning) {
boolean canMigrateVm = false;
ServiceOfferingVO serviceOffering =
serviceOfferingDao.findById(runningVM.getServiceOfferingId());
+Integer cpu = serviceOffering.getCpu();
+Integer speed = serviceOffering.getSpeed();
+Integer ramSize = serviceOffering.getRamSize();
+if (serviceOffering.isDynamic()) {
+List vmDetails =
userVmDetailsDao.listDetails(runningVM.getId());
+if (CollectionUtils.isNotEmpty(vmDetails)) {
+for (UserVmDetailVO vmDetail : vmDetails) {
+if (vmDetail.getName() != null &&vmDetail.getValue()
!= null) {
Review Comment:
```suggestion
if (vmDetail.getName() != null &&
vmDetail.getValue() != null) {
```
##
server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java:
##
@@ -622,9 +628,35 @@ private Pair
performCapacityChecksBeforeHostInMaintenance(Host
for (VMInstanceVO runningVM : vmsRunning) {
boolean canMigrateVm = false;
ServiceOfferingVO serviceOffering =
serviceOfferingDao.findById(runningVM.getServiceOfferingId());
+Integer cpu = serviceOffering.getCpu();
+Integer speed = serviceOffering.getSpeed();
+Integer ramSize = serviceOffering.getRamSize();
+if (serviceOffering.isDynamic()) {
+List vmDetails =
userVmDetailsDao.listDetails(runningVM.getId());
+if (CollectionUtils.isNotEmpty(vmDetails)) {
+for (UserVmDetailVO vmDetail : vmDetails) {
+if (vmDetail.getName() != null &&vmDetail.getValue()
!= null) {
+if (cpu == null &&
VmDetailConstants.CPU_NUMBER.equals(vmDetail.getName())) {
+cpu = Integer.valueOf(vmDetail.getValue());
+}
+if (speed == null &&
VmDetailConstants.CPU_SPEED.equals(vmDetail.getName())) {
+speed = Integer.valueOf(vmDetail.getValue());
+}
+if (ramSize == null &&
VmDetailConstants.MEMORY.equals(vmDetail.getName())) {
+ramSize = Integer.valueOf(vmDetail.getValue());
+}
+}
+}
+}
+}
+if (cpu == null || speed == null || ramSize == null) {
+s_logger.warn(String.format("Cannot fetch compute resources
for the VM %s, skipping it from the capacity check", runningVM));
+continue;
+}
Review Comment:
Definitely, also, maybe add some unit tests for the created method?
##
server/src/main/java/com/cloud/resource/Rollin
[PR] Improve logging to include more identifiable information [cloudstack]
vishesh92 opened a new pull request, #9873:
URL: https://github.com/apache/cloudstack/pull/9873
### Description
This PR updates the logging for some modules to ensure that we log more
details to easily identify resources from the logs.
e.g. We use id at a lot of places in the logs and it makes it difficult to
know about the resource without querying the database. This PR makes changes to
include uuid or any other relevant fields to the objects in the logs so that
the user can easily identify the resource.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Improve logging to include more identifiable information [cloudstack]
vishesh92 commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2446694574 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list hosts API fix, when any stale entries exists on storage_pool_host_ref for the removed pools [cloudstack]
slavkap commented on code in PR #9852:
URL: https://github.com/apache/cloudstack/pull/9852#discussion_r1822667626
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -504,7 +504,7 @@ public boolean isLocalStorageActiveOnHost(Long hostId) {
List storagePoolHostRefs =
_storagePoolHostDao.listByHostId(hostId);
for (StoragePoolHostVO storagePoolHostRef : storagePoolHostRefs) {
StoragePoolVO PrimaryDataStoreVO =
_storagePoolDao.findById(storagePoolHostRef.getPoolId());
Review Comment:
Great! Thanks @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] extraconfig issue after upgrade cloudstack [cloudstack]
GutoVeronezi commented on issue #9875: URL: https://github.com/apache/cloudstack/issues/9875#issuecomment-2448936940 > How can i remove the extraconfig if its grayed out > I need to be able to power on this vm > > Thanks! Hello @shulemmosko You can try to remove the extraconfig by calling the updateVirtualMachine API via CMK with all the details you have in the VM, expect the extraconfig. For the whole syntax of the command, you might want to take a look at the browser's network tab when you update anything in the VM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Http direct downloader can not get size of non compressed qcow2 [cloudstack]
borisstoyanov commented on issue #9835: URL: https://github.com/apache/cloudstack/issues/9835#issuecomment-2446160775 Hi @hulucc, could you please use the template for issues. Also could you please provide steps to reproduce/logs/error messages that would help investigation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
