sureshanaparti commented on code in PR #9773:
URL: https://github.com/apache/cloudstack/pull/9773#discussion_r1822360345


##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -425,3 +425,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, 
hypervisor_type, hypervi
 
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance', 'delete_protection', 
'boolean DEFAULT FALSE COMMENT "delete protection for vm" ');
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'delete_protection', 
'boolean DEFAULT FALSE COMMENT "delete protection for volumes" ');
+
+-- Create a new group for Usage Server related configurations
+INSERT INTO `cloud`.`configuration_group` (`name`, `description`, 
`precedence`) VALUES ('Usage Server', 'Usage Server related configuration', 9);

Review Comment:
   yes, the config keys will be discover group and sub-group if they doesn't 
have (so, mostly for the new configs added after this new group & subgroup). If 
the config keys already have (all existing configs) and need to be re-discover 
to this, then schema path needs to remove group and sub-group for the configs 
Or update configs with group and sub-group ids with the new group and sub-group 
ids added here.
   
   cc @abh1sar @borisstoyanov @rohityadavcloud 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to