sureshanaparti commented on code in PR #9855:
URL: https://github.com/apache/cloudstack/pull/9855#discussion_r1822475183
##########
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/snapshot/StorPoolSnapshotStrategy.java:
##########
@@ -117,10 +116,11 @@ public boolean deleteSnapshot(Long snapshotId, Long
zoneId) {
if (resp.getError() != null) {
final String err = String.format("Failed to clean-up
Storpool snapshot %s. Error: %s", name, resp.getError());
StorPoolUtil.spLog(err);
- markSnapshotAsDestroyedIfAlreadyRemoved(snapshotId, resp);
+ markSnapshotAsDestroyedIfAlreadyRemoved(snapshotId,
resp.getError().getName().equals("objectDoesNotExist"));
Review Comment:
@slavkap maybe, you can define these string constants in StorPoolUtil and
use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
