[GitHub] [cloudstack] DaanHoogland commented on pull request #4773: Fix deploy VM from ISOs with UEFI

[GitBox]

DaanHoogland commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-797316884


   In your opinion @slavkap, can we automate those tests in a marvin script, 
using a smaller linux iso?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4701: Added support for removing unused port groups on VMWare

[GitBox]

DaanHoogland commented on pull request #4701:
URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-797320059


   code looks good @Spaceman1984 , but i don't see how it is being called. Am I 
missing something?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on issue #4757: issues with life migration on centos (was: Trillian test failures)

[GitBox]

DaanHoogland commented on issue #4757:
URL: https://github.com/apache/cloudstack/issues/4757#issuecomment-797326810


   I've added a PR to skip the tests on centos #4801, of course that does not 
solve the underlying problem but we can not implement features on hypervisors 
that do not support them.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4675: Bug fix in displaying public IP address of shared networks

[GitBox]

rhtyd commented on pull request #4675:
URL: https://github.com/apache/cloudstack/pull/4675#issuecomment-797327950


   @Spaceman1984 can you help manually test/verify this? cc @shwstppr Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #4801: skip lifemigration for centos

[GitBox]

shwstppr commented on pull request #4801:
URL: https://github.com/apache/cloudstack/pull/4801#issuecomment-797332488


   @DaanHoogland there seems some issue with one of the test - 
test_02_migrate_VM_with_two_data_disks. I found it failing on Ubuntu18 as well,
   
   ```
   [root@pr4710-t97-kvm-ubuntu18-marvin marvin]# nosetests --with-xunit 
--xunit-file=results.xml --with-marvin 
--marvin-config=./pr4710-t97-kvm-ubuntu18-advanced-cfg -s -a tags=advanced 
--hypervisor=KVM tests/smoke/atest.py
   
    Marvin Init Started 
   
   === Marvin Parse Config Successful ===
   
   === Marvin Setting TestData Successful===
   
    Log Folder Path: /marvin/MarvinLogs/Mar_12_2021_08_37_07_133UM3. All 
logs will be available here 
   
   === Marvin Init Logging Successful===
   
    Marvin Init Successful 
   === TestName: test_01_migrate_VM_and_root_volume | Status : SUCCESS ===
   
   === TestName: test_02_migrate_VM_with_two_data_disks | Status : EXCEPTION ===
   
   ```
   
   ```
   2021-03-12 08:39:14,524 DEBUG [o.a.c.s.v.VolumeServiceImpl] 
(Work-Job-Executor-73:ctx-ad649327 job-188/job-189 ctx-896c5319) 
(logid:3d8a7bb9) Failed to copy volume
   com.cloud.utils.exception.CloudRuntimeException: Copy operation failed in 
'StorageSystemDataMotionStrategy.copyAsync': null
at 
org.apache.cloudstack.storage.motion.StorageSystemDataMotionStrategy.copyAsync(StorageSystemDataMotionStrategy.java:1901)
at 
org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:119)
at 
org.apache.cloudstack.storage.volume.VolumeServiceImpl.migrateVolumes(VolumeServiceImpl.java:1645)
at 
org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.migrateVolumes(VolumeOrchestrator.java:1181)
at 
com.cloud.vm.VirtualMachineManagerImpl.orchestrateMigrateWithStorage(VirtualMachineManagerImpl.java:3000)
at 
com.cloud.vm.VirtualMachineManagerImpl.orchestrateMigrateWithStorage(VirtualMachineManagerImpl.java:5524)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
at 
com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5631)
at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:568)
at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
   2021-03-12 08:39:14,524 DEBUG [o.a.c.e.o.VolumeOrchestrator] 
(Work-Job-Executor-73:ctx-ad649327 job-188/job-189 ctx-896c5319) 
(logid:3d8a7bb9) Failed to migrated vm VM[User|i-9-20-VM] along with its 
volumes. com.cloud.utils.exception.CloudRuntimeException: Copy operation failed 
in 'StorageSystemDataMotionStrategy.copyAsync': null
   2021-03-12 08:39:14,524 INFO  [c.c.v.VirtualMachineManagerImpl] 
(Work-Job-Executor-73:ctx-ad649327 job-188/job-189 ctx-896c5319) 
(logid:3d8a7bb9) Migration was unsuccessful.  Cleaning up: VM[User|i-9-20-VM]
   2021-03-12 08:39:14,524 WARN  [c.c.a.AlertManagerImpl] 
(Work-Job-Executor-73:ctx-ad649327 job-188/job-189 ctx-896c5319) 
(logid:3d8a7bb9) AlertType:: 17 | dataCenterId:: 1 | podId:: 1 | clusterId:: 
null | message:: Unable to migrate vm i-9-20-VM from host 
template-ubuntu180401-2 in zone pr4710-t97-kvm-ubuntu18 and pod 
pr4710-t97-kvm-ubuntu18
   2021-03-12 08:39:14,525 DEBUG [c.c.a.AlertManagerImpl] 
(Work-Job-Executor-73:ctx-ad649327 job-188/job-189 ctx-896c5319) 
(logid:3d8a7bb9) Have already s

[GitHub] [cloudstack] weizhouapache commented on pull request #4801: skip lifemigration for centos

[GitBox]

weizhouapache commented on pull request #4801:
URL: https://github.com/apache/cloudstack/pull/4801#issuecomment-797338002


   > @weizhouapache @shwstppr @rhtyd please let me know if this needs to go on 
4.15. as it is only an intergration test skipping, I didn't deeem it important.
   
   @DaanHoogland To be honest, I suspect the failures are caused by some 
changes in code, not infrastructure/os side.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch marvin3 updated (bc09184 -> 25fb029)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch marvin3
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from bc09184  clean up VMs
 add 25fb029  remove superfluent arg

No new revisions were added by this update.

Summary of changes:
 test/integration/smoke/test_portable_publicip.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[GitHub] [cloudstack] DaanHoogland closed issue #4753: Bug in download page verification instructions

[GitBox]

DaanHoogland closed issue #4753:
URL: https://github.com/apache/cloudstack/issues/4753


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland closed issue #4752: Bug: incorrect link to issue tracker

[GitBox]

DaanHoogland closed issue #4752:
URL: https://github.com/apache/cloudstack/issues/4752


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-www] branch master updated (bb435e0 -> 5ff6d74)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git.


from bb435e0  downloads: use 
https://downloads.apache.org/cloudstack/releases links
 add 604bd98  update issues link
 add b53f8ff  checksum procedures
 new 5ff6d74  Merge pull request #79 from apache/DaanHoogland-patch-1

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/contribute.html| 2 +-
 source/downloads.html.markdown.erb | 9 ++---
 2 files changed, 7 insertions(+), 4 deletions(-)

[cloudstack-www] 01/01: Merge pull request #79 from apache/DaanHoogland-patch-1

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit 5ff6d746a324ac796858b363691bc10b7961dd12
Merge: bb435e0 b53f8ff
Author: dahn 
AuthorDate: Fri Mar 12 09:55:41 2021 +0100

Merge pull request #79 from apache/DaanHoogland-patch-1

 content/contribute.html| 2 +-
 source/downloads.html.markdown.erb | 9 ++---
 2 files changed, 7 insertions(+), 4 deletions(-)

[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

[GitBox]

rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797341382


   @soreana this looks like a good enhancement. @DaanHoogland @shwstppr should 
we consider/ask for 4.15.1?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume

[GitBox]

rhtyd commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-797341868


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume

[GitBox]

blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-797342307


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress. [S]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4775: [Backport] #4698 Fix npe when migrating vm with volume

[GitBox]

blueorangutan commented on pull request #4775:
URL: https://github.com/apache/cloudstack/pull/4775#issuecomment-797352992


   Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: 
centos8 :heavy_check_mark: debian. SL-JID 97



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-www] branch master updated: double-quotes

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/master by this push:
 new 9d93c94  double-quotes
9d93c94 is described below

commit 9d93c94e6600b95a2c05c1c87419143ddf84
Author: Daan Hoogland 
AuthorDate: Fri Mar 12 10:16:30 2021 +0100

double-quotes
---
 source/downloads.html.markdown.erb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/downloads.html.markdown.erb 
b/source/downloads.html.markdown.erb
index 1cd5e86..ffad3b0 100644
--- a/source/downloads.html.markdown.erb
+++ b/source/downloads.html.markdown.erb
@@ -139,7 +139,7 @@ main distribution directory, rather than from a mirror. 
Then verify the signatur
 % gpg --import KEYS
 % gpg --verify apache-cloudstack-X.X.X-src.tar.bz2.asc 
apache-cloudstack-X.X.X-src.tar.bz2
 
-Please see https://www.apache.org/info/verification.html#CheckingSignatures>CheckingSignatures
 for a more extensive explanation of the pgp verification.
+Please see https://www.apache.org/info/verification.html#CheckingSignatures";>CheckingSignatures
 for a more extensive explanation of the pgp verification.
 
 Additionally, you can verify the SHA512 signatures on the files, by performing
 

[cloudstack-www] branch asf-site updated (4c49c67 -> 7c44b93)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git.


from 4c49c67  build master
 add 604bd98  update issues link
 add b53f8ff  checksum procedures
 add 5ff6d74  Merge pull request #79 from apache/DaanHoogland-patch-1
 add 9d93c94  double-quotes
 add 5f3ab83  updated PR79 to include compiled content
 new 7c44b93  Merge branch 'master' into asf-site

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/downloads.html | 9 ++---
 source/downloads.html.markdown.erb | 9 ++---
 2 files changed, 12 insertions(+), 6 deletions(-)

[cloudstack-www] 01/01: Merge branch 'master' into asf-site

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit 7c44b93ccfcf26f0f063938f38594a0bfe118ea9
Merge: 4c49c67 5f3ab83
Author: Daan Hoogland 
AuthorDate: Fri Mar 12 10:24:37 2021 +0100

Merge branch 'master' into asf-site

 content/downloads.html | 9 ++---
 source/downloads.html.markdown.erb | 9 ++---
 2 files changed, 12 insertions(+), 6 deletions(-)

[GitHub] [cloudstack] shwstppr commented on pull request #4675: Bug fix in displaying public IP address of shared networks

[GitBox]

shwstppr commented on pull request #4675:
URL: https://github.com/apache/cloudstack/pull/4675#issuecomment-797360468


   @ravening still some issue



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4675: Bug fix in displaying public IP address of shared networks

[GitBox]

ravening commented on pull request #4675:
URL: https://github.com/apache/cloudstack/pull/4675#issuecomment-797361250


   > @ravening still some issue
   
   @shwstppr but I dont think the issue is with ip management.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ravening removed a comment on pull request #4675: Bug fix in displaying public IP address of shared networks

[GitBox]

ravening removed a comment on pull request #4675:
URL: https://github.com/apache/cloudstack/pull/4675#issuecomment-797361250


   > @ravening still some issue
   
   @shwstppr but I dont think the issue is with ip management.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DK101010 opened a new pull request #4802: version 2.11 is incompatible with java 11

[GitBox]

DK101010 opened a new pull request #4802:
URL: https://github.com/apache/cloudstack/pull/4802


   With 2.11 wire mock tests hanging and mvn can't execute in thread mode.
   Update to 2.27.2(newest version)
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Build cs with tests and multithreading in my env. 
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-www] branch release-4.15 updated (0634262 -> 2e85b08)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch release-4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git.


from 0634262  site updates for 4.15
 add 2e85b08  added 4.14.1

No new revisions were added by this update.

Summary of changes:
 data/cloudstack.yml | 2 ++
 1 file changed, 2 insertions(+)

[GitHub] [cloudstack] slavkap commented on pull request #4773: Fix deploy VM from ISOs with UEFI

[GitBox]

slavkap commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-797366632


   Hi @DaanHoogland, what should be the expectations of Marvin's tests? I mean, 
do they have to do an automated install (probably with a kickstart for CentOS) 
and check if UEFI is enabled. Or deploy a VM from ISO with UEFI secure/legacy 
and check that we have access to it through ssh?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4675: Bug fix in displaying public IP address of shared networks

[GitBox]

Spaceman1984 commented on pull request #4675:
URL: https://github.com/apache/cloudstack/pull/4675#issuecomment-797369613


   > @Spaceman1984 can you help manually test/verify this? cc @shwstppr Thanks.
   
   I'll test @rhtyd 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on issue #4778: Listhostsmetric cpuallocated >100%

[GitBox]

DaanHoogland commented on issue #4778:
URL: https://github.com/apache/cloudstack/issues/4778#issuecomment-797372878


   agree, just make sure you don't change the semantics or format of any key 
causing backwards incompatibilities (unless the current filling of a value is 
obviously a bug, but even than,...)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4675: Bug fix in displaying public IP address of shared networks

[GitBox]

ravening commented on pull request #4675:
URL: https://github.com/apache/cloudstack/pull/4675#issuecomment-797375897


   > @ravening still some issue
   
   @shwstppr found the issue.. without the change, if ip address is in free 
state, its not displayed by `list publicipaddress` command but with this 
change, it will be displayed. so need to pass an extra param `state=Allocated`. 
Then its not displayed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4793: systemvmtemplate: new template for 4.15.1

[GitBox]

DaanHoogland commented on a change in pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#discussion_r593047900



##
File path: 
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java
##
@@ -58,6 +66,175 @@ public boolean supportsRollingUpgrade() {
 public void performDataMigration(Connection conn) {
 }
 
+@Override
+@SuppressWarnings("serial")
+public void updateSystemVmTemplates(final Connection conn) {
+LOG.debug("Updating System Vm template IDs");
+final Set hypervisorsListInUse = new 
HashSet();
+try (PreparedStatement pstmt = conn.prepareStatement("select 
distinct(hypervisor_type) from `cloud`.`cluster` where removed is null"); 
ResultSet rs = pstmt.executeQuery()) {
+while (rs.next()) {
+switch (Hypervisor.HypervisorType.getType(rs.getString(1))) {
+case XenServer:
+
hypervisorsListInUse.add(Hypervisor.HypervisorType.XenServer);
+break;
+case KVM:
+
hypervisorsListInUse.add(Hypervisor.HypervisorType.KVM);
+break;
+case VMware:
+
hypervisorsListInUse.add(Hypervisor.HypervisorType.VMware);
+break;
+case Hyperv:
+
hypervisorsListInUse.add(Hypervisor.HypervisorType.Hyperv);
+break;
+case LXC:
+
hypervisorsListInUse.add(Hypervisor.HypervisorType.LXC);
+break;
+case Ovm3:
+
hypervisorsListInUse.add(Hypervisor.HypervisorType.Ovm3);
+break;
+default:
+break;
+}
+}
+} catch (final SQLException e) {
+LOG.error("updateSystemVmTemplates: Exception caught while getting 
hypervisor types from clusters: " + e.getMessage());
+throw new CloudRuntimeException("updateSystemVmTemplates:Exception 
while getting hypervisor types from clusters", e);
+}
+
+final Map NewTemplateNameList = new 
HashMap() {
+{
+put(Hypervisor.HypervisorType.KVM, "systemvm-kvm-4.15.1");
+put(Hypervisor.HypervisorType.VMware, 
"systemvm-vmware-4.15.1");
+put(Hypervisor.HypervisorType.XenServer, 
"systemvm-xenserver-4.15.1");
+put(Hypervisor.HypervisorType.Hyperv, 
"systemvm-hyperv-4.15.1");
+put(Hypervisor.HypervisorType.LXC, "systemvm-lxc-4.15.1");
+put(Hypervisor.HypervisorType.Ovm3, "systemvm-ovm3-4.15.1");
+}
+};
+
+final Map 
routerTemplateConfigurationNames = new HashMap() {
+{
+put(Hypervisor.HypervisorType.KVM, "router.template.kvm");
+put(Hypervisor.HypervisorType.VMware, 
"router.template.vmware");
+put(Hypervisor.HypervisorType.XenServer, 
"router.template.xenserver");
+put(Hypervisor.HypervisorType.Hyperv, 
"router.template.hyperv");
+put(Hypervisor.HypervisorType.LXC, "router.template.lxc");
+put(Hypervisor.HypervisorType.Ovm3, "router.template.ovm3");
+}
+};
+
+final Map newTemplateUrl = new 
HashMap() {
+{
+put(Hypervisor.HypervisorType.KVM, 
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-kvm.qcow2.bz2";);
+put(Hypervisor.HypervisorType.VMware, 
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-vmware.ova";);
+put(Hypervisor.HypervisorType.XenServer, 
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-xen.vhd.bz2";);
+put(Hypervisor.HypervisorType.Hyperv, 
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-hyperv.vhd.zip";);
+put(Hypervisor.HypervisorType.LXC, 
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-kvm.qcow2.bz2";);
+put(Hypervisor.HypervisorType.Ovm3, 
"https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-ovm.raw.bz2";);
+}
+};
+
+final Map newTemplateChecksum = new 
HashMap() {
+{
+put(Hypervisor.HypervisorType.KVM, 
"0e9f9a7d0957c3e0a2088e41b2da2cec");
+put(Hypervisor.HypervisorType.XenServer, 
"86373992740b1eca8aff8b08ebf3aea5");
+put(Hypervisor.HypervisorType.VMware, 
"4006982765846d373eb3719b2fe4d720");
+put(Hypervisor.HypervisorType.Hyperv, 
"0b9514e4b6cba1f636fea2125f0f7a5f");
+put(Hypervisor.HypervisorType.LXC, 
"0e9f9a7d0957c3e0a2088e41b2da2cec");
+put(Hypervisor.HypervisorType.Ovm3, 
"ae3977e696b3e6c81bdcbb792d514d29");
+

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4793: systemvmtemplate: new template for 4.15.1

[GitBox]

DaanHoogland commented on a change in pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#discussion_r593048761



##
File path: tools/appliance/systemvmtemplate/template.json
##
@@ -36,8 +36,8 @@
   "disk_size": 2500,
   "disk_interface": "virtio",
   "net_device": "virtio-net",
-  "iso_url": 
"https://download.cloudstack.org/systemvm/debian/debian-10.5.0-amd64-netinst.iso";,
-  "iso_checksum": 
"0a6aee1d9aafc1ed095105c052f9fdd65ed00ea9274188c9cd0072c8e6838ab40e246d45a1e6956d74ef1b04a1fc042151762f25412e9ff0cbf49418eef7992e",
+  "iso_url": 
"https://cdimage.debian.org/debian-cd/10.8.0/amd64/iso-cd/debian-10.8.0-amd64-netinst.iso";,

Review comment:
   debian tends to move their ISOs, is this the best way, or should we keep 
a vopy as we used to?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4801: skip lifemigration for centos

[GitBox]

weizhouapache commented on pull request #4801:
URL: https://github.com/apache/cloudstack/pull/4801#issuecomment-797381283


   @DaanHoogland I checked the result of pr #4582 which are good.
   ```
   Test Deploy Virtual Machine ... === TestName: test_01_deploy_vm | Status : 
SUCCESS ===
   ok
   Test advanced zone virtual router ... === TestName: 
test_02_advZoneVirtualRouter | Status : SUCCESS ===
   ok
   Test Multiple Deploy Virtual Machine ... === TestName: 
test_04_deploy_vm_multiple | Status : SUCCESS ===
   ok
   Test Stop Virtual Machine ... === TestName: test_05_stop_vm | Status : 
SUCCESS ===
   ok
   Test Force Stop Virtual Machine ... === TestName: test_06_stop_vm_forced | 
Status : SUCCESS ===
   ok
   Test Start Virtual Machine ... === TestName: test_07_start_vm | Status : 
SUCCESS ===
   ok
   Test Reboot Virtual Machine ... === TestName: test_08_reboot_vm | Status : 
SUCCESS ===
   ok
   Test destroy Virtual Machine ... === TestName: test_09_destroy_vm | Status : 
SUCCESS ===
   ok
   Test recover Virtual Machine ... === TestName: test_10_restore_vm | Status : 
SUCCESS ===
   ok
   Test migrate VM ... === TestName: test_11_migrate_vm | Status : SUCCESS ===
   ok
   Test destroy(expunge) Virtual Machine ... === TestName: test_12_expunge_vm | 
Status : SUCCESS ===
   ok
   Test for attach and detach ISO to virtual machine ... === TestName: 
test_13_attachAndDetach_iso | Status : SUCCESS ===
   ok
   Test secure VM migration ... === TestName: 
test_14_secure_to_secure_vm_migration | Status : SUCCESS ===
   ok
   Test destroy Virtual Machine ... === TestName: 
test_15_secured_to_nonsecured_vm_migration | Status : SUCCESS ===
   ok
   Test Non-secured VM Migration ... === TestName: 
test_16_nonsecured_to_secured_vm_migration | Status : SUCCESS ===
   ok
   
   --
   Ran 15 tests in 1172.225s
   
   OK
   ```
   
   Strange I cannot find some test cases in 
test/integration/smoke/test_vm_life_cycle.py and its history !!
   
   
   the test cases in result for pr #4531 are same as what we see in 
test/integration/smoke/test_vm_life_cycle.py
   
   ```
   Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
   ok
   Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
   ok
   Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
   ok
   Test VM will be migrated with it's root volume ... === TestName: 
test_01_migrate_VM_and_root_volume | Status : EXCEPTION ===
   ERROR
   Test VM will be migrated with it's root volume ... === TestName: 
test_02_migrate_VM_with_two_data_disks | Status : EXCEPTION ===
   ERROR
   Test VM will be migrated with it's root volume ... SKIP: VM Migration with 
Volumes is not supported on other than VMware
   Test VM will be migrated with it's root volume ... SKIP: VM Migration with 
Volumes is not supported on other than VMware
   Test VM will be migrated with it's root volume ... SKIP: VM Migration with 
Volumes is not supported on other than VMware
   Test secure VM migration ... === TestName: test_01_secure_vm_migration | 
Status : SUCCESS ===
   ok
   Test Non-secured VM Migration ... === TestName: 
test_02_unsecure_vm_migration | Status : SUCCESS ===
   ok
   Test destroy Virtual Machine ... === TestName: 
test_03_secured_to_nonsecured_vm_migration | Status : SUCCESS ===
   ok
   Test Non-secured VM Migration ... === TestName: 
test_04_nonsecured_to_secured_vm_migration | Status : SUCCESS ===
   ok
   Test the following: ... SKIP: Skipping test: Reason -  hypervisorNotSupported
   Test the following for all found ovf templates: ... SKIP: Skipping test: 
Reason -  hypervisorNotSupported
   Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
   ok
   Test Force Stop Virtual Machine ... === TestName: test_01_stop_vm_forced | 
Status : SUCCESS ===
   ok
   Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
   ok
   Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
   ok
   Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : 
SUCCESS ===
   ok
   Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : 
SUCCESS ===
   ok
   Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
   ok
   Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | 
Status : SUCCESS ===
   ok
   Test for attach and detach ISO to virtual machine ... === TestName: 
test_10_attachAndDetach_iso | Status : SUCCESS ===
   ok
   Test destroy Virtual Machine and it's volumes ... === TestName: 
test_11_destroy_vm_and_volumes | Status : SUCCESS ===
   ok
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please lo

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4801: skip lifemigration for centos

[GitBox]

weizhouapache commented on a change in pull request #4801:
URL: https://github.com/apache/cloudstack/pull/4801#discussion_r593056295



##
File path: test/integration/smoke/test_vm_life_cycle.py
##
@@ -1443,6 +1443,12 @@ def setUp(self):
 if len(self.hosts) < 2:
 self.skipTest("Requires at least two hosts for performing 
migration related tests")
 
+
+for host in self.hosts:

Review comment:
   @DaanHoogland it seems not be a CentOS issue, but issue with test 
scripts or libvrt/kvm plugin.
   let's skip the live migration with volume on kvm at first, so trillian test 
for other prs is good.
   
   we can fix the issue afterwards. it needs investigation.
   
   could you change the lines to skip the test by checking the host hypervisor 
instead of host os ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4794: server: filter null details during volume to template creation

[GitBox]

DaanHoogland commented on pull request #4794:
URL: https://github.com/apache/cloudstack/pull/4794#issuecomment-797386465


   clgtm, but; while this solves the problem that null values are allowed on 
volume details and not on template values, this problem is not the root of the 
issue. Why this discrepancy? I see no reason for the difference and I think we 
need to address that and not work around it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on issue #4799: GSoC 2021 idea: New marvin tests service

[GitBox]

weizhouapache commented on issue #4799:
URL: https://github.com/apache/cloudstack/issues/4799#issuecomment-797389443


   @nvazquez good.
   I do not know if administrators are interested in it, but it will help 
cloudstack developers a lot !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration

[GitBox]

DaanHoogland commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797389521


   @weizhouapache I'm confused by your description in context of the code 
change. If we do have a disk, but no backing format, we go ahead and rebase it 
as qcow2, am I right?
   and if we don't have a file path or we do have a backing format, we do 
nothing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

[GitBox]

weizhouapache commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797392700


   > @weizhouapache I'm confused by your description in context of the code 
change. If we do have a disk, but no backing format, we go ahead and rebase it 
as qcow2, am I right?
   > and if we don't have a file path or we do have a backing format, we do 
nothing.
   
   @DaanHoogland I changed the title and description.
   
   we do nothing if (1) disk does not have a backing file ; (2) disk has 
backing file, and also backing file format.
   we set backing file format only if disk has a backing file but does not have 
backing file format.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4779: Fix NPE while cloudstack agent failed to connect to mgt server

[GitBox]

blueorangutan commented on pull request #4779:
URL: https://github.com/apache/cloudstack/pull/4779#issuecomment-797392702


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 
:heavy_check_mark: debian. SL-JID 98



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

[GitBox]

weizhouapache edited a comment on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797392700


   > @weizhouapache I'm confused by your description in context of the code 
change. If we do have a disk, but no backing format, we go ahead and rebase it 
as qcow2, am I right?
   > and if we don't have a file path or we do have a backing format, we do 
nothing.
   
   @DaanHoogland I changed the title and description.
   
   we do nothing if (1) disk does not have a backing file ; (2) disk has 
backing file, and also backing file format.
   we set backing file format only if disk has a backing file but backing file 
format is missing



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

[GitBox]

DaanHoogland commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797393607


   @rhtyd (cc @soreana ) though it is a minor change it does include AI and DB 
changes, so I'd say leave it for 4.16 (that is not a definite :-1: at all, just 
a expression of our merge principles and principles are there to be broken with)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4773: Fix deploy VM from ISOs with UEFI

[GitBox]

DaanHoogland commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-797397490


   > Hi @DaanHoogland, what should be the expectations of Marvin's tests? I 
mean, do they have to do an automated install (probably with a kickstart for 
CentOS) and check if UEFI is enabled. Or deploy a VM from ISO with UEFI 
secure/legacy and check that we have access to it through ssh?
   
   @slavkap, the only expectation is that the verification is automated. This 
could be with ssh to host or instance, but also with APIs. Both are done a lot 
in the current set of tests. the problem would probably be with the install 
from ISO I imagine, but it was a genuine question, You did the testing and 
probably know best if the manual actions can be automated in python.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on issue #4696: GSoC 2021 Idea: Add virt-v2v support in CloudStack for cold migration of VM from VMware/XenServer to KVM

[GitBox]

weizhouapache commented on issue #4696:
URL: https://github.com/apache/cloudstack/issues/4696#issuecomment-797401605


   @rhtyd 
   fyi, we used libguestfs/guestfish and rsync to convert openvz containers to 
kvm vm in the past.
   https://www.youtube.com/watch?v=mmWs9H7dnNA



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4801: skip lifemigration for centos

[GitBox]

DaanHoogland commented on a change in pull request #4801:
URL: https://github.com/apache/cloudstack/pull/4801#discussion_r593077404



##
File path: test/integration/smoke/test_vm_life_cycle.py
##
@@ -1443,6 +1443,12 @@ def setUp(self):
 if len(self.hosts) < 2:
 self.skipTest("Requires at least two hosts for performing 
migration related tests")
 
+
+for host in self.hosts:

Review comment:
   I could, but since the tests are for KVM only anyway, that would 
effectively mean disabling the tests completely.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on issue #4799: GSoC 2021 idea: New marvin tests service

[GitBox]

DaanHoogland commented on issue #4799:
URL: https://github.com/apache/cloudstack/issues/4799#issuecomment-797404730


   Nota Bene: a lot of tests leave garbage around, I've done a lot of cleanup 
during python3 migration of marvin tests, but it is far from clean now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

[GitBox]

DaanHoogland commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797406054


   > > @weizhouapache I'm confused by your description in context of the code 
change. If we do have a disk, but no backing format, we go ahead and rebase it 
as qcow2, am I right?
   > > and if we don't have a file path or we do have a backing format, we do 
nothing.
   > 
   > @DaanHoogland I changed the title and description.
   > 
   > we do nothing if (1) disk does not have a backing file ; (2) disk has 
backing file, and also backing file format.
   > we set backing file format only if disk has a backing file but backing 
file format is missing
   
   exactly what the code does, good text for the tin ;)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] sebbASF commented on issue #4752: Bug: incorrect link to issue tracker

[GitBox]

sebbASF commented on issue #4752:
URL: https://github.com/apache/cloudstack/issues/4752#issuecomment-797408876


   AFAICT the web page has not been updated



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] slavkap commented on pull request #4773: Fix deploy VM from ISOs with UEFI

[GitBox]

slavkap commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-797413493


   @DaanHoogland, I could do the python tests, but the only problem (for me) is 
the automating of the installation. I should research how and is it possible to 
automate the installation from ISO. This will take time, and I can't commit how 
much



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

[GitBox]

weizhouapache commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797413805


   > @rhtyd (cc @soreana ) though it is a minor change it does include AI and 
DB changes, so I'd say leave it for 4.16 (that is not a definite 👎 at all, just 
a expression of our merge principles and principles are there to be broken with)
   
   @DaanHoogland  let's merge it to 4.16.
   as far as I know, 4.15 accepts only bug fixes and security fixes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch python3-benchmark created (now 25fb029)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch python3-benchmark
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 25fb029  remove superfluent arg

No new revisions were added by this update.

[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

[GitBox]

rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797464622


   +1 I didn't look at code changes, if it involved db changes.
   
   On Fri, 12 Mar, 2021, 4:27 pm Wei Zhou, ***@***.***> wrote:
   
   > @rhtyd  (cc @soreana
   >  ) though it is a minor change it does
   > include AI and DB changes, so I'd say leave it for 4.16 (that is not a
   > definite 👎 at all, just a expression of our merge principles and
   > principles are there to be broken with)
   >
   > @DaanHoogland  let's merge it to 4.16.
   > as far as I know, 4.15 accepts only bug fixes and security fixes.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

[GitBox]

rhtyd commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593146838



##
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
 Map info = qemu.info(file);
 String backingFilePath = info.get(new String("backing_file"));
 String backingFileFormat = info.get(new 
String("backing_file_format"));
-if 
(org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+&& 
org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {

Review comment:
   What if the backing file format is not empty? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache opened a new issue #4803: GSoC 2021 Idea: Add SPICE console for vms on KVM/XenServer

[GitBox]

weizhouapache opened a new issue #4803:
URL: https://github.com/apache/cloudstack/issues/4803


   ## Background
   
   CloudStack provides ajax vnc view and novnc console to access vm. It would 
be good to have spice console for vms on kvm/xenserver.
   
   ## Proposed Tasks
   
   - Get started on basic CloudStack codebase and development (building and 
running CloudStack)
   - Setup KVM based CloudStack dev/test environment
   - Setup Xenserver based CloudStack dev/test environment
   - Test websockify-based SPICE console
   - Add websockify/spice-html5 source code in cloudstack
   - Run websockify server with token authentication
   - Implement a http server in CPVM to verify websockify token.
   - Create URL with a token to access novnc/spice console
   
   ps1: VNC password will be removed from vm xml definition as it is not 
supported by websockify.
   ps2: websockify-based novnc console can be added as well.
   
   ### Relevant Skills
   - Java
   - python (few)
   - networking (few)
   
   ## Proposed Mentor
   
   Wei Zhou, PMC/commiter Apache CloudStack
   
   ## Difficulty
   
   Major
   
   ## Potential Mentors
   
   Wei Zhou, PMC/commiter Apache CloudStack
   
   ### Example and references
   https://www.spice-space.org/spice-html5.html
   https://gitlab.freedesktop.org/spice/spice-html5
   https://github.com/novnc/websockify
   https://docs.openstack.org/nova/pike/admin/remote-console-access.html
   https://github.com/novnc/noVNC
   
   # ISSUE TYPE
   
* Feature Idea



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

[GitBox]

weizhouapache commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593155348



##
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
 Map info = qemu.info(file);
 String backingFilePath = info.get(new String("backing_file"));
 String backingFileFormat = info.get(new 
String("backing_file_format"));
-if 
(org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+&& 
org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {

Review comment:
   @rhtyd then it is fine, we do nothing.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch marvin3 updated (25fb029 -> adb8b6b)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch marvin3
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


omit 25fb029  remove superfluent arg
omit bc09184  clean up VMs
omit 004cd05  ip to net address conversions
omit 0862765  byte as separator on byte[]
omit 14e7e87  more cleanup for test_accounts
omit 8705a1f  syntax (suerfluent '.')
omit 406c069  no importing of False in python3 (or in sensible code)
omit 6e2c4d2  cleanup fir ip tests
omit 7f4fa43  format and cleanup internal lb tests
omit 0a2c2f3  write as byte[]
omit 65bc352  read files in vr as list(byte[])
omit 3f24df8  cleanup hygiene
omit d5cba75  further cleanup of resource heavy test
omit 76d67d1  test tag removed
omit 3265df3  cleanup imports
omit c5b028a  cleanup, indent, taberrors
omit 0fa8e71  another indentation issue identified
omit cddd321  another network for cleanup
omit 587c8ac  cleanup incosistent passing test
omit 9d21efd  rigorous cleanup discipline
omit 5d25d49  cleanup and indentation
omit 82ffd02  artifact tag removed
omit 64c4538  message attribute not available on exception
omit dd1f3ae  endodestring can't consume a string, needs bytes
omit d4432d4  remove false copy-block
omit 73f5ff2  encodestring() instead of b64encode()
omit d17360c  cleanup and fix autoindent issues
omit f3a670a  Revert python version change from 3.8 to 3.9
omit 69d72bd  Upgrade pip
omit a62c0d4  Change python version due to cryptography
omit 6b23cd0  setuptools upgrade
omit c308ac5  nose to install (from before_install)
omit 56b5912  skip lifemigration for centos
omit 8ffb0a1  just to see
omit e561b19  Update before_install.sh
omit 6216a3c  svm to p3
omit 86ffc1e  str f'ormat'
omit 42b50ba  pylint issues
omit 33bc9ac  replace mock with unittest.mock
omit 7c97896  pylint cmd debug
omit 23472e8  Fix indentation issues and use python3 when running 
pycodestyle checker
omit 28ff962  Make Virtual Router '.py' scripts Python3 compatible
omit d816774  reformat because of indentation problems
omit 88b4229  cleanup and feedback from internal version
omit ec13d78  retries on ssh verification
omit 193f6e5  redundant braces removed
omit 95a7a4b  cleanup
omit e86d43d  cleanup of setup() (not sure why this would help)
omit 07cc2a5  socketserver take bytes
omit 1bbec82  inherritics
omit 442e4f0  2to3 artifact/remnance removed
omit b351ff5  exception assert fix
omit 4b1dfd1  remove superfluent parentesis
omit d496385  str() when str() due
omit a1fe05e  foutje bedank: None vs 0
omit 9048981  unittest method rename assertItemEqual to assertCountEqual
omit 7a11abd  awkward encode-decode of userdata
omit a4a1030  only fetchall for select statements
omit 62643b9  Revert "add dep for python browsing in IDE"
omit 1ded87a  mysql connector does not properly defend against index out of 
bounds
omit 6a8c815  add dep for python browsing in IDE
omit 1191804  start on tabs in component tests  :'(
omit cb357c8  license exclude for pyenv
omit e5197fc  certificates as bytes arrays
omit f4c9be5  pylint/travis trouble
omit e589b68  version output in svm tests
omit 39f0029  Revert "travis systemvm tests"
omit 3de1ff3  separate python for systemvm (tests)
omit 2ec3a84  travis container does not inherit pylint either
omit 483a07c  travis container does not inherit before_install stuff??
omit 06329f8  travis prefered python version
omit 1db2b31  travis systemvm tests
 add bf8d7be  travis prefered python version
 add f182e95  travis container does not inherit before_install stuff??
 add c59632d  travis container does not inherit pylint either
 add 0adfa1d  separate python for systemvm (tests)
 add 9427718  version output in travis svm tests
 add f8caa887 certificates as bytes arrays
 add a92a289  license exclude for pyenv
 add ea92e94  start on tabs in component tests  :'(
 add 1be2cd3  mysql connector does not properly defend against index out of 
bounds
 add 113b203  only fetchall for select statements
 add 64720a9  awkward encode-decode of userdata
 add 7d277ba  unittest method rename assertItemEqual to assertCountEqual
 add 24c8c64  foutje bedank: None vs 0
 add c628111  str() when str() due
 add 9709050  remove superfluent parentesis
 add 4988b8c  exception assert fix
 add ea2215a  2to3 artifact/remnance removed
 add be38b4e  inherritics
 add 7c5ace8  socketserver take bytes
 add 2bfa45b  cleanup of setup() (not sure why this would help)
 add 5de9bc5  cleanup of tearDown(Class)
 add 097b1e7  redundant braces removed
 add c3ab2c3  retries on ssh verification
 add 41a6319  cleanup and feedback from internal version
 add 2a2a486  reformat bec

[GitHub] [cloudstack] blueorangutan commented on pull request #4727: Marvin3

[GitBox]

blueorangutan commented on pull request #4727:
URL: https://github.com/apache/cloudstack/pull/4727#issuecomment-797490189


   Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: 
centos8 :heavy_check_mark: debian. SL-JID 99



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration

[GitBox]

weizhouapache commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593171611



##
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
 Map info = qemu.info(file);
 String backingFilePath = info.get(new String("backing_file"));
 String backingFileFormat = info.get(new 
String("backing_file_format"));
-if 
(org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+&& 
org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {

Review comment:
   > Maybe some log messages for debug/warn purposes would be interesting. 
Or do you think that it is something that system admins should not be bothered 
with?
   > 
   > I am thinking especially on cases such as `backingFileFormat` not empty 
and blank/empty `backingFilePath`, or _vice versa_.
   > 
   > Additionally, what do you think of replacing 
`StringUtils.isEmpty(backingFileFormat)` with 
`StringUtils.isBlank(backingFileFormat)`? In such case it would then check if 
`backingFileFormat` is whitespace, empty ("") or null.
   
   @GabrielBrascher there is a info next to these lines
   ```
   s_logger.info("Setting backing file format of " + volPath);
   ```
   I will add a line as comment to explain why we need this change.
   
https://libvirt.org/kbase/backing_chains.html#vm-refuses-to-start-due-to-misconfigured-backing-store-format
   
   StringUtils.isBlank(backingFileFormat) and 
StringUtils.isEmpty(backingFileFormat) have no difference I think.  there are 
only  2 possible values: empty and 'qcow2'. I will change to isBlank





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4804: server: allow copy cross-zone templates to other zone

[GitBox]

ustcweizhou opened a new pull request #4804:
URL: https://github.com/apache/cloudstack/pull/4804


   ### Description
   
   This PR fixes the issue that cross-zone templates cannot be copied to new 
zone.
   
   steps to reproduce the issue
   (1) register a cross-zone template
   (2) when it is done, remote it from http server
   (3) create a new zone
   (4) template cannot be downloaded to new zone, as it has been removed from 
http server
   (5) copy template from first zone to new zone
   
   Expected result: succeed
   Actual result: API succeed, but nothing changed, logs: "Template 300  is 
cross-zone, don't need to copy"
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch marvin3 updated (adb8b6b -> d99b685)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch marvin3
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from adb8b6b  clean up VMs
 add d99b685  disable pylint3 running on py2 code (needs addressing and 
reverting)

No new revisions were added by this update.

Summary of changes:
 systemvm/test/runtests.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4805: server: create DB entry for storage pool capacity when create storage pool

[GitBox]

ustcweizhou opened a new pull request #4805:
URL: https://github.com/apache/cloudstack/pull/4805


   ### Description
   This PR fixes the issue that new storage pool can not be used in the first 
few minute after adding to cloudstack.
   
   steps to reproduce the issue
   (1) change global setting vm.allocation.algorithm to 'firstfitleastconsumed' 
(this allocator orders host/storage by capacity, maybe other algorithim has 
same issue).
   (2) create a zone and enable it
   (3) systemvm cannot be created, until Capacity Checker runs (it runs every 5 
minutes).
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4806: vpc: dnsmasq is not started if use.external.dns is true

[GitBox]

ustcweizhou opened a new pull request #4806:
URL: https://github.com/apache/cloudstack/pull/4806


   ### Description
   
   This PR fixes the issue that dnsmasq cannot be started in VPC VR is 
use.external.dns is true
   
   Steps to reproduce the issue
   (1) change global setting use.external.dns to true
   (2) create vpc
   (3) check VPC VR, dnasmasq is not started with error
   ```
   Mar 12 14:15:07 r-999-VM dnsmasq[11176]: dnsmasq: bad IP address at line 5 
of /etc/dnsmasq.d/cloud.conf
   Mar 12 14:15:07 r-999-VM dnsmasq[11176]: bad IP address at line 5 of 
/etc/dnsmasq.d/cloud.conf
   Mar 12 14:15:07 r-999-VM dnsmasq[11176]: FAILED to start up
   ```
   dnsmasq config
   ```
   root@r-999-VM:~# cat /etc/dnsmasq.d/cloud.conf
   dhcp-hostsfile=/etc/dhcphosts.txt
   listen-address=127.0.0.1,192.168.20.1
   dhcp-range=set:interface-eth2-0,192.168.20.1,static
   dhcp-option=tag:interface-eth2-0,15,cs2cloud.internal
   dhcp-option=tag:interface-eth2-0,6,
   dhcp-option=tag:interface-eth2-0,3,192.168.20.1
   dhcp-option=tag:interface-eth2-0,1,255.255.255.240
   ```
   
   with this PR, dnsmasq config is good and dnsmasq is running
   ```
   root@r-999-VM:~# cat /etc/dnsmasq.d/cloud.conf
   dhcp-hostsfile=/etc/dhcphosts.txt
   listen-address=127.0.0.1,192.168.20.1
   dhcp-range=set:interface-eth2-0,192.168.20.1,static
   dhcp-option=tag:interface-eth2-0,15,cs2cloud.internal
   dhcp-option=tag:interface-eth2-0,6,8.8.8.8
   dhcp-option=tag:interface-eth2-0,3,192.168.20.1
   dhcp-option=tag:interface-eth2-0,1,255.255.255.240
   
   ```
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4794: server: filter null details during volume to template creation

[GitBox]

blueorangutan commented on pull request #4794:
URL: https://github.com/apache/cloudstack/pull/4794#issuecomment-797613687


   [S] Trillian test result (tid-93)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34973 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4794-t93-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 67.15 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 50.07 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ThyLAW commented on issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken

[GitBox]

ThyLAW commented on issue #4700:
URL: https://github.com/apache/cloudstack/issues/4700#issuecomment-797616585


   (First off sorry for posting on these forums w/ this issue, I didn't know 
the mail client existed)
   Update in case someone eventually sees this:
   
   I got it working, however I completely scrapped Hyper-V. The workaround for 
nested virtualization I believed had worked, but I  don't think the NAT network 
was setup correctly (as shown in my documentation) as I could ping the 
management server from an external network. 
   I also would recommend **NOT** following the **Quick Installation Guide** . 
It will be necessary for installing sql but that is it. It completely leaves 
out the vlan and the bridge **cloudbr1** that is needed, which is resulting in 
the "can not find nic name" error. Go through the documentation.
   
   I have since reinstalled on VMWare using the NAT network provided on there 
using ESXi. It has run relatively smoothly and I have got it fully configured. 
   
   I am happy to have finally succeeded. I am currently creating a more 
in-depth beginning to completion documentation, as I have found no such 
resource online, and I only managed to complete this through hundreds of 
web-searches and scouring the documentation and forums. I hope to be able to 
publish that documentation online and allow for beginner users such as myself 
to get involved with Cloudstack.
   
   Thank you, I am closing this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] ThyLAW closed issue #4700: Uefi.properties doesn't Exist / connection w/ libvirtd broken

[GitBox]

ThyLAW closed issue #4700:
URL: https://github.com/apache/cloudstack/issues/4700


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4795: api: cpu values with overprovisioning in host metrics response

[GitBox]

blueorangutan commented on pull request #4795:
URL: https://github.com/apache/cloudstack/pull/4795#issuecomment-797618337


   [S] Trillian test result (tid-92)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35368 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4795-t92-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 79.55 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 50.17 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] 05/12: Fix indentation issues and use python3 when running pycodestyle checker

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 4604d472ceaa4e10961f76bd3b917fb73a9223c0
Author: Gabriel Brascher 
AuthorDate: Thu Feb 25 03:49:27 2021 -0300

Fix indentation issues and use python3 when running pycodestyle checker

Conflicts were found & fixed:

modified:   systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
modified:   systemvm/debian/root/health_checks/router_version_check.py
modified:   systemvm/test/runtests.sh
---
 systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py| 2 +-
 systemvm/debian/root/health_checks/router_version_check.py | 4 ++--
 systemvm/test/runtests.sh  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
index e39595d..1679970 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
@@ -28,7 +28,7 @@ class CsChain(object):
 self.count = {}
 
 def add(self, table, chain):
- if table not in list(self.chain.keys()):
+if table not in list(self.chain.keys()):
 self.chain.setdefault(table, []).append(chain)
 else:
 self.chain[table].append(chain)
diff --git a/systemvm/debian/root/health_checks/router_version_check.py 
b/systemvm/debian/root/health_checks/router_version_check.py
index 3ab33fe..1ec37e9 100644
--- a/systemvm/debian/root/health_checks/router_version_check.py
+++ b/systemvm/debian/root/health_checks/router_version_check.py
@@ -68,8 +68,8 @@ def main():
 print("Scripts signature is not yet setup at " + sigFile +
   ", skipping")
 if expected != found:
-print("Scripts Version mismatch. Expected: " + expected +
-  ", found: " + found)
+print("Scripts Version mismatch. Expected: " +
+  expected + ", found: " + found)
 scriptVersionMatches = False
 
 if templateVersionMatches and scriptVersionMatches:
diff --git a/systemvm/test/runtests.sh b/systemvm/test/runtests.sh
index 9646b54..3f113f5 100755
--- a/systemvm/test/runtests.sh
+++ b/systemvm/test/runtests.sh
@@ -22,8 +22,8 @@ export PYTHONPATH="../debian/opt/cloud/bin/"
 export PYTHONDONTWRITEBYTECODE=False
 
 echo "Running pycodestyle to check systemvm/python code for errors"
-pycodestyle --max-line-length=179 *py
-pycodestyle --max-line-length=179 
--exclude=monitorServices.py,baremetal-vr.py,passwd_server_ip.py `find 
../debian -name \*.py`
+python3 -m pycodestyle --max-line-length=179 *py
+python3 -m pycodestyle --max-line-length=179 
--exclude=monitorServices.py,baremetal-vr.py,passwd_server_ip.py `find 
../debian -name \*.py`
 if [ $? -gt 0 ]
 then
 echo "pycodestyle failed, please check your code"

[cloudstack] 03/12: Fix conflict with master

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 6b2330bbda0c61478c66b3c08c07d62f9ffdd831
Author: Gabriel Brascher 
AuthorDate: Thu Sep 24 06:09:53 2020 -0300

Fix conflict with master

Also: port cloud-grab-dependent-library-versions to python3
---
 python/bindir/cloud-grab-dependent-library-versions | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/python/bindir/cloud-grab-dependent-library-versions 
b/python/bindir/cloud-grab-dependent-library-versions
index cdb5053..ca6d4a9 100755
--- a/python/bindir/cloud-grab-dependent-library-versions
+++ b/python/bindir/cloud-grab-dependent-library-versions
@@ -6,9 +6,9 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#
 #   http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing,
 # software distributed under the License is distributed on an
 # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@@ -38,7 +38,7 @@ def getDependentLibraryInfo():
 start = True
 continue
 if not start: continue
-
+
 (key, value) = l.split(':', 2)
 key = key.strip()
 value = value.strip()
@@ -70,7 +70,7 @@ def arrangeOutPut(libraryMap):
 entry = "%-40s:%s"%(l, 'UNKNOWN')
 msg.append(entry)
 print('\n'.join(msg))
-
+
 if __name__ == '__main__':
 pythonDepLibraries = ['python', 'python3']
 relver = runCmd(['rpm', '-q', 'centos-release'])

[cloudstack] 08/12: str f'ormat'

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 20288b2e3a77ed0346bfb35066dac3090f31969b
Author: Daan Hoogland 
AuthorDate: Thu Feb 25 15:50:17 2021 +0100

str f'ormat'
---
 systemvm/debian/opt/cloud/bin/cs/CsRedundant.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py 
b/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
index 7caf9ee..f9f7931 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
@@ -225,7 +225,7 @@ class CsRedundant(object):
 except socket.error as e:
 error_code = e.args[0]
 error_string = e.args[1]
-print("Process already running (%d:%s). Exiting" % 
(error_code, error_string))
+print(f"Process already running ({error_code}:{error_string}). 
Exiting")
 logging.info("Master is already running, waiting")
 sleep(time_between)
 

[cloudstack] 07/12: pylint issues

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e3c8b34954fa52ef878e3001aa0a6eb9cec3737a
Author: Daan Hoogland 
AuthorDate: Thu Feb 25 15:04:15 2021 +0100

pylint issues
---
 systemvm/debian/opt/cloud/bin/baremetal-vr.py  | 8 
 systemvm/debian/opt/cloud/bin/cs_ip.py | 2 +-
 systemvm/debian/opt/cloud/bin/filesystem_writable_check.py | 6 +++---
 systemvm/debian/opt/cloud/bin/merge.py | 2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/baremetal-vr.py 
b/systemvm/debian/opt/cloud/bin/baremetal-vr.py
index 1547d82..4bb3d2b 100755
--- a/systemvm/debian/opt/cloud/bin/baremetal-vr.py
+++ b/systemvm/debian/opt/cloud/bin/baremetal-vr.py
@@ -16,7 +16,7 @@
 #under the License.
 
 import subprocess
-import urllib
+import urllib.request, urllib.parse, urllib.error
 import hmac
 import hashlib
 import base64
@@ -131,10 +131,10 @@ class Server(object):
 "mac": mac
 }
 
-request = zip(reqs.keys(), reqs.values())
+request = list(zip(list(reqs.keys()), list(reqs.values(
 request.sort(key=lambda x: str.lower(x[0]))
-hashStr = "&".join(["=".join([str.lower(r[0]), 
str.lower(urllib.quote_plus(str(r[1]))).replace("+", "%20").replace('=', 
'%3d')]) for r in request])
-sig = urllib.quote_plus(base64.encodestring(hmac.new(secretkey, 
hashStr, hashlib.sha1).digest()).strip())
+hashStr = "&".join(["=".join([str.lower(r[0]), 
str.lower(urllib.parse.quote_plus(str(r[1]))).replace("+", "%20").replace('=', 
'%3d')]) for r in request])
+sig = urllib.parse.quote_plus(base64.encodebytes(hmac.new(secretkey, 
hashStr, hashlib.sha1).digest()).strip())
 return sig
 
 def notify_provisioning_done(self, mac):
diff --git a/systemvm/debian/opt/cloud/bin/cs_ip.py 
b/systemvm/debian/opt/cloud/bin/cs_ip.py
index fe78c03..5a9f275 100755
--- a/systemvm/debian/opt/cloud/bin/cs_ip.py
+++ b/systemvm/debian/opt/cloud/bin/cs_ip.py
@@ -54,7 +54,7 @@ def merge(dbag, ip):
 ip['broadcast'] = str(ipo.broadcast_address)
 ip['cidr'] = str(ipo.network_address) + '/' + str(ipo.prefixlen)
 ip['size'] = str(ipo.prefixlen)
-ip['network'] = str(ipo.ip_network)
+ip['network'] = str(ipo.compressed)
 if 'nw_type' not in list(ip.keys()):
 ip['nw_type'] = 'public'
 else:
diff --git a/systemvm/debian/opt/cloud/bin/filesystem_writable_check.py 
b/systemvm/debian/opt/cloud/bin/filesystem_writable_check.py
index eac7d9c..4b2e2cb 100644
--- a/systemvm/debian/opt/cloud/bin/filesystem_writable_check.py
+++ b/systemvm/debian/opt/cloud/bin/filesystem_writable_check.py
@@ -28,17 +28,17 @@ def check_filesystem():
 readOnly1 = bool(stat1.f_flag & ST_RDONLY)
 
 if (readOnly1):
-print "Read-only file system : monitor results (/root) file system is 
mounted as read-only"
+print("Read-only file system : monitor results (/root) file system is 
mounted as read-only")
 exit(1)
 
 stat2 = os.statvfs('/var/cache/cloud')
 readOnly2 = bool(stat2.f_flag & ST_RDONLY)
 
 if (readOnly2):
-print "Read-only file system : config info (/var/cache/cloud) file 
system is mounted as read-only"
+print("Read-only file system : config info (/var/cache/cloud) file 
system is mounted as read-only")
 exit(1)
 
-print "file system is writable"
+print("file system is writable")
 exit(0)
 
 
diff --git a/systemvm/debian/opt/cloud/bin/merge.py 
b/systemvm/debian/opt/cloud/bin/merge.py
index 607dca7..60318e5 100755
--- a/systemvm/debian/opt/cloud/bin/merge.py
+++ b/systemvm/debian/opt/cloud/bin/merge.py
@@ -97,7 +97,7 @@ class updateDataBag:
 self.db.setKey("forwardingrules")
 else:
 self.db.setKey(self.qFile.type)
-dbag = self.db.load()
+self.db.load()
 logging.info("Command of type %s received", self.qFile.type)
 
 if self.qFile.type == 'ips':

[cloudstack] 04/12: Change Pylint to Pylint3

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 3a7a4f672d69dda6d8646597817a29974a197e7c
Author: Gabriel Brascher 
AuthorDate: Sat Sep 26 01:23:50 2020 -0300

Change Pylint to Pylint3
---
 systemvm/test/runtests.sh  | 4 
 tools/travis/before_install.sh | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/systemvm/test/runtests.sh b/systemvm/test/runtests.sh
old mode 100644
new mode 100755
index b4fb5a1..9646b54
--- a/systemvm/test/runtests.sh
+++ b/systemvm/test/runtests.sh
@@ -40,6 +40,10 @@ pyenv versions
 pylint3 --disable=R,C,W *.py
 pylint3 --disable=R,C,W `find ../debian -name \*.py`
 
+
+pylint3 --disable=R,C,W *.py
+pylint3 --disable=R,C,W `find ../debian -name \*.py`
+
 if [ $? -gt 0 ]
 then
 echo "pylint failed, please check your code"
diff --git a/tools/travis/before_install.sh b/tools/travis/before_install.sh
index f2ecd97..6b3a12f 100755
--- a/tools/travis/before_install.sh
+++ b/tools/travis/before_install.sh
@@ -81,7 +81,7 @@ if [[ $? -ne 0 ]]; then
   echo -e "\napt-get packages failed to install"
 fi
 
-sudo apt-get -q -y -V install freeipmi-common libfreeipmi16 libgcrypt20 
libgpg-error-dev libgpg-error0 libopenipmi0 ipmitool libpython-dev libssl-dev 
libffi-dev python-openssl build-essential --no-install-recommends > /dev/null
+sudo apt-get -q -y -V install freeipmi-common libfreeipmi16 libgcrypt20 
libgpg-error-dev libgpg-error0 libopenipmi0 ipmitool libpython-dev libssl-dev 
libffi-dev pylint3 python-openssl build-essential --no-install-recommends > 
/dev/null
 
 echo -e "\nIPMI version"
 ipmitool -V

[cloudstack] 10/12: write as byte[]

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit f151e7b543b6cb959f34c7ff75a330d80deeb524
Author: Daan Hoogland 
AuthorDate: Tue Mar 9 17:54:05 2021 +0100

write as byte[]
---
 systemvm/debian/opt/cloud/bin/get_diagnostics_files.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/get_diagnostics_files.py 
b/systemvm/debian/opt/cloud/bin/get_diagnostics_files.py
index 3b3e9d1..8790821 100755
--- a/systemvm/debian/opt/cloud/bin/get_diagnostics_files.py
+++ b/systemvm/debian/opt/cloud/bin/get_diagnostics_files.py
@@ -129,9 +129,9 @@ def generate_retrieved_files_txt(zip_file, files_found, 
files_not_found):
 try:
 with open(output_file, 'wb', 0) as man:
 for i in files_found:
-man.write(i + '\n')
+man.write(i + b'\n')
 for j in files_not_found:
-man.write(j + 'File Not Found!!\n')
+man.write(j + b' File Not Found!!\n')
 zip_file.write(output_file, output_file)
 finally:
 cleanup_cmd = "rm -f %s" % output_file

[cloudstack] branch python3-vr created (now 12b2a2f)

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a change to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 12b2a2f  ip to net address conversions

This branch includes the following new commits:

 new ab01180  Make Virtual Router '.py' scripts Python3 compatible
 new 1a9402d  Fix pycodestyle 'errors'
 new 6b2330b  Fix conflict with master
 new 3a7a4f6  Change Pylint to Pylint3
 new 4604d47  Fix indentation issues and use python3 when running 
pycodestyle checker
 new de248a6  replace mock with unittest.mock
 new e3c8b34  pylint issues
 new 20288b2  str f'ormat'
 new e7ba52a  read files in vr as list(byte[])
 new f151e7b  write as byte[]
 new a9043dc  byte as separator on byte[]
 new 12b2a2f  ip to net address conversions

The 12 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[cloudstack] 02/12: Fix pycodestyle 'errors'

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 1a9402d568a80afbd96cff53344e96f634d824a3
Author: Gabriel Brascher 
AuthorDate: Mon Aug 10 11:30:49 2020 -0300

Fix pycodestyle 'errors'
---
 systemvm/debian/root/health_checks/memory_usage_check.py   |  6 +++---
 systemvm/debian/root/health_checks/router_version_check.py | 10 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/systemvm/debian/root/health_checks/memory_usage_check.py 
b/systemvm/debian/root/health_checks/memory_usage_check.py
index 20b5653..08b73df 100644
--- a/systemvm/debian/root/health_checks/memory_usage_check.py
+++ b/systemvm/debian/root/health_checks/memory_usage_check.py
@@ -28,7 +28,7 @@ def main():
 data = entries[0]
 
 if "maxMemoryUsage" not in data:
-print("Missing maxMemoryUsage in health_checks_data " + \
+print("Missing maxMemoryUsage in health_checks_data " +
   "systemThresholds, skipping")
 exit(0)
 
@@ -39,10 +39,10 @@ def main():
 if pout.wait() == 0:
 currentUsage = float(pout.communicate()[0].strip())
 if currentUsage > maxMemoryUsage:
-print("Memory Usage " + str(currentUsage) + \
+print("Memory Usage " + str(currentUsage) +
   "% has crossed threshold of " + str(maxMemoryUsage) + "%")
 exit(1)
-print("Memory Usage within limits with current at " + \
+print("Memory Usage within limits with current at " +
   str(currentUsage) + "%")
 exit(0)
 else:
diff --git a/systemvm/debian/root/health_checks/router_version_check.py 
b/systemvm/debian/root/health_checks/router_version_check.py
index b65aca4..3ab33fe 100644
--- a/systemvm/debian/root/health_checks/router_version_check.py
+++ b/systemvm/debian/root/health_checks/router_version_check.py
@@ -53,10 +53,10 @@ def main():
 releaseFile = "/etc/cloudstack-release"
 found = getFirstLine(releaseFile)
 if found is None:
-print("Release version not yet setup at " + releaseFile +\
+print("Release version not yet setup at " + releaseFile +
   ", skipping.")
 elif expected != found:
-print("Template Version mismatch. Expected: " + \
+print("Template Version mismatch. Expected: " +
   expected + ", found: " + found)
 templateVersionMatches = False
 
@@ -65,11 +65,11 @@ def main():
 sigFile = "/var/cache/cloud/cloud-scripts-signature"
 found = getFirstLine(sigFile)
 if found is None:
-print("Scripts signature is not yet setup at " + sigFile +\
+print("Scripts signature is not yet setup at " + sigFile +
   ", skipping")
 if expected != found:
-print("Scripts Version mismatch. Expected: " + \
-  expected + ", found: " + found)
+print("Scripts Version mismatch. Expected: " + expected +
+  ", found: " + found)
 scriptVersionMatches = False
 
 if templateVersionMatches and scriptVersionMatches:

[cloudstack] 11/12: byte as separator on byte[]

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit a9043dccaa0cf98d28a882f36a8bceb7a211f548
Author: Daan Hoogland 
AuthorDate: Wed Mar 10 16:12:26 2021 +0100

byte as separator on byte[]
---
 systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
index 31112ff..931b932 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
@@ -90,7 +90,7 @@ class CsNetfilters(object):
 if i.startswith(b'*'):  # Table
 self.table.add(i[1:])
 if i.startswith(b':'):  # Chain
-self.chain.add(self.table.last(), i[1:].split(' ')[0])
+self.chain.add(self.table.last(), i[1:].split(b' ')[0])
 if i.startswith(b'-A'):  # Rule
 self.chain.add_rule(i.split()[1])
 rule = CsNetfilter()

[cloudstack] 12/12: ip to net address conversions

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 12b2a2f4f35afdf60def6b4418975d96685ab464
Author: Daan Hoogland 
AuthorDate: Wed Mar 10 17:01:35 2021 +0100

ip to net address conversions
---
 systemvm/debian/opt/cloud/bin/cs/CsAddress.py | 4 +++-
 systemvm/debian/opt/cloud/bin/cs/CsHelper.py  | 2 +-
 systemvm/debian/opt/cloud/bin/cs_ip.py| 4 +++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsAddress.py 
b/systemvm/debian/opt/cloud/bin/cs/CsAddress.py
index 8f688d7..512734c 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsAddress.py
@@ -149,7 +149,9 @@ class CsInterface:
 
 def ip_in_subnet(self, ip):
 ipo = ip_address(ip)
-net = ip_network("%s/%s" % (self.get_ip(), self.get_size()))
+# we are using an ip as netaddress so strict must be False
+net = ip_network("%s/%s" % (self.get_ip(), self.get_size()),
+ strict=False)
 return ipo in net
 
 def get_gateway_cidr(self):
diff --git a/systemvm/debian/opt/cloud/bin/cs/CsHelper.py 
b/systemvm/debian/opt/cloud/bin/cs/CsHelper.py
index c818c39..1809170 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsHelper.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsHelper.py
@@ -119,7 +119,7 @@ def get_device_info():
 to = {}
 to['ip'] = vals[1]
 to['dev'] = vals[-1]
-to['network'] = ip_network(to['ip'])
+to['network'] = ip_network(to['ip'], strict=False)
 to['dnsmasq'] = False
 list.append(to)
 return list
diff --git a/systemvm/debian/opt/cloud/bin/cs_ip.py 
b/systemvm/debian/opt/cloud/bin/cs_ip.py
index 5a9f275..cb6541b 100755
--- a/systemvm/debian/opt/cloud/bin/cs_ip.py
+++ b/systemvm/debian/opt/cloud/bin/cs_ip.py
@@ -42,7 +42,9 @@ def merge(dbag, ip):
 nic_dev_id = address['nic_dev_id']
 dbag[dev].remove(address)
 
-ipo = ip_network(ip['public_ip'] + '/' + ip['netmask'])
+# we are passing and must allow for host bits so strict is False
+ipo = ip_network(ip['public_ip'] + '/' + ip['netmask'],
+ strict=False)
 if 'nic_dev_id' in ip:
 nic_dev_id = ip['nic_dev_id']
 if 'vif_mac_address' in ip:

[cloudstack] 09/12: read files in vr as list(byte[])

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e7ba52ab4b5d1641de53cd5e5faa0fa2564cc032
Author: Daan Hoogland 
AuthorDate: Tue Mar 9 17:51:01 2021 +0100

read files in vr as list(byte[])
---
 systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py 
b/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
index 1679970..31112ff 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py
@@ -87,11 +87,11 @@ class CsNetfilters(object):
 
 def get_all_rules(self):
 for i in CsHelper.execute("iptables-save"):
-if i.startswith('*'):  # Table
+if i.startswith(b'*'):  # Table
 self.table.add(i[1:])
-if i.startswith(':'):  # Chain
+if i.startswith(b':'):  # Chain
 self.chain.add(self.table.last(), i[1:].split(' ')[0])
-if i.startswith('-A'):  # Rule
+if i.startswith(b'-A'):  # Rule
 self.chain.add_rule(i.split()[1])
 rule = CsNetfilter()
 rule.parse(i)

[cloudstack] 06/12: replace mock with unittest.mock

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit de248a629bcea8ff6bab4b5fb8186c2cc51d2244
Author: Daan Hoogland 
AuthorDate: Thu Feb 25 10:20:54 2021 +0100

replace mock with unittest.mock
---
 systemvm/test/TestCsDhcp.py   | 2 +-
 systemvm/test/TestCsHelper.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemvm/test/TestCsDhcp.py b/systemvm/test/TestCsDhcp.py
index 339fc6a..8a176fe 100644
--- a/systemvm/test/TestCsDhcp.py
+++ b/systemvm/test/TestCsDhcp.py
@@ -16,7 +16,7 @@
 # under the License.
 
 import unittest
-import mock
+from unittest import mock
 from cs.CsDhcp import CsDhcp
 from cs import CsHelper
 import merge
diff --git a/systemvm/test/TestCsHelper.py b/systemvm/test/TestCsHelper.py
index c3be13c..515a9a1 100644
--- a/systemvm/test/TestCsHelper.py
+++ b/systemvm/test/TestCsHelper.py
@@ -16,7 +16,7 @@
 # under the License.
 
 import unittest
-import mock
+from unittest import mock
 from cs import CsHelper
 import merge
 

[cloudstack] 01/12: Make Virtual Router '.py' scripts Python3 compatible

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch python3-vr
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit ab0118064494a57d58845a3289ec326778372c53
Author: Gabriel Brascher 
AuthorDate: Fri Jul 24 09:02:58 2020 -0300

Make Virtual Router '.py' scripts Python3 compatible
---
 systemvm/debian/opt/cloud/bin/configure.py | 69 +++---
 systemvm/debian/opt/cloud/bin/cs/CsAddress.py  | 32 +-
 systemvm/debian/opt/cloud/bin/cs/CsApp.py  |  5 +-
 systemvm/debian/opt/cloud/bin/cs/CsConfig.py   |  4 +-
 systemvm/debian/opt/cloud/bin/cs/CsDatabag.py  |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py |  8 +--
 systemvm/debian/opt/cloud/bin/cs/CsFile.py |  4 +-
 systemvm/debian/opt/cloud/bin/cs/CsGuestNetwork.py |  4 +-
 systemvm/debian/opt/cloud/bin/cs/CsHelper.py   |  6 +-
 systemvm/debian/opt/cloud/bin/cs/CsLoadBalancer.py | 10 ++--
 systemvm/debian/opt/cloud/bin/cs/CsMonitor.py  |  8 +--
 systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py| 20 +++
 systemvm/debian/opt/cloud/bin/cs/CsProcess.py  | 11 ++--
 systemvm/debian/opt/cloud/bin/cs/CsRedundant.py| 22 +++
 systemvm/debian/opt/cloud/bin/cs/CsRoute.py|  6 +-
 systemvm/debian/opt/cloud/bin/cs/CsRule.py |  4 +-
 systemvm/debian/opt/cloud/bin/cs/CsStaticRoutes.py |  6 +-
 systemvm/debian/opt/cloud/bin/cs_dhcp.py   |  4 +-
 systemvm/debian/opt/cloud/bin/cs_firewallrules.py  |  4 +-
 .../debian/opt/cloud/bin/cs_forwardingrules.py |  8 +--
 systemvm/debian/opt/cloud/bin/cs_guestnetwork.py   |  4 +-
 systemvm/debian/opt/cloud/bin/cs_ip.py | 12 ++--
 systemvm/debian/opt/cloud/bin/cs_monitorservice.py |  2 +-
 systemvm/debian/opt/cloud/bin/cs_network_acl.py|  2 +-
 .../debian/opt/cloud/bin/cs_remoteaccessvpn.py |  2 +-
 systemvm/debian/opt/cloud/bin/cs_site2sitevpn.py   |  2 +-
 systemvm/debian/opt/cloud/bin/cs_vmp.py|  2 +-
 systemvm/debian/opt/cloud/bin/cs_vpnusers.py   | 10 ++--
 systemvm/debian/opt/cloud/bin/diagnostics.py   |  2 +-
 .../debian/opt/cloud/bin/get_diagnostics_files.py  |  4 +-
 systemvm/debian/opt/cloud/bin/merge.py |  6 +-
 systemvm/debian/opt/cloud/bin/passwd_server_ip.py  | 16 ++---
 systemvm/debian/opt/cloud/bin/update_config.py |  4 +-
 systemvm/debian/opt/cloud/bin/vmdata.py| 22 +++
 .../debian/root/health_checks/cpu_usage_check.py   | 16 ++---
 systemvm/debian/root/health_checks/dhcp_check.py   | 10 ++--
 .../debian/root/health_checks/disk_space_check.py  | 10 ++--
 systemvm/debian/root/health_checks/dns_check.py| 10 ++--
 .../debian/root/health_checks/gateways_check.py| 12 ++--
 .../debian/root/health_checks/haproxy_check.py | 26 
 .../debian/root/health_checks/iptables_check.py| 10 ++--
 .../root/health_checks/memory_usage_check.py   | 18 +++---
 .../root/health_checks/router_version_check.py | 25 
 .../debian/root/health_checks/utility/__init__.py  |  4 +-
 systemvm/debian/root/monitorServices.py| 12 ++--
 systemvm/test/runtests.sh  |  7 +++
 46 files changed, 250 insertions(+), 237 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/configure.py 
b/systemvm/debian/opt/cloud/bin/configure.py
index be67f40..5378180 100755
--- a/systemvm/debian/opt/cloud/bin/configure.py
+++ b/systemvm/debian/opt/cloud/bin/configure.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3
 # -- coding: utf-8 --
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
@@ -21,8 +21,9 @@ import logging
 import os
 import re
 import sys
-import urllib
-import urllib2
+from urllib.request import *
+from urllib.parse import *
+from urllib.error import *
 import time
 
 from collections import OrderedDict
@@ -77,10 +78,10 @@ class CsPassword(CsDataBag):
 if proc.find():
 url = "http://%s:8080/"; % server_ip
 payload = {"ip": vm_ip, "password": password, "token": token}
-data = urllib.urlencode(payload)
-request = urllib2.Request(url, data=data, 
headers={"DomU_Request": "save_password"})
+data = urllib.parse.urlencode(payload)
+request = urllib.request.Request(url, data=data, 
headers={"DomU_Request": "save_password"})
 try:
-resp = urllib2.urlopen(request, data)
+resp = urlopen(request, data)
 logging.debug("Update password server result: http:%s, 
content:%s" % (resp.code, resp.read()))
 except Exception as e:
 logging.error("Failed to update password server due to: 
%s" % e)
@@ -135,15 +136,15 @@ class CsAcl(CsDataBag):
 icmp_type = ''
 rule = self.rule
 icmp_type = "any"
-if "icmp_ty

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4807: Migrate VR codebase from Python2 to Python3

[GitBox]

GabrielBrascher opened a new pull request #4807:
URL: https://github.com/apache/cloudstack/pull/4807


   ### Description
   
   Considering the Python2 end of life we must migrate the VR's codebase to 
Python3.
   
   This PR covers partially issue #3195. Additionally, this PR is a joint of 
the work done in #3730 and #4727.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] aleskxyz opened a new issue #4808: CloudStack uses 1st cdrom of VM to mount ConfigDrive ISO

[GitBox]

aleskxyz opened a new issue #4808:
URL: https://github.com/apache/cloudstack/issues/4808


   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   ConfigDrive
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.14.1
   ~~~
   
   # CONFIGURATION
   
   N/A
   
   # OS / ENVIRONMENT
   
   ESXi 6.5
   CentOS7
   
   # SUMMARY
   
   This bug report actually has 2 root cause that solving each of them can 
solve the bug. 
   
   1. Based on [design 
document](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+ConfigDrive+for+Metadata%2C+Userdata+and+Password)
 of ConfigDrive feature, the iso should be mounted on 2nd cdrom drive of VM but 
CS don't even create it.
   
   1. When user tries to attach an ISO to the created VM, CloudStack tries to 
replace the ISOs but don't answer the esxi question about unmounting iso, so 
the operation fails.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Create a network with ConfigDrive as userdata
   Create a VM attached to that network and start it
   Attach an ISO to the VM
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   CloudStack creates the 2nd cdrom drive for VM and mount ConfigDrive ISO on it
   or
   CloudStack answer the question of ESXi about unmounting ConfigDrive ISO
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   CloudStack tries to unmount ConfigDrive iso but leave the esxi question 
unanswered so operation fails. 
   ~~~
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4807: Migrate VR codebase from Python2 to Python3

[GitBox]

blueorangutan commented on pull request #4807:
URL: https://github.com/apache/cloudstack/pull/4807#issuecomment-797648739


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 
:heavy_check_mark: debian. SL-JID 100



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4773: Fix deploy VM from ISOs with UEFI

[GitBox]

blueorangutan commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-797664139


   [S] Trillian test result (tid-100)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33524 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4773-t100-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 85.53 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 47.07 | 
test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 1.08 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 1.07 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.08 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 0.08 | 
test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 4.21 | test_vm_life_cycle.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.59 | 
test_hostha_kvm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] aleskxyz opened a new issue #4809: Missing password.txt in ConfigDrive in multihomed VM

[GitBox]

aleskxyz opened a new issue #4809:
URL: https://github.com/apache/cloudstack/issues/4809


   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   ConfigDrive
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.14.1
   ~~~
   
   # CONFIGURATION
   
   advanced networking
   
   # OS / ENVIRONMENT
   
   CentOS7
   ESXi 6.5
   
   # SUMMARY
   
   When attach a VM to 2 networks which one of them uses VirtualRouter as 
userdata provider and other uses ConfigDrive, after password reset, you can't 
find password.txt file in ConfigDrive ISO
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Create a network with VirtualRouter as userdata provider
   Create a network with ConfigDrive  as userdata provider
   Create a VM and attach it to both networks
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   Get password from VirtualRouter as well as ConfigDrive
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   VritualRouter gives you the password but there is no password.txt in 
ConfigDrive ISO
   ~~~
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4793: systemvmtemplate: new template for 4.15.1

[GitBox]

blueorangutan commented on pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#issuecomment-797686064


   [S] Trillian test result (tid-95)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40585 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4793-t95-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.43 | test_diagnostics.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 785.37 | 
test_kubernetes_clusters.py
   test_03_migrate_detached_volume | `Error` | 96.19 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 44.45 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4212: Migrate/Stop VMs with local storage when preparing host for maintenance

[GitBox]

blueorangutan commented on pull request #4212:
URL: https://github.com/apache/cloudstack/pull/4212#issuecomment-797693398


   [S] Trillian test result (tid-102)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35571 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4212-t102-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 77.42 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 53.18 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4796: db, server: refactor host_view to prevent duplicate entries

[GitBox]

blueorangutan commented on pull request #4796:
URL: https://github.com/apache/cloudstack/pull/4796#issuecomment-797723409


   [S] Trillian test result (tid-101)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38889 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4796-t101-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 66.22 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 49.11 | 
test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 1.09 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 0.08 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 0.07 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 0.08 | 
test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 0.06 | test_vm_life_cycle.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 300.49 | 
test_hostha_kvm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4793: systemvmtemplate: new template for 4.15.1

[GitBox]

blueorangutan commented on pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#issuecomment-797735541


   [S] Trillian test result (tid-96)
   Environment: xcpng81 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45763 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4793-t96-xcpng81.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 4.15 | test_scale_vm.py
   test_01_volume_usage | `Error` | 96.50 | test_usage.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4779: Fix NPE while cloudstack agent failed to connect to mgt server

[GitBox]

blueorangutan commented on pull request #4779:
URL: https://github.com/apache/cloudstack/pull/4779#issuecomment-797746638


   [S] Trillian test result (tid-104)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34123 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4779-t104-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 67.22 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 50.11 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

[GitBox]

blueorangutan commented on pull request #4577:
URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-797834252


   [S] Trillian test result (tid-108)
   Environment: kvm-ubuntu20 (x2), Advanced Networking with Mgmt server u20
   Total time taken: 35428 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4577-t108-kvm-ubuntu20.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_supported_versions.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1802.54 | 
test_kubernetes_supported_versions.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4727: Marvin3

[GitBox]

blueorangutan commented on pull request #4727:
URL: https://github.com/apache/cloudstack/pull/4727#issuecomment-797840913


   [S] Trillian test result (tid-107)
   Environment: xenserver-72 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38032 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4727-t107-xenserver-72.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeleteDomain | `Error` | 226.57 | test_accounts.py
   test_01_scale_vm | `Failure` | 10.24 | test_scale_vm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] abdelouahabb commented on issue #4734: Cant upload ISO Using TrueNas with NFS

[GitBox]

abdelouahabb commented on issue #4734:
URL: https://github.com/apache/cloudstack/issues/4734#issuecomment-797843380


   @rhtyd 
   Both system VM are on, but cant accept uploading the iso to create a new 
machine
   ```
 "connections": []
   }","wait":"0"}}] }
   2021-03-11 04:29:23,388 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-7:null) (logid:) SeqA 2-100: Sending Seq 2-100:  { Ans: , 
MgmtId: 69076629592718, via: 2, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":"true","wait":"0"}}] }
   2021-03-11 04:29:24,389 DEBUG [c.c.h.o.r.Ovm3HypervisorGuru] 
(Timer-5:ctx-21f911c7) (logid:679471cb) getCommandHostDelegation: class 
org.apache.cloudstack.storage.command.DownloadProgressCommand
   2021-03-11 04:29:24,392 DEBUG [c.c.h.XenServerGuru] (Timer-5:ctx-21f911c7) 
(logid:679471cb) We are returning the default host to execute commands because 
the command is not of Copy type.
   2021-03-11 04:29:24,392 DEBUG [o.a.c.s.RemoteHostEndPoint] 
(Timer-5:ctx-21f911c7) (logid:679471cb) Sending command 
org.apache.cloudstack.storage.command.DownloadProgressCommand to host: 3
   2021-03-11 04:29:24,396 DEBUG [c.c.a.t.Request] (Timer-5:ctx-21f911c7) 
(logid:679471cb) Seq 3-7070088465018257495: Sending  { Cmd , MgmtId: 
69076629592718, via: 3(s-2-VM), Ver: v1, Flags: 100011, 
[{"org.apache.cloudstack.storage.command.DownloadProgressCommand":{"jobId":"e53b045f-d37a-4633-acd8-9c115853b0e0","request":"GET_STATUS","hvm":"false","description":"CentOS
 5.5(64-bit) no GUI 
(KVM)","checksum":"ed0e788280ff2912ea40f7f91ca7a249","maxDownloadSizeInBytes":"(50.00
 GB) 
53687091200","id":"4","resourceType":"TEMPLATE","installPath":"template/tmpl/1/4","_store":{"com.cloud.agent.api.to.NfsTO":{"_url":"nfs://192.168.122.10/export/secondary","_role":"Image"}},"url":"http://download.cloudstack.org/releases/2.2.0/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2","format":"QCOW2","accountId":"1","name":"centos55-x86_64","secUrl":"nfs://192.168.122.10/export/secondary","wait":"0"}}]
 }
   2021-03-11 04:29:24,446 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-11:null) (logid:) Seq 3-7070088465018257495: Processing:  
{ Ans: , MgmtId: 69076629592718, via: 3, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.storage.DownloadAnswer":{"jobId":"e53b045f-d37a-4633-acd8-9c115853b0e0","downloadPct":"33","errorString":"
 
","downloadStatus":"DOWNLOAD_IN_PROGRESS","downloadPath":"/mnt/SecStorage/7a9d8904-a9fa-3e75-a4fa-1bec3d89b971/template/tmpl/1/4/dnld5603439648184798285tmp_","installPath":"template/tmpl/1/4","templateSize":"(0
 bytes) 0","templatePhySicalSize":"(0 bytes) 
0","checkSum":"ed0e788280ff2912ea40f7f91ca7a249","result":"true","details":" 
","wait":"0"}}] }
   2021-03-11 04:29:24,447 DEBUG [o.a.c.s.i.BaseImageStoreDriverImpl] 
(RemoteHostEndPoint-1:ctx-5d27821b) (logid:2188bfd0) Performing image store 
createTemplate async callback
   2021-03-11 04:29:24,451 INFO  [o.a.c.s.i.BaseImageStoreDriverImpl] 
(RemoteHostEndPoint-1:ctx-5d27821b) (logid:2188bfd0) Updating store ref entry 
for template CentOS 5.5(64-bit) no GUI (KVM)
   2021-03-11 04:29:26,233 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(RouterStatusMonitor-1:ctx-17db1e01) (logid:b0902c1e) Found 0 routers to update 
status. 
   2021-03-11 04:29:26,234 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(RouterStatusMonitor-1:ctx-17db1e01) (logid:b0902c1e) Found 0 VPC's to update 
Redundant State. 
   2021-03-11 04:29:26,236 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(RouterStatusMonitor-1:ctx-17db1e01) (logid:b0902c1e) Found 0 networks to 
update RvR status. 
   2021-03-11 04:29:26,946 DEBUG [c.c.a.ApiServlet] 
(qtp1644231115-15:ctx-b1a9fc1d) (logid:5754932c) ===START===  192.168.122.1 -- 
GET  
name=Lubuntu+18.04.5&displaytext=Server+no+GUI&zoneid=3ea197d5-827e-4563-91e8-d23fd3075f2f&bootable=true&ostypeid=b91cdcc8-821e-11eb-ac45-525400644510&isextractable=false&ispublic=false&isfeatured=false&format=ISO&command=getUploadParamsForIso&response=json
   2021-03-11 04:29:26,956 DEBUG [c.c.a.ApiServer] 
(qtp1644231115-15:ctx-b1a9fc1d ctx-fa54ddb0) (logid:5754932c) CIDRs from which 
account 'Acct[ed2c36a7-821e-11eb-ac45-525400644510-admin]' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2021-03-11 04:29:27,091 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] 
(qtp1644231115-15:ctx-b1a9fc1d ctx-fa54ddb0) (logid:5754932c) template 206 is 
not in store:1, type:Image
   2021-03-11 04:29:27,100 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] 
(qtp1644231115-15:ctx-b1a9fc1d ctx-fa54ddb0) (logid:5754932c) template 206 is 
already in store:1, type:Image
   2021-03-11 04:29:27,110 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp1644231115-15:ctx-b1a9fc1d ctx-fa54ddb0) (logid:5754932c) Updating resource 
Type = template count for Account = 2 Operation = increasing Amount = 1
   2021-03-11 04:29:27,356 DEBUG [c.c.a.ApiServlet] 
(qtp1644231115-15:ctx-b1a9fc1d ctx-fa54ddb0) (logid:5754932c) ===END===  
192.168.122.1 -- GET  
name=Lubuntu+18.04.5&displaytext=S

[GitHub] [cloudstack] blueorangutan commented on pull request #4727: Marvin3

[GitBox]

blueorangutan commented on pull request #4727:
URL: https://github.com/apache/cloudstack/pull/4727#issuecomment-797844165


   [S] Trillian test result (tid-105)
   Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8
   Total time taken: 39528 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4727-t105-kvm-centos8.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 82 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeleteDomain | `Error` | 168.55 | test_accounts.py
   test_oobm_background_powerstate_sync | `Failure` | 21.75 | 
test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 32.24 | 
test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 19.72 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 19.72 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 18.72 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 19.70 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 19.74 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 18.71 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Failure` | 27.89 | 
test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 6.34 | test_outofbandmanagement.py
   ContextSuite context=TestSecuredVmMigration>:teardown | `Error` | 198.30 | 
test_vm_life_cycle.py
   test_hostha_kvm_host_degraded | `Error` | 9.96 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 10.99 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 9.92 | test_hostha_kvm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4727: Marvin3

[GitBox]

blueorangutan commented on pull request #4727:
URL: https://github.com/apache/cloudstack/pull/4727#issuecomment-797845090


   [S] Trillian test result (tid-106)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40451 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4727-t106-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeleteDomain | `Error` | 153.35 | test_accounts.py
   ContextSuite context=TestSecuredVmMigration>:teardown | `Error` | 198.54 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] abdelouahabb opened a new issue #4810: Cant run instance

[GitBox]

abdelouahabb opened a new issue #4810:
URL: https://github.com/apache/cloudstack/issues/4810


   ```
   - Cloudstack 4.15
   - Ubuntu 18.04.5
   - Virt Manager 3.2 (nested on Ubuntu 20.04)
   ```
   
   Everything was installed, secondary storage works (same machine), uploaded 
the template as in the tutorial 
`/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt 
-m /export/secondary -f systemvmtemplate-4.15.0-kvm.qcow2.bz2 -h kvm -F`
   
   But cant make it run
   
![one](https://user-images.githubusercontent.com/2527234/111014919-6d825580-83a6-11eb-972c-be8f2e321834.png)
   
![two](https://user-images.githubusercontent.com/2527234/111014922-7541fa00-83a6-11eb-8dc0-f2476e21e59c.png)
   
   Here is the full log (launched it  just when pressing run)
   ```
   }","wait":"0"}}] }
   2021-03-13 02:39:50,615 DEBUG [c.c.s.s.SnapshotSchedulerImpl] 
(SnapshotPollTask:ctx-6708c44a) (logid:ea60923b) Snapshot scheduler.poll is 
being called at 2021-03-13 01:39:50 GMT
   2021-03-13 02:39:50,616 DEBUG [c.c.s.s.SnapshotSchedulerImpl] 
(SnapshotPollTask:ctx-6708c44a) (logid:ea60923b) Got 0 snapshots to be executed 
at 2021-03-13 01:39:50 GMT
   2021-03-13 02:39:50,676 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-11:null) (logid:) SeqA 2-288: Sending Seq 2-288:  { Ans: 
, MgmtId: 191528580652610, via: 2, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":"true","wait":"0"}}] }
   2021-03-13 02:39:50,799 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-12:null) (logid:) Ping from Routing host 
1(alien.akham.local)
   2021-03-13 02:39:50,799 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-12:null) (logid:) Process host VM state report from ping 
process. host: 1
   2021-03-13 02:39:50,805 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-12:null) (logid:) Process VM state report. host: 1, 
number of records in report: 2
   2021-03-13 02:39:50,805 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-12:null) (logid:) VM state report. host: 1, vm id: 1, 
power state: PowerOn
   2021-03-13 02:39:50,810 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-12:null) (logid:) VM state report. host: 1, vm id: 2, 
power state: PowerOn
   2021-03-13 02:39:50,815 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] 
(AgentManager-Handler-12:null) (logid:) Done with process of VM state report. 
host: 1
   2021-03-13 02:39:56,737 DEBUG [c.c.a.ApiServlet] 
(qtp182531396-13:ctx-c25be67a) (logid:9fac86d2) ===START===  192.168.122.1 -- 
GET  
zoneid=3ea197d5-827e-4563-91e8-d23fd3075f2f&podid=5c1abf4e-4113-425d-8f33-fe330f1a64b6&clusterid=e1d74192-1b02-40b4-8361-fe60593839fb&templateid=a628f943-821d-11eb-ac45-525400644510&serviceofferingid=2ba8f0f1-a25a-4c7e-8ca7-5620e19ae353&affinitygroupids=&iptonetworklist[0].networkid=21dba76c-2744-4b80-945a-9de7d426e134&command=deployVirtualMachine&response=json
   2021-03-13 02:39:56,752 DEBUG [c.c.a.ApiServer] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) CIDRs from which 
account 'Acct[ed2c36a7-821e-11eb-ac45-525400644510-admin]' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2021-03-13 02:39:56,797 DEBUG [c.c.u.AccountManagerImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Access granted to 
Acct[ed2c36a7-821e-11eb-ac45-525400644510-admin] to 
org.apache.cloudstack.quota.vo.ServiceOfferingVO$$EnhancerByCGLIB$$fc0b01ab@4765e5a1
 by AffinityGroupAccessChecker
   2021-03-13 02:39:56,798 DEBUG [c.c.u.AccountManagerImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Access granted to 
Acct[ed2c36a7-821e-11eb-ac45-525400644510-admin] to null by 
AffinityGroupAccessChecker
   2021-03-13 02:39:56,826 DEBUG [c.c.n.NetworkModelImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Service 
SecurityGroup is not supported in the network id=204
   2021-03-13 02:39:56,918 DEBUG [c.c.v.UserVmManagerImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Allocating in the 
DB for vm
   2021-03-13 02:39:56,941 INFO  [c.c.v.VirtualMachineManagerImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) allocating virtual 
machine from template:a628f943-821d-11eb-ac45-525400644510 with 
hostname:i-2-6-VM and 1 networks
   2021-03-13 02:39:56,949 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Allocating entries 
for VM: VM[User|i-2-6-VM]
   2021-03-13 02:39:56,951 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Allocating nics 
for VM[User|i-2-6-VM]
   2021-03-13 02:39:56,954 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
(qtp182531396-13:ctx-c25be67a ctx-44b49ac4) (logid:9fac86d2) Allocating nic for 
vm VM[User|i-2-6-VM] in network Ntwk[204|Guest|8] with requested profile 
NicProfile[0-0-null-null-null]
   2021-03-13 02:39:57,084 DEBUG [c.c.n.NetworkModelImpl] 
(qtp182531396-13:ctx-c25be6

[GitHub] [cloudstack] abdelouahabb edited a comment on issue #4734: Cant upload ISO Using TrueNas with NFS

[GitBox]

abdelouahabb edited a comment on issue #4734:
URL: https://github.com/apache/cloudstack/issues/4734#issuecomment-797843380


   @rhtyd 
   Both system VM are on, but cant accept uploading the iso to create a new 
machine
   ```
   2021-03-13 03:36:46,546 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(RouterStatusMonitor-1:ctx-cc3a4008) (logid:0c7684af) Found 0 networks to 
update RvR status. 
   2021-03-13 03:36:50,685 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-1:null) (logid:) SeqA 2-239: Processing Seq 2-239:  { Cmd 
, MgmtId: -1, via: 2, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":"1","_loadInfo":"{
 "connections": []
   }","wait":"0"}}] }
   2021-03-13 03:36:50,812 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-1:null) (logid:) SeqA 2-239: Sending Seq 2-239:  { Ans: , 
MgmtId: 279278805500290, via: 2, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":"true","wait":"0"}}] }
   2021-03-13 03:36:55,314 DEBUG [c.c.s.d.DownloadListener] 
(Timer-5:ctx-630f3b4f) (logid:5bb0) Scheduling timeout at 3 ms, 
TEMPLATE: 4 at host 3
   2021-03-13 03:36:55,689 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-15:null) (logid:) SeqA 2-240: Processing Seq 2-240:  { 
Cmd , MgmtId: -1, via: 2, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":"1","_loadInfo":"{
 "connections": []
   }","wait":"0"}}] }
   2021-03-13 03:36:55,786 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-15:null) (logid:) SeqA 2-240: Sending Seq 2-240:  { Ans: 
, MgmtId: 279278805500290, via: 2, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":"true","wait":"0"}}] }
   2021-03-13 03:36:59,021 DEBUG [o.a.c.s.SecondaryStorageManagerImpl] 
(secstorage-1:ctx-2112f164) (logid:846dc128) Zone 1 is ready to launch 
secondary storage VM
   2021-03-13 03:36:59,070 DEBUG [c.c.c.ConsoleProxyManagerImpl] 
(consoleproxy-1:ctx-b412ebc2) (logid:05d60268) Zone 1 is ready to launch 
console proxy
   2021-03-13 03:37:01,258 DEBUG [c.c.a.ApiServlet] 
(qtp182531396-302:ctx-d6abf2ce) (logid:d79e09e4) ===START===  192.168.122.1 -- 
GET  
name=Ubuntu+18.04.5&displaytext=No-GUI&zoneid=3ea197d5-827e-4563-91e8-d23fd3075f2f&bootable=true&ostypeid=b91cdcc8-821e-11eb-ac45-525400644510&isextractable=false&ispublic=false&isfeatured=false&format=ISO&command=getUploadParamsForIso&response=json
   2021-03-13 03:37:01,272 DEBUG [c.c.a.ApiServer] 
(qtp182531396-302:ctx-d6abf2ce ctx-3f418508) (logid:d79e09e4) CIDRs from which 
account 'Acct[ed2c36a7-821e-11eb-ac45-525400644510-admin]' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2021-03-13 03:37:01,442 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] 
(qtp182531396-302:ctx-d6abf2ce ctx-3f418508) (logid:d79e09e4) template 217 is 
not in store:2, type:Image
   2021-03-13 03:37:01,454 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] 
(qtp182531396-302:ctx-d6abf2ce ctx-3f418508) (logid:d79e09e4) template 217 is 
already in store:2, type:Image
   2021-03-13 03:37:01,476 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp182531396-302:ctx-d6abf2ce ctx-3f418508) (logid:d79e09e4) Updating resource 
Type = template count for Account = 2 Operation = increasing Amount = 1
   2021-03-13 03:37:02,223 DEBUG [c.c.a.ApiServlet] 
(qtp182531396-302:ctx-d6abf2ce ctx-3f418508) (logid:d79e09e4) ===END===  
192.168.122.1 -- GET  
name=Ubuntu+18.04.5&displaytext=No-GUI&zoneid=3ea197d5-827e-4563-91e8-d23fd3075f2f&bootable=true&ostypeid=b91cdcc8-821e-11eb-ac45-525400644510&isextractable=false&ispublic=false&isfeatured=false&format=ISO&command=getUploadParamsForIso&response=json
   2021-03-13 03:37:02,368 DEBUG [c.c.a.ApiServlet] 
(qtp182531396-23:ctx-03adae4b) (logid:1e6dfee5) ===START===  192.168.122.1 -- 
GET  
listall=true&isofilter=all&showunique=true&page=1&pagesize=20&command=listIsos&response=json
   2021-03-13 03:37:02,381 DEBUG [c.c.a.ApiServer] 
(qtp182531396-23:ctx-03adae4b ctx-558de57d) (logid:1e6dfee5) CIDRs from which 
account 'Acct[ed2c36a7-821e-11eb-ac45-525400644510-admin]' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2021-03-13 03:37:02,464 DEBUG [c.c.a.ApiServlet] 
(qtp182531396-23:ctx-03adae4b ctx-558de57d) (logid:1e6dfee5) ===END===  
192.168.122.1 -- GET  
listall=true&isofilter=all&showunique=true&page=1&pagesize=20&command=listIsos&response=json
   2021-03-13 03:37:05,315 DEBUG [c.c.h.o.r.Ovm3HypervisorGuru] 
(Timer-5:ctx-c449ed94) (logid:d55575e4) getCommandHostDelegation: class 
org.apache.cloudstack.storage.command.DownloadProgressCommand
   2021-03-13 03:37:05,318 DEBUG [c.c.h.XenServerGuru] (Timer-5:ctx-c449ed94) 
(logid:d55575e4) We are returning the default host to execute commands because 
the command is not of Copy type.
   2021-03-13 03:37:05,318 DEBUG [o.a.c.s.RemoteHostEndPoint] 
(Timer-5:ctx-c449ed94) (logid:d55575e4) Sending command 
org.apache.cloudstack.storage.command.DownloadProgressCommand to host: 3
   2021-03-13 03:37:05,321 DEB

[GitHub] [cloudstack] aleskxyz commented on issue #4810: Cant run instance

[GitBox]

aleskxyz commented on issue #4810:
URL: https://github.com/apache/cloudstack/issues/4810#issuecomment-797868141


   Here is not the right place for asking help or questions. You can use 
mailing lists for this purpose.
   Please subscribe to users mailing list and ask you questions there:
   https://cloudstack.apache.org/mailing-lists.html
   
   Anyway, I think the root cause of problem is that you don't define a range 
for usable VLANs for your guest network.
   `com.cloud.exception.InsufficientVirtualNetworkCapacityException: Unable to 
allocate vnet as a part of network Ntwk[204|Guest|8] implement Scope=interface 
com.cloud.dc.DataCenter; id=1
   `
   
![image](https://user-images.githubusercontent.com/39186039/111019795-afc38b00-83d6-11eb-8419-35fed99768c0.png)
   
   Please don't continue this issue here. We can help you on mailing list.
   Thanks
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4727: Marvin3

[GitBox]

blueorangutan commented on pull request #4727:
URL: https://github.com/apache/cloudstack/pull/4727#issuecomment-797872671


   [S] Trillian test result (tid-119)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39187 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4727-t119-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 82 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeleteDomain | `Error` | 219.79 | test_accounts.py
   test_03_nic_multiple_vmware | `Error` | 74.09 | test_nic.py
   test_01_deploy_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_01_migrate_VM_and_root_volume | `Error` | 0.01 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 0.01 | 
test_vm_life_cycle.py
   test_03_migrate_detached_volume | `Error` | 0.01 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 44.32 | 
test_vm_life_cycle.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org