DaanHoogland commented on pull request #4800: URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797406054
> > @weizhouapache I'm confused by your description in context of the code change. If we do have a disk, but no backing format, we go ahead and rebase it as qcow2, am I right? > > and if we don't have a file path or we do have a backing format, we do nothing. > > @DaanHoogland I changed the title and description. > > we do nothing if (1) disk does not have a backing file ; (2) disk has backing file, and also backing file format. > we set backing file format only if disk has a backing file but backing file format is missing exactly what the code does, good text for the tin ;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
