GSoC report #2 - Integrate Spotify into Amarok
Hi, The Spotify service plugin has two parts, a standalone Spotify resolver and a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the Amarok side resolver, it can work without Tomahawk base classes and headers now. Here[1] is the code. In the following week, I will continue working on the resolver to make it more suited for Amarok. [1] http://quickgit.kde.org/index.php?p=scratch%2Fzhengliangfeng%2Fgsoc-scratch.git&a=summary Thanks, Ryan ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Review Request: Fix build with ffmpeg 0.11
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105073/ --- Review request for Amarok and Sergey Ivanov. Description --- Fixes two issues: - replace deprecated av_open_input_file() - replace toAscii() with toLocal8Bit() This does not replace other deprecated calls to help building with older ffmpeg. This addresses bug 300729. https://bugs.kde.org/show_bug.cgi?id=300729 Diffs - src/musicbrainz/MusicDNSAudioDecoder.cpp 0fa1946 Diff: http://git.reviewboard.kde.org/r/105073/diff/ Testing --- Compiles, but do not know how to test. Thanks, Christoph Feck ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: GSoC report #2 - Integrate Spotify into Amarok
On Sun, May 27, 2012 at 11:13 PM, Ryan Feng wrote: > Hi, > > The Spotify service plugin has two parts, a standalone Spotify resolver and > a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the > Amarok side resolver, it can work without Tomahawk base classes and headers > now. Here[1] is the code. > > In the following week, I will continue working on the resolver to make it > more suited > for Amarok. > > [1] http://quickgit.kde.org/index.php?p=scratch%2Fzhengliangfeng%2Fgsoc-scratch.git&a=summary > > Thanks, > Ryan > > Thanks Ryan. Certainly not a wasted effort to split of the tomahawk headers. I'll go through the code tomorrow. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104048/#review14233 --- Hmm. How about changing the tool tip instead of the playlist itself. Now the description() function does not return the description any longer. - Ralf Engels On Feb. 23, 2012, 4:49 p.m., Claudio Desideri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104048/ > --- > > (Updated Feb. 23, 2012, 4:49 p.m.) > > > Review request for Amarok. > > > Description > --- > > My first attempt to contribute. > > > This addresses bug 275821. > https://bugs.kde.org/show_bug.cgi?id=275821 > > > Diffs > - > > src/playlistmanager/sql/SqlPlaylist.h a001194 > > Diff: http://git.reviewboard.kde.org/r/104048/diff/ > > > Testing > --- > > It works. :P > > > Thanks, > > Claudio Desideri > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Fix build with ffmpeg 0.11
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105073/#review14241 --- Note that this change breaks compatibility with ffmpeg 0.6 and earlier. The readme would need updating (it's the MusicBrainz section of the dependencies) to reflect that ffmpeg/libav 0.7 is now required. Furthermore, 0.7 was only released in June 2011 - are we okay with requiring a version this recent? We discussed this before and were planning to make the changes after release of Amarok 2.6, but that was before ffmpeg had rolled out a release breaking this. It may need #ifdefing. - Sam Lade On May 27, 2012, 10:28 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105073/ > --- > > (Updated May 27, 2012, 10:28 p.m.) > > > Review request for Amarok and Sergey Ivanov. > > > Description > --- > > Fixes two issues: > - replace deprecated av_open_input_file() > - replace toAscii() with toLocal8Bit() > > This does not replace other deprecated calls to help building with older > ffmpeg. > > > This addresses bug 300729. > https://bugs.kde.org/show_bug.cgi?id=300729 > > > Diffs > - > > src/musicbrainz/MusicDNSAudioDecoder.cpp 0fa1946 > > Diff: http://git.reviewboard.kde.org/r/105073/diff/ > > > Testing > --- > > Compiles, but do not know how to test. > > > Thanks, > > Christoph Feck > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Fix build with ffmpeg 0.11
> On May 28, 2012, 3:19 p.m., Sam Lade wrote: > > Note that this change breaks compatibility with ffmpeg 0.6 and earlier. The > > readme would need updating (it's the MusicBrainz section of the > > dependencies) to reflect that ffmpeg/libav 0.7 is now required. > > Furthermore, 0.7 was only released in June 2011 - are we okay with > > requiring a version this recent? We discussed this before and were planning > > to make the changes after release of Amarok 2.6, but that was before ffmpeg > > had rolled out a release breaking this. It may need #ifdefing. I agree on that one. Now if the FFMPEG people could learn a bit on how not to break their own API on every release it would also be helpful... Could we agree on the fix pre-2.6 to not break compatibility with versions before 0.7? We will have to re-discuss this again after 2.6 is released anyway. - Myriam --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105073/#review14241 --- On May 27, 2012, 10:28 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105073/ > --- > > (Updated May 27, 2012, 10:28 p.m.) > > > Review request for Amarok and Sergey Ivanov. > > > Description > --- > > Fixes two issues: > - replace deprecated av_open_input_file() > - replace toAscii() with toLocal8Bit() > > This does not replace other deprecated calls to help building with older > ffmpeg. > > > This addresses bug 300729. > https://bugs.kde.org/show_bug.cgi?id=300729 > > > Diffs > - > > src/musicbrainz/MusicDNSAudioDecoder.cpp 0fa1946 > > Diff: http://git.reviewboard.kde.org/r/105073/diff/ > > > Testing > --- > > Compiles, but do not know how to test. > > > Thanks, > > Christoph Feck > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: initialize m_bpm field in TimecodeMetac class
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104024/#review14232 --- This review has been submitted with commit e9e37f307f9dbe35f0113b0c3286d152ea6fe1be by Ralf Engels to branch master. - Commit Hook On Feb. 19, 2012, 6:38 p.m., Andriy Gapon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104024/ > --- > > (Updated Feb. 19, 2012, 6:38 p.m.) > > > Review request for Amarok. > > > Description > --- > > Uninitialized double (qreal) field can get an arbitrary value including > exotics like NaN, denormalized numbers etc. > This could lead to surprises in the code that doesn't expect an "unreal" > values - e.g. any logical with NaN always returns false. > > > Diffs > - > > src/core-impl/meta/timecode/TimecodeMeta.cpp 5ebe859 > > Diff: http://git.reviewboard.kde.org/r/104024/diff/ > > > Testing > --- > > > Thanks, > > Andriy Gapon > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Dates fixed - fill in your details, was: Amarok and KDE-multimedia in Randa in September
On Sun, 2012-05-27 at 16:45 +0200, Myriam Schweingruber wrote: > hm, I missed some words apparently, so let's try again: > > On Sun, May 27, 2012 at 4:42 PM, Myriam Schweingruber wrote: > > Hi all, > > > > On Mon, May 21, 2012 at 10:26 AM, Myriam Schweingruber > > wrote: > ... > > As those who have been in Randa > > before (Ian Monroe in particular), it is really worth the travel. > > "As those who have been in Randa in the past can tell you, ..." Yup. I was there last year. Totally worth it. > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Fix build with ffmpeg 0.11
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105073/#review14243 --- This review has been submitted with commit 4752e41ff6235afaef88211e25e240df40ecb712 by Sam Lade to branch master. - Commit Hook On May 27, 2012, 10:28 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105073/ > --- > > (Updated May 27, 2012, 10:28 p.m.) > > > Review request for Amarok and Sergey Ivanov. > > > Description > --- > > Fixes two issues: > - replace deprecated av_open_input_file() > - replace toAscii() with toLocal8Bit() > > This does not replace other deprecated calls to help building with older > ffmpeg. > > > This addresses bug 300729. > https://bugs.kde.org/show_bug.cgi?id=300729 > > > Diffs > - > > src/musicbrainz/MusicDNSAudioDecoder.cpp 0fa1946 > > Diff: http://git.reviewboard.kde.org/r/105073/diff/ > > > Testing > --- > > Compiles, but do not know how to test. > > > Thanks, > > Christoph Feck > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
[KDE Bugtracking System] Release blockers
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 256869: https://bugs.kde.org/show_bug.cgi?id=256869 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary: Selecting Podcast view crashes Amarok; ditto for Saved Playlist [@ PlaylistBrowserNS::PlaylistBrowserView::viewportEvent] Bug 279966: https://bugs.kde.org/show_bug.cgi?id=279966 Priority: NOR Severity: crash Platform: Ubuntu Packages Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary: Amarok crashes on Phone plug [@ Collections::MediaDeviceCollection::collectionDisconnected] Bug 292245: https://bugs.kde.org/show_bug.cgi?id=292245 Priority: HI Severity: normal Platform: Ubuntu Packages Assignee: amarok-bugs-d...@kde.org Status: ASSIGNED Summary: stats lost after changing metadata and moving files within amarok. Bug 299890: https://bugs.kde.org/show_bug.cgi?id=299890 Priority: NOR Severity: normal Platform: Fedora RPMs Assignee: amarok-bugs-d...@kde.org Status: NEW Summary: Bug #188330 is back: Playcount increased by 2 by "Stop Playing After Track" Bug 300334: https://bugs.kde.org/show_bug.cgi?id=300334 Priority: NOR Severity: normal Platform: Fedora RPMs Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary: Unknown Artist and Unknown Album when playing streams Bug 300413: https://bugs.kde.org/show_bug.cgi?id=300413 Priority: NOR Severity: crash Platform: Compiled Sources Assignee: amarok-bugs-d...@kde.org Status: NEW Summary: Amarok crashes when trying to play a strem from "Cool Streams" [@ LyricsAppletPrivate::_trackPositionChanged] ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
