> On May 28, 2012, 3:19 p.m., Sam Lade wrote: > > Note that this change breaks compatibility with ffmpeg 0.6 and earlier. The > > readme would need updating (it's the MusicBrainz section of the > > dependencies) to reflect that ffmpeg/libav 0.7 is now required. > > Furthermore, 0.7 was only released in June 2011 - are we okay with > > requiring a version this recent? We discussed this before and were planning > > to make the changes after release of Amarok 2.6, but that was before ffmpeg > > had rolled out a release breaking this. It may need #ifdefing.
I agree on that one. Now if the FFMPEG people could learn a bit on how not to break their own API on every release it would also be helpful... Could we agree on the fix pre-2.6 to not break compatibility with versions before 0.7? We will have to re-discuss this again after 2.6 is released anyway. - Myriam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105073/#review14241 ----------------------------------------------------------- On May 27, 2012, 10:28 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105073/ > ----------------------------------------------------------- > > (Updated May 27, 2012, 10:28 p.m.) > > > Review request for Amarok and Sergey Ivanov. > > > Description > ------- > > Fixes two issues: > - replace deprecated av_open_input_file() > - replace toAscii() with toLocal8Bit() > > This does not replace other deprecated calls to help building with older > ffmpeg. > > > This addresses bug 300729. > https://bugs.kde.org/show_bug.cgi?id=300729 > > > Diffs > ----- > > src/musicbrainz/MusicDNSAudioDecoder.cpp 0fa1946 > > Diff: http://git.reviewboard.kde.org/r/105073/diff/ > > > Testing > ------- > > Compiles, but do not know how to test. > > > Thanks, > > Christoph Feck > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
