----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104024/#review14232 -----------------------------------------------------------
This review has been submitted with commit e9e37f307f9dbe35f0113b0c3286d152ea6fe1be by Ralf Engels to branch master. - Commit Hook On Feb. 19, 2012, 6:38 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104024/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2012, 6:38 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Uninitialized double (qreal) field can get an arbitrary value including > exotics like NaN, denormalized numbers etc. > This could lead to surprises in the code that doesn't expect an "unreal" > values - e.g. any logical with NaN always returns false. > > > Diffs > ----- > > src/core-impl/meta/timecode/TimecodeMeta.cpp 5ebe859 > > Diff: http://git.reviewboard.kde.org/r/104024/diff/ > > > Testing > ------- > > > Thanks, > > Andriy Gapon > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel