Re: [PATCH 1/1] usb: gadget: ether: Disable USB pullup in eth probe

2024-08-29 Thread Mattijs Korpershoek
On lun., août 26, 2024 at 16:40, Marek Vasut wrote: > On 8/26/24 11:12 AM, Zixun LI wrote: >> On Sun, Aug 25, 2024 at 2:13 AM Marek Vasut wrote: >>> I am looking at the usb_add_gadget_udc_release() and usb_gadget_probe_driver() and I am thinking, sigh, all that code is ready

Re: [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On lun., août 26, 2024 at 16:38, Marek Vasut wrote: > The release parameter of usb_add_gadget_udc_release() is never used. > The function is never called from anywhere except from a wrapper in > udc-core.c . Inline the function into the wrapper. > > Signed-of

Re: [PATCH 01/13] Makefile: detect HOST_ARCH properly when CROSS_COMPILE is multi-word

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > When CROSS_COMPILE contains multiple words, HOST_ARCH is not properly > detected and the sandbox build fail. It typically happens when using > ccache. For example: > > $ make sandbox_defconfig > $ make CROSS_COMPILE="ccache x86_64-linux-g

Re: [PATCH 03/13] at91: rename mem_init() to at91_mem_init()

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > THe AT91-based platforms have a mem_init() function declared in > arch/arm/mach-at91/include/mach/at91_common.h and implemented in various > places. In preparation of the introduction of the lwIP networking library > which also has a global

Re: [PATCH 04/13] arm: omap2: add missing #include

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > emac.c implements cpu_eth_init() so it needs to pull the corresponding > header file. > > Signed-off-by: Jerome Forissier > Reviewed-by: Tom Rini > --- > arch/arm/mach-omap2/omap3/emac.c | 1 + > 1 file changed, 1 insertion(+) > > diff -

[PATCH] test/py: spi: Set the expected error message

2024-08-29 Thread Love Kumar
If erase/write/read size is 0 then it throws the mentioned error message when debug message ie enabled as per "899fb5aa8becc159b1eb086d8828c4e8eb28f121" , setting it to None as debug message is not enabled by default for testing. Signed-off-by: Love Kumar --- test/py/tests/test_spi.py | 4 ++--

Re: [PATCH 07/13] net: phy: ncsi: depend on NET

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > PHY_NCSI enables drivers/net/phy/ncsi.c which calls net_loop() and > net_set_timeout_handler(). That's the legacy NET stack (as opposed to > NET_LWIP). Therefore add the dependency to Kconfig. > > Signed-off-by: Jerome Forissier > --- > d

Re: [PATCH 09/13] net: wget: allow EFI boot

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > wget followed by bootefi currently fails as follows: > > U-Boot> wget 20 192.168.0.30:helloworld.efi > Waiting for Ethernet connection... done. > HTTP/1.0 200 OK > Packets received 13, Transfer Successful > Bytes transferred = 1272

Re: [PATCH 10/13] net: fec_mxc_init(): do not ignore return status of fec_open()

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > The fec_mxc_init() function currently always returns 0. This does not > allow the callers to detect when for instance the PHY initialization > failed due to the port being unconnected. Fix that by returning the > status of fec_open(). > > S

Re: [PATCH 11/13] test/py: net_boot: fix comment

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > If env__pxe_boot_test_skip is not present, it defaults to True not > False. Therefore fix the comment. > > Signed-off-by: Jerome Forissier > --- > test/py/tests/test_net_boot.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 12/13] test/py: test_efi_loader: add missing dependency on cmd_tftpboot

2024-08-29 Thread Ilias Apalodimas
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier wrote: > > test_efi_helloworld_net() and test_efi_grub_net() depend on > cmd_tftpboot so add the missing annotations. > > Reported-by: Tom Rini > Signed-off-by: Jerome Forissier > --- > test/py/tests/test_efi_loader.py | 2 ++ > 1 file changed, 2 i

Re: [PATCH 2/6] usb: gadget: Drop usb_udc_release()

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On lun., août 26, 2024 at 16:38, Marek Vasut wrote: > This callback is never called, drop it. Instead, call kfree(udc) > in usb_del_gadget_udc() to free the struct usb_udc data. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: L

Re: [PATCH 3/6] usb: gadget: Track driver data as part of struct usb_gadget

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On lun., août 26, 2024 at 16:38, Marek Vasut wrote: > Move driver data directly into struct usb_gadget {} in preparation for > conversion of struct device to struct udevice * in struct usb_gadget. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpersh

Re: [PATCH 4/6] usb: gadget: Drop dev_to_usb_gadget()

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On lun., août 26, 2024 at 16:38, Marek Vasut wrote: > This function is unused, remove it. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Linus Walleij > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Miquel Raynal > C

Re: [PATCH 5/6] usb: gadget: dwc2: Drop get/set_udc_gadget_private_data()

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On lun., août 26, 2024 at 16:38, Marek Vasut wrote: > Neither get_udc_gadget_private_data() nor set_udc_gadget_private_data() > is ever called anywhere, remove both. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Linus Walleij

Re: Grub doesn’t load devicetree

2024-08-29 Thread Peter Robinson
On Thu, 29 Aug 2024 at 05:14, Tomaž Zaman wrote: > > I’m working on an arm64 board with an NXP LS1046A CPU and I simply cannot get > Grub to load a different device tree than the one that’s provided to it by > the EFI Stub. > > => fatload mmc 0:1 $kernel_addr_r /EFI/boot/grubaa64.efi > => fatloa

Re: How to retrieve cpu info from u-boot fucntion?

2024-08-29 Thread Peter Robinson
Hi Sourabh, > Thanks for the update. Looking at the board/raspberrypi/rpi/rpi.c I think MAC > address is only returned for models that have onboard ethernet. but for > models raspberry pi 0w / pi 02w it might not return any value. > Am I correct? (maybe I overlooked it?) Is there any other appro

[PATCH u-boot-marvell 0/3] Turris Omnia DDR speed change with reset button (for 2024.10)

2024-08-29 Thread Marek Behún
Hello Stefan, this series adds the ability to select 1333H DDR speed mode for DDR training (instead of the default 1600K) with the factory reset button. If possible, I would like if this series went for U-Boot 2024.10 release. The heavy stuff to support DDR speed change is already in, this just a

[PATCH u-boot-marvell 1/3] arm: mvebu: turris_omnia: Rename variable holding EEPROM udevice

2024-08-29 Thread Marek Behún
Rename the variable holding the EEPROM udevice from `chip` to `eeprom`. Signed-off-by: Marek Behún --- board/CZ.NIC/turris_omnia/turris_omnia.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/tur

[PATCH u-boot-marvell 2/3] arm: mvebu: turris_omnia: Use the i2c_eeprom misc driver for EEPROM reading in U-Boot proper

2024-08-29 Thread Marek Behún
Use the i2c_eeprom miscellaneous driver for reading Turris Omnia EEPROM in U-Boot proper. Keep using dm_i2c_read() in SPL build, since adding the i2c_eeprom driver to SPL build increases the image by 1.5 KiB. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/Kconfig | 1 + board/CZ

[PATCH u-boot-marvell 3/3] arm: mvebu: turris_omnia: Switch DDR speed to 1333H when reset 9 is selected

2024-08-29 Thread Marek Behún
Users experiencing random kernel crashes due to new versions of Marvell's DDR training algorithm can solve the issue by setting DDR speed to 1333H. But if kernel crashes, it has to be done in U-Boot, which is impossible without UART connection. In order to make it easier for users, use the rescue

Re: [PATCH 03/13] at91: rename mem_init() to at91_mem_init()

2024-08-29 Thread Heiko Schocher
Hello Jerome, On 28.08.24 14:10, Jerome Forissier wrote: THe AT91-based platforms have a mem_init() function declared in arch/arm/mach-at91/include/mach/at91_common.h and implemented in various places. In preparation of the introduction of the lwIP networking library which also has a global mem_

Re: [EXTERNAL] Re: [PATCH 1/6] arm: dts: k3-j7200-r5: Add the pmic node in R5 dt

2024-08-29 Thread Limaye, Aniket
On 6/14/2024 8:25 PM, Tom Rini wrote: On Fri, May 31, 2024 at 10:24:30PM +0530, Limaye, Aniket wrote: On 5/31/2024 7:25 PM, Kumar, Udit wrote: On 5/31/2024 6:38 PM, Aniket Limaye wrote: Add bootph-pre-ram property to the buck node in the pmic needed for ESM error event handling. Signed-

[PATCH] ram: k3-ddrss: Handle error properly in lpddr4_start

2024-08-29 Thread Udit Kumar
In lpddr4_start function error returned by lpddr4_enablepiinitiator may go undetected due to overwrite of return code. Add support to handle error in above case. Reported-by: Andreas Dannenberg Signed-off-by: Udit Kumar --- drivers/ram/k3-ddrss/lpddr4.c | 5 +++-- 1 file changed, 3 insertions(+

Re: [PATCH v3 4/4] imx: Remove CFG_MXC_USB_PORTSC

2024-08-29 Thread Soeren Moch
On 28.08.24 15:25, Fabio Estevam wrote: From: Fabio Estevam The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c. Suggested-by: Tim Harv

Re: [PATCH 6/6] usb: gadget: Pass struct udevice to usb_add_gadget_udc()

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On lun., août 26, 2024 at 16:38, Marek Vasut wrote: > Almost every UDC driver already passes casted pointer to struct udevice > usb_add_gadget_udc(), even if the behavior is not exactly correct. That > struct udevice is at risk of being corrupted in case some

Re: [PATCH v2] android_ab: Fixes: Fix backup offset calculation

2024-08-29 Thread Mattijs Korpershoek
Hi Joshua, Thank you for the patch. On mer., août 28, 2024 at 08:37, Joshua Watt wrote: > The backup offset is in bytes, but was incorrectly be interpreted as > blocks, leading to it being written to the wrong location. Fix the > calculation, clarify that ANDROID_AB_BACKUP_OFFSET is in bytes an

Re: [PATCH] mmc: Hide mmc speed command under mmc command

2024-08-29 Thread Mattijs Korpershoek
Hi Marek, Thank you for the patch. On jeu., août 29, 2024 at 03:22, Marek Vasut wrote: > The mmc speed command configuration option keeps showing up in > Kconfig even if CMD_MMC is not set. Move MMC_SPEED_MODE_SET under > CMD_MMC to show up the Kconfig option only if MMC command is enabled. >

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-29 Thread Jonas Karlman
Hi Simon, On 2024-08-29 00:17, Simon Glass wrote: > Hi Jonas, > > On Wed, 28 Aug 2024 at 13:01, Jonas Karlman wrote: >> >> Hi Simon, >> >> On 2024-08-28 20:11, Simon Glass wrote: >>> Hi again Jonas, >>> >>> On Wed, 28 Aug 2024 at 11:06, Simon Glass wrote: Hi Jonas, On Wed, 2

Re: Grub doesn’t load devicetree

2024-08-29 Thread Tomaž Zaman
Doesn’t work - at least not correctly: => fatload mmc 0:1 $fdt_addr_r /boot/dtb/fsl-ls1046a-rdb-sdk.dtb 31793 bytes read in 4 ms (7.6 MiB/s) => fatload mmc 0:1 $kernel_addr_r /EFI/boot/grubaa64.efi 3978688 bytes read in 168 ms (22.6 MiB/s) => setenv fman_ucode => bootefi $kernel_addr_r $fdt_addr_r

Re: Grub doesn’t load devicetree

2024-08-29 Thread Peter Robinson
On Thu, 29 Aug 2024 at 10:31, Tomaž Zaman wrote: > Doesn’t work - at least not correctly: > > => fatload mmc 0:1 $fdt_addr_r /boot/dtb/fsl-ls1046a-rdb-sdk.dtb > 31793 bytes read in 4 ms (7.6 MiB/s) > => fatload mmc 0:1 $kernel_addr_r /EFI/boot/grubaa64.efi > 3978688 bytes read in 168 ms (22.6 MiB

Re: Grub doesn’t load devicetree

2024-08-29 Thread Tomaž Zaman
I get this: No UEFI binary known at 0x8100 Tomaž Zaman, CEO Mono Technologies Inc. +386 30 651 645 [cid:C1D504EAD21B41379FD3EEB7B3129E94] On 29 Aug 2024 at 11:38 +0200, Peter Robinson , wrote: On Thu, 29 Aug 2024 at 10:31, Tomaž Zaman mailto:to...@mono.si>> wrote: Doesn’t work - at least

Re: Grub doesn’t load devicetree

2024-08-29 Thread Peter Robinson
On Thu, 29 Aug 2024 at 10:40, Tomaž Zaman wrote: > I get this: > > No UEFI binary known at 0x8100 > Are you building the kernel with all the appropriate UEFI shim bits? Installing the EFI kernel pieces etc? Sorry, I can't help with kernel build process bits, you'll need to google that. >

Re: Grub doesn’t load devicetree

2024-08-29 Thread Tomaž Zaman
Thanks for the help, kernel is configured with all the EFI necessities turned on (CONFIG_EFI=y, CONFIG_EFI_STUB=y). I’ll dig deeper. Tomaž Zaman, CEO Mono Technologies Inc. +386 30 651 645 [cid:7E23C6DC89DF4381B59E228581293ABA] On 29 Aug 2024 at 11:44 +0200, Peter Robinson , wrote: On Thu, 2

Re: [PATCH 2/4] ram: rockchip: Kconfig: Fix dependency of RAM_ROCKCHIP_DEBUG

2024-08-29 Thread Quentin Schulz
Hi Lukasz, On 8/27/24 4:20 PM, Lukasz Czechowski wrote: The RAM_ROCKCHIP_DEBUG can be used only if DEBUG_UART is available, otherwise it won't have any effect. Add negative dependency to TPL_SILENT_CONSOLE. Signed-off-by: Lukasz Czechowski --- drivers/ram/rockchip/Kconfig | 2 ++ 1 file cha

Re: [PATCH 3/4] rockchip: Kconfig: PX30: Weaken dependency TPL/SPL serial

2024-08-29 Thread Quentin Schulz
Hi Lukasz, On 8/27/24 4:20 PM, Lukasz Czechowski wrote: Allow to disable serial console in TPL and SPL. Weak dependency to SPL_SERIAL and TPL_SERIAL is also used in other Rockchip boards. Signed-off-by: Lukasz Czechowski FWIW, most commits in that file for px30 have the following prefix for

Re: [PATCH 4/4] arm: rockchip: PX30: Fix hard dependency to DEBUG_UART_BOARD_INIT

2024-08-29 Thread Quentin Schulz
Hi Lukasz, On 8/27/24 4:20 PM, Lukasz Czechowski wrote: Because DEBUG_UART_BOARD_INIT depends on DEBUG_UART, hard dependency to DEBUG_UART_BOARD_INIT in ROCKCHIP_PX30 can cause warnings if DEBUG_UART is disabled. The DEBUG_UART_BOARD_INIT is already implied by ARCH_ROCKCHIP entry. Remove hard de

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Peter Robinson
On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: > > Hi Peter, > > On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: > > > > Hi Simon, > > > > > With Labgrid we don't need to specify the various methods, except for > > > the console, which simply calls labgrid-client. > > > > > > This allows su

[PATCH] configs: verdin-imx8m[mp]: set CONFIG_SPL_LOAD_FIT_ADDRESS

2024-08-29 Thread Hiago De Franco
From: Rogerio Guerra Borin Set the CONFIG_SPL_LOAD_FIT_ADDRESS for both verdin-imx8mm and verdin-imx8mp configurations to specify the load address for FIT images loaded by the SPL. As per lastest instructions from NXP, the generation of a HABv4 CSF (Command Sequence File) requires the U-Boot FIT

Re: [PATCH] configs: verdin-imx8m[mp]: set CONFIG_SPL_LOAD_FIT_ADDRESS

2024-08-29 Thread Francesco Dolcini
On Thu, Aug 29, 2024 at 08:23:57AM -0300, Hiago De Franco wrote: > From: Rogerio Guerra Borin > > Set the CONFIG_SPL_LOAD_FIT_ADDRESS for both verdin-imx8mm and > verdin-imx8mp configurations to specify the load address for FIT images > loaded by the SPL. > > As per lastest instructions from NXP

Re: [PATCH] test/py: spi: Set the expected error message

2024-08-29 Thread Michal Simek
On 8/29/24 09:33, Love Kumar wrote: If erase/write/read size is 0 then it throws the mentioned error message when debug message ie enabled as per "899fb5aa8becc159b1eb086d8828c4e8eb28f121" you should use this format not just sha1. 899fb5aa8bec ("cmd: sf/nand: Print and return failure when 0

Re: [PATCH] test/py/tests/test_bootstage.py: Combine stash/unstash tests

2024-08-29 Thread Simon Glass
On Wed, 28 Aug 2024 at 16:56, Tom Rini wrote: > > When running the bootstage tests currently we get a warning like: > tests/test_bootstage.py::test_bootstage_stash > ...PytestReturnNotNoneWarning: Expected None, but > tests/test_bootstage.py::test_bootstage_stash returned (37748736, 4096), > whi

Re: [PATCH v2 2/3] efi: Convert device_path allocation to use malloc()

2024-08-29 Thread Simon Glass
Hi Ilias, On Wed, 28 Aug 2024 at 01:40, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > > > --- > > > > > > > > > > > > > > (no changes since v1) > > > > > > > > > > > > What about > > > > > > https://lore.kernel.org/u-boot/caflsztjlakayk_jlxj7z571l-qmtoiqe-oxhcrs186dz2qo...@mail.gma

Re: Grub doesn’t load devicetree

2024-08-29 Thread Simon Glass
Hi Tomaž, On Thu, 29 Aug 2024 at 03:44, Peter Robinson wrote: > > On Thu, 29 Aug 2024 at 10:40, Tomaž Zaman wrote: > > > I get this: > > > > No UEFI binary known at 0x8100 > > That is the UEFI hack which we need to clean up at some point. When you load an image, it calls efi_set_bootdev()

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-29 Thread Simon Glass
Hi Jonas, On Thu, 29 Aug 2024 at 03:25, Jonas Karlman wrote: > > Hi Simon, > > On 2024-08-29 00:17, Simon Glass wrote: > > Hi Jonas, > > > > On Wed, 28 Aug 2024 at 13:01, Jonas Karlman wrote: > >> > >> Hi Simon, > >> > >> On 2024-08-28 20:11, Simon Glass wrote: > >>> Hi again Jonas, > >>> > >>>

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Simon Glass
Hi Peter, On Thu, 29 Aug 2024 at 04:43, Peter Robinson wrote: > > On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: > > > > Hi Peter, > > > > On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: > > > > > > Hi Simon, > > > > > > > With Labgrid we don't need to specify the various methods, except

Re: [PATCH] ram: k3-ddrss: Handle error properly in lpddr4_start

2024-08-29 Thread Bryan Brattlof
On August 29, 2024 thus sayeth Udit Kumar: > In lpddr4_start function error returned by lpddr4_enablepiinitiator > may go undetected due to overwrite of return code. > Add support to handle error in above case. > > Reported-by: Andreas Dannenberg > Signed-off-by: Udit Kumar Reviewed-by: Bryan B

Re: [PATCH v2 2/3] efi: Convert device_path allocation to use malloc()

2024-08-29 Thread Ilias Apalodimas
On Thu, 29 Aug 2024 at 15:17, Simon Glass wrote: > > Hi Ilias, > > On Wed, 28 Aug 2024 at 01:40, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > [...] > > > > > > > > > > --- > > > > > > > > > > > > > > > > (no changes since v1) > > > > > > > > > > > > > > What about > > > > > > > https://lo

[PATCH] mkimage: ecdsa: add nodes to signature/key node

2024-08-29 Thread Matthias Pritschet
From: Matthias Pritschet Add the "required", "algo", and "key-name-hint" nodes to the signature/key node if ecdsa256 is used. This change is mainly copy&paste from rsa_add_verify_data which already adds these nodes. Signed-off-by: Matthias Pritschet --- lib/ecdsa/ecdsa-libcrypto.c | 19 ++

[GIT PULL] Please pull u-boot-imx-master-20240829

2024-08-29 Thread Fabio Estevam
: https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git tags/u-boot-imx-master-20240829 for you to fetch changes up to aec0015a52d3faf723fec9ed9fe1d1af0b89e996: mach-imx: do not use if_changed more than once per target (2024-08-29 08:34:46 -0300) u-boot-imx-maste

Re: [PATCH] mach-imx: do not use if_changed more than once per target

2024-08-29 Thread Fabio Estevam
Hi Jerome, On Wed, Aug 28, 2024 at 12:37 PM Jerome Forissier wrote: > > doc/develop/makefiles.rst has the following note: > > if_changed should not be used more than once per target. > It stores the executed command in a corresponding .cmd > file and multiple calls would result in overwrite

[PATCH 1/2] watchdog: Add a driver for the photonicat watchdog

2024-08-29 Thread Coia Prant
This driver supports the photonicat watchdog timers. Signed-off-by: Coia Prant --- drivers/watchdog/Kconfig| 6 + drivers/watchdog/Makefile | 1 + drivers/watchdog/pcat_wdt.c | 218 3 files changed, 225 insertions(+) create mode 100644 drivers/watc

[PATCH 1/2] watchdog: Add a driver for the photonicat watchdog

2024-08-29 Thread Coia Prant
This driver supports the photonicat watchdog timers. Signed-off-by: Coia Prant --- drivers/watchdog/Kconfig| 6 + drivers/watchdog/Makefile | 1 + drivers/watchdog/pcat_wdt.c | 218 3 files changed, 225 insertions(+) create mode 100644 drivers/watc

Re: Grub doesn’t load devicetree

2024-08-29 Thread Tomaž Zaman
This is exactly what I’m testing now. The board I’m working on has an SDK device tree which deletes the smmu node that’s defined in another dts file, and the lack of that node makes uboot throw errors, but if it’s there, then kernel doesn’t load correclty. Tomaž Zaman, CEO Mono Technologies Inc

Re: [PATCH 05/13] net: fm: call dtsec_init_phy() only when it is defined

2024-08-29 Thread Simon Glass
Hi Jerome, On Wed, 28 Aug 2024 at 06:11, Jerome Forissier wrote: > > dtsec_init_phy() is defined only with MII so add the proper conditional > in the caller code. > > Signed-off-by: Jerome Forissier > --- > drivers/net/fm/eth.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/

Re: [PATCH 09/13] net: wget: allow EFI boot

2024-08-29 Thread Simon Glass
On Thu, 29 Aug 2024 at 01:34, Ilias Apalodimas wrote: > > On Wed, 28 Aug 2024 at 15:10, Jerome Forissier > wrote: > > > > wget followed by bootefi currently fails as follows: > > > > U-Boot> wget 20 192.168.0.30:helloworld.efi > > Waiting for Ethernet connection... done. > > HTTP/1.0 200 O

Re: [PATCH 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2024-08-29 Thread Simon Glass
On Tue, 27 Aug 2024 at 08:21, Lukasz Czechowski wrote: > > In case DEBUG UART is not used, define dummy macros replacing > the actual function implementations that will not be available. > This allows to compile code and avoid linker errors. > Because the DEBUG_UART_FUNCS macro should not be used

Re: [PATCH 13/18] mmc: Add more debugging for SPL

2024-08-29 Thread Simon Glass
Hi Marek, On Tue, 27 Aug 2024 at 22:10, Marek Vasut wrote: > > On 8/28/24 3:45 AM, Simon Glass wrote: > > When MMC booting fails it is sometimes hard to figure out what went > > wrong as there is no error code. It isn't even clear which MMC device > > was chosen, since SPL can have its own number

Re: [PATCH v9 18/37] net: eth-uclass: add function eth_start_udev()

2024-08-29 Thread Simon Glass
Hi Jerome, On Fri, 23 Aug 2024 at 07:49, Jerome Forissier wrote: > > Add a function to start a given network device, and update eth_init() > to use it. > > Signed-off-by: Jerome Forissier > Reviewed-by: Tom Rini > --- > drivers/mtd/altera_qspi.c | 4 ++-- > include/net-common.h | 1 + >

Re: [PATCH v2 14/32] lmb: introduce a function to add memory to the lmb memory map

2024-08-29 Thread Simon Glass
Hi Sughosh, On Wed, 21 Aug 2024 at 08:40, Sughosh Ganu wrote: > > On Wed, 21 Aug 2024 at 19:30, Simon Glass wrote: > > > > +Bin Meng > > > > Hi Sughosh, > > > > On Tue, 20 Aug 2024 at 23:29, Sughosh Ganu wrote: > > > > > > On Wed, 21 Aug 2024 at 07:41, Simon Glass wrote: > > > > > > > > Hi Sug

Re: RPI CM4 - I2C BUS and Device Tree

2024-08-29 Thread Simon Glass
Hi Romain, On Mon, 19 Aug 2024 at 01:15, Romain Crausaz wrote: > > Hi Simon, Hi Peter, > > First of all, thanks a lot for your answers. > > 1. When I enable the i2c bus in the config.txt (which is parsed by the rpi > first stage bootloader), the overlay put this as compatible:"brcm,bcm2835". I

Re: [PATCH 02/10] sysinfo: Add sysinfo driver and data structure for SMBIOS

2024-08-29 Thread Simon Glass
Hi Raymond, On Fri, 16 Aug 2024 at 09:47, Raymond Mao wrote: > > Add sysinfo interface and definitions to support SMBIOS type 0 to > type 4. > > Signed-off-by: Raymond Mao > --- > drivers/sysinfo/Makefile | 1 + > drivers/sysinfo/smbios_plat.c | 270 ++ >

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Simon Glass
Hi Dario, On Sun, 25 Aug 2024 at 06:26, Dario Binacchi wrote: > > All three addresses printed are in hexadecimal format, but only the > first two have the "0x" prefix. The patch aligns the format of the > "end" address with the other two by adding the "0x" prefix. > > Signed-off-by: Dario Binacch

Re: [PATCH 08/13] net: ftgmac100: depend on NET

2024-08-29 Thread Simon Glass
On Wed, 28 Aug 2024 at 06:12, Jerome Forissier wrote: > > FTGMAC100 enables drivers/net/ftgmac100.c which uses > PHY_INTERFACE_MODE_NCSI, which is defined only when PHY_NCSI is enabled. > Therefore FTGMAC100 depends on PHY_NCSI. However adding such a > dependency causes a "recursive dependency det

Re: [PATCH v9 35/37] [TESTING] Kconfig: enable NET_LWIP by default except for SANDBOX

2024-08-29 Thread Simon Glass
Hi Jerome, On Fri, 23 Aug 2024 at 07:50, Jerome Forissier wrote: > > Enable NET_LWIP by default for testing purposes. SANDBOX doesn't support > NET_LWIP so default to NET in this case. Sandbox needs to support NET_LWIP. > > Signed-off-by: Jerome Forissier > --- > Kconfig | 1 + > 1 file chang

Re: [RFC PATCH 1/1] env: introduce variable ranges

2024-08-29 Thread Simon Glass
Hi, On Mon, 26 Aug 2024 at 06:51, wrote: > > From: Lukas Funke > > This commit extends the flags-variable with ranges for environment > variables. The range is appended to the variable flags using > the '@'-character. A range can be decimal (min/max), bitmask or regular > expression (64 byte). >

Re: [PATCH v4 1/4] binman: Add nxp_imx8mcst etype for i.MX8M flash.bin signing

2024-08-29 Thread Simon Glass
Hi Marek, On Sun, 18 Aug 2024 at 14:51, Marek Vasut wrote: > > On 7/9/24 11:24 AM, Simon Glass wrote: > > Hi Marek, > > Hi, > > > On Sun, 7 Jul 2024 at 01:55, Marek Vasut wrote: > >> > >> On 6/27/24 10:19 AM, Simon Glass wrote: > >>> Hi Marek, > >> > >> Hi, > >> > Add new binman etype w

Re: [PATCH 12/35] global_data: Convert have_console into a flag

2024-08-29 Thread Simon Glass
Hi Alexander, On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander wrote: > > Hi Simon, > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > We don't need a full word for this boolean value. Convert it into a flag > > to save space in global_data. > > > > Signed-off-by: Simon Glass > > ---

Re: [PATCH v5 00/20] labgrid: Provide an integration with Labgrid

2024-08-29 Thread Tom Rini
On Wed, Aug 28, 2024 at 04:08:26PM -0600, Simon Glass wrote: > Labgrid provides access to a hardware lab in an automated way. It is > possible to boot U-Boot on boards in the lab without physically touching > them. It relies on relays, USB UARTs and SD muxes, among other things. > > By way of bac

Re: [PATCH v2 2/3] efi: Convert device_path allocation to use malloc()

2024-08-29 Thread Simon Glass
Hi Ilias, On Thu, 29 Aug 2024 at 06:39, Ilias Apalodimas wrote: > > On Thu, 29 Aug 2024 at 15:17, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 28 Aug 2024 at 01:40, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > [...] > > > > > > > > > > > > --- > > > > > > > > > > > > >

Re: [PATCH v5 08/20] test: Introduce the concept of a role

2024-08-29 Thread neil . armstrong
Hi, On 29/08/2024 00:08, Simon Glass wrote: In Labgrid there is the concept of a 'role', which is similar to the U-Boot board ID in U-Boot's pytest subsystem. The role indicates both the target and information about the U-Boot build to use. It can also provide any amount of other configuration.

Re: [PATCH v5 01/20] test: Allow signaling that U-Boot is ready

2024-08-29 Thread neil . armstrong
On 29/08/2024 00:08, Simon Glass wrote: When Labgrid is used, it can get U-Boot ready for running tests. It prints a message when it has done so. Add logic to detect this message and accept it. So labgrid can boot and wait for `board_type & board_identity` itself right ? It's cool, but if the

Re: [PATCH v5 03/20] test: Pass stderr to stdout

2024-08-29 Thread neil . armstrong
On 29/08/2024 00:08, Simon Glass wrote: Some tests may output things to stderr. Ensure that this output is not dropped, by redirecting it to stdout Can't you make sure to output all labgrid output to stdout in the hook script instead ? Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Dario Binacchi
Hi Simon, On Thu, Aug 29, 2024 at 4:05 PM Simon Glass wrote: > > Hi Dario, > > On Sun, 25 Aug 2024 at 06:26, Dario Binacchi > wrote: > > > > All three addresses printed are in hexadecimal format, but only the > > first two have the "0x" prefix. The patch aligns the format of the > > "end" addres

Re: [PATCH v5 17/20] test: Try to shut down the lab console gracefully

2024-08-29 Thread neil . armstrong
On 29/08/2024 00:08, Simon Glass wrote: Send the Labgrid quit characters to ask it to exit gracefully. This typically allows it to power off the board being used. Sending those characters every time could collide with other CI systems, I don't think it's a good idea. If that doesn't work, tr

Re: [PATCH 12/35] global_data: Convert have_console into a flag

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:05:35AM -0600, Simon Glass wrote: > Hi Alexander, > > On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander > wrote: > > > > Hi Simon, > > > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > > We don't need a full word for this boolean value. Convert it into a fla

Re: [PATCH v5 01/20] test: Allow signaling that U-Boot is ready

2024-08-29 Thread Neil Armstrong
On 29/08/2024 16:22, neil.armstr...@linaro.org wrote: On 29/08/2024 00:08, Simon Glass wrote: When Labgrid is used, it can get U-Boot ready for running tests. It prints a message when it has done so. Add logic to detect this message and accept it. So labgrid can boot and wait for `board_type

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 11:43:12AM +0100, Peter Robinson wrote: > On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: > > > > Hi Peter, > > > > On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: > > > > > > Hi Simon, > > > > > > > With Labgrid we don't need to specify the various methods, except fo

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread neil . armstrong
On 29/08/2024 14:17, Simon Glass wrote: Hi Peter, On Thu, 29 Aug 2024 at 04:43, Peter Robinson wrote: On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: Hi Peter, On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: Hi Simon, With Labgrid we don't need to specify the various methods, ex

Re: [PATCH 00/20] arm: Initial support for Analog Devices SC5xx boards

2024-08-29 Thread Tom Rini
On Wed, Aug 28, 2024 at 11:02:08AM +0100, Oliver Gaskell via B4 Relay wrote: > ADSP-SC5xx is a series of ARM-based DSPs. > This comprises the armv7 based SC57x, SC58x and SC594 series, and the > armv8 based SC598. > > This patch series includes configurations, init code, and minimal DTs > to enabl

[PATCH 01/19] image: Add a prototype for fit_image_get_phase()

2024-08-29 Thread Simon Glass
This function exists but is not exported. Add a prototype so it can be used elsewhere. Signed-off-by: Simon Glass --- include/image.h | 12 1 file changed, 12 insertions(+) diff --git a/include/image.h b/include/image.h index dd4042d1bd9..dbf8d0e7ba9 100644 --- a/include/image.h +

[PATCH 02/19] serial: ns16550: Allow clocks to be missing

2024-08-29 Thread Simon Glass
Allow serial init when clock support is not enabled in a particular phase. Signed-off-by: Simon Glass --- drivers/serial/ns16550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 6fcb5b523ac..5cda273623d 100644 --- a/

[PATCH 03/19] boot: Allow FIT to fall back from best-match option

2024-08-29 Thread Simon Glass
When the best-match feature fails to find something, use the provided config name as a fallback. The allows SPL to select a suitable config when best-match is enabled. Signed-off-by: Simon Glass --- boot/image-fit.c | 19 ++- include/image.h | 4 +++- 2 files changed, 13 inser

[PATCH 04/19] bootstd: Avoid sprintf() in SPL when creating bootdevs

2024-08-29 Thread Simon Glass
The name of the bootdev device is not that important, particular in SPL. Save a little code space by using a simpler name. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/boot/bootdev-uclass.c b/boot/bootdev-ucl

[PATCH 05/19] boot: Respect the load_op in fit_image_load()

2024-08-29 Thread Simon Glass
Some code has crept in which ignores this parameter. Fix this and add a little debugging. Signed-off-by: Simon Glass --- boot/image-fit.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/boot/image-fit.c b/boot/image-fit.c index 439ff51edf6..db7fb61bca9 100644 ---

[PATCH 06/19] malloc: Show amount of used space when memory runs out

2024-08-29 Thread Simon Glass
Show a bit more information when malloc() space is exhausted and debugging is enabled. Signed-off-by: Simon Glass --- common/malloc_simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/malloc_simple.c b/common/malloc_simple.c index 5a8ec538f8f..f2b3dc53689 10064

[PATCH 07/19] malloc: Provide a simple malloc for VPL

2024-08-29 Thread Simon Glass
The VPL phase may want to use the smaller malloc() implementation, so add an option for this. Signed-off-by: Simon Glass --- common/spl/Kconfig.vpl | 9 + 1 file changed, 9 insertions(+) diff --git a/common/spl/Kconfig.vpl b/common/spl/Kconfig.vpl index d06f36d4ee4..3dc0e95e09f 100644

[PATCH 08/19] Support setting a maximum size for the VPL image

2024-08-29 Thread Simon Glass
Add a size limit for VPL, to match those for SPL and TPL Signed-off-by: Simon Glass --- common/spl/Kconfig.vpl | 8 1 file changed, 8 insertions(+) diff --git a/common/spl/Kconfig.vpl b/common/spl/Kconfig.vpl index 3dc0e95e09f..eb57dfabea5 100644 --- a/common/spl/Kconfig.vpl +++ b/com

[PATCH 09/19] spl: Report a loader failure

2024-08-29 Thread Simon Glass
If a loader returns an error code it is silently ignored. Show a message to at least provide some feedback to the user. Signed-off-by: Simon Glass --- common/spl/spl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index da11

[PATCH 10/19] spl: Allow serial to be disabled in any XPL phase

2024-08-29 Thread Simon Glass
The current check looks only at SPL, but TPL or VPL might have a different setting. Update the condition. Signed-off-by: Simon Glass --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 143ae96baf0..8b868a298f2 100644

[PATCH 11/19] spl: Support a relocated stack in any XPL phase

2024-08-29 Thread Simon Glass
The current check looks only at SPL, but TPL or VPL might have a different setting. Update the condition. Signed-off-by: Simon Glass --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 8b868a298f2..5c687cfc73b 100644

[PATCH 12/19] spl: Drop use of uintptr_t

2024-08-29 Thread Simon Glass
U-Boot uses ulong for addresses. It is confusing to use uintptr_t in a few places, since it makes people wonder if the types are compatible. Change the few occurences in SPL to use ulong Signed-off-by: Simon Glass --- common/spl/spl_atf.c| 36 ++-- common/spl

[PATCH 13/19] spl: Drop a duplicate variable in boot_from_devices()

2024-08-29 Thread Simon Glass
The variable 'ret' is defined twice, which is not intended. This may have been a local merge error. Signed-off-by: Simon Glass Fixes: 2eefeb6d893 ("spl: Report a loader failure") --- common/spl/spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 5c

[PATCH 14/19] spl: Add some more debugging to load_simple_fit()

2024-08-29 Thread Simon Glass
Add debugging of image-loading progress. Fix a stale comment in the function comment while we are here. Signed-off-by: Simon Glass --- common/spl/spl_fit.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 614dea9ae18

[PATCH 16/19] boot: Allow use of FIT in TPL and VPL

2024-08-29 Thread Simon Glass
With VBE we want to use FIT in all phases of the boot. Add Kconfig options to support this. Disable the options for sandbox_vpl for now. Signed-off-by: Simon Glass --- boot/Kconfig | 69 ++- boot/Makefile | 4 +- configs/sandbox

[PATCH 15/19] spl: lib: Allow for decompression in any SPL build

2024-08-29 Thread Simon Glass
Add Kconfig symbols and update the Makefile rules so that decompression can be used in TPL and VPL Signed-off-by: Simon Glass --- lib/Kconfig | 35 +++ lib/Makefile | 8 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig b/lib/

[PATCH 18/19] boot: Imply CRC8 with VBE

2024-08-29 Thread Simon Glass
VBE uses a crc8 checksum to verify that the nvdata is valid, so make sure it is available if VBE is enabled. Signed-off-by: Simon Glass --- boot/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/Kconfig b/boot/Kconfig index afe04c7327a..49e99e5e155 100644 --- a/boot/Kconfig +++

[PATCH 17/19] lib: Allow crc8 in TPL and VPL

2024-08-29 Thread Simon Glass
Provide options to enable the CRC8 feature in TPL and VPL builds. Signed-off-by: Simon Glass --- lib/Kconfig | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index 72a5f3cb04f..b2d5e8d04a7 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -698,6 +698

[PATCH 19/19] hash: Plumb crc8 into the hash functions

2024-08-29 Thread Simon Glass
Add an entry for crc8, with watchdog handling. Signed-off-by: Simon Glass --- common/hash.c| 8 include/u-boot/crc.h | 3 +++ lib/crc8.c | 6 ++ 3 files changed, 17 insertions(+) diff --git a/common/hash.c b/common/hash.c index ac63803fed9..43c4e185750 100644 ---

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Simon Glass
Hi Dario, On Thu, 29 Aug 2024 at 08:25, Dario Binacchi wrote: > > Hi Simon, > > On Thu, Aug 29, 2024 at 4:05 PM Simon Glass wrote: > > > > Hi Dario, > > > > On Sun, 25 Aug 2024 at 06:26, Dario Binacchi > > wrote: > > > > > > All three addresses printed are in hexadecimal format, but only the >

  1   2   >