[pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Hi, PFA patches, 1) To fix the validation issue while creating new sequence RM#3014 2) Fix PEP-8 issues in sequence module pycodestyle --config=.pycodestyle ./pgadmin/browser/server_groups/servers/databases/schemas/sequences/ 3) To fix the regression test for Tablespace when running with Python3

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hi, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 20, 2018 at 10:34 PM, Dave Page wrote: > Hi > > On Tue, Feb 20, 2018 at 7:22 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >>

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

Hello Murtuza, After reviewing the code I have some suggestions: - We should split the PEP and the features into different patches, or else it becomes very hard to separate Feature code from Code Style change - The function: `getTextRepresentaionShortcut` has a typo - As a personal point I have

[pgadmin4] Priorities of features

Hi Hackers, After the last month or something that I came back to this project I noticed that we put a lot of effort in making all these shortcuts configurable. But I do not understand the driver for this push. Do we have people complaining about the lack of shortcuts? Are people complaining abou

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

Hi The patch looks good, do we have any example error that we can test in order to ensure the problem no longer shows up in the future? If they could be Unit Tests instead of Feature tests that would be awesome, because Feature tests are much more expensive then Unit. Thanks Joao On Wed, Feb 21,

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Hi Murtuza, Looks good. Was there any reason for the change in position of the if statements in the sql file. Makes the output more readable? Looks like we need some test to ensure that the Sequence issue does not happen again. Maybe a Unit Test is good enough, to ensure that we are creating a good

Re: [pgadmin4] Priorities of features

Hi On Wed, Feb 21, 2018 at 3:42 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > After the last month or something that I came back to this project I > noticed that we put a lot of effort in making all these shortcuts > configurable. > But I do not understand t

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hello Harshal, I passed the patch through our CI and all the tests passed. The changes do not break previous behavior but because there are no tests on the new feature we could not be sure it was really working. So we did some manual testing and sometimes it doesn't work, like it gets stuck in a

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

On Wed, Feb 21, 2018 at 3:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > Looks good. > Was there any reason for the change in position of the if statements in > the sql file. Makes the output more readable? > Looks like we need some test to ensure that the Se

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Harshal, > > I passed the patch through our CI and all the tests passed. The changes do > not break previous behavior but because there are no tests on the new > feature we could not be sure it

pgAdmin 4 commit: Don't depend on standards_conforming_strings being en

Don't depend on standards_conforming_strings being enabled. Fixes #3077 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b49d625c2d0243df6c5ad7d11470cfd0b9ada867 Author: Khushboo Vashi Modified Files -- .../schemas/tables/templates

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

Thanks, patch applied. On Wed, Feb 21, 2018 at 7:33 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #3077 : ERROR: invalid byte > sequence for encoding "LATIN1":0x00 > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blog

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi > The patch looks good, do we have any example error that we can test in > order to ensure the problem no longer shows up in the future? > If they could be Unit Tests instead of Feature tests that

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Yep I installed the V2 file On Wed, Feb 21, 2018 at 11:31 AM Dave Page wrote: > On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Harshal, >> >> I passed the patch through our CI and all the tests passed. The changes >> do not break prev

pgAdmin 4 commit: Fix validation of sequence parameters. Fixes #3014

Fix validation of sequence parameters. Fixes #3014 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8771d55852eb66872319dcd6fbb94e397347ea0 Author: Murtuza Zabuawala Modified Files -- .../templates/sequence/sql/default/create.sql

pgAdmin 4 commit: Fix tablespace tests for Python 3.x. Fixes #3138

Fix tablespace tests for Python 3.x. Fixes #3138 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=51cc04b5b0c10d8ad693ee036009d0a6323e0f48 Author: Murtuza Zabuawala Modified Files -- .../servers/tablespaces/tests/test_backend_suppo

pgAdmin 4 commit: PEP8 cleanups for the sequences module.

PEP8 cleanups for the sequences module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55875f0cfa7b19cdd4831150e8232e53df6f9ef3 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/sequences/__init__.py| 105

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Thanks, applied. On Wed, Feb 21, 2018 at 8:13 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patches, > 1) To fix the validation issue while creating new sequence > RM#3014 > > 2) Fix PEP-8 issues in sequence module > pycodestyle --config=.pycodestyle ./pgadmin/b

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Hi Joao, ​Thank you for your time in reviewing the patch.​ On Wed, Feb 21, 2018 at 9:24 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > Looks good. > Was there any reason for the change in position of the if statements in > the sql file. Makes the output more

Re: Regarding PEP-8 checker

On Tue, Feb 20, 2018 at 6:28 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi All, > > Earlier we have fixed PEP-8 issues in below modules, > pycodestyle --config=.pycodestyle ./pgadmin/tools/ > pycodestyle --config=.pycodestyle ./pgadmin/utils/ > pycodestyle --config=.pycod

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

Hi Joao, Thank you for your time in reviewing the patch. On Wed, Feb 21, 2018 at 9:11 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > After reviewing the code I have some suggestions: > - We should split the PEP and the features into different patches, or

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hi, On Wed, Feb 21, 2018 at 10:59 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Yep I installed the V2 file > > On Wed, Feb 21, 2018 at 11:31 AM Dave Page wrote: > >> On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>>

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

Hello Murtuza, I created a small patch on the way I believe the function should work. Not 100% sure why we are piggybacking on the window.top, window.opener and so on to give us information. Nowadays I do not think that loading the JS files again costs that much in terms of time. The issue I came

[pgadmin4] PEP-8 on pgadmin/tools

Hi hackers, Attached, you can find the PEP-8 the pgadmin/tools fixes. Thanks Joao pep8-on-pgadmin-tools.diff Description: Binary data

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

On Wed, Feb 21, 2018 at 10:51 PM, Dave Page wrote: > > > On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi >> The patch looks good, do we have any example error that we can test in >> order to ensure the problem no longer shows up in the fut

How to decrypt stored psql server password from pgadmin4.db?

Hi, long story short, I need to recover a psql server password stored in pgadmin4.db. I can see the encrypted password, but have no idea how to decrypt it. It also seems salted. Please help. Looking forward to hearing from you. P.S Resetting the password in psql is not an option. I really need t

[pgAdmin4][Patch]: Remove webpack plugin hardSourceWebpackPlugin from the production environment

Hi, Please find the attached patch to remove webpack plugin hardSourceWebpackPlugin from the production environment. Thanks, Khushboo diff --git a/web/webpack.config.js b/web/webpack.config.js index b989a4c..84f8466 100644 --- a/web/webpack.config.js +++ b/web/webpack.config.js @@ -324,7 +324,6 @