On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote:
> Hi > The patch looks good, do we have any example error that we can test in > order to ensure the problem no longer shows up in the future? > If they could be Unit Tests instead of Feature tests that would be > awesome, because Feature tests are much more expensive then Unit. > I think we need to consider a couple of options here: 1) Make sure that many/all of our tests use non-ASCII names. 2) Consider adding a mechanism to allow running the regression tests with overridden GUC values. For example, a parameter in the test config file that gives a set of GUCs to change upon connection. The downside of 2 of course, is that it adds a huge amount of possible environment combinations to test. Thoughts? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
