Hi Joao, Thank you for your time in reviewing the patch.
On Wed, Feb 21, 2018 at 9:24 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > Looks good. > Was there any reason for the change in position of the if statements in > the sql file. Makes the output more readable? > Yes > Looks like we need some test to ensure that the Sequence issue does not > happen again. Maybe a Unit Test is good enough, to ensure that we are > creating a good SQL > I'll add a test case for the same. > > Thanks > Joao > > On Wed, Feb 21, 2018 at 3:13 AM Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA patches, >> 1) To fix the validation issue while creating new sequence >> RM#3014 >> >> 2) Fix PEP-8 issues in sequence module >> pycodestyle --config=.pycodestyle ./pgadmin/browser/server_ >> groups/servers/databases/schemas/sequences/ >> >> 3) To fix the regression test for Tablespace when running with Python3.x >> RM#3138 >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >>
