https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/111951
A memory region can be relatively large. Searching for a value in the entire
region is time-consuming, especially when running tests against a remote
target, because the memory data is transferred in small c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
A memory region can be relatively large. Searching for a value in the entire
region is time-consuming, especially when running tests against a remote
target, because the memory data is transferred in small
adrian-prantl wrote:
> > Looks good, I guess. Is that constructor even necessary, given that it just
> > forwards the argument to the base class, and we already have the forwarding
> > `using` declaration?
>
> The constructor looks redundant at the moment, perhaps it is just a legacy
> from t
vvereschaka wrote:
@chelcassanova `lldb/API/SBLanguages.h` is generated file. I suppose its
generation must be enabled for the `lldb-server` target in that case; otherwise
we get the following build errors:
```
In file included from
/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/l
Author: Jason Molenda
Date: 2024-10-10T14:50:34-07:00
New Revision: c99b36554745837c549e1b46cd60db70588affcf
URL:
https://github.com/llvm/llvm-project/commit/c99b36554745837c549e1b46cd60db70588affcf
DIFF:
https://github.com/llvm/llvm-project/commit/c99b36554745837c549e1b46cd60db70588affcf.diff
igorkudrin wrote:
So the test basically shows that it makes sense to set `use-source-cache` to
`false` on Windows, otherwise the source file will be locked for editing.
Windows 11 seems to allow deleting mmaped files, so we need to try opening the
file for writing to re-enable the test. Thanks
https://github.com/igorkudrin edited
https://github.com/llvm/llvm-project/pull/111237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> This looks better to me. I'm not sure why we were using defines from
> llvm::DWARF that seem to overlap the ones here, however. So I'll defer to
> Adrian or someone more knowledgeable about that side of things.
Yeah, that wasn't clear to me either, why didn't we just use
emrekultursay wrote:
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/111237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
I reverted both this commit and also
https://github.com/llvm/llvm-project/commit/b77fdf5799be6b29869f2f7969851709e03938ba,
so you'll need to add that change to your commit before merging again.
https://github.com/llvm/llvm-project/pull/99736
_
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> On Oct 10, 2024, at 4:14 PM, Alex Langford ***@***.***> wrote:
>
>
> My mental model is that everything in lldb-enumerations.h should be public
> and all the private enumerations should go in lldb-private-enumerations.h. In
> practice I think there are tons of things in l
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From e13c841a6452ae5b0cfae129764dc95d6ac29e09 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111237
>From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Fri, 4 Oct 2024 23:27:04 -0700
Subject: [PATCH 1/2] [lldb] Fix and re-enable TestUseSourceCache.py
The decorato
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1809d0fa1c15b16ca94381d8be3ef70c4a83c36b...ef848fd2c7de9483cfe2cb0286a20df0a2005f97
lldb/
@@ -194,28 +194,50 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
My mental model is that everything in `lldb-enumerations.h` should be public
and all the private enumerations should go in `lldb-private-enumerations.h`. In
practice I think there are tons of things in `lldb-enumerations.h` that should
not be public at all, but I'm not sure wh
Author: Jason Molenda
Date: 2024-10-10T16:24:38-07:00
New Revision: 4f320778148ba481881eb53ba065ed2a9d9bbc03
URL:
https://github.com/llvm/llvm-project/commit/4f320778148ba481881eb53ba065ed2a9d9bbc03
DIFF:
https://github.com/llvm/llvm-project/commit/4f320778148ba481881eb53ba065ed2a9d9bbc03.diff
Author: Jason Molenda
Date: 2024-10-10T16:24:38-07:00
New Revision: a28e7ce378d717e6aacbdc3089974b93b6b62948
URL:
https://github.com/llvm/llvm-project/commit/a28e7ce378d717e6aacbdc3089974b93b6b62948
DIFF:
https://github.com/llvm/llvm-project/commit/a28e7ce378d717e6aacbdc3089974b93b6b62948.diff
@@ -5,22 +5,21 @@
import os
HEADER = """\
-//===-- SBLanguages.h -*- C++ -*-===//
+//===-- SourceLanguageNames.h ---*- C++
-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLV
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova commented:
This looks good to me and I agree with the original feedback that led to this
change in the first place, though I'll also wait for any comments Adrian might
have.
https://github.com/llvm/llvm-project/pull/111929
__
Author: Robert O'Callahan
Date: 2024-10-10T16:08:19-07:00
New Revision: 4f297566b3150097de26c6a23a987d2bd5fc19c5
URL:
https://github.com/llvm/llvm-project/commit/4f297566b3150097de26c6a23a987d2bd5fc19c5
DIFF:
https://github.com/llvm/llvm-project/commit/4f297566b3150097de26c6a23a987d2bd5fc19c5.d
https://github.com/mentlerd updated
https://github.com/llvm/llvm-project/pull/111892
>From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001
From: David Mentler
Date: Mon, 7 Oct 2024 21:46:50 +0200
Subject: [PATCH 1/7] Make existing tests break
---
.../data-formatter-stl/libcx
Author: Jonas Devlieghere
Date: 2024-10-10T16:08:19-07:00
New Revision: fae7d6848bbb59fc2bad17adbdb34bd6a11a0651
URL:
https://github.com/llvm/llvm-project/commit/fae7d6848bbb59fc2bad17adbdb34bd6a11a0651
DIFF:
https://github.com/llvm/llvm-project/commit/fae7d6848bbb59fc2bad17adbdb34bd6a11a0651.d
Author: Jason Molenda
Date: 2024-10-10T16:08:19-07:00
New Revision: c686eeb7fcc89673909e7e1f0a0a09a0da269d28
URL:
https://github.com/llvm/llvm-project/commit/c686eeb7fcc89673909e7e1f0a0a09a0da269d28
DIFF:
https://github.com/llvm/llvm-project/commit/c686eeb7fcc89673909e7e1f0a0a09a0da269d28.diff
chelcassanova wrote:
I was going to fix the dependency issue here to make sure that SBLanguages gets
generated before trying to build any of these targets, but talking with
@jimingham, this shouldn't have been included at all as `lldb-enumerations`
shouldn't be exposed to any SB layer componen
https://github.com/jimingham commented:
This layering seems wrong to me. If you put an SB header in
lldb-enumerations.h, then you are pretty much including it in all of lldb. But
SB defines should really only be used in include/lldb/API and source/API.
Note, SBLanguages.h itself seems wrong t
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/111929
This patch moves `SBLanguages.h` out of the API tree. This file gets generated
at build time using DWARF table-gen file and contains an enumeration of the
DWARF supported source language names and there re
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch moves `SBLanguages.h` out of the API tree. This file gets generated
at build time using DWARF table-gen file and contains an enumeration of the
DWARF supported source language names and
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/111911
Log errors to the (always-on) system log if they would otherwise get dropped by
LLDB_LOG_ERROR and LLDB_LOG_ERRORV.
>From 55eab57c695d4be99305d2b6cee0c4f44261a473 Mon Sep 17 00:00:00 2001
From: Jonas Devli
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Log errors to the (always-on) system log if they would otherwise get dropped by
LLDB_LOG_ERROR and LLDB_LOG_ERRORV.
---
Full diff: https://github.com/llvm/llvm-project/pull/111911.diff
3 Files Aff
@@ -0,0 +1,11 @@
+# RUN: echo quit | %lldb -o "log enable -x" \
adrian-prantl wrote:
Thanks! Indeed, there's bug there.
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.
DmT021 wrote:
> I was playing with the performance in a couple of different scenarios. For
> some reason that I haven't looked into, we're getting less parallelism when
> many of the binaries are in the shared cache in lldb. Maybe there is locking
> around the code which finds the binary in ll
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1809d0fa1c15b16ca94381d8be3ef70c4a83c36b...6ea11737a9edbf1a1be413c2eaa7075438effb05
lldb/
https://github.com/igorkudrin edited
https://github.com/llvm/llvm-project/pull/111951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111951
>From e027444340be4020002126da0d2c8a705c2c7e3f Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Thu, 10 Oct 2024 20:27:10 -0700
Subject: [PATCH] [lldb] Speed up FindInMemory tests
A memory region can be rela
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/111814
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657
The complete changes for porting a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657
The complete changes for por
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This makes tests more portable.
Environment variables for LLVM utils are passed to `make` on Darwin as well.
---
Full diff: https://github.com/llvm/llvm-project/pull/111816.diff
7 Files Affected:
DhruvSrivastavaX wrote:
Hi Community Members,
Apologies for being away for a while as I was occupied with some other
activities.
Here's some update at what all we are working on based on the past discussions:
1. Removed the CMAKE flag __AIX__ and replaced it with the LLVM environment's
_AIX
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/111814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/111816
This makes tests more portable.
Environment variables for LLVM utils are passed to `make` on Darwin as well.
>From 050b000a5fe4fd517fefed1532e6cf56e2bb147b Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka
labath wrote:
A couple of quick notes:
- are you sure that ObjectFileELF is the best thing to start with here? Based
on the name, I would expect that ObjectFilePECOFF would be a better baseline.
Or maybe the object file format is different enough from all of the existing
ones that this kind of
Michael137 wrote:
could you mention that this is a`Darwin`-only change in the commit/PR title?
Otherwise, LGTM. Will help with the situation i ran into a while ago:
https://reviews.llvm.org/D143842
https://github.com/llvm/llvm-project/pull/111816
___
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/111820
This is to fix buildbot failure
https://lab.llvm.org/staging/#/builders/195/builds/4242.
The test can't be used with llvm-strip on macOS. Apparently,
llvm-strip/llvm-objcopy can't clean symbols from Mach-O
dzhidzhoev wrote:
> > Environment variables for LLVM utils are passed to make on Darwin as well.
>
> Technically, these are `make` variables, right?
Yes. I'll fix it in the description.
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commit
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This is to fix buildbot failure
https://lab.llvm.org/staging/#/builders/195/builds/4242.
The test can't be used with llvm-strip on macOS. Apparently,
llvm-strip/llvm-objcopy can't clean symbols fr
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vladislav Dzhidzhoev
Date: 2024-10-10T14:21:25+02:00
New Revision: b773da0c5eed06f21f4caeea5eae47cacefb376c
URL:
https://github.com/llvm/llvm-project/commit/b773da0c5eed06f21f4caeea5eae47cacefb376c
DIFF:
https://github.com/llvm/llvm-project/commit/b773da0c5eed06f21f4caeea5eae47cacefb376
Author: David Spickett
Date: 2024-10-10T10:21:41+01:00
New Revision: 993de5512d81f4582373aa8bd7507e5aa44311ab
URL:
https://github.com/llvm/llvm-project/commit/993de5512d81f4582373aa8bd7507e5aa44311ab
DIFF:
https://github.com/llvm/llvm-project/commit/993de5512d81f4582373aa8bd7507e5aa44311ab.diff
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
@@ -143,8 +142,14 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native_
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -143,8 +142,14 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native_
@@ -492,23 +492,36 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
https://github.com/DavidSpickett commented:
So is this X86 and ARM64 or just one?
Also this needs a release note, which is a good place to note the limitations
as well.
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
ll
@@ -337,6 +338,17 @@ class DynamicLoader : public PluginInterface {
return std::nullopt;
}
+ /// Returns a list of memory ranges that should be saved in the core file,
+ /// specific for this dßynamic loader.
labath wrote:
```suggestion
/// specific
@@ -337,6 +338,17 @@ class DynamicLoader : public PluginInterface {
return std::nullopt;
}
+ /// Returns a list of memory ranges that should be saved in the core file,
+ /// specific for this dßynamic loader.
+ ///
+ /// By default, this returns an empty list, but fo
@@ -866,3 +867,81 @@ bool DynamicLoaderPOSIXDYLD::AlwaysRelyOnEHUnwindInfo(
bool DynamicLoaderPOSIXDYLD::IsCoreFile() const {
return !m_process->IsLiveDebugSession();
}
+
+// For our ELF/POSIX builds save off the fs_base/gs_base regions
+static void AddSegmentRegisterSections
@@ -866,3 +867,81 @@ bool DynamicLoaderPOSIXDYLD::AlwaysRelyOnEHUnwindInfo(
bool DynamicLoaderPOSIXDYLD::IsCoreFile() const {
return !m_process->IsLiveDebugSession();
}
+
+// For our ELF/POSIX builds save off the fs_base/gs_base regions
+static void AddSegmentRegisterSections
@@ -6528,6 +6528,75 @@ static void AddRegion(const MemoryRegionInfo ®ion,
bool try_dirty_pages,
CreateCoreFileMemoryRange(region));
}
+static void AddSegmentRegisterSections(Process &process, ThreadSP &thread_sp,
labath wrote:
Slightly less o
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/109477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -83,7 +83,11 @@ ModuleSP DynamicLoader::GetTargetExecutable() {
ModuleSpec module_spec(executable->GetFileSpec(),
executable->GetArchitecture());
auto module_sp = std::make_shared(module_spec);
-
+ // If we're a coredump and we a
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/111810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Bradbury
Date: 2024-10-10T12:01:49+01:00
New Revision: 99cec7ff8eabbec929d3d0b3a15b272867cf2a46
URL:
https://github.com/llvm/llvm-project/commit/99cec7ff8eabbec929d3d0b3a15b272867cf2a46
DIFF:
https://github.com/llvm/llvm-project/commit/99cec7ff8eabbec929d3d0b3a15b272867cf2a46.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/111810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1024,6 +1024,46 @@ static void
LLDBSwigPythonCallPythonLogOutputCallback(const char *str,
}
}
+// For NotificationCallback functions
+static void LLDBSwigPythonCallPythonSBNotificationCallback(
+ lldb::NotificationType type, lldb::SBDebugger &debugger,
+ lldb::SBExec
@@ -1703,6 +1703,30 @@ void SBDebugger::SetDestroyCallback(
}
}
+lldb::callback_token_t SBDebugger::AddNotificationCallback(
+lldb::NotificationType type,
+lldb::SBNotificationCallback notification_callback, void *baton) {
+ LLDB_INSTRUMENT_VA(type, notification_cal
@@ -739,16 +745,29 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
g_debugger_list_ptr->push_back(debugger_sp);
}
debugger_sp->InstanceInitialize();
+
+ InvokeNotificationCallbacks(debugger_sp, lldb::eDebuggerWillBeCreated);
return debu
@@ -1703,6 +1703,30 @@ void SBDebugger::SetDestroyCallback(
}
}
+lldb::callback_token_t SBDebugger::AddNotificationCallback(
+lldb::NotificationType type,
+lldb::SBNotificationCallback notification_callback, void *baton) {
+ LLDB_INSTRUMENT_VA(type, notification_cal
@@ -1362,6 +1362,12 @@ enum Severity {
eSeverityInfo, // Equivalent to Remark used in clang.
};
+enum NotificationType {
+ eDebuggerWillBeCreated = (1 << 0),
+ eDebuggerWillBeDestroyed =
+ (1 << 1), // Call before debugger object is destroyed
labath w
@@ -739,16 +745,29 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
g_debugger_list_ptr->push_back(debugger_sp);
}
debugger_sp->InstanceInitialize();
+
+ InvokeNotificationCallbacks(debugger_sp, lldb::eDebuggerWillBeCreated);
return debu
labath wrote:
(This is in reply to Jim's comment
[here](https://github.com/llvm/llvm-project/pull/111206#issuecomment-2400376223).
I can't quote it, because github garbles it beyond recognition, probably
because it was sent by email :/)
You're right, I have misunderstood the intention. The th
labath wrote:
> Environment variables for LLVM utils are passed to make on Darwin as well.
Technically, these are `make` variables, right?
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
DhruvSrivastavaX wrote:
> A couple of quick notes:
>
> * are you sure that ObjectFileELF is the best thing to start with here? Based
> on the name, I would expect that ObjectFilePECOFF would be a better baseline.
> Or maybe the object file format is different enough from all of the existing
>
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I considered *always* logging to the system log, but copying errors is a bit
tricky. I could reuse the logic that Adrian added to status, but wanted to
gather your input. Regardless, I tried this out locally by debugging the
`count` tool and this already reported a bunch of
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111237
>From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Fri, 4 Oct 2024 23:27:04 -0700
Subject: [PATCH 1/3] [lldb] Fix and re-enable TestUseSourceCache.py
The decorato
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/111237
>From 6756842b1c78ac6f41fa467f112aa7632f260582 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Fri, 4 Oct 2024 23:27:04 -0700
Subject: [PATCH 1/3] [lldb] Fix and re-enable TestUseSourceCache.py
The decorato
Author: Augusto Noronha
Date: 2024-10-10T15:05:58-07:00
New Revision: f02252e1fd2965db007cf7be74c448b7a119c321
URL:
https://github.com/llvm/llvm-project/commit/f02252e1fd2965db007cf7be74c448b7a119c321
DIFF:
https://github.com/llvm/llvm-project/commit/f02252e1fd2965db007cf7be74c448b7a119c321.dif
Author: Augusto Noronha
Date: 2024-10-10T15:05:58-07:00
New Revision: 2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9
URL:
https://github.com/llvm/llvm-project/commit/2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9
DIFF:
https://github.com/llvm/llvm-project/commit/2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9.dif
adrian-prantl wrote:
To clone an error, do Status::FromError(error). Every call to Status::toError()
clones the error (as opposed to takeError()). Generally we want to avoid
cloning errors though.
https://github.com/llvm/llvm-project/pull/111911
___
Author: Jacob Lalonde
Date: 2024-10-10T15:59:51-07:00
New Revision: e9c8f75d45ababe7f805078bbf7bda2e7425f1b7
URL:
https://github.com/llvm/llvm-project/commit/e9c8f75d45ababe7f805078bbf7bda2e7425f1b7
DIFF:
https://github.com/llvm/llvm-project/commit/e9c8f75d45ababe7f805078bbf7bda2e7425f1b7.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/109477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,79 @@
+//===-- DiagnosticsRendering.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -160,6 +166,9 @@ class CommandReturnObject {
StreamTee m_out_stream;
StreamTee m_err_stream;
+ std::vector m_diagnostics;
+ StreamString m_diag_stream;
+ std::optional m_diagnostic_indent;
adrian-prantl wrote:
Because DiagnostcDetails are created in
@@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs():
configuration.make_path = "gmake"
else:
configuration.make_path = "make"
+if ' ' in configuration.make_path:
+configuration.make_path = f'"{configuration.make_path}"'
welivei
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/111531
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:40:37 +0200
Subject: [PATCH 1/7] [lldb] Add early CMake check for 'm
@@ -250,6 +250,9 @@ def delete_module_cache(path):
if is_configured("dsymutil"):
dotest_cmd += ["--dsymutil", config.dsymutil]
+if is_configured("make"):
+dotest_cmd += ["--make", config.make]
+
weliveindetail wrote:
Changed in follow-up patch
https:
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+ if(LLDB_TEST_MAKE)
+set(LLDB_DEFAULT_TEST_MAKE
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/111744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
Fixed as part of the earlier PR linked above.
https://github.com/llvm/llvm-project/pull/111744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 178 matches
Mail list logo
