================
@@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs():
configuration.make_path = "gmake"
else:
configuration.make_path = "make"
+ if ' ' in configuration.make_path:
+ configuration.make_path = f'"{configuration.make_path}"'
----------------
weliveindetail wrote:
I added this because yesterday my tests failed with:
```
'C:/Program' is not recognized as an internal or external command,
operable program or batch file.
```
I double-checked again today and this doesn't happen anymore. I am not sure
why, maybe I had an inconsistent configuration state. The parameter for
dotest.py is `--make C:/Program Files (x86)/GnuWin32/bin/make.exe` and the
command that lldbtest.py runs is starting with `C:/Program Files
(x86)/GnuWin32/bin/make.exe VPATH=...`. I cleared the cached in
`lldb-test-build.noindex` and checked sure the binaries are recreated
successfully by the test suite. It works without the quotes.
I am attaching a log file
[TestBreakpointByLineAndColumn.log](https://github.com/user-attachments/files/17326545/TestBreakpointByLineAndColumn.log)
with the commands dumped for future reference. I will the quoting and assume
it just keeps working.
https://github.com/llvm/llvm-project/pull/111531
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
