Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #14988: URL: https://github.com/apache/kafka/pull/14988#issuecomment-1853431750 @jeffkbkim Yeah, I have noticed that failing test too. It is not related to your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #14988: URL: https://github.com/apache/kafka/pull/14988#issuecomment-1853432817 All the failed tests are not related. Merging to trunk and 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15981: update Group size only when groups size changes [kafka]

2023-12-13 Thread via GitHub
dajac merged PR #14988: URL: https://github.com/apache/kafka/pull/14988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-15981) update Group size only when groups size changes

2023-12-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15981. - Fix Version/s: 3.7.0 Resolution: Fixed > update Group size only when groups size changes

[jira] [Reopened] (KAFKA-9545) Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted`

2023-12-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-9545: -- > Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` >

Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]

2023-12-13 Thread via GitHub
cadonna commented on PR #14910: URL: https://github.com/apache/kafka/pull/14910#issuecomment-1853437970 @wcarlson5 @ashwinpankaj This fix does not seem to unflake the test. If I run it multiple times locally I get a failure after a couple of runs. -- This is an automated message from the

[jira] [Commented] (KAFKA-9545) Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted`

2023-12-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796053#comment-17796053 ] Bruno Cadonna commented on KAFKA-9545: -- I am reopening this issue, because https://g

Re: [PR] KAFKA-15445: Add JVM Docker image [kafka]

2023-12-13 Thread via GitHub
mimaison commented on PR #14552: URL: https://github.com/apache/kafka/pull/14552#issuecomment-1853448090 This adds a small piece of code in Go. I think this should have been mentioned in the KIP as adding a new language is something worth discussing. I understand Go is well suited fo

[jira] [Commented] (KAFKA-14454) KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest#shouldThrowIllegalArgumentExceptionWhenCustomPartionerReturnsMultiplePartitions passes when run individ

2023-12-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796079#comment-17796079 ] Bruno Cadonna commented on KAFKA-14454: --- [~sagarrao] Was the error: {code:java} j

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2023-12-13 Thread via GitHub
cadonna commented on PR #14983: URL: https://github.com/apache/kafka/pull/14983#issuecomment-1853482186 The failed Streams tests are either known to be flaky (I checked the failure reason) or I ran into a timeout. For the ones that run into a timeout I checked if they run locally w/o failur

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2023-12-13 Thread via GitHub
cadonna merged PR #14983: URL: https://github.com/apache/kafka/pull/14983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-14454) KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest#shouldThrowIllegalArgumentExceptionWhenCustomPartionerReturnsMultiplePartitions passes when run individ

2023-12-13 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796095#comment-17796095 ] Sagar Rao commented on KAFKA-14454: --- [~cadonna], I don't recall the error and I tried

Re: [PR] KAFKA-15883: Implement RemoteCopyLagBytes [kafka]

2023-12-13 Thread via GitHub
showuon commented on PR #14832: URL: https://github.com/apache/kafka/pull/14832#issuecomment-1853541938 It failed 61 tests in the CI build. Re-triggering it: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14832/8/ -- This is an automated message from the Apache Git Servi

[jira] [Commented] (KAFKA-14454) KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest#shouldThrowIllegalArgumentExceptionWhenCustomPartionerReturnsMultiplePartitions passes when run individ

2023-12-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796101#comment-17796101 ] Bruno Cadonna commented on KAFKA-14454: --- [~sagarrao] First of all my apologies! I

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
lucasbru commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1853559479 Restarting build as previous was aborted. @philipnee have you run the integration tests on this one? -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Commented] (KAFKA-14454) KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest#shouldThrowIllegalArgumentExceptionWhenCustomPartionerReturnsMultiplePartitions passes when run individ

2023-12-13 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796108#comment-17796108 ] Sagar Rao commented on KAFKA-14454: --- Aah ok, no problem at all :) Good to know that it

[jira] [Created] (KAFKA-16002) Implement RemoteCopyLagSegments, RemoteDeleteLagBytes and RemoteDeleteLagSegments

2023-12-13 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-16002: - Summary: Implement RemoteCopyLagSegments, RemoteDeleteLagBytes and RemoteDeleteLagSegments Key: KAFKA-16002 URL: https://issues.apache.org/jira/browse/KAFKA-16002 P

[jira] [Created] (KAFKA-16003) The znode /config/topics is not updated during KRaft migration in "dual-write" mode

2023-12-13 Thread Paolo Patierno (Jira)
Paolo Patierno created KAFKA-16003: -- Summary: The znode /config/topics is not updated during KRaft migration in "dual-write" mode Key: KAFKA-16003 URL: https://issues.apache.org/jira/browse/KAFKA-16003

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
vamossagar12 commented on code in PR #14981: URL: https://github.com/apache/kafka/pull/14981#discussion_r1425209384 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -950,6 +965,43 @@ public void testScheduleWriteOpW

Re: [PR] KAFKA-14585: Move StorageTool to tools [kafka]

2023-12-13 Thread via GitHub
showuon commented on PR #14847: URL: https://github.com/apache/kafka/pull/14847#issuecomment-1853758861 OK, let's wait until https://issues.apache.org/jira/browse/KAFKA-15853 is merged, or we've got response from Colin. -- This is an automated message from the Apache Git Service. To

[jira] [Assigned] (KAFKA-16003) The znode /config/topics is not updated during KRaft migration in "dual-write" mode

2023-12-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-16003: -- Assignee: Mickael Maison > The znode /config/topics is not updated during KRaft migra

Re: [PR] KAFKA-15720: KRaft support in DeleteTopicTest [kafka]

2023-12-13 Thread via GitHub
tinaselenge commented on PR #14846: URL: https://github.com/apache/kafka/pull/14846#issuecomment-1853763567 @dengziming I believe I fixed the flaky tests which did not appear to be failing in any of the recent builds. The builds still failed but due to the non related tests. -- This is

Re: [PR] KAFKA-15158: Add metrics for RemoteRequestsPerSec [kafka]

2023-12-13 Thread via GitHub
showuon commented on PR #14375: URL: https://github.com/apache/kafka/pull/14375#issuecomment-1853767041 I'll take a look tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14981: URL: https://github.com/apache/kafka/pull/14981#discussion_r1425241345 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -19,16 +19,7 @@ import org.apache.kafka.common.KafkaException;

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14981: URL: https://github.com/apache/kafka/pull/14981#discussion_r1425242119 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -997,7 +997,7 @@ public void testScheduleWriteOpWhenWrite

[PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2023-12-13 Thread via GitHub
lucasbru opened a new pull request, #15000: URL: https://github.com/apache/kafka/pull/15000 We need to make sure to call the consumer interceptor and test its integration. This is adding the required call in `commitSync` and `commitAsync`. The calls in `commitAsync` are executed usin

[jira] [Assigned] (KAFKA-15942) Implement ConsumerInterceptor

2023-12-13 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-15942: -- Assignee: Lucas Brutschy (was: johndoe) > Implement ConsumerInterceptor > --

Re: [PR] MINOR: Add 3.6.1 to system tests [kafka]

2023-12-13 Thread via GitHub
mimaison commented on PR #14932: URL: https://github.com/apache/kafka/pull/14932#issuecomment-1853880955 Ping @dajac @mjsax @vvcephei Can you take a look at this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] MINOR: transform new coordinator error before returning to client [kafka]

2023-12-13 Thread via GitHub
jeffkbkim opened a new pull request, #15001: URL: https://github.com/apache/kafka/pull/15001 This was missing from https://issues.apache.org/jira/browse/KAFKA-14500. The existing coordinator transforms the log append error before returning to client. Apply the same transformation. ##

Re: [PR] MINOR: transform new coordinator error before returning to client [kafka]

2023-12-13 Thread via GitHub
jeffkbkim commented on code in PR #15001: URL: https://github.com/apache/kafka/pull/15001#discussion_r1425372870 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2348,7 +2348,8 @@ private CoordinatorResult completeGenericGr

[jira] [Commented] (KAFKA-15366) Log directory failure integration test

2023-12-13 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796284#comment-17796284 ] Viktor Somogyi-Vass commented on KAFKA-15366: - [~soarez] I think I'll separa

Re: [PR] KAFKA-15366: Modify LogDirFailureTest for KRaft [kafka]

2023-12-13 Thread via GitHub
viktorsomogyi commented on code in PR #14977: URL: https://github.com/apache/kafka/pull/14977#discussion_r1425393002 ## core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala: ## @@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness { TestUtils

Re: [PR] KAFKA-15366: Modify LogDirFailureTest for KRaft [kafka]

2023-12-13 Thread via GitHub
viktorsomogyi commented on PR #14977: URL: https://github.com/apache/kafka/pull/14977#issuecomment-1853976752 @rondagostino would you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-16004) Review new consumer inflight offset commit logic

2023-12-13 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16004: -- Summary: Review new consumer inflight offset commit logic Key: KAFKA-16004 URL: https://issues.apache.org/jira/browse/KAFKA-16004 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-16005) ZooKeeper to KRaft migration rollback missing disabling controller and migration configuration on brokers

2023-12-13 Thread Paolo Patierno (Jira)
Paolo Patierno created KAFKA-16005: -- Summary: ZooKeeper to KRaft migration rollback missing disabling controller and migration configuration on brokers Key: KAFKA-16005 URL: https://issues.apache.org/jira/browse/

Re: [PR] MINOR: transform new coordinator error before returning to client [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #15001: URL: https://github.com/apache/kafka/pull/15001#issuecomment-1854048021 Could we add a test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425475580 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lucasbru commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425393938 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1104,8 +1137,21 @@ private void clearPendingAssignmentsAndLocal

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425483590 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -16,57 +16,50 @@ */ package org.apache.kafka.coordina

Re: [PR] KAFKA-15366: Modify LogDirFailureTest for KRaft [kafka]

2023-12-13 Thread via GitHub
soarez commented on code in PR #14977: URL: https://github.com/apache/kafka/pull/14977#discussion_r1425505344 ## core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala: ## @@ -191,12 +198,27 @@ class LogDirFailureTest extends IntegrationTestHarness { TestUtils.pollUn

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854157002 Sorry @lucasbru - forgot to post the integration results but I did. Let me do that for the record. -- This is an automated message from the Apache Git Service. To respond to the mess

[PR] MINOR Minor Cleanup KRaft code [kafka]

2023-12-13 Thread via GitHub
jlprat opened a new pull request, #15002: URL: https://github.com/apache/kafka/pull/15002 Clean up minor issues with KRaft code *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to

Re: [PR] MINOR Minor Cleanup KRaft code [kafka]

2023-12-13 Thread via GitHub
jlprat commented on code in PR #15002: URL: https://github.com/apache/kafka/pull/15002#discussion_r1425533832 ## raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotReader.java: ## @@ -62,12 +62,7 @@ public int lastContainedLogEpoch() { public long lastContainedLogT

Re: [PR] MINOR Minor Cleanup KRaft code [kafka]

2023-12-13 Thread via GitHub
jlprat commented on PR #15002: URL: https://github.com/apache/kafka/pull/15002#issuecomment-1854162928 Hi @ijuma if you have a couple of cycles, this one is a small one. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
lucasbru commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854172469 CI ran `testFetcherConcurrency` for > 1h on two pipelines and seems to OOM as well. Can you check if this PR is in any way related? https://ci-builds.apache.org/blue/rest/

Re: [PR] KAFKA-15988: Reuse embedded clusters across test cases in Connect OffsetsApiIntegrationTest suite [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #14966: URL: https://github.com/apache/kafka/pull/14966#discussion_r1425552879 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java: ## @@ -70,74 +80,115 @@ public class OffsetsApiIntegrationTest {

Re: [PR] KAFKA-15988: Reuse embedded clusters across test cases in Connect OffsetsApiIntegrationTest suite [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #14966: URL: https://github.com/apache/kafka/pull/14966#discussion_r1425557390 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java: ## @@ -895,6 +909,55 @@ private Map baseSourceConnectorConfigs()

Re: [PR] MINOR: Client state machine fix for ignoring new assignments when leaving [kafka]

2023-12-13 Thread via GitHub
cadonna commented on code in PR #15003: URL: https://github.com/apache/kafka/pull/15003#discussion_r1425582606 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -261,6 +261,32 @@ public void testFencingWhenStateIsPrepareLe

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425599818 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -174,75 +151,91 @@ public GroupCoordinatorMetrics(Metric

Re: [PR] KAFKA-15366: Modify LogDirFailureTest for KRaft [kafka]

2023-12-13 Thread via GitHub
viktorsomogyi commented on code in PR #14977: URL: https://github.com/apache/kafka/pull/14977#discussion_r1425600506 ## core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala: ## @@ -191,12 +198,27 @@ class LogDirFailureTest extends IntegrationTestHarness { TestUtils

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425601951 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java: ## @@ -71,21 +55,30 @@ public TimelineGaugeCounter(Timeli

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425605559 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -281,100 +277,99 @@ public void onUpdateLastCommittedOff

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425608080 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -174,75 +151,91 @@ public GroupCoordinatorMetrics(Metric

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425610115 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -174,75 +151,91 @@ public GroupCoordinatorMetrics(Metric

Re: [PR] MINOR: Client state machine fix for ignoring new assignments when leaving [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #15003: URL: https://github.com/apache/kafka/pull/15003#discussion_r1425622660 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -348,34 +348,54 @@ public void onHeartbeatResponseReceived(Consu

Re: [PR] MINOR: Client state machine fix for ignoring new assignments when leaving [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #15003: URL: https://github.com/apache/kafka/pull/15003#discussion_r1425629956 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -261,6 +261,32 @@ public void testFencingWhenStateIsPrepareLe

Re: [PR] MINOR: Client state machine fix for ignoring new assignments when leaving [kafka]

2023-12-13 Thread via GitHub
lianetm commented on PR #15003: URL: https://github.com/apache/kafka/pull/15003#issuecomment-1854329031 Thanks for the comments @cadonna ! All addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-14237) Kafka TLS Doesn't Present Intermediary Certificates when using PEM

2023-12-13 Thread Ryan R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796379#comment-17796379 ] Ryan R commented on KAFKA-14237: I don't think so. The referenced ticket KAFKA-10338 is

[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module

2023-12-13 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796383#comment-17796383 ] Federico Valeri commented on KAFKA-15853: - [~ijuma] the current StrageTool imple

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2023-12-13 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796383#comment-17796383 ] Federico Valeri edited comment on KAFKA-15853 at 12/13/23 4:57 PM: ---

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2023-12-13 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796383#comment-17796383 ] Federico Valeri edited comment on KAFKA-15853 at 12/13/23 4:58 PM: ---

Re: [PR] KAFKA-15988: Reuse embedded clusters across test cases in Connect OffsetsApiIntegrationTest suite [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #14966: URL: https://github.com/apache/kafka/pull/14966#discussion_r1425647269 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java: ## @@ -895,6 +909,55 @@ private Map baseSourceConnectorConfigs()

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425661185 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425661550 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -350,13 +353,16 @@ private void assertRequestTimesOut(String

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854443779 Let me close and reopen the ticket to trigger the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee closed pull request #14937: KAFKA-15696: Refactor closing consumer URL: https://github.com/apache/kafka/pull/14937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854460882 Sorry about the exceedingly large log, but for documentation purposes: 269/269 tests passed (so i enabled both generic and consumer protocol). ``` Gradle Test Run :core:integration

[jira] [Closed] (KAFKA-15868) KIP-951 - Leader discovery optimisations for the client

2023-12-13 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula closed KAFKA-15868. - > KIP-951 - Leader discovery optimisations for the client >

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854478484 for `testFetcherConcurrency` I'm actually having a hard time to replicate the issue locally. So let's see what the test suggests -- This is an automated message from the Apache Git S

Re: [PR] MINOR: Give FETCH request own MetadataVersion for KIP-951 [kafka]

2023-12-13 Thread via GitHub
jolshan closed pull request #14997: MINOR: Give FETCH request own MetadataVersion for KIP-951 URL: https://github.com/apache/kafka/pull/14997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: Give FETCH request own MetadataVersion for KIP-951 [kafka]

2023-12-13 Thread via GitHub
jolshan commented on PR #14997: URL: https://github.com/apache/kafka/pull/14997#issuecomment-1854528600 I will close this for now after syncing with Proven and others offline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-16002: Implement RemoteCopyLagSegments, RemoteDeleteLagBytes and RemoteDeleteLagSegments [kafka]

2023-12-13 Thread via GitHub
clolov commented on PR #15005: URL: https://github.com/apache/kafka/pull/15005#issuecomment-1854551258 Heya @showuon and @kamalcph! I have marked this as a draft, but will aim to add the needed test + functionality tomorrow. I would appreciate any initial reviews and suggestions for improve

[PR] MINOR: Fix thread leak in AuthorizerIntegrationTest [kafka]

2023-12-13 Thread via GitHub
dajac opened a new pull request, #15006: URL: https://github.com/apache/kafka/pull/15006 Producers and consumers could be leaked in the AuthorizerIntegrationTest. In the teardown logic, `removeAllClientAcls()` is called before calling the super teardown method. If `removeAllClientAcls()` f

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #14981: URL: https://github.com/apache/kafka/pull/14981#issuecomment-1854579152 The failed tests are not related. Merging to trunk and 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
dajac merged PR #14981: URL: https://github.com/apache/kafka/pull/14981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-15237) Implement write operation timeout

2023-12-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15237. - Fix Version/s: 3.7.0 Resolution: Fixed > Implement write operation timeout >

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425798851 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception { pu

Re: [PR] KAFKA-12216; Improve flaky test reporting [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #14862: URL: https://github.com/apache/kafka/pull/14862#issuecomment-1854591910 Rebased to include https://github.com/apache/kafka/commit/87e3cbe4daa084964596d3f6f79041d85548426b. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425827813 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -75,31 +74,23 @@ public class GroupCoordinatorMetrics ex

[jira] [Commented] (KAFKA-16003) The znode /config/topics is not updated during KRaft migration in "dual-write" mode

2023-12-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796445#comment-17796445 ] David Arthur commented on KAFKA-16003: -- Thanks for the report [~ppatierno]. Does th

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425879028 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

Re: [PR] KAFKA-15471 [MINOR]: Fix backward-compatibility bug [kafka]

2023-12-13 Thread via GitHub
rondagostino commented on code in PR #14996: URL: https://github.com/apache/kafka/pull/14996#discussion_r1425899082 ## bin/kafka-server-stop.sh: ## @@ -32,16 +32,6 @@ elif [[ "$OSNAME" == "OS400" ]]; then else PIDS=$(ps ax | grep ' kafka\.Kafka ' | grep java | grep -v grep

[jira] [Created] (KAFKA-16006) mTLS authentication works for kafka-topic.sh but fails for kafka-metadata-quorum.sh

2023-12-13 Thread 10011 (Jira)
10011 created KAFKA-16006: - Summary: mTLS authentication works for kafka-topic.sh but fails for kafka-metadata-quorum.sh Key: KAFKA-16006 URL: https://issues.apache.org/jira/browse/KAFKA-16006 Project: Kafka

[jira] [Updated] (KAFKA-16006) mTLS authentication works for kafka-topic.sh but fails for kafka-metadata-quorum.sh

2023-12-13 Thread 10011 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 10011 updated KAFKA-16006: -- Component/s: tools Affects Version/s: 3.4.0 > mTLS authentication works for kafka-topic.sh but fails

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425904694 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] KAFKA-14412: Generalise over RocksDB WriteBatch [kafka]

2023-12-13 Thread via GitHub
ableegoldman commented on PR #14853: URL: https://github.com/apache/kafka/pull/14853#issuecomment-1854731072 Two of the builds failed again...one of them looks like a failing Connect test bailed out with a sys exit, not sure what happened with the other one, but let's retry it... -- This

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425906944 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425906944 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

[jira] [Created] (KAFKA-16007) ZK migrations can be slow for large clusters

2023-12-13 Thread David Arthur (Jira)
David Arthur created KAFKA-16007: Summary: ZK migrations can be slow for large clusters Key: KAFKA-16007 URL: https://issues.apache.org/jira/browse/KAFKA-16007 Project: Kafka Issue Type: Impr

Re: [PR] KAFKA-14505; [3/N] Wire WriteTxnMarkers API [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14985: URL: https://github.com/apache/kafka/pull/14985#discussion_r1425954235 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -299,14 +304,14 @@ class TransactionsTest extends IntegrationTestHarness { @nowarn("cat=de

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
rondagostino commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1425955291 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -165,13 +165,15 @@ public void testFromVersionString() { ass

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
rondagostino commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1425956907 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest { MetadataVersion.IBP_3

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425958312 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java: ## @@ -18,17 +18,36 @@ import org.apache.kafka.clients.consu

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
jolshan commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1425960046 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,13 @@ public enum MetadataVersion { // Add JBOD support for K

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425965837 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -457,120 +535,224 @@ public void onResponse(final ClientResponse r

[jira] [Updated] (KAFKA-15835) Group commit/callbacks triggering logic

2023-12-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15835: --- Description: The new consumer reconciliation logic triggers a commit request, revocation ca

[jira] [Updated] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16008: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMs}} is failing with the

[jira] [Created] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2023-12-13 Thread Kirk True (Jira)
Kirk True created KAFKA-16008: - Summary: Fix PlaintextConsumerTest.testMaxPollIntervalMs Key: KAFKA-16008 URL: https://issues.apache.org/jira/browse/KAFKA-16008 Project: Kafka Issue Type: Test

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425982023 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -190,63 +179,90 @@ private static long findMinTime(final Collectio

[jira] [Updated] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16008: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMs}} is failing when usi

  1   2   >