lianetm commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1425958312
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java:
##########
@@ -18,17 +18,36 @@
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.utils.Timer;
import java.util.Collections;
import java.util.Map;
+import java.util.Optional;
public class CommitApplicationEvent extends CompletableApplicationEvent<Void> {
+ /**
+ * Offsets to commit per partition.
+ */
private final Map<TopicPartition, OffsetAndMetadata> offsets;
- public CommitApplicationEvent(final Map<TopicPartition, OffsetAndMetadata>
offsets) {
+ /**
+ * Timer to wait for a response, retrying on retriable errors. If not
present, the request is
+ * triggered without waiting for a response or being retried.
+ */
+ private final Optional<Timer> timer;
Review Comment:
Good catch! Changed it to use timeouts instead. Intentionally in the same
way that the `TopicMetadataApplicationEvent` that has just been merged does it,
trying to start getting a consistent implementation of timeouts across all
appEvents and managers that need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
