dajac commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1425605559
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -281,100 +277,99 @@ public void onUpdateLastCommittedOffset(TopicPartition
tp, long offset) {
}
}
- public static MetricName getMetricName(String type, String name) {
+ public static com.yammer.metrics.core.MetricName getMetricName(String
type, String name) {
return getMetricName("kafka.coordinator.group", type, name);
}
private void registerGauges() {
- registry.newGauge(NUM_OFFSETS, new Gauge<Long>() {
+ registry.newGauge(NUM_OFFSETS, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
return numOffsets();
}
});
- registry.newGauge(NUM_GENERIC_GROUPS, new Gauge<Long>() {
- @Override
- public Long value() {
- return numGenericGroups();
- }
- });
-
- registry.newGauge(NUM_GENERIC_GROUPS_PREPARING_REBALANCE, new
Gauge<Long>() {
- @Override
- public Long value() {
- return numGenericGroupsPreparingRebalanceCount();
- }
- });
-
- registry.newGauge(NUM_GENERIC_GROUPS_COMPLETING_REBALANCE, new
Gauge<Long>() {
- @Override
- public Long value() {
- return numGenericGroupsCompletingRebalanceCount();
- }
- });
-
- registry.newGauge(NUM_GENERIC_GROUPS_STABLE, new Gauge<Long>() {
- @Override
- public Long value() {
- return numGenericGroupsStableCount();
- }
- });
-
- registry.newGauge(NUM_GENERIC_GROUPS_DEAD, new Gauge<Long>() {
- @Override
- public Long value() {
- return numGenericGroupsDeadCount();
- }
- });
-
- registry.newGauge(NUM_GENERIC_GROUPS_EMPTY, new Gauge<Long>() {
- @Override
- public Long value() {
- return numGenericGroupsEmptyCount();
- }
- });
-
- registry.newGauge(NUM_CONSUMER_GROUPS, new Gauge<Long>() {
- @Override
- public Long value() {
- return numConsumerGroups();
- }
- });
-
- registry.newGauge(NUM_CONSUMER_GROUPS_EMPTY, new Gauge<Long>() {
+ registry.newGauge(NUM_GENERIC_GROUPS_PREPARING_REBALANCE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numConsumerGroupsEmpty();
+ return numGenericGroupsPreparingRebalance();
}
});
- registry.newGauge(NUM_CONSUMER_GROUPS_ASSIGNING, new Gauge<Long>() {
+ registry.newGauge(NUM_GENERIC_GROUPS_COMPLETING_REBALANCE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numConsumerGroupsAssigning();
+ return numGenericGroupsCompletingRebalance();
}
});
- registry.newGauge(NUM_CONSUMER_GROUPS_RECONCILING, new Gauge<Long>() {
+ registry.newGauge(NUM_GENERIC_GROUPS_STABLE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numConsumerGroupsReconciling();
+ return numGenericGroupsStable();
}
});
- registry.newGauge(NUM_CONSUMER_GROUPS_STABLE, new Gauge<Long>() {
+ registry.newGauge(NUM_GENERIC_GROUPS_DEAD, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numConsumerGroupsStable();
+ return numGenericGroupsDead();
}
});
- registry.newGauge(NUM_CONSUMER_GROUPS_DEAD, new Gauge<Long>() {
+ registry.newGauge(NUM_GENERIC_GROUPS_EMPTY, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numConsumerGroupsDead();
+ return numGenericGroupsEmpty();
}
});
+ metrics.addMetric(
+ metrics.metricName(GROUPS_COUNT_METRIC_NAME, METRICS_GROUP,
Collections.singletonMap(
Review Comment:
I wonder if we could add the description to all the new metrics. Have you
considered it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
