dajac commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694568169
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfNeeded(f
[
https://issues.apache.org/jira/browse/KAFKA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403611#comment-17403611
]
Bruno Cadonna commented on KAFKA-13195:
---
[~mjsax] [~tchiotludo] Can we close this
dajac merged pull request #11230:
URL: https://github.com/apache/kafka/pull/11230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
[
https://issues.apache.org/jira/browse/KAFKA-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-12840.
-
Fix Version/s: 3.1.0
Reviewer: Jun Rao
Resolution: Fixed
> Removing `compact` cl
[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yanwen Lin reassigned KAFKA-10038:
--
Assignee: Yanwen Lin
> ConsumerPerformance.scala supports the setting of client.id
>
kowshik opened a new pull request #11253:
URL: https://github.com/apache/kafka/pull/11253
It looked odd that the code has a local variable named
`updatedFirstStableOffset` which is used to update
`MergedLog.firstUnstableOffsetMetadata`. This PR improves the local variable
name to be `upda
jlprat commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r694629688
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamMapTest.java
##
@@ -68,6 +70,12 @@ public void testMap() {
cadonna commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r694622105
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -249,7
dajac commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-904481315
@jolshan All the builds have failed. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
dajac merged pull request #11127:
URL: https://github.com/apache/kafka/pull/11127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
[
https://issues.apache.org/jira/browse/KAFKA-13134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13134.
-
Fix Version/s: 3.1.0
Reviewer: David Jacot
Resolution: Fixed
> Heartbeat Request
[
https://issues.apache.org/jira/browse/KAFKA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403737#comment-17403737
]
Ludo commented on KAFKA-13195:
--
[~cadonna] : I think there is still some improvement to han
cadonna commented on a change in pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#discussion_r694676118
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -1873,7 +1875,13 @@ public OffsetAndMetadata committed(Top
cadonna commented on pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#issuecomment-904548251
The title of the PR should start with the Jira ID, i.e., KAFKA-1234.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat reassigned KAFKA-2424:
-
Assignee: Josep Prat
> Consider introducing lint-like tool for Scala
> -
jlprat opened a new pull request #11254:
URL: https://github.com/apache/kafka/pull/11254
Introduces Scalafix, a linter with some rewrite capabilities on
top (https://scalacenter.github.io/scalafix/)
By running the `checkScalafix` gradle tasks a report is printed with all
broken
[
https://issues.apache.org/jira/browse/KAFKA-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403765#comment-17403765
]
Josep Prat commented on KAFKA-2424:
---
I know this is a very old task, but there is still
jlprat commented on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-904569475
@cadonna, @ijuma and @vvcephei if any of you has time to take a look at this
PR I'd be thankful.
--
This is an automated message from the Apache Git Service.
To respond to the
jlprat commented on a change in pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#discussion_r694776794
##
File path: Jenkinsfile
##
@@ -20,7 +20,7 @@
def doValidation() {
sh """
./gradlew -PscalaVersion=$SCALA_VERSION clean compileJava compileScala
jlprat commented on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-904572739
As far as I understand, my jenkinsfile modification will not be taken into
consideration by Jenkins in this run, maybe it's worth keep a close eye to this
once it's merged
--
dajac commented on a change in pull request #11104:
URL: https://github.com/apache/kafka/pull/11104#discussion_r694816464
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -332,6 +329,9 @@ public FetchRequestData build() {
dajac commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694843292
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -159,10 +159,11 @@ private void ha
jlprat commented on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-904646319
Failure was https://issues.apache.org/jira/browse/KAFKA-9897p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jlprat edited a comment on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-904646319
Failure was https://issues.apache.org/jira/browse/KAFKA-9897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jlprat edited a comment on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-904646319
Failure was https://issues.apache.org/jira/browse/KAFKA-13128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694870996
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -159,10 +159,11 @@ private void
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-904662073
> excuse me for the delay
Never mind! :)
And thanks for the comment. I've updated the PR. Thank you.
--
This is an automated message from the Apache Git Service.
To
dajac commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694876130
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -158,25 +158,24 @@ private void ha
dajac commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r694960458
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2207,15 +2198,28 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r694960197
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2207,15 +2198,28 @@ class ReplicaManager(val config: KafkaConfig,
jasonyanwenl commented on pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#issuecomment-904751684
> LGTM! Thanks for the fix!
> One suggestion: please try not to email to the whole dev group to request
for a code review next time (unless it's an urgent PR). If every P
splett2 opened a new pull request #11255:
URL: https://github.com/apache/kafka/pull/11255
### What
The controller can skip sending `updateMetadataRequest` during the broker
failure callback if there are offline partitions and the deleted brokers don't
host any partitions. Looking at the
[
https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson reassigned KAFKA-13215:
--
Assignee: Walker Carlson
> Flaky test
> org.apache.kafka.streams.integration.TaskMet
[
https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403921#comment-17403921
]
Walker Carlson commented on KAFKA-13215:
[GitHub Pull Request #11083|https://git
jasonyanwenl commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695002209
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,10 @@ public void testFlatMap
jasonyanwenl commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695002209
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,10 @@ public void testFlatMap
[
https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson resolved KAFKA-13215.
Resolution: Fixed
> Flaky test
> org.apache.kafka.streams.integration.TaskMetadataIntegra
jasonyanwenl commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695002209
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,10 @@ public void testFlatMap
wcarlson5 commented on pull request #11083:
URL: https://github.com/apache/kafka/pull/11083#issuecomment-904782977
@kkonstantine I saw you made a ticket for a failing test. I think this PR
should fix it for 3.0 as well if cherrypicked
--
This is an automated message from the Apache Git S
wcarlson5 edited a comment on pull request #11083:
URL: https://github.com/apache/kafka/pull/11083#issuecomment-904782977
@kkonstantine I saw you made a ticket for a failing test. I think this PR
should fix it for 3.0 as well if cherrypicked.
https://issues.apache.org/jira/browse/KAFKA-1
hachikuji merged pull request #11246:
URL: https://github.com/apache/kafka/pull/11246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
hachikuji commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r695012453
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfNeed
jlprat commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695017818
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,10 @@ public void testFlatMap() {
jlprat commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695019986
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,12 @@ public void testFlatMap() {
jlprat commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695017818
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,10 @@ public void testFlatMap() {
jolshan commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-904805600
Looks like an issue with more recent changes. I'll fix it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jasonyanwenl commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r695031580
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,10 @@ public void testFlatMap
rondagostino commented on pull request #11238:
URL: https://github.com/apache/kafka/pull/11238#issuecomment-904824877
> we can have ceil method to use, which will be easier
Good suggestion! Done. Here's some system tests runs that show the new
code is syntactically correct (and I
abbccdda commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r695050765
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##
@@ -36,7 +36,6 @@ public WindowStoreBuilder(fina
ijuma commented on pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#issuecomment-904843864
@guozhangwang @dajac does the last commit from Jason look good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
guozhangwang commented on pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#issuecomment-904852557
> The title of the PR should start with the Jira ID, i.e., KAFKA-1234.
Just to explain the context here, we have a browser plugin for AK tickets
which can re-direct f
guozhangwang edited a comment on pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#issuecomment-904852557
> The title of the PR should start with the Jira ID, i.e., KAFKA-1234.
Just to explain the context here, we have a browser plugin for AK tickets
which can re-d
guozhangwang commented on pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#issuecomment-904853346
Yup, I've approved it yesterday night.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ijuma commented on pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#issuecomment-904853838
The commit metadata said it was added 1 hour ago and hence why I asked :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
guozhangwang commented on pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#issuecomment-904860153
Yeah I reviewed that last commit as well, btw it is not a correctness issue
anyways so I was happy to merge as-is even :)
--
This is an automated message from the Apache
hachikuji merged pull request #11231:
URL: https://github.com/apache/kafka/pull/11231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-13214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13214.
-
Fix Version/s: 2.8.1
2.7.2
3.0.0
Resolution:
rondagostino opened a new pull request #11256:
URL: https://github.com/apache/kafka/pull/11256
Plugins may expect `broker.id` to exist as a key in the config's various
originals()-related maps, but with KRaft we rely solely on `node.id` for the
broker's ID, and with the Zk-based brokers we
rondagostino commented on a change in pull request #11256:
URL: https://github.com/apache/kafka/pull/11256#discussion_r695176785
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1405,21 +1405,95 @@ class KafkaConfig(val props: java.util.Map[_, _],
doLog:
jolshan commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-905024994
Fixed my issue locally but looks like 2.8 branch is broken in general.
```
> Task :streams:compileTestJava
/Users/jolshan/kafka/streams/src/test/java/org/apache/kafka/st
jolshan commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-905028262
Hi. This PR seemed to break the 2.8 branch. When I try to run checkstyle I
see:
```
> Task :streams:compileTestJava
/Users/jolshan/kafka/streams/src/test/java/org/apach
jsancio commented on a change in pull request #11186:
URL: https://github.com/apache/kafka/pull/11186#discussion_r687906243
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -90,8 +90,7 @@ class BrokerServer(
this.logIdent = logContext.logPrefix
-
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13010:
---
Fix Version/s: (was: 3.1.0)
3.0.0
> Flaky test
> org
[
https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13215:
---
Fix Version/s: (was: 3.1.0)
3.0.0
> Flaky test
> org
ableegoldman commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-905084553
@jolshan ah, whoops. Thanks for the heads up. I'll get a patch ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ableegoldman opened a new pull request #11257:
URL: https://github.com/apache/kafka/pull/11257
A backport of #11248 broke the 2.8 build due to usage of the
`EmbeddedKafkaCluster#stop` method, which used to be private. It seems we made
this public when we upgraded to JUnit5 on the 3.0 branc
ableegoldman commented on pull request #11257:
URL: https://github.com/apache/kafka/pull/11257#issuecomment-905096193
@jolshan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ableegoldman commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-905097291
Fix is available here: https://github.com/apache/kafka/pull/11257
This also got me digging into why we had to make `stop()` public in 3.0, and
seem to now be required
ableegoldman commented on a change in pull request #9858:
URL: https://github.com/apache/kafka/pull/9858#discussion_r695328381
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -75,9 +76,19 @@
@Category(Integration
jolshan commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-905114876
fix here: https://github.com/apache/kafka/pull/11257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rodesai commented on a change in pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#discussion_r695341815
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/KafkaConsumerMetrics.java
##
@@ -63,6 +66,18 @@ public KafkaConsumerMetri
rodesai commented on a change in pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#discussion_r695342570
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -905,6 +971,57 @@ public void testSendTxnOffsetsWithGr
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r695353891
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -158,25 +158,24 @@ private void
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-905139875
@dajac , thanks for the comment. I've updated the PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
kowshik commented on pull request #11253:
URL: https://github.com/apache/kafka/pull/11253#issuecomment-905142894
cc @junrao @ijuma for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on pull request #11257:
URL: https://github.com/apache/kafka/pull/11257#issuecomment-905150624
Failures are unrelated are known to be flaky on older branches
(`connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining`)
-- will merge
ableegoldman merged pull request #11257:
URL: https://github.com/apache/kafka/pull/11257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404165#comment-17404165
]
Yanwen Lin commented on KAFKA-10038:
Hi [~tigertan], I'm working on this issue and t
[
https://issues.apache.org/jira/browse/KAFKA-12933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404166#comment-17404166
]
Yanwen Lin commented on KAFKA-12933:
Hi [~mjsax], I guess we shall mark this ticket
[
https://issues.apache.org/jira/browse/KAFKA-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404167#comment-17404167
]
Yanwen Lin commented on KAFKA-1935:
---
Hi [~guozhang], is this still an issue currently?
[
https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404175#comment-17404175
]
Yanwen Lin commented on KAFKA-6579:
---
Hi [~teamurko], are you still working on this? If
[
https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yanwen Lin updated KAFKA-6579:
--
Comment: was deleted
(was: Hi [~teamurko], are you still working on this? If not, I'd like to give a
s
[
https://issues.apache.org/jira/browse/KAFKA-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404177#comment-17404177
]
Yanwen Lin commented on KAFKA-13032:
Hi [~mjsax], I have raised a PR for this and it
[
https://issues.apache.org/jira/browse/KAFKA-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404179#comment-17404179
]
Yanwen Lin commented on KAFKA-5666:
---
Hi [~RensGroothuijsen], are you still working on t
[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404185#comment-17404185
]
Luke Chen commented on KAFKA-10038:
---
If it's just to provide default value when not pr
85 matches
Mail list logo
