abbccdda commented on a change in pull request #11047:
URL: https://github.com/apache/kafka/pull/11047#discussion_r695050765
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java
##########
@@ -36,7 +36,6 @@ public WindowStoreBuilder(final WindowBytesStoreSupplier
storeSupplier,
final Serde<V> valueSerde,
final Time time) {
super(storeSupplier.name(), keySerde, valueSerde, time);
- Objects.requireNonNull(storeSupplier, "storeSupplier can't be null");
Review comment:
@tang7526 Thanks, could we do sth similar to
https://github.com/apache/kafka/blob/d30b4e51513e6938970020bf1e894c983447ef8f/streams/src/main/java/org/apache/kafka/streams/state/internals/SessionStoreBuilder.java#L36
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
