jlprat commented on a change in pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#discussion_r694776794
##########
File path: Jenkinsfile
##########
@@ -20,7 +20,7 @@
def doValidation() {
sh """
./gradlew -PscalaVersion=$SCALA_VERSION clean compileJava compileScala
compileTestJava compileTestScala \
- spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain rat \
+ spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain
checkScalafix rat \
Review comment:
Added the new task in the Jenkins job script
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1737,11 +1737,11 @@ class KafkaConfig(val props: java.util.Map[_, _],
doLog: Boolean, dynamicConfigO
Set.empty[String]
}
- def interBrokerListenerName =
getInterBrokerListenerNameAndSecurityProtocol._1
- def interBrokerSecurityProtocol =
getInterBrokerListenerNameAndSecurityProtocol._2
- def controlPlaneListenerName =
getControlPlaneListenerNameAndSecurityProtocol.map { case (listenerName, _) =>
listenerName }
- def controlPlaneSecurityProtocol =
getControlPlaneListenerNameAndSecurityProtocol.map { case (_, securityProtocol)
=> securityProtocol }
- def saslMechanismInterBrokerProtocol =
getString(KafkaConfig.SaslMechanismInterBrokerProtocolProp)
+ def interBrokerListenerName: ListenerName =
getInterBrokerListenerNameAndSecurityProtocol._1
+ def interBrokerSecurityProtocol: SecurityProtocol =
getInterBrokerListenerNameAndSecurityProtocol._2
+ def controlPlaneListenerName: Option[ListenerName] =
getControlPlaneListenerNameAndSecurityProtocol.map { case (listenerName, _) =>
listenerName }
+ def controlPlaneSecurityProtocol: Option[SecurityProtocol] =
getControlPlaneListenerNameAndSecurityProtocol.map { case (_, securityProtocol)
=> securityProtocol }
Review comment:
These 2 were incorrectly inferred by Scalafix, I needed to correct them
manually.
Scalafix inferred for both `Option[Any]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
