RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

2023-07-21 Thread Sunil Kumar Kori
> -Original Message- > From: Jerin Jacob > Sent: Friday, July 21, 2023 12:18 PM > To: Rakesh Kudurumalla > Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; Yan, > Zhirun ; tho...@monjalon.net; Jerin Jacob > Kollanukkaran ; Nithin Kumar Dabilpuram > ; Liang, Cunming ; > Wang, Haiyue ; Sunil Kuma

RE: [EXT] Re: [PATCH v2 4/4] app: add testgraph application

2023-07-21 Thread Rakesh Kudurumalla
> -Original Message- > From: Sunil Kumar Kori > Sent: Friday, July 21, 2023 12:31 PM > To: Jerin Jacob ; Rakesh Kudurumalla > > Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; Yan, > Zhirun ; tho...@monjalon.net; Jerin Jacob > Kollanukkaran ; Nithin Kumar Dabilpuram > ; Liang, Cunming ; > Wa

Re: [PATCH] net/mana: fix stats for txq bytes sent

2023-07-21 Thread Ferruh Yigit
On 7/20/2023 11:42 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > Bytes should be calculated using the packet length, not the mbuf segment > data length. > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Cc: sta...@dpdk.org > > Signed-off-by: Long Li > Ap

RE: release candidate 23.07-rc4

2023-07-21 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 20, 2023 1:16 PM > To: annou...@dpdk.org > Subject: release candidate 23.07-rc4 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v23.07-rc4 > > There are 37 new patches in

[POC v3] net/iavf: support no data path polling mode

2023-07-21 Thread Mingjin Ye
Currently, during a PF to VF reset due to an action such as changing trust settings on a VF, the DPDK application running with iavf PMD loses connectivity, and the only solution is to reset the DPDK application. Instead of forcing a reset of the DPDK application to restore connectivity, the iavf P

crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Suanming Mou
Hi Guys, Sorry for the inconvenience. I have one small question with pmd-cycle-count test in test-crypto-perf application. As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is called to fill the test data. So for decryption, I assume it will always fails. Feel like pmd-cy

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

2023-07-21 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 21-Jul-23 10:58 AM, Gagandeep Singh wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button when RTE_ENABLE_ASSERT is enable, DPAA driver is doi

[PATCH] app/test: fix include of standard header

2023-07-21 Thread Bruce Richardson
Standard headers, or headers not in the current directory generally, should be wrapped in "<>" rather than in regular quotes "". Fix one instance of unistd.h being included using quotes Fixes: df468c4937bb ("app/test: refactor bonding checks with macros") Cc: sta...@dpdk.org Signed-off-by: Bruce

RE: [PATCH] app/test: fix include of standard header

2023-07-21 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 21 July 2023 12.57 > > Standard headers, or headers not in the current directory generally, > should be wrapped in "<>" rather than in regular quotes "". Fix one > instance of unistd.h being included using quotes > > Fix

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Akhil Goyal
Hi Suanming, The pmd-cycle-count mode is for counting the cycles for enqueue and dequeue. It does not matter what is the content of the packet, as we are not validating the content after dequeue of the packet. PMD/Hw will assume it as plain/encrypted payload and will process it as per the sessio

[RFC PATCH 0/5] replace build code for unit tests

2023-07-21 Thread Bruce Richardson
While working on series such as [1] to make DPDK builds more configurable, the majority of the complexity involved centered on the unit tests, and ensuring that the individual files were added/removed from the build as the components were enabled/disabled. This complexity was exacerbated by: * C f

[RFC PATCH 1/5] app/test: add new macros for various test types

2023-07-21 Thread Bruce Richardson
Rather than just registering all tests using a single generic macro, add macros which identify the test as being of a particular type. Signed-off-by: Bruce Richardson --- app/test/test.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/test/test.h b/app/test/test.h

[RFC PATCH 2/5] app/test: tag tests with the test type

2023-07-21 Thread Bruce Richardson
Rather than having the test types called out in the meson.build file, we can use macros to identify the test type in the C file itself and then dynamically build up the tests lists at config time. Signed-off-by: Bruce Richardson --- NOTE: This replacement was automatically done using the list of

[RFC PATCH 3/5] app/test: build using per-file dependency matrix

2023-07-21 Thread Bruce Richardson
Rather than using if-else constructs to selectively add or remove files from the UT build, switch to a table-based approach where each file lists out what libs or drivers it depends upon. Initial version of this table was generated via analysis of the header files included in each C file. Signed-

[RFC PATCH 4/5] app/test: define unit tests suites based on test macros

2023-07-21 Thread Bruce Richardson
Rather than having the test suites listed out in the meson.build files and having to have them enabled/disabled selectively based on what libs are being built, pull the tests to run from the source files which were added to the build. Signed-off-by: Bruce Richardson --- app/meson.build

[RFC PATCH 5/5] app/test: add fast test suite to new build infrastructure

2023-07-21 Thread Bruce Richardson
The fast-tests are special in that they have additional parameters associated with them. This requires script changes and meson.build changes to take account of these parameters. Signed-off-by: Bruce Richardson --- app/test/suites/meson.build | 56 +-- buildtool

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Suanming Mou
Thanks Akhil. Yes, I see. But for decryption, we should prepare the correct cipher data, right? Or that test does not make any sense. I assume decryption with incorrect data will cause PMD reject work properly. From: Akhil Goyal Sent: Friday, July 21, 2023 7:49 PM To: Suanming Mou ; ciara.po...@

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Akhil Goyal
Yes, for auth cases, the PMD may give errors. However, cipher only cases would work without issues. You can send a patch to fix this. But make sure not to add that inside the time keeping loop. From: Suanming Mou Sent: Friday, July 21, 2023 5:23 PM To: Akhil Goyal ; ciara.po...@intel.com Cc: de

RE: crypto decryption support in test-crypto-perf pmd-cycle-count test

2023-07-21 Thread Suanming Mou
Sure, in fact I also find throughput testing with decryption and in-place-mode will override the cipher data in the single mbuf as well. So I assume out-of-place mode is valid in that case. I will try to deliver some patches when have effort. Thank you! From: Akhil Goyal Sent: Friday, July 21,

Re: [PATCH] net/ngbe: fix RSS offload capability

2023-07-21 Thread Ferruh Yigit
On 7/20/2023 10:01 AM, Jiawen Wu wrote: > Fix missed RTE_ETH_RX_OFFLOAD_RSS_HASH flag in ngbe_get_rx_port_offloads(). > > Fixes: 0779d7f61991 ("net/ngbe: support RSS hash") > Cc: sta...@dpdk.org > > Signed-off-by: Jiawen Wu > Applied to dpdk-next-net/main, thanks.

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

2023-07-21 Thread Jerin Jacob
On Fri, Jul 21, 2023 at 4:18 PM Hemant Agrawal wrote: > > Acked-by: Hemant Agrawal Acked-by: Jerin Jacob > > On 21-Jul-23 10:58 AM, Gagandeep Singh wrote: > > Caution: This is an external email. Please take care when clicking links or > > opening attachments. When in doubt, report the messa

Re: [PATCH v1] test/graph: fix unused return value

2023-07-21 Thread Jerin Jacob
On Fri, Jul 21, 2023 at 8:12 AM Zhirun Yan wrote: > > Return value stored in "ret" but it may be overwritten before use. > Add goto to return when meet an error. Issue reported by coverity scan. > > Coverity issue: 395532 > Fixes: 15f483feec65 ("graph: fix model check in core binding") > > Signed-

Re: [PATCH v3] tap: fix build of TAP BPF program

2023-07-21 Thread Ferruh Yigit
On 7/21/2023 12:25 AM, Stephen Hemminger wrote: > Move the BPF program related code into a subdirectory. > And add a Makefile for building it. > > The code was depending on old versions of headers from iproute2. > Include those headers here so that build works. > Thanks Stephen, build works now.

DPDK Release Status Meeting 2023-07-20

2023-07-21 Thread Mcnamara, John
Release status meeting minutes 2023-07-20 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat * Canonical Release Dates - The following are t

[PATCH v1] doc: update release notes for 23.07

2023-07-21 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 23.07 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_23_07.rst | 49 +- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_note

Re: [PATCH v3] tap: fix build of TAP BPF program

2023-07-21 Thread Stephen Hemminger
On Fri, 21 Jul 2023 14:05:52 +0100 Ferruh Yigit wrote: > On 7/21/2023 12:25 AM, Stephen Hemminger wrote: > > Move the BPF program related code into a subdirectory. > > And add a Makefile for building it. > > > > The code was depending on old versions of headers from iproute2. > > Include those h

[RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ferruh Yigit
Drivers start/stop device queues on port start/stop, but not all drivers update queue state accordingly. This becomes more visible if a specific queue stopped explicitly and port stopped/started later, in this case although all queues are started, the state of that specific queue is stopped and it

[PATCH v12 1/2] mempool cache: add zero-copy get and put functions

2023-07-21 Thread Dharmik Thakkar
From: Morten Brørup Zero-copy access to mempool caches is beneficial for PMD performance. Furthermore, having a zero-copy mempool API is considered a precondition for fixing a certain category of bugs, present in some PMDs: For performance reasons, some PMDs had bypassed the mempool API in order

[PATCH v12 2/2] net/i40e: replace put function

2023-07-21 Thread Dharmik Thakkar
From: Kamalakshitha Aligeri Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang

Re: [PATCH] app/test: fix include of standard header

2023-07-21 Thread Ferruh Yigit
On 7/21/2023 12:24 PM, Morten Brørup wrote: >> From: Bruce Richardson [mailto:bruce.richard...@intel.com] >> Sent: Friday, 21 July 2023 12.57 >> >> Standard headers, or headers not in the current directory generally, >> should be wrapped in "<>" rather than in regular quotes "". Fix one >> instance

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ivan Malov
Hi Ferruh, The commit log says "commit [1]" and "commit [2]" but does not seem to provide the URLs for the [1] and [2]. What are these resources? I'd like to know. Thank you. On Fri, 21 Jul 2023, Ferruh Yigit wrote: Drivers start/stop device queues on port start/stop, but not all drivers upda

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ivan Malov
Hi Ferruh, PSB Thank you. On Fri, 21 Jul 2023, Ferruh Yigit wrote: Drivers start/stop device queues on port start/stop, but not all drivers update queue state accordingly. This becomes more visible if a specific queue stopped explicitly and port stopped/started later, in this case although a

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ferruh Yigit
On 7/21/2023 6:33 PM, Ivan Malov wrote: > Hi Ferruh, > > The commit log says "commit [1]" and "commit [2]" but > does not seem to provide the URLs for the [1] and [2]. > What are these resources? I'd like to know. > Ahh, I missed to add them to commit log, will add to next version: [1] 3c4426db

Re: [RFC] ethdev: clarify device queue state after start and stop

2023-07-21 Thread Ferruh Yigit
On 7/21/2023 6:42 PM, Ivan Malov wrote: > Hi Ferruh, > > PSB > > Thank you. > > On Fri, 21 Jul 2023, Ferruh Yigit wrote: > >> Drivers start/stop device queues on port start/stop, but not all drivers >> update queue state accordingly. >> >> This becomes more visible if a specific queue stopped e