Re: [RFC PATCH v2 3/9] vhost: annotate virtqueue access lock

2022-04-07 Thread David Marchand
On Thu, Apr 7, 2022 at 3:40 AM Hu, Jiayu wrote: > > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index > > a9edc271aa..158460b7d7 100644 > > --- a/lib/vhost/vhost.h > > +++ b/lib/vhost/vhost.h > > @@ -834,6 +834,7 @@ vhost_need_event(uint16_t event_idx, uint16_t > > new_idx, uint16_t old) >

RE: [PATCH v2] net/ice: refact parser API usage

2022-04-07 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Thursday, April 7, 2022 2:45 PM > To: Zhang, Qi Z ; Guo, Junfeng > > Cc: dev@dpdk.org; Yang, Qiming ; > sta...@dpdk.org > Subject: RE: [PATCH v2] net/ice: refact parser API usage > > > -Original Message- > > From: Zhang, Qi Z > >

[PATCH v3 1/2] cryptodev: move dh type from xform to dh op

2022-04-07 Thread Arek Kusztal
Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free to choose for any operation. One xform/session should be enough to perform both DH operations, if this is xform member, session needs to be created twice for the same group, similar problem would be observed in sessionless case. A

[PATCH v3 2/2] test/crypto: move dh type from xform to dh op

2022-04-07 Thread Arek Kusztal
This commit reflects API changes in Diffie-Hellman, now for setting crypto operation type asym_op no xform is responsible. Signed-off-by: Arek Kusztal --- v3: - changed op_type comments in dh app/test/test_cryptodev_asym.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

Re: [RFC PATCH v1 00/15] merge DTS core files to DPDK

2022-04-07 Thread Thomas Monjalon
07/04/2022 07:04, Jerin Jacob: > On Wed, Apr 6, 2022 at 8:26 PM Juraj Linkeš > wrote: > > > > These are the basic libraries that other libraries depend on. There's > > also the basic framework functionality related to test execution. > > > > Juraj Linkeš (15): > > dts: merge DTS dep/tclclient.t

Re: [PATCH] kni: fix device address set

2022-04-07 Thread Thomas Monjalon
07/04/2022 02:44, Min Hu (Connor): > Hi, Stephen, > I think this is a good option, but the macro definition is like: > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 14, 0) > +#define ether_addr_copy(dst, src) memcpy(dst, src, ETH_ALEN) > +#endif > > @Ferry, why is it limited for "LINUX_VERSION_COD

[PATCH] cryptodev: add elliptic curve diffie hellman

2022-04-07 Thread Arek Kusztal
This commit adds Elliptic Curve Diffie-Hellman option to Cryptodev. This could be achieved with EC point multiplication but: 1) Phase 1 of DH is used with EC generator, multiplication expect setting generator manually. 2) It will unify usage of DH. 3) Can be extended easily to support X25519 and X4

[PATCH v3] net/ice: refact parser API usage

2022-04-07 Thread Qi Zhang
Not necessary to create / destroy a parser instance for every raw packet rule. A global parser instance will be created in ice_flow_init and be destroyed in ice_flow_uninit. Also, ice_dev_udp_tunnel_port_add has been hooked to perform corresponding parser configure. This also fix the issue that RS

[PATCH] test/crypto: add key exchange dh tests

2022-04-07 Thread Arek Kusztal
This patch adds Diffie-Hellman key exchange tests. Alice's and Bob's private keys are generated in tests, public keys are then generated followed by shared secret. Alice's and Bob's shared secret are then compared to obtain result of the test. This test should be easy to extend to use ECDH. Signe

[PATCH] examples/kni: add interrupt mode to receive packets

2022-04-07 Thread Tianli Lai
kni application have two main-loop threads that they CPU utilization are up to 100 percent, this two theads are writing thread and reading thread. I thank set interrupt mode at reading thread would reduce this thread CPU utilization. Signed-off-by: Tianli Lai --- examples/kni/main.c | 107 ++

Re: [RFC PATCH v2 2/9] eal: annotate spinlock and rwlock

2022-04-07 Thread David Marchand
On Mon, Apr 4, 2022 at 8:21 AM Stephen Hemminger wrote: > > On Wed, 30 Mar 2022 15:49:49 +0200 > David Marchand wrote: > > > +#ifdef RTE_ANNOTATE_LOCKS > > + > > +#define RTE_ANNOTATED_LOCK \ > > + __attribute__((lockable)) > > + > > +#define RTE_GUARDED_BY(...) \ > > + __attribute__((gua

Re: [PATCH v2] net/dpaa2: fix dpdmux default interface

2022-04-07 Thread Thomas Monjalon
31/03/2022 12:19, Hemant Agrawal: > Acked-by: Hemant Agrawal > > On 3/30/2022 3:31 AM, Tianli Lai wrote: > > if dpdmux objects created by restool tools with > > the argument "--default-if=", this > > function would change it to 1 > > > > Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization

[RFC] add support for async packed ring dequeue

2022-04-07 Thread Cheng Jiang
This RFC patch implements packed ring dequeue data path for asynchronous vhost. It's based on the RFC patch: http://patchwork.dpdk.org/project/dpdk/cover/20220310065407.17145-1-xuan.d...@intel.com/ Signed-off-by: Cheng Jiang --- lib/vhost/virtio_net.c | 217 --

DPDK 19.11.12 released

2022-04-07 Thread christian . ehrhardt
Hi all, thanks to all the developers, testers and all of the community we have completed another stable release for DPDK 19.11. Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.11.12.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.11 Christian

Re: [PATCH 08/20] net/cnxk: free 'node' memory when node add fail

2022-04-07 Thread Nithin Kumar Dabilpuram
Acked-by: Nithin Dabilpuram On 2/22/22 11:48 PM, Weiguo Li wrote: When node_add failed and function return, then the memory of 'node' is leaked. Fixes: 4435371b8fb1c0 ("net/cnxk: add TM shaper and node operations") Signed-off-by: Weiguo Li --- drivers/net/cnxk/cnxk_tm.c | 1 + 1 file chan

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 February 2022 11.34 > > This patch fixes the rte_mempool_do_generic_put() caching algorithm, > which was fundamentally wrong, causing multiple performance issues when > flushing. > [...] Olivier, Will you please con

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten Brørup wrote: > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Wednesday, 2 February 2022 11.34 > > > > This patch fixes the rte_mempool_do_generic_put() caching algorithm, > > which was fundamentally wrong, causing multiple per

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 7 April 2022 11.14 > > On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten Brørup wrote: > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > Sent: Wednesday, 2 February 2022 11.34 > > > > > > This patch fix

[PATCH] net/bonding: fix rss key configuration when the key length is 52

2022-04-07 Thread Ke Zhang
when creating a bonding device, if the slave device's rss key length is 52, then bonding device will be same as slave, in function bond_ethdev_configure(), the default_rss_key length is 40, it is not matched, so it should calculate a new key for bonding device if the deault key could not be used.

[PATCH] crypto/qat: enable asymmetric crypto on gen4 device

2022-04-07 Thread Arek Kusztal
This commit enables asymmetric crypto in generation four devices (4xxx). Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst| 1 + drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 12 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/guides/

[PATCH 0/3] add partial SGL support to AESNI_MB

2022-04-07 Thread Ciara Power
This patchset adds SGL support for GCM and CHACHA20-POLY1305 algorithms, using the IPSec-MB JOB API. Supported SGL types: - INPLACE SGL - OOP SGL IN, LB OUT - OOP SGL IN, SGL OUT The SGL Feature Flags for AESNI_MB PMD are not added, as it does not yet support SGL for all other algorithms. Cia

[PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb

2022-04-07 Thread Ciara Power
Add SGL support for GCM algorithm through JOB API. This change supports IN-PLACE SGL, OOP SGL IN and LB OUT, and OOP SGL IN and SGL OUT. Feature flags are not added, as the PMD does not yet support SGL for all other algorithms. Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_m

[PATCH 2/3] crypto/ipsec_mb: add chachapoly SGL support to aesni_mb

2022-04-07 Thread Ciara Power
Add SGL support for chacha20_poly1305 algorithm through JOB API. Supports IN-PLACE SGL, OOP SGL IN and LB OUT, and OOP SGL IN and SGL OUT. Feature flags not added, as the PMD does not support SGL for all other algorithms. Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c

[PATCH 3/3] crypto/ipsec_mb: check SGL support for algorithm

2022-04-07 Thread Ciara Power
This patch adds a check when dequeueing ops and processing, SGL support only exists for AES-GCM and CHACHA20_POLY1305 algorithms. If an SGL op for an unsupported algorithm is being processed, submit a NULL job instead. Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 7 +++

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 11:26:53AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 7 April 2022 11.14 > > > > On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten Brørup wrote: > > > > From: Morten Brørup [mailto:m...@smartsharesystems.com

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 11:32:12AM +0100, Bruce Richardson wrote: > On Thu, Apr 07, 2022 at 11:26:53AM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Thursday, 7 April 2022 11.14 > > > > > > On Thu, Apr 07, 2022 at 11:04:53AM +0200, Morten

Re: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-07 Thread Andrew Rybchenko
On 4/2/22 13:41, wenxuanx...@intel.com wrote: From: Xuan Ding Header split consists of splitting a received packet into two separate regions based on the packet content. The split happens after the packet header and before the packet payload. Splitting is usually between the packet header that

Re: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-07 Thread Jerin Jacob
00 0 0 00 0 0 On Tue, Mar 1, 2022 at 11:18 PM Dumitrescu, Cristian wrote: > > HI Jerin, Hi Cristian, > > Thanks for your patch! I think we are making great progress, here are a few > more commen

Re: [PATCH] eal/windows: add missing C++ include guards

2022-04-07 Thread Tyler Retzlaff
On Tue, Apr 05, 2022 at 03:48:58PM +0200, David Marchand wrote: > Add missing 'extern "C"' to file. > > Fixes: 1db72630da0c ("eal/windows: do not expose private facilities") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by: Tyler Retzlaff

RE: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-07 Thread Ori Kam
Hi Jack, > -Original Message- > From: Jack Min > Sent: Thursday, April 7, 2022 8:31 AM > Subject: [RFC 1/2] ethdev: port flags for pre-configuration flow hints > > The data-path focused flow rule management can manage flow rules in more > optimized way then tranditional one by using hits

RE: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-04-07 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 7 April 2022 12.44 > > On Thu, Apr 07, 2022 at 11:32:12AM +0100, Bruce Richardson wrote: > > On Thu, Apr 07, 2022 at 11:26:53AM +0200, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.c

[PATCH] examples/l2fwd-crypto: fix stats refresh rate

2022-04-07 Thread Raja Zidane
TIMER_MILLISECOND is defined as the number of cpu cycles per millisecond, current definition is correct for cores with frequency of 2GHZ, for cores with different frequency, it caused different periods between refresh, (i.e. the definition is about 14ms on ARM cores). The devarg that stated the per

Re: [PATCH v2 0/2] rte_dump_stack: improvements

2022-04-07 Thread David Marchand
On Sat, Feb 12, 2022 at 7:44 PM Stephen Hemminger wrote: > > This is update to earlier RFC. Add some more comments and changes > to have common code for Linux and FreeBSD > > Stephen Hemminger (2): > eal_debug: do not use malloc in rte_dump_stack > eal: common rte_dump_stack for both Linux and

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-07 Thread Jack Min
On 4/7/22 19:27, Ori Kam wrote: Hi Jack, Hey Ori, -Original Message- From: Jack Min Sent: Thursday, April 7, 2022 8:31 AM Subject: [RFC 1/2] ethdev: port flags for pre-configuration flow hints The data-path focused flow rule management can manage flow rules in more optimized way then

Re: [PATCH] eal/windows: set Windows main lcore affinitization

2022-04-07 Thread David Marchand
Hello Tyler, On Wed, Mar 30, 2022 at 11:00 AM Tyler Retzlaff wrote: > > add missing code to affinitize main_lcore from lcore configuration. Nit: Add* > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/windows/eal.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/eal/windows/

RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-07 Thread Dumitrescu, Cristian
> > To summarize we have 4 attributes, Please find below the truth table > 1) Outer VLAN > 2) Outer IP > 3) Inner VLAN > 4) Inner IP > > > Inner IP -Inner VLAN- Outer IP-Outer VLAN > 00 0 0 > - Not valid case > 00 0

Re: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-07 Thread Jerin Jacob
On Sat, Apr 2, 2022 at 4:33 PM wrote: > > From: Xuan Ding > > Header split consists of splitting a received packet into two separate > regions based on the packet content. The split happens after the > packet header and before the packet payload. Splitting is usually between > the packet header t

[RFC PATCH] cryptodev: add diffie hellman verify, change ec enum

2022-04-07 Thread Arek Kusztal
This commit: 1) adds Diffie-Hellman verify operation. 2) splits asym_op_type with dh op_type 3) removes next pointer from asym_xform 4) changes enumeration of elliptic curves Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 36 +--- 1 file changed

[PATCH] cryptodev: add support for 25519 and 448 curves

2022-04-07 Thread Arek Kusztal
This commit adds support for following elliptic curves: 1) Curve25519 2) Curve448 Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Van Haaren, Harry
Hi OVS & DPDK, Maintainers & Community, Top posting overview of discussion as replies to thread become slower: perhaps it is a good time to review and plan for next steps? >From my perspective, it those most vocal in the thread seem to be in favour of >the clean rx/tx split ("defer work"), with

RE: [RFC PATCH] cryptodev: add diffie hellman verify, change ec enum

2022-04-07 Thread Kusztal, ArkadiuszX
Hi, Some explanations below. > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 7, 2022 3:43 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [RFC PATCH] cryptodev: add diffie hellman verify, change ec enum > > This

Re: [PATCH v5] ip_frag: add IPv4 options fragment and test data

2022-04-07 Thread Aaron Conole
Hi, "Ananyev, Konstantin" writes: > Hi Huichao, > > > > In general yes, it is developer responsibility to address any issues with > his/her patches. +1 > In that particular case, looking at the logs, it seems to be some > misconfiguration > > on test-machine not related anyhow to your chan

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Maxime Coquelin
Hi Harry, On 4/7/22 16:04, Van Haaren, Harry wrote: Hi OVS & DPDK, Maintainers & Community, Top posting overview of discussion as replies to thread become slower: perhaps it is a good time to review and plan for next steps? From my perspective, it those most vocal in the thread seem to be in

ethdev: mtr: input color - Discussion

2022-04-07 Thread Jerin Jacob Kollanukkaran
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:India Standard Time BEGIN:STANDARD DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T00 TZOFFSETFROM:+0530 TZOFFSETTO:+0530 END:DAYLIGHT E

[PATCH] crypto/qat: add ecdh key exchange algorithm

2022-04-07 Thread Arek Kusztal
This commit adds Elliptic Curve Diffie-Hellman algorithm to Intel QuickAssist Technology PMD. Signed-off-by: Arek Kusztal --- Depends-on: patch-109409 ("cryptodev: add elliptic curve diffie hellman") drivers/crypto/qat/qat_asym.c | 95 +++ 1 file changed,

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Ilya Maximets
On 4/7/22 16:25, Maxime Coquelin wrote: > Hi Harry, > > On 4/7/22 16:04, Van Haaren, Harry wrote: >> Hi OVS & DPDK, Maintainers & Community, >> >> Top posting overview of discussion as replies to thread become slower: >> perhaps it is a good time to review and plan for next steps? >> >>  From my p

Re: [PATCH v3 1/1] ethdev: mtr: support input color selection

2022-04-07 Thread Jerin Jacob
On Thu, Apr 7, 2022 at 6:55 PM Dumitrescu, Cristian wrote: > > > > > To summarize we have 4 attributes, Please find below the truth table > > 1) Outer VLAN > > 2) Outer IP > > 3) Inner VLAN > > 4) Inner IP > > > > > > Inner IP -Inner VLAN- Outer IP-Outer VLAN > > 00

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Thursday, April 7, 2022 3:40 PM > To: Maxime Coquelin ; Van Haaren, Harry > ; Morten Brørup ; > Richardson, Bruce > Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian > ; Hu, Jiayu ; Ferriter, Cian > ; ovs-...@openvswitch.org; dev@dpdk.or

[dpdk][PATCH 1/2] sched: enable/disable TC OV at runtime

2022-04-07 Thread Marcin Danilewicz
From: Megha Ajmera Added new API to enable or disable TC over subscription for best effort traffic class at subport level. By default TC OV is disabled for subport. Signed-off-by: Megha Ajmera diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index ec74bee939..1d05089d00 100644 --- a

[dpdk][PATCH 2/2] sched: fix to manage TC OV at runtime

2022-04-07 Thread Marcin Danilewicz
Added changes after review and increased throughput. Signed-off-by: Marcin Danilewicz diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 1d05089d00..6e7d81df46 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -155,7 +155,6 @@ struct rte_sched_subport { uint

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Ilya Maximets
On 4/7/22 16:42, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Thursday, April 7, 2022 3:40 PM >> To: Maxime Coquelin ; Van Haaren, Harry >> ; Morten Brørup ; >> Richardson, Bruce >> Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian >> ; Hu, Jiayu ; Ferri

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-07 Thread Stephen Hemminger
On Thu, 7 Apr 2022 13:30:46 +0800 Xiaoyu Min wrote: > * @b EXPERIMENTAL: this API may change without prior notice. > @@ -4972,6 +4983,11 @@ struct rte_flow_port_attr { >* @see RTE_FLOW_ACTION_TYPE_METER >*/ > uint32_t nb_meters; > + /** > + * Port flags. > +

Re: [PATCH v7] eal: fix rte_memcpy strict aliasing/alignment bugs

2022-04-07 Thread David Marchand
On Thu, Mar 10, 2022 at 3:55 PM Ananyev, Konstantin wrote: > > Calls to rte_memcpy for 1 < n < 16 could result in unaligned > > loads/stores, which is undefined behaviour according to the C > > standard, and strict aliasing violations. > > > > The code was changed to use a packed structure that al

[PATCH] crypto/qat: use intel-ipsec-mb for partial hash

2022-04-07 Thread Fan Zhang
Since openssl 3.0 now deprecates the low level API QAT required to perform partial hash operation when creating the session. This patch is to transfer such dependency from openssl to intel-ipsec-mb. Signed-off-by: Fan Zhang --- drivers/common/qat/meson.build | 10 +++ drivers/crypto/qat/q

[PATCH v1 0/5] vhost: support async dequeue data path

2022-04-07 Thread xuan . ding
From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch implements vhost async dequeue data path for split ring. This patch set is a new design and implementation of [2]. S

[PATCH v1 1/5] vhost: prepare sync for descriptor to mbuf refactoring

2022-04-07 Thread xuan . ding
From: Xuan Ding This patch extracts the descriptors to buffers filling from copy_desc_to_mbuf() into a dedicated function. Besides, enqueue and dequeue path are refactored to use the same function sync_fill_seg() for preparing batch elements, which simplies the code without performance degradatio

[PATCH v1 2/5] vhost: prepare async for descriptor to mbuf refactoring

2022-04-07 Thread xuan . ding
From: Xuan Ding This patch refactors vhost async enqueue path and dequeue path to use the same function async_fill_seg() for preparing batch elements, which simplies the code without performance degradation. Signed-off-by: Xuan Ding --- lib/vhost/virtio_net.c | 23 +++ 1 fi

[PATCH v1 3/5] vhost: merge sync and async descriptor to mbuf filling

2022-04-07 Thread xuan . ding
From: Xuan Ding This patches refactors copy_desc_to_mbuf() used by the sync path to support both sync and async descriptor to mbuf filling. Signed-off-by: Xuan Ding --- lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c | 47 -- 2 files changed, 37 in

[PATCH v1 4/5] vhost: support async dequeue for split ring

2022-04-07 Thread xuan . ding
From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, a new API rte_vhost_async_try_dequeue_burst() is introduced. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang --- doc/guides/prog_guide/vhost_lib.rst| 7 + doc/guides/rel_notes/release_22_07.rst

[PATCH v1 5/5] examples/vhost: support async dequeue data path

2022-04-07 Thread xuan . ding
From: Xuan Ding This patch adds the use case for async dequeue API. Vswitch can leverage DMA device to accelerate vhost async dequeue path. Signed-off-by: Wenwu Ma Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding --- doc/guides/sample_app_ug/vhost.rst | 9 +- examples/vhost/main.c

Re: [PATCH v7] eal: fix rte_memcpy strict aliasing/alignment bugs

2022-04-07 Thread David Marchand
On Thu, Apr 7, 2022 at 5:24 PM David Marchand wrote: > > On Thu, Mar 10, 2022 at 3:55 PM Ananyev, Konstantin > wrote: > > > Calls to rte_memcpy for 1 < n < 16 could result in unaligned > > > loads/stores, which is undefined behaviour according to the C > > > standard, and strict aliasing violatio

Re: [PATCH v7] eal: fix rte_memcpy strict aliasing/alignment bugs

2022-04-07 Thread David Marchand
On Thu, Apr 7, 2022 at 5:32 PM David Marchand wrote: > > On Thu, Apr 7, 2022 at 5:24 PM David Marchand > wrote: > > > > On Thu, Mar 10, 2022 at 3:55 PM Ananyev, Konstantin > > wrote: > > > > Calls to rte_memcpy for 1 < n < 16 could result in unaligned > > > > loads/stores, which is undefined be

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Maxime Coquelin
On 4/7/22 17:01, Ilya Maximets wrote: On 4/7/22 16:42, Van Haaren, Harry wrote: -Original Message- From: Ilya Maximets Sent: Thursday, April 7, 2022 3:40 PM To: Maxime Coquelin ; Van Haaren, Harry ; Morten Brørup ; Richardson, Bruce Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Bruce Richardson
On Thu, Apr 07, 2022 at 05:46:32PM +0200, Maxime Coquelin wrote: > > > On 4/7/22 17:01, Ilya Maximets wrote: > > On 4/7/22 16:42, Van Haaren, Harry wrote: > > > > -Original Message- > > > > From: Ilya Maximets > > > > Sent: Thursday, April 7, 2022 3:40 PM > > > > To: Maxime Coquelin ; Va

[dpdk-dev v1] crypto/openssl: openssl 3.0 support on asym crypto routine

2022-04-07 Thread Kai Ji
This patch update the asymmetric RSA and DH routine in crypto openssl pmd to adopt openssl 3.0 EVP library. Signed-off-by: Kai Ji --- drivers/crypto/openssl/compat.h | 43 ++- drivers/crypto/openssl/openssl_pmd_private.h | 11 + drivers/crypto/openssl/rte_openssl_pmd.c | 288 +

[PATCH] cryptodev: add dh verify option

2022-04-07 Thread Arek Kusztal
For some elliptic curves public point in DH exchange needs to be checked, if lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off-by: Arek Kusztal --- Depends-on: patch-109409 ("

[PATCH] crypto/qat: add ec point verify function

2022-04-07 Thread Arek Kusztal
This commit adds elliptic curve point verification to Intel QuickAssist Technology PMD. Signed-off-by: Arek Kusztal --- Depends-on: patch-109436 ("cryptodev: add dh verify option") drivers/common/qat/qat_adf/qat_pke.h | 24 ++ drivers/crypto/qat/qat_asym.c| 64 ++

Re: i40e QinQ Offload w/ NVM 8.40 not working

2022-04-07 Thread Ben Magistro
Hello, We were able to narrow it down to a NVM change between 8.30 (v26.2) and 8.40 (v26.4). The release notes for v26.2 indicate the wrong NVM version. We are trying to reach out to Intel as well to report the issue and get additional assistance. If anyone can assist with that, it would be appr

[PATCH v1 0/4] [RFC] Testpmd RPC API

2022-04-07 Thread ohilyard
From: Owen Hilyard Currently, DTS uses Testpmd for most of its testing. This has been successful in reducing the need to create more test apps, but it has a few drawbacks. First, if some part of DPDK is not exposed via Testpmd or one of the example applications, for the purposes of DTS it

[PATCH v1 4/4] app/test-pmd-api: Implementation files for the API

2022-04-07 Thread ohilyard
From: Owen Hilyard As of right now, this is a fairly direct port. As such, most of the main file from test-acl is present in api_impl.cc. If this proof of concept is going to expand into a usable application, the acl test helper can be moved to another file to help keep the service definition fil

[PATCH v1 1/4] app/test-pmd-api: Add C++ Compiler

2022-04-07 Thread ohilyard
From: Owen Hilyard Adds a C++ compiler to the project, which is currently enabled by default for ease of testing. Meson currently lacks a way to try to get a compiler, and failing to find a compiler for a language always causes a hard error, so this is the only workable approach. Signed-off-by:

[PATCH v1 2/4] app/test-pmd-api: Add POC with gRPC deps

2022-04-07 Thread ohilyard
From: Owen Hilyard The new app is disabled if the dependencies are not present, in order to avoid breaking the build on any system that does not have gRPC installed. The meson file for the app is heavily derived from the testpmd. Signed-off-by: Owen Hilyard --- app/meson.build | 1

[PATCH v1 3/4] app/test-pmd-api: Add protobuf file

2022-04-07 Thread ohilyard
From: Owen Hilyard This file contains the gRPC definitions for the api as it currently stands. Signed-off-by: Owen Hilyard --- app/test-pmd-api/api.proto | 12 1 file changed, 12 insertions(+) create mode 100644 app/test-pmd-api/api.proto diff --git a/app/test-pmd-api/api.proto

Re: [PATCH v2 0/2] rte_dump_stack: improvements

2022-04-07 Thread Stephen Hemminger
On Thu, 7 Apr 2022 14:45:07 +0200 David Marchand wrote: > On Sat, Feb 12, 2022 at 7:44 PM Stephen Hemminger > wrote: > > > > This is update to earlier RFC. Add some more comments and changes > > to have common code for Linux and FreeBSD > > > > Stephen Hemminger (2): > > eal_debug: do not use

[PATCH] examples/kni: add interrupt mode to receive packets

2022-04-07 Thread Tianli Lai
kni application have two main-loop threads that they CPU utilization are up to 100 percent, this two theads are writing thread and reading thread. I thank set interrupt mode at reading thread would reduce this thread CPU utilization. Signed-off-by: Tianli Lai --- examples/kni/main.c | 135 ++

[PATCH v3] examples/kni: add interrupt mode to receive packets

2022-04-07 Thread Tianli Lai
kni application have two main-loop threads that they CPU utilization are up to 100 percent, this two theads are writing thread and reading thread. I thank set interrupt mode at reading thread would reduce this thread CPU utilization. Signed-off-by: Tianli Lai --- examples/kni/main.c | 134 ++

[PATCH v2 0/3] Enable queue rate limit and quanta size configuration

2022-04-07 Thread Wenjun Wu
This patch set adds queue rate limit and quanta size configuration. Quanta size can be changed by driver devarg quanta_size=xxx. Quanta size should be set to the value between 256 and 4096 and be the product of 64. v2: rework virtchnl Wenjun Wu (3): common/iavf: support queue rate limit and qua

[PATCH v2 1/3] common/iavf: support queue rate limit and quanta size configuration

2022-04-07 Thread Wenjun Wu
This patch adds new virtchnl opcodes and structures for rate limit and quanta size configuration, which include: 1. VIRTCHNL_OP_CONFIG_QUEUE_BW, to configure max bandwidth for each VF per queue. 2. VIRTCHNL_OP_CONFIG_QUANTA, to configure quanta size per queue. Signed-off-by: Ting Xu Signed-off-by

[PATCH v2 2/3] net/iavf: support queue rate limit configuration

2022-04-07 Thread Wenjun Wu
This patch adds queue rate limit configuration support. Only max bandwidth is supported. Signed-off-by: Ting Xu Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h | 13 +++ drivers/net/iavf/iavf_tm.c| 190 -- drivers/net/iavf/iavf_vchnl.c | 23

[PATCH v2 3/3] net/iavf: support quanta size configuration

2022-04-07 Thread Wenjun Wu
This patch adds quanta size configuration support. Quanta size should between 256 and 4096, and be a product of 64. Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h| 3 +++ drivers/net/iavf/iavf_ethdev.c | 40 ++ drivers/net/iavf/iavf_vchnl.c | 28 ++

[PATCH v1 0/3] net/iavf: support Rx timestamp on flex descriptor

2022-04-07 Thread Simei Su
[PATCH v1 1/3] add related ops and structure for Rx timestamp in virtual channel. [PATCH v1 2/3] add support for Rx timestamp on flex descriptor in driver. [PATCH v1 3/3] improve performance with Rx timestamp enabled. Simei Su (2): common/iavf: support Rx timestamp in virtual channel net/iavf

[PATCH v1 1/3] common/iavf: support Rx timestamp in virtual channel

2022-04-07 Thread Simei Su
Add new ops and structures to support VF to support Rx timestamp on flex descriptor. "VIRTCHNL_OP_1588_PTP_GET_CAPS" ops is sent by the VF to request PTP capablilities and responded by the PF with capabilities enabled for that VF. "VIRTCHNL_OP_1588_PTP_GET_TIME" ops is sent by the VF to request t

[PATCH v1 2/3] net/iavf: enable Rx timestamp on Flex Descriptor

2022-04-07 Thread Simei Su
Dump Rx timestamp value into dynamic mbuf field by flex descriptor. This feature is turned on by dev config "enable-rx-timestamp". Currently, it's only supported under scalar path. Signed-off-by: Simei Su --- drivers/net/iavf/iavf.h | 5 ++ drivers/net/iavf/iavf_ethdev.c

[PATCH v1 3/3] net/iavf: improve performance of Rx timestamp offload

2022-04-07 Thread Simei Su
From: Wenjun Wu In this patch, We use CPU ticks instead of HW register to determin whether low 32 bits timestamp has turned over. It can avoid requesting register value frequently and improve receving performance. Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h| 1 + drivers/net/

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-07 Thread Jack Min
On 4/7/22 23:04, Stephen Hemminger wrote: On Thu, 7 Apr 2022 13:30:46 +0800 Xiaoyu Min wrote: * @b EXPERIMENTAL: this API may change without prior notice. @@ -4972,6 +4983,11 @@ struct rte_flow_port_attr { * @see RTE_FLOW_ACTION_TYPE_METER */ uint32_t nb_meters; +

[Bug 992] [dpdk 21.11.1-rc1] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag param optimization=1 on Ubuntu20.04 with GCC10.3

2022-04-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=992 Bug ID: 992 Summary: [dpdk 21.11.1-rc1] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag param optimization=1 on Ubuntu20.04 with GCC10.3 Product: DPDK Versi

[RFC] ethdev: datapath-focused meter actions

2022-04-07 Thread Alexander Kozyrev
The introduction of asynchronous flow rules operations allowed users to create/destroy flow rules as part of the datapath without blocking on Flow API and slowing the packet processing down. That applies to every possible action that has no preparation steps. Unfortunately, one notable exception i

[PATCH v3 0/4] Enable queue rate limit and quanta size configuration

2022-04-07 Thread Wenjun Wu
This patch set adds queue rate limit and quanta size configuration. Quanta size can be changed by driver devarg quanta_size=xxx. Quanta size should be set to the value between 256 and 4096 and be the product of 64. v2: rework virtchnl v3: add release note Wenjun Wu (4): common/iavf: support que

[PATCH v3 1/4] common/iavf: support queue rate limit and quanta size configuration

2022-04-07 Thread Wenjun Wu
This patch adds new virtchnl opcodes and structures for rate limit and quanta size configuration, which include: 1. VIRTCHNL_OP_CONFIG_QUEUE_BW, to configure max bandwidth for each VF per queue. 2. VIRTCHNL_OP_CONFIG_QUANTA, to configure quanta size per queue. Signed-off-by: Ting Xu Signed-off-by

[PATCH v3 2/4] net/iavf: support queue rate limit configuration

2022-04-07 Thread Wenjun Wu
This patch adds queue rate limit configuration support. Only max bandwidth is supported. Signed-off-by: Ting Xu Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h | 13 +++ drivers/net/iavf/iavf_tm.c| 190 -- drivers/net/iavf/iavf_vchnl.c | 23

[PATCH v3 3/4] net/iavf: support quanta size configuration

2022-04-07 Thread Wenjun Wu
This patch adds quanta size configuration support. Quanta size should between 256 and 4096, and be a product of 64. Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h| 3 +++ drivers/net/iavf/iavf_ethdev.c | 40 ++ drivers/net/iavf/iavf_vchnl.c | 28 ++

[PATCH v3 4/4] doc: add release notes for 22.07

2022-04-07 Thread Wenjun Wu
Add support for queue rate limit and quanta size configuration Signed-off-by: Wenjun Wu --- doc/guides/rel_notes/release_22_07.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst index 42a5f2d990..f1b4057d70

[PATCH v6 01/10] net/ice/base: fix dead lock issue when getting node from ID type

2022-04-07 Thread Wenjun Wu
The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v6 00/10] Enable ETS-based TX QoS on PF

2022-04-07 Thread Wenjun Wu
This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. v2: fix code style issue. v3: fix uninitialization issue. v4: fix logical issue. v5: fix CI testing issue. Add explicit cast. v6:

[PATCH v6 02/10] net/ice/base: support priority configuration of the exact node

2022-04-07 Thread Wenjun Wu
This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 21 + drivers/net/ice/base/ice_sched.h | 3 +++ 2 files

[PATCH v6 03/10] net/ice/base: support queue BW allocation configuration

2022-04-07 Thread Wenjun Wu
This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v6 04/10] net/ice: support queue bandwidth limit

2022-04-07 Thread Wenjun Wu
From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- drivers/net/ice/ice_ethdev.c | 19 ++ dri

[PATCH v6 05/10] net/ice: support queue group bandwidth limit

2022-04-07 Thread Wenjun Wu
To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v6 06/10] net/ice: support queue priority configuration

2022-04-07 Thread Wenjun Wu
This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v6 07/10] net/ice: support queue weight configuration

2022-04-07 Thread Wenjun Wu
This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 91e420d653..4d7bb9102c 100644 --- a/drivers/net/i

  1   2   >