07/04/2022 07:04, Jerin Jacob: > On Wed, Apr 6, 2022 at 8:26 PM Juraj Linkeš <juraj.lin...@pantheon.tech> > wrote: > > > > These are the basic libraries that other libraries depend on. There's > > also the basic framework functionality related to test execution. > > > > Juraj Linkeš (15): > > dts: merge DTS dep/tclclient.tgz to DPDK > > dts: merge DTS dep/tgen.tgz to DPDK > > dts: merge DTS dts to DPDK > > dts: merge DTS framework/__init__.py to DPDK > > dts: merge DTS framework/asan_test.py to DPDK > > dts: merge DTS framework/checkCase.py to DPDK > > dts: merge DTS framework/dts.py to DPDK > > dts: merge DTS framework/exception.py to DPDK > > dts: merge DTS framework/logger.py to DPDK > > dts: merge DTS framework/packet.py to DPDK > > dts: merge DTS framework/project_dpdk.py to DPDK > > dts: merge DTS framework/serializer.py to DPDK > > dts: merge DTS framework/utils.py to DPDK > > dts: merge DTS main.py to DPDK > > dts: merge DTS version.py to DPDK > > merge->import > > > > > dts/dep/tclclient.tgz | Bin 0 -> 199327 bytes > > dts/dep/tgen.tgz | Bin 0 -> 134392 bytes > > Some top level comments: > - I think, we should not check in binary files.
+1 > - git commit comment should much more than "dts: merge DTS xxxx to DPDK" where > the commit log should have details on check in. +1 > -Add the documentation from the first patch and update the > documentation per patch > based on the content. +1 More comments: - Please don't send so many patches, it looks like spam. - Please let's start small with the very minimal code to run a dummy test. - Split by file does not make sense The process is going to be very long. The techboard said in the past that we must have a very careful review of an import piece by piece. So please be patient. Thank you
