On Thu, Apr 7, 2022 at 3:40 AM Hu, Jiayu <jiayu...@intel.com> wrote: > > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index > > a9edc271aa..158460b7d7 100644 > > --- a/lib/vhost/vhost.h > > +++ b/lib/vhost/vhost.h > > @@ -834,6 +834,7 @@ vhost_need_event(uint16_t event_idx, uint16_t > > new_idx, uint16_t old) > > > > static __rte_always_inline void > > vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq) > > + RTE_EXC_LOCK_REQUIRES(vq->access_lock) > > vhost_vring_call_split() is called in rte_vhost_vring_call() too, but it > doesn't > acquire vq->access_lock before calling vhost_vring_call_split().
I have some issues with sending patches from other people (Mimecast seems to think I try to impersonate them and strip the content of the mail?). You'll notice the series in patchwork starts at patch 2. https://patchwork.dpdk.org/project/dpdk/list/?series=22292&state=* My intent was to have Maxime fix (already in next-virtio: https://git.dpdk.org/next/dpdk-next-virtio/commit/?id=53d8fffcf8e3c89c9785f8ce50db892f2cdfd7c7) in this series. [snip] > > @@ -1955,11 +1957,11 @@ write_back_completed_descs_packed(struct > > vhost_virtqueue *vq, } > > > > static __rte_always_inline uint16_t > > -vhost_poll_enqueue_completed(struct virtio_net *dev, uint16_t queue_id, > > +vhost_poll_enqueue_completed(struct virtio_net *dev, struct > > +vhost_virtqueue *vq, > > struct rte_mbuf **pkts, uint16_t count, int16_t dma_id, > > uint16_t vchan_id) > > + RTE_EXC_LOCK_REQUIRES(vq->access_lock) > > rte_vhost_clear_queue_thread_unsafe() doesn't acquire vq->access_lock. > Will it cause a compiler warning? Mm, probably a rebase/split error on my side when doing rfc v2. On the other hand I don't think we can enable the check at this point of the series in any case (there would be other warnings, at least for rwlocks). I'll double check before sending next revision, thanks for pointing out. -- David Marchand
