https://github.com/jh7370 commented:
Thanks, llvm-readobj aspects look good to me (I don't feel like I can review
the clang side).
https://github.com/llvm/llvm-project/pull/96159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
Author: CarolineConcatto
Date: 2024-07-01T08:23:16+01:00
New Revision: 6859e5a169aa235ac04005aaa86ed5ae11372c4c
URL:
https://github.com/llvm/llvm-project/commit/6859e5a169aa235ac04005aaa86ed5ae11372c4c
DIFF:
https://github.com/llvm/llvm-project/commit/6859e5a169aa235ac04005aaa86ed5ae11372c4c.di
https://github.com/CarolineConcatto closed
https://github.com/llvm/llvm-project/pull/88901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jh7370 approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/91280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
I'd use `std::string_view` as a return value instead of `const char *` as a
more idiomatic C++ in which case you don't need to rename the method to
`c_str()`.
https://github.com/llvm/llvm-project/pull/96921
___
cfe-commits mailing li
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/97058
>From 4a6c4033f7deddcd4094ebde81402960de85bd80 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Fri, 28 Jun 2024 10:13:16 +
Subject: [PATCH] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions
---
clan
kovdan01 wrote:
Would be glad to see feedback on the changes from those who are interested.
https://github.com/llvm/llvm-project/pull/96478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,NagyDonat
,NagyDonat
Message-ID:
In-Reply-To:
steakhal wrote:
This fixed tickets in our backlog. Thanks for pushing for this.
https://github.com/llvm/llvm-project/pull/85791
___
cfe-commits
@@ -0,0 +1,433 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+#include
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +neon
-target-feature +lut -target-feature +bf16 -O3 -emit-llvm -o - %s | FileChec
@@ -545,6 +545,25 @@ let TargetPrefix = "aarch64", IntrProperties = [IntrNoMem]
in {
def int_aarch64_neon_vcmla_rot270 : AdvSIMD_3VectorArg_Intrinsic;
}
+let TargetPrefix = "aarch64" in {
+def int_aarch64_neon_vluti2_lane : DefaultAttrsIntrinsic<[llvm_anyvector_ty],
---
@@ -0,0 +1,433 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+#include
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +neon
-target-feature +lut -target-feature +bf16 -O3 -emit-llvm -o - %s | FileChec
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/96475
>From 97d1b80680112c3fa271501427a18273aed61dbe Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Mon, 24 Jun 2024 10:58:53 +0200
Subject: [PATCH 1/4] [clang] Extend the existing lifetimebound check for
assignments.
kovdan01 wrote:
Would be glad to see feedback on the changes from those who are interested.
https://github.com/llvm/llvm-project/pull/96159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
@@ -964,17 +966,34 @@ static bool
pathOnlyInitializesGslPointer(IndirectLocalPath &Path) {
return false;
}
-void checkExprLifetime(Sema &SemaRef, const InitializedEntity &Entity,
+void checkExprLifetime(Sema &SemaRef, const CheckingEntity &CEntity,
hokein w
kovdan01 wrote:
@MaskRay Would be glad to see your feedback on the changes
https://github.com/llvm/llvm-project/pull/96159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjacek approved this pull request.
https://github.com/llvm/llvm-project/pull/97232
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `mlir-nvidia-gcc7` running
on `mlir-nvidia` while building `clang,llvm` at step 5
"build-check-mlir-build-only".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/116/builds/676
Here is the relevant piec
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/97265
This is exactly as originally landed in #95128,
but now the minimal Z3 version was increased to meet this change in #96682.
https://discourse.llvm.org/t/bump-minimal-z3-requirements-from-4-7-1-to-4-8-9/79664/4
-
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
This is exactly as originally landed in #95128,
but now the minimal Z3 version was increased to meet this change in #96682.
https://discourse.llvm.org/t/bump-minimal-z3-requirements-from-4-
steakhal wrote:
This was already reviewed and approved in the past. The content is identical to
that one.
https://github.com/llvm/llvm-project/pull/97265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/NagyDonat requested changes to this pull request.
Unfortunately this PR is not a full solution, because e.g. the following test
code still triggers the crash (if it is appended to the test file `stream.c`):
```c
struct zerosized {
int foo[0];
};
void fread_zerosized(struc
@@ -545,6 +545,25 @@ let TargetPrefix = "aarch64", IntrProperties = [IntrNoMem]
in {
def int_aarch64_neon_vcmla_rot270 : AdvSIMD_3VectorArg_Intrinsic;
}
+let TargetPrefix = "aarch64" in {
+def int_aarch64_neon_vluti2_lane : DefaultAttrsIntrinsic<[llvm_anyvector_ty],
---
https://github.com/tmatheson-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/96628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea updated
https://github.com/llvm/llvm-project/pull/96628
>From ff4635208e9cd83c6735c95ebf12125ca737029a Mon Sep 17 00:00:00 2001
From: Alexandros Lamprineas
Date: Tue, 25 Jun 2024 00:27:45 +0100
Subject: [PATCH 1/3] [clang][FMV] Do not omit explicit default target_ver
https://github.com/gamesh411 edited
https://github.com/llvm/llvm-project/pull/97034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gamesh411 wrote:
I have tried to ensure no information is lost with this change.
I have cross-checked the history of the checker's HTML files with commits that
introduce checkers and have found that we tend to add checkers only to the RST
files and sometimes miss the fact that there is another
@@ -545,6 +545,25 @@ let TargetPrefix = "aarch64", IntrProperties = [IntrNoMem]
in {
def int_aarch64_neon_vcmla_rot270 : AdvSIMD_3VectorArg_Intrinsic;
}
+let TargetPrefix = "aarch64" in {
+def int_aarch64_neon_vluti2_lane : DefaultAttrsIntrinsic<[llvm_anyvector_ty],
---
https://github.com/momchil-velikov edited
https://github.com/llvm/llvm-project/pull/96883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -545,6 +545,25 @@ let TargetPrefix = "aarch64", IntrProperties = [IntrNoMem]
in {
def int_aarch64_neon_vcmla_rot270 : AdvSIMD_3VectorArg_Intrinsic;
}
+let TargetPrefix = "aarch64" in {
+def int_aarch64_neon_vluti2_lane : DefaultAttrsIntrinsic<[llvm_anyvector_ty],
---
DeinAlptraum wrote:
\*Ping*
@boomanaiden154 @linux4life798 a review/feedback would be appreciated!
https://github.com/llvm/llvm-project/pull/95608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/DominikAdamski closed
https://github.com/llvm/llvm-project/pull/96909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Dominik Adamski
Date: 2024-07-01T11:36:49+02:00
New Revision: 8bb00cb160830ec8f6029c2aae79d3e46b04b99c
URL:
https://github.com/llvm/llvm-project/commit/8bb00cb160830ec8f6029c2aae79d3e46b04b99c
DIFF:
https://github.com/llvm/llvm-project/commit/8bb00cb160830ec8f6029c2aae79d3e46b04b99c.dif
Fznamznon wrote:
Ping.
https://github.com/llvm/llvm-project/pull/91364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-07-01T11:58:56+02:00
New Revision: 7f1d672d70eabe010567fcd8c365d27549736c6d
URL:
https://github.com/llvm/llvm-project/commit/7f1d672d70eabe010567fcd8c365d27549736c6d
DIFF:
https://github.com/llvm/llvm-project/commit/7f1d672d70eabe010567fcd8c365d27549736c6d.diff
LO
Author: Timm Bäder
Date: 2024-07-01T11:59:56+02:00
New Revision: 42fc93d3ffb35ec1ff5c6584e1b15d5118db7311
URL:
https://github.com/llvm/llvm-project/commit/42fc93d3ffb35ec1ff5c6584e1b15d5118db7311
DIFF:
https://github.com/llvm/llvm-project/commit/42fc93d3ffb35ec1ff5c6584e1b15d5118db7311.diff
LO
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/97274
Instead of playing "whack a mole" with places where #embed should be expanded
as comma-separated list, just inject each byte as a token back into the stream,
separated by commas.
>From 4d5008fcf3ac37fa213c8f2
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Instead of playing "whack a mole" with places where #embed should be expanded
as comma-separated list, just inject each byte as a token back into the stream,
separated by commas.
---
Full diff: h
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8bb00cb160830ec8f6029c2aae79d3e46b04b99c
4d5008fcf3ac37fa213c8f2cf42c3cce6369c83d --
a-tarasyuk wrote:
ping
https://github.com/llvm/llvm-project/pull/96228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CarolineConcatto created
https://github.com/llvm/llvm-project/pull/97277
ARM ACLE PR#323[1] adds new modal types for 8-bit floating point intrinsic.
>From the PR#323:
```
ACLE defines the `__fpm8` type, which can be used for the E5M2 and E4M3
8-bit floating-point formats. It
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (CarolineConcatto)
Changes
ARM ACLE PR#323[1] adds new modal types for 8-bit floating point
intrinsic.
>From the PR#323:
```
ACLE defines the `__fpm8` type, which can be used for the E5M2 and E4M3
8-bit floating-point formats
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (CarolineConcatto)
Changes
ARM ACLE PR#323[1] adds new modal types for 8-bit floating point
intrinsic.
>From the PR#323:
```
ACLE defines the `__fpm8` type, which can be used for the E5M2 and E4M3
8-bit floating-point formats. It is
CarolineConcatto wrote:
Just in I don't believe this patch is ready, but I would like to share so I
could get some pointers of what is missing.
I also have question about implementation:
Should we convert to a)unsigned 8 bits correspondent in CodeGenTypes.cpp or
b)should we create another opa
@@ -10,26 +10,6 @@
class TestTokenKind(unittest.TestCase):
-def test_constructor(self):
Endilll wrote:
Can't we keep those tests?
https://github.com/llvm/llvm-project/pull/95608
___
cfe-commits mailing list
cf
https://github.com/DominikAdamski updated
https://github.com/llvm/llvm-project/pull/96742
>From 5b487aac3c8414b6f37f6888f361ca7488094048 Mon Sep 17 00:00:00 2001
From: Dominik Adamski
Date: Fri, 21 Jun 2024 18:03:53 +0200
Subject: [PATCH 1/2] [Flang-new][OpenMP] Add offload related flags for AM
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/96442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm commented:
ping
https://github.com/llvm/llvm-project/pull/96442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,6 +39,7 @@ ENUM_CODEGENOPT(RelocationModel, llvm::Reloc::Model, 3,
llvm::Reloc::PIC_) ///<
ENUM_CODEGENOPT(DebugInfo, llvm::codegenoptions::DebugInfoKind, 4,
llvm::codegenoptions::NoDebugInfo) ///< Level of debug info to generate
ENUM_CODEGENOPT(VecLib, llvm::driver::
@@ -39,6 +39,7 @@ ENUM_CODEGENOPT(RelocationModel, llvm::Reloc::Model, 3,
llvm::Reloc::PIC_) ///<
ENUM_CODEGENOPT(DebugInfo, llvm::codegenoptions::DebugInfoKind, 4,
llvm::codegenoptions::NoDebugInfo) ///< Level of debug info to generate
ENUM_CODEGENOPT(VecLib, llvm::driver::
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Also remove the comment that links to
https://github.com/llvm/llvm-project/issues/94994 and add `Fixes #94994` to the
commit message.
https://github.com/llvm/llvm-project/pull/97071
@@ -10,26 +10,6 @@
class TestTokenKind(unittest.TestCase):
-def test_constructor(self):
DeinAlptraum wrote:
thNot really:
- `test_constructor`: this tests the ability to add enum variants "on the fly",
which is not possible with the Python stdlib's `Enu
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/95608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/95608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From 90cedd519da8b76c686db9c3f824b6d044e16eb6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/6] [analyzer] Check the correct first and la
tmatheson-arm wrote:
Thank you for the example, I understand what is happening how.
- Before #94279, we used to add CPU features in `AArch64::initFeatureMap`.
- In #94279, we decided that actually you should do that in the Driver, which
should put all `-target-features` it wants on the -cc1 com
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test th
alexfh wrote:
It looks like the presence of `static` on template variable specializations
makes difference in the namespace context: https://gcc.godbolt.org/z/b5ns1zhx6
Specifically, the specializations not marked `static` result in an exported
variable. Thus, we have seemingly valid code that
NagyDonat wrote:
> Even protobuf contains this type of code:
> https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=protobuf_v3.13.0_pointersub1&is-unique=on&diff-type=New&checker-name=alpha.core.PointerSub&report-id=5545776&report-hash=1bcd310fbaeccbcc13645b9b277239a2&re
alexfh wrote:
There's more (https://gcc.godbolt.org/z/YKKah8M1n):
```
class D {
template
static constexpr int kMaxUnsignedInt = 2 * kMaxUnsignedInt + 1;
template <>
constexpr auto kMaxUnsignedInt<1> = 1;
};
```
fails to compile with
```
:14:11: error: 'auto' not allowed in non-static class mem
@@ -10,26 +10,6 @@
class TestTokenKind(unittest.TestCase):
-def test_constructor(self):
Endilll wrote:
> test_constructor: this tests the ability to add enum variants "on the fly",
> which is not possible with the Python stdlib's Enum class
Do we have
https://github.com/zmodem commented:
I've read half the patch so far, but wanted to ask before continuing: would it
be possible (and simpler) to extend the /winsysroot support somehow to also
handle --sysroot?
(It would also be easier to review if the unrelated formatting changes were
removed
@@ -1290,6 +1296,9 @@ void ToolChain::AddCXXStdlibLibArgs(const ArgList &Args,
case ToolChain::CST_Libstdcxx:
CmdArgs.push_back("-lstdc++");
break;
+
+ default:
zmodem wrote:
Let's spell out the CST_Stl case explicitly and avoid a default case. That
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/96417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -95,43 +95,52 @@ void visualstudio::Linker::ConstructJob(Compilation &C,
const JobAction &JA,
// the environment variable is set however, assume the user knows what
// they're doing. If the user passes /vctoolsdir or /winsdkdir, trust that
// over env vars.
- if (con
@@ -763,19 +789,36 @@ void MSVCToolChain::AddClangSystemIncludeArgs(const
ArgList &DriverArgs,
// As a fallback, select default install paths.
// FIXME: Don't guess drives and paths like this on Windows.
const StringRef Paths[] = {
-"C:/Program Files/Microsoft Visual
@@ -95,18 +95,21 @@ class ToolChain {
enum CXXStdlibType {
CST_Libcxx,
-CST_Libstdcxx
+CST_Libstdcxx,
+CST_Stl,
zmodem wrote:
Could this be Msvcstl or something? Just Stl seems a pretty generic name.
https://github.com/llvm/llvm-project/pul
DominikAdamski wrote:
Updated PR after: https://github.com/llvm/llvm-project/pull/96909/ .
Scope of changes:
`-fcuda-is-device` is not attached by OpenMP AMD GPU toolchain any more, so we
do not need to accept this flag by Flang-new. This flag remains HIP/CUDA
specific.
- OpenMP AMD GPU toolcha
https://github.com/DominikAdamski edited
https://github.com/llvm/llvm-project/pull/96742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/95411
>From 0ef4b61d0429517b92f7b6de7fa52c516f3a1468 Mon Sep 17 00:00:00 2001
From: David Truby
Date: Thu, 13 Jun 2024 14:01:36 +
Subject: [PATCH 1/4] [flang] Implement -mcmodel flag
This patch implements
https://github.com/DominikAdamski edited
https://github.com/llvm/llvm-project/pull/96742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1d4523505e54415a270d7b13b6e203fc25585c5b
eaad187a5e1372cc34f79f36ca5d28016a94b221 --
AaronBallman wrote:
> We already have `-Wnan-infinity-disabled`, which I think is sufficient on the
> warning side? Haven't checked carefully to see what cases it covers.
Not this one. :-D https://godbolt.org/z/hq8jvse9o But yeah, that may be a good
diagnostic to consider putting this under, b
Author: hdoc
Date: 2024-07-01T08:47:26-04:00
New Revision: 9f04d75b2bd8ba83863db74ebe1a5c08cfc5815c
URL:
https://github.com/llvm/llvm-project/commit/9f04d75b2bd8ba83863db74ebe1a5c08cfc5815c
DIFF:
https://github.com/llvm/llvm-project/commit/9f04d75b2bd8ba83863db74ebe1a5c08cfc5815c.diff
LOG: [Cl
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@hdoc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build, yo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff de68294b4dd31370773cb7a976b2d59e0e8b9bcc
1ba1735702376bfb46b96d819ab141f1c841263a --
smanna12 wrote:
Thank you @ChuanqiXu9 for reviews!
https://github.com/llvm/llvm-project/pull/97221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: smanna12
Date: 2024-07-01T07:50:57-05:00
New Revision: 035e76ff3706ee3e677fbae67cf47a343cf6eceb
URL:
https://github.com/llvm/llvm-project/commit/035e76ff3706ee3e677fbae67cf47a343cf6eceb
DIFF:
https://github.com/llvm/llvm-project/commit/035e76ff3706ee3e677fbae67cf47a343cf6eceb.diff
LOG:
https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/97221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonChesterfield wrote:
This PR is invalid.
First, the alignment on the eight byte pointer is supposed to be four.
Increasing it to 8 makes things worse.
Second, I can't see any support for the claim that the code is incrementing by
the alignment of the value, as opposed to the size.
The fram
Author: MagentaTreehouse
Date: 2024-07-01T14:55:23+02:00
New Revision: a66275090e140b9e800d694ce79b7781636dc849
URL:
https://github.com/llvm/llvm-project/commit/a66275090e140b9e800d694ce79b7781636dc849
DIFF:
https://github.com/llvm/llvm-project/commit/a66275090e140b9e800d694ce79b7781636dc849.di
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/96831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NagyDonat wrote:
_I only noticed that this PR was already merged after posting the review. There
is no need to revert the commit -- it's better than nothing -- but I'd be happy
if you created a followup change that also handles the testcase that I
mentioned._
https://github.com/llvm/llvm-proj
@@ -0,0 +1,77 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -emit-llvm -o - %s | FileCheck
%s
+
+extern void varargs_simple(int, ...);
+
+// CHECK-LABEL: define dso_local vo
@@ -47,6 +47,8 @@
(defined(__cplusplus) && __cplusplus >= 201103L) ||
\
(__STDC_HOSTED__ && defined(_AIX) && defined(_ALL_SOURCE))
#undef DECIMAL_DIG
+#undef INFINITY
AaronBallman wrote:
Good catch, I've corrected this.
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -623,6 +623,8 @@ Improvements to Clang's diagnostics
- Clang no longer emits a "declared here" note for a builtin function that has
no declaration in source.
Fixes #GH93369.
+- Clang now has an improved error message when trying to capture a class
member variable for la
https://github.com/Sirraide commented:
Release note could still be a bit less wordy and should also include the issue
this fixes.
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -942,6 +942,36 @@ struct Amdgpu final : public VariadicABIInfo {
}
};
+struct NVPTX final : public VariadicABIInfo {
+
+ bool enableForTarget() override { return true; }
+
+ bool vaListPassedInSSARegister() override { return true; }
+
+ Type *vaListType(LLVMContext &Ct
Sirraide wrote:
(Also, just so you know, don’t worry too much about merge conflicts in the
release notes; usually, whoever merges the pr can handle those if they’re not
too complicated)
https://github.com/llvm/llvm-project/pull/94865
___
cfe-commits
https://github.com/DominikAdamski updated
https://github.com/llvm/llvm-project/pull/96742
>From 5b487aac3c8414b6f37f6888f361ca7488094048 Mon Sep 17 00:00:00 2001
From: Dominik Adamski
Date: Fri, 21 Jun 2024 18:03:53 +0200
Subject: [PATCH 1/3] [Flang-new][OpenMP] Add offload related flags for AM
@@ -942,6 +942,36 @@ struct Amdgpu final : public VariadicABIInfo {
}
};
+struct NVPTX final : public VariadicABIInfo {
+
+ bool enableForTarget() override { return true; }
+
+ bool vaListPassedInSSARegister() override { return true; }
+
+ Type *vaListType(LLVMContext &Ct
https://github.com/JonChesterfield requested changes to this pull request.
The amdgpu patch is incorrect, see
https://github.com/llvm/llvm-project/pull/96370/
The nvptx lowering looks dubious - values smaller than slot size should be
passed with the same alignment as the slot and presently are
@@ -942,6 +942,36 @@ struct Amdgpu final : public VariadicABIInfo {
}
};
+struct NVPTX final : public VariadicABIInfo {
+
+ bool enableForTarget() override { return true; }
+
+ bool vaListPassedInSSARegister() override { return true; }
+
+ Type *vaListType(LLVMContext &Ct
https://github.com/JonChesterfield requested changes to this pull request.
Patch should not land. Need to know what bug this was trying to address to
guess at what the right fix would be.
https://github.com/llvm/llvm-project/pull/96370
___
cfe-commits
jhuber6 wrote:
> The nvptx lowering looks dubious - values smaller than slot size should be
> passed with the same alignment as the slot and presently aren't. A struct
> containing i8, i16 or half should be miscompiled on nvptx as written.
I mentioned this in the original patch, it's correct a
Sirraide wrote:
> I'm concerned that we're calling EvaluateKnownConstInt on an lvalue; that
> might indicate there's something wrong with the AST. Usually there should be
> an lvalue-to-rvalue cast somewhere.
Yeah, I also remember finding that strange, but after looking into it I figured
it m
Sirraide wrote:
Actually, where are we calling `EvaluateKnownConstInt` here; am I missing
something obvious?
https://github.com/llvm/llvm-project/pull/97146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
arsenm wrote:
> You could theoretically break this if you didn't go through the C ABI and
> ignored type promotion, but I'm not concerned with that kind of misuse since
> it's against the ABI in the first place.
The IR has its own ABI that may or may not match whatever the platform "C ABI'
is
jhuber6 wrote:
> Patch should not land. Need to know what bug this was trying to address to
> guess at what the right fix would be.
My understanding was that the variadics did lowering to a struct with a minimum
alignment of four. This currently *doesn't* do that, hence my confusion. The
curr
1 - 100 of 484 matches
Mail list logo
