[PATCH] D133633: [CMake] Add ClangBootstrap configuration

phosek added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" We usually use lowercase na

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3924002 , @sstwcw wrote: > Can you make `TokenAnnotator::printDebugInfo` print `PPLevel`? @goldstein.w.n can you add it as follows? $ git diff TokenAnnotator.cpp diff --git a/clang/lib/Format/TokenAnnotator.cpp b

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

kadircet updated this revision to Diff 475362. kadircet added a comment. - Drop documentation - Call remove_dots on the common path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137962/new/ https://reviews.llvm.org/D137962 Files: clang/lib/Tooli

[clang] d649452 - [code-owners] Add Vassil as a code owner for clang incremental compilation.

Author: Vassil Vassilev Date: 2022-11-15T08:56:16Z New Revision: d6494524490e0d4ffb99dcf21d633c11108b6bf6 URL: https://github.com/llvm/llvm-project/commit/d6494524490e0d4ffb99dcf21d633c11108b6bf6 DIFF: https://github.com/llvm/llvm-project/commit/d6494524490e0d4ffb99dcf21d633c11108b6bf6.diff LO

[clang] cb2289f - [C++20] [Modules] Attach implicitly declared allocation funcitons to

Author: Chuanqi Xu Date: 2022-11-15T17:21:48+08:00 New Revision: cb2289f39240a0fdccc9a853a02ae9751578a0fd URL: https://github.com/llvm/llvm-project/commit/cb2289f39240a0fdccc9a853a02ae9751578a0fd DIFF: https://github.com/llvm/llvm-project/commit/cb2289f39240a0fdccc9a853a02ae9751578a0fd.diff LO

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. For both ARM and AArch64 add support for specifyi

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff updated this revision to Diff 475370. urazoff added a comment. Added test to show the advantage in AST dump. Missing keywords are added in 'IsUnknownTypedefName', the function is static now. 'DisambiguatingWithExpression' check is added to narrow down the effect of the changes. CHANGES

[clang] ae59131 - [clang][Tooling] Make the filename behaviour consistent

Author: Kadir Cetinkaya Date: 2022-11-15T10:47:52+01:00 New Revision: ae59131d3ef311fb4b1e50627c6457be00e60dc9 URL: https://github.com/llvm/llvm-project/commit/ae59131d3ef311fb4b1e50627c6457be00e60dc9 DIFF: https://github.com/llvm/llvm-project/commit/ae59131d3ef311fb4b1e50627c6457be00e60dc9.dif

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae59131d3ef3: [clang][Tooling] Make the filename behaviour consistent (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:70-76 +AARCH64_ARCH("armv8.9-a", ARMV8_9A, "8.9-A", "v8.9a", + ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8, + (AArch64::AEK_CRC | AArch64::AEK_FP | +

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

tmatheson added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH("armv9-a", ARMV9A, "9-A", "v9a", --

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

rymiel added inline comments. Comment at: clang/include/clang/Format/Format.h:3073-3076 + /// If ``true``, clang-format will attempt to re-flow comments. That is it + /// will touch a comment and *reflow* long comments into new lines, trying to + /// obey the ``ColumnLimit``.

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 475400. sepavloff added a comment. Missed changes in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst clang/include/clang

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2168 +Actions.ActOnOpenMPErrorDirective(Clauses, StartLoc, SourceLocation(), + /*InExcontext = */ false); +break; InExContext ===

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/69993/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137962/new/ https://reviews.llvm.org/D137

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

aykevl updated this revision to Diff 475419. aykevl added a comment. - Fix ArchHas3BytePC to remove arch 107 (of which no chips have more than 128kB flash) - Fix ArchHasELPM/ArchHasELPMX to add arch 102 (it does support elpm even though avr-gcc claims it doesn't). - Add notes where the provided

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

aykevl added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); benshi001 wrote: > benshi001 wrote: > > ATxmega16a4 with family code 102 also supp

[clang] eed1f33 - [clang][Tooling] Sort filenames in test

Author: Kadir Cetinkaya Date: 2022-11-15T13:31:40+01:00 New Revision: eed1f337a1fbf8c1e7e53a6e1d0dfd4eb800aa08 URL: https://github.com/llvm/llvm-project/commit/eed1f337a1fbf8c1e7e53a6e1d0dfd4eb800aa08 DIFF: https://github.com/llvm/llvm-project/commit/eed1f337a1fbf8c1e7e53a6e1d0dfd4eb800aa08.dif

Re: [PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

oops, should be fixed with eed1f337a1fbf8c1e7e53a6e1d0dfd4eb800aa08 On Tue, Nov 15, 2022 at 1:03 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > This breaks tests on windows: http://45.33.8.238/win/69993/step_7.txt > > Please take a look and revert f

[clang] 00b1f7a - Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI

Author: Alex Richardson Date: 2022-11-15T12:42:19Z New Revision: 00b1f7a6ab2aecd2309e2faebde18a11309c6181 URL: https://github.com/llvm/llvm-project/commit/00b1f7a6ab2aecd2309e2faebde18a11309c6181 DIFF: https://github.com/llvm/llvm-project/commit/00b1f7a6ab2aecd2309e2faebde18a11309c6181.diff LO

[PATCH] D135142: Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00b1f7a6ab2a: Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI (authored by arichardson). Repository: rG LLVM Github Monorep

Re: How can Autoconf help with the transition to stricter compilation defaults?

> On 13 Nov 2022, at 00:43, Paul Eggert wrote: > > On 2022-11-11 07:11, Aaron Ballman wrote: >> We believe the runtime behavior is sufficiently dangerous to >> warrant a conservative view that any call to a function will be a call >> that gets executed at runtime, hence a definitive signature m

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Tue, Nov 15, 2022, at 12:03 AM, Sam James wrote: >> On 13 Nov 2022, at 00:43, Paul Eggert wrote: >> >> Although there will be problems with people who run "./configure >> CFLAGS='-Werror'", that sort of usage has always been problematic and >> unsupported by Autoconf, so we can simply contin

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry created this revision. v1nh1shungry added a reviewer: tom-anders. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tool

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc : IdentsToQ

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

ymandel updated this revision to Diff 475440. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137968/new/ https://reviews.llvm.org/D137968 Files: clang-tools-extra/clang-tidy/readability/ConstReturnTypeChe

[PATCH] D137972: [clang-tidy] Optionally ignore findings in macros in `readability-const-return-type`.

ymandel updated this revision to Diff 475441. ymandel added a comment. reorder release notes blurb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137972/new/ https://reviews.llvm.org/D137972 Files: clang-tools-extra/clang-tidy/readability/ConstRe

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3522 - Result.clearFlag(Token::NeedsCleaning); - Result.setIdentifierInfo(nullptr); Was this setting the identifier info to nullptr as a shorthand to clear *any* token data that was pre

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

erichkeane added a comment. I dont really get the logic here, I'm in need of a much better commit message/description here before I can review this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 _

[clang-tools-extra] f3afd16 - [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

Author: Thomas Etter Date: 2022-11-15T14:24:05Z New Revision: f3afd16b65ebda19e417120acf3c3793c171cf5e URL: https://github.com/llvm/llvm-project/commit/f3afd16b65ebda19e417120acf3c3793c171cf5e DIFF: https://github.com/llvm/llvm-project/commit/f3afd16b65ebda19e417120acf3c3793c171cf5e.diff LOG:

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3afd16b65eb: [clang-tidy] Ignore overriden methods in `readability-const-return-type`. (authored by thomasetter, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a49fcca - [clang-tidy] Optionally ignore findings in macros in `readability-const-return-type`.

Author: Thomas Etter Date: 2022-11-15T14:28:03Z New Revision: a49fcca9e3ec9e310312416599405d26c189a81b URL: https://github.com/llvm/llvm-project/commit/a49fcca9e3ec9e310312416599405d26c189a81b DIFF: https://github.com/llvm/llvm-project/commit/a49fcca9e3ec9e310312416599405d26c189a81b.diff LOG:

[PATCH] D137972: [clang-tidy] Optionally ignore findings in macros in `readability-const-return-type`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa49fcca9e3ec: [clang-tidy] Optionally ignore findings in macros in `readability-const-return… (authored by thomasetter, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:3926 +SME_AttributeMask = 255 // We only support maximum 8 bits because of the +// bitmask in FunctionTypeExtraBitfields + }; Comment

[clang] d256377 - [AVR][Clang] Move family names into MCU list

Author: Ayke van Laethem Date: 2022-11-15T15:29:37+01:00 New Revision: d2563775cd6e7b6b26d306ff233349443ef1945c URL: https://github.com/llvm/llvm-project/commit/d2563775cd6e7b6b26d306ff233349443ef1945c DIFF: https://github.com/llvm/llvm-project/commit/d2563775cd6e7b6b26d306ff233349443ef1945c.di

[PATCH] D137520: [AVR][Clang] Move family names into MCU list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2563775cd6e: [AVR][Clang] Move family names into MCU list (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137521: [AVR][Clang] Implement __AVR_ARCH__ macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09ab9d4d111f: [AVR][Clang] Implement __AVR_ARCH__ macro (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 09ab9d4 - [AVR][Clang] Implement __AVR_ARCH__ macro

Author: Ayke van Laethem Date: 2022-11-15T15:29:37+01:00 New Revision: 09ab9d4d111f7ee2c31b7783099ca41f3aab625d URL: https://github.com/llvm/llvm-project/commit/09ab9d4d111f7ee2c31b7783099ca41f3aab625d DIFF: https://github.com/llvm/llvm-project/commit/09ab9d4d111f7ee2c31b7783099ca41f3aab625d.di

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij updated this revision to Diff 475454. stuij added a comment. make work with recent TargetParser changes (D137924 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH

[PATCH] D138031: Add clang-tidy check for missing move constructors

mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM (without testing, just eyeball review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___

[PATCH] D137901: [Clang] `nothrow`-implying attributes should actually manifest `nothrow` attribute (PR58798)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8794 + case ParsedAttr::AT_Pure: +handleSimpleAttribute(S, D, AL); +if (!D->hasAttr()) { First, I'm not a fan of doing this in this list ast all, we shouldn't really have logi

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Mon, 14 Nov 2022 at 18:15, Paul Eggert wrote: > > On 2022-11-14 04:41, Aaron Ballman wrote: > > it's generally a problem when autoconf relies on invalid > > language constructs > > Autoconf *must* rely on invalid language constructs, if only to test > whether the language constructs work. And C

[clang] de034cf - [NFC] Fix the typo and the format in the StandardCPlusPlusModules

Author: Chuanqi Xu Date: 2022-11-15T22:53:43+08:00 New Revision: de034cf3136dfe421189d8627654aad0313cf988 URL: https://github.com/llvm/llvm-project/commit/de034cf3136dfe421189d8627654aad0313cf988 DIFF: https://github.com/llvm/llvm-project/commit/de034cf3136dfe421189d8627654aad0313cf988.diff LO

[PATCH] D138031: Add clang-tidy check for missing move constructors

mbid added inline comments. Comment at: clang/include/clang/Lex/Token.h:101 -return is(K1) || is(K2); - } template bool isOneOf(tok::TokenKind K1, Ts... Ks) const { This change is necessary to make `isOneOf` work with a single argument (and also no argu

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH("armv9-a", ARMV9A, "9-A", "v9a", --

[PATCH] D138035: Fix clang-tidy util findNextTokenSkippingComments

mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The function did not update the Start sou

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel updated this revision to Diff 475468. ymandel added a comment. Rewrite widen-related comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files: clang/include/clang/Analysis/FlowSensitive/D

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel updated this revision to Diff 475469. ymandel marked an inline comment as done. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files: clang/include/clang/Analy

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 475470. v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. Rebase + fix the failure on windows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clan

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:532 + testARMArch("armv9.4-a", "generic", "v9.4a", + ARMBuildAttrs::CPUArch::v8_A)); EXPECT_TRUE( Should this be testing for `ARMBuildAttrs::

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

li.zhe.hua added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:166 + + // The second-choice implementation: `transferBranch` is implemented. No-op. + template I think this is missing a word. Comme

[PATCH] D138031: Add clang-tidy check for missing move constructors

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/missing-move-constructor.rst:6 + +Warns when a class has a copy constructor but not move constructor. + Please synchronize this sentence with Release Notes.

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:100 + /// Contains all non self-contained files during the parsing. + llvm::DenseSet NonSelfContainedFiles; s/during/detected during/ =

[PATCH] D137714: Do not merge traps in functions annotated optnone

delcypher accepted this revision. delcypher added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137714/new/ https://reviews.llvm.org/D137714 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

vaibhav.y updated this revision to Diff 475475. vaibhav.y added a comment. Update FileCheck tests to include now serialized file URIs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135987/new/ https://reviews.llvm.org/D135987 Files: clang/include

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

vaibhav.y added a comment. In D135987#3906253 , @aaron.ballman wrote: > Thank you for this refactoring, I really like the direction it's going! I've > not spotted anything concerning, but if someone can double-check conformance > to SARIF in terms of t

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added a comment. Sorry for not reviewing this sooner. This looks very good overall, but I still have some NITs and a few major comments. For the major points see: - the comment about the filler and the syntactic/semantic form for the newly added expression, - the comment about rel

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel updated this revision to Diff 475478. ymandel marked 2 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files: clang/include/cla

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal created this revision. steakhal added reviewers: xazax.hun, NoQ, martong, ASDenysPetrov, vabridgers, Szelethus. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel marked 3 inline comments as done and 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:68 +/// `LatticeT` can optionally provide the following members: +/// * `bool widen(const LatticeT &Pr

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal updated this revision to Diff 475480. steakhal added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138037/new/ https://reviews.llvm.org/D138037 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij updated this revision to Diff 475489. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475490. jyu2 added a comment. Thanks Alexey for the review. This is address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2168 +Actions.ActOnOpenMPErrorDirective(Clauses, StartLoc, SourceLocation(), + /*InExcontext = */ false); +break; ABataev wrote: > InExContext Sor

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam added a comment. In D136283#3911832 , @sammccall wrote: > I don't think we should add significant build-system complexity here in order > to support the completion model on ppc32. > Do people actually use clangd on ppc32 machines? (The linked

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

erichkeane added a comment. T Comment at: clang/lib/Sema/SemaExpr.cpp:2671 // Check whether this might be a C++ implicit instance member access. // C++ [class.mfct.non-static]p3: So what I was asking above: You're making a ton of changes to this section

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:103 + bool hasSubstitutionFailureInArgs() const { +return ArgsHasSubstitutionFailure; usaxena95 wrote: > erichkeane wrote: > > Does this really belong here instead of as a

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

rsundahl updated this revision to Diff 475497. rsundahl added a comment. Removed extraneous blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137992/new/ https://reviews.llvm.org/D137992 Files: clang/lib/Driver/SanitizerArgs.cpp Index:

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. @vitalybuka @rjmccall thank you for taking a look! Since posting this, there has been a conversation in `#llvm` with @jyknight, where it was established that the situation is even worse than i though. Essentially, there are two situations: 1. exception escape out of no

[PATCH] D137901: [Clang] `nothrow`-implying attributes should actually manifest `nothrow` attribute (PR58798)

lebedev.ri abandoned this revision. lebedev.ri added a comment. Actually, apparently those attributes really do introduce UB, so it is correct that they do not cause program termination. https://reviews.llvm.org/D137381#3927923 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

mikerice added a comment. In D137570#3921879 , @erichkeane wrote: > I haven't dealt much with the loop hint attributes, but two of my coworkers > have done extensive work in our downstream (@jyu2 and @mikerice), and likely > have feedback about how thi

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

jyu2 added a comment. It is okay with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added a comment. Mostly looks good. Is this expected to work with Clang modules at all? Comment at: clang/include/clang/Driver/Driver.h:240 + unsigned CCPrintHeadersJson : 1; + Please document this. Comment at: clang/include/c

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:114 bool isEqualTypeErased(const TypeErasedLattice &E1, const TypeErasedLattice &E2) final { const Lattice &L1 = llvm::any_cast(E1.Value);

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

ldionne created this revision. ldionne added a reviewer: Mordante. Herald added a subscriber: arichardson. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: li

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 475505. Amir added a comment. s/clang_Bootstrap_Add/clang_bootstrap_add Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modul

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" ---

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > We seem to be missing all of the modules-storage code for these. Since

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) && D

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

erichkeane added a comment. I also don't see anything in this with how it works with function pointer conversions, how it affects template instantiation, overload resolution/etc. If this is a type attribute, we need to specify all of that, probably in a separate document, since this is such a

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

ymandel added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:249-258 Visitor.runOverAnnotated(R"cpp( - #define ATTR __attribute__((deprecated("message"))) - $r[[ATTR + $r[[__attribute__((deprecated("message"))) int x;]])cpp");

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

aaron.ballman added reviewers: erichkeane, elizabethandrews. aaron.ballman added a comment. Adding some additional reviewers for more awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 ___

[PATCH] D138031: Add clang-tidy check for missing move constructors

njames93 added a comment. What is the purpose of this check when we have cppcoreguidelines-special-member-functions . Granted that check won't emit replacements, however the replacements that this

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:249-258 Visitor.runOverAnnotated(R"cpp( - #define ATTR __attribute__((deprecated("message"))) - $r[[ATTR + $r[[__attribute__((deprecated("message"))) int x;]])cpp");

[PATCH] D136354: [Driver] Enable nested configuration files

MaskRay accepted this revision. MaskRay added a comment. > To solve such problems, the option --config is allowed inside ... `--config=` Comment at: clang/docs/UsersManual.rst:989 +``linux.opts`` is searched for in the directory ``~/.llvm/os``. Another way to +include a file c

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:1010 + std::error_code makeAbsolute(StringRef WorkingDir, + SmallVectorImpl &Path) const; Should be private IMO Comment a

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

lenary added a comment. I'm going to move this into the newly created `ARMTargetParserCommon` files which @tmatheson created in https://reviews.llvm.org/D137924 (which has landed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137835/new/ https://

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

tom-anders added a comment. LGTM, but I'll give @kadircet a chance to review as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 ___ cfe-commits mailing lis

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

tahonermann added a comment. @rjmccall, could you please take a look at the updated changes? I think I've addressed the issues you raised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. IncludeFixer uses this BuildDir stri

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman added a comment. LMK of the best way to add a test for this, maybe I can somehow make a test with relative path arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047 ___

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137760/new/ https://reviews.llvm.org/D137760 _

[PATCH] D137897: Extend the number of case Sema::CheckForIntOverflow covers

shafik updated this revision to Diff 475528. shafik added a comment. Add Release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137897/new/ https://reviews.llvm.org/D137897 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/Sema/integer-overflow.cp

[clang] ea5be25 - [AVR] Fix use-of-uninitialized-value after D137520

Author: Fangrui Song Date: 2022-11-15T11:06:18-08:00 New Revision: ea5be2571dc95edb8ee04d966addd6b58bfe7b85 URL: https://github.com/llvm/llvm-project/commit/ea5be2571dc95edb8ee04d966addd6b58bfe7b85 DIFF: https://github.com/llvm/llvm-project/commit/ea5be2571dc95edb8ee04d966addd6b58bfe7b85.diff

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 475530. compnerd added a comment. Add unsupported test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Pars

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

vitalybuka added a subscriber: kstoimenov. vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1256 if (AsanOutlineInstrumentation) { CmdArgs.push_back("-mllvm"); CC @kstoimenov it's maybe not the best name for flag, but t

  1   2   3   >