erichkeane added a comment. I also don't see anything in this with how it works with function pointer conversions, how it affects template instantiation, overload resolution/etc. If this is a type attribute, we need to specify all of that, probably in a separate document, since this is such a change to all those things.
================ Comment at: clang/include/clang/AST/Type.h:3940 + /// on declarations and function pointers. + unsigned AArch64SMEAttributes : 8; + ---------------- sdesmalen wrote: > erichkeane wrote: > > We seem to be missing all of the modules-storage code for these. Since > > this is modifying the AST, we need to increment the 'breaking change' AST > > code, plus add this to the ASTWriter/ASTReader interface. > > Since this is modifying the AST, we need to increment the 'breaking change' > > AST code > Could you give me some pointers on what you expect to see changed here? I > understand your point about adding this to the ASTWriter/Reader interfaces > for module-storage, but it's not entirely clear what you mean by "increment > the breaking change AST code". > > I see there is also an ASTImporter, I guess this different from the ASTReader? > > Please apologise my ignorance here, I'm not as familiar with the Clang > codebase. See VersionMajor here: https://clang.llvm.org/doxygen/ASTBitCodes_8h_source.html Yes, ASTReader/ASTWriter and ASTImporter are different unfortunately. I'm not completely sure of the difference, but doing this patch changing the type here without doing those will break modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.llvm.org/D127762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
