[clang-tools-extra] b7d6640 - [NFC][clang-tidy] Move recently newly-added tests into checkers/ subdir

Author: Roman Lebedev Date: 2020-02-14T11:25:05+03:00 New Revision: b7d6640ba9812ec74a0f86ae7bc9850332f5fd2b URL: https://github.com/llvm/llvm-project/commit/b7d6640ba9812ec74a0f86ae7bc9850332f5fd2b DIFF: https://github.com/llvm/llvm-project/commit/b7d6640ba9812ec74a0f86ae7bc9850332f5fd2b.diff

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; --

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

balazske updated this revision to Diff 244582. balazske added a comment. Added to the generic tests (and removed one redundant test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74554/new/ https://reviews.llvm.org/D74554 Files: clang/lib/AST/A

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2600 + EnumDecl *FoundDef = FoundEnum->getDefinition(); + if (D->isThisDeclarationADefinition() && FoundDef) +return Importer.MapImpo

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added a comment. I'd still like to see the nits addressed and comments on the tests addressed before approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto added a comment. @richard.barton.arm A new patch will land today with the changes asked by you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951 __

[clang] a82f35e - [OpenMP] Lower taskwait using OpenMP IR Builder

Author: Roger Ferrer Ibanez Date: 2020-02-14T09:53:02Z New Revision: a82f35e17621a036cb726244ee5cb9708545fb93 URL: https://github.com/llvm/llvm-project/commit/a82f35e17621a036cb726244ee5cb9708545fb93 DIFF: https://github.com/llvm/llvm-project/commit/a82f35e17621a036cb726244ee5cb9708545fb93.diff

[PATCH] D69828: [OpenMP] Lower taskwait using OpenMP IR Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82f35e17621: [OpenMP] Lower taskwait using OpenMP IR Builder (authored by rogfer01). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

rsmith added a comment. In D74051#1872856 , @MaskRay wrote: > @rsmith Does `clang/test/utils/` (a new directory) look appropriate to you? That seems fine to me. Following that pattern, I think we should also move: - `test/clang-rename` -> `test/tools/cl

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. In D73904#1874303 , @thakis wrote: > I fixed windows tests in a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 > . > Please watch bots after landing patches next time

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. @aaron.ballman I just noticed this in https://mlir.llvm.org/getting_started/Contributing/ > Note: if you haven’t used Arcanist to send your patch for review, committers > don’t have access to your preferred identity for commit messages. Make sure > to communicate it to

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 244601. njames93 added a comment. - Small refactor of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-extra/clang-tidy/bugprone/ReservedIdent

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

kbobyrev accepted this revision. kbobyrev added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size()));

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

sdesmalen added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-index.ll:35 +; CHECK-NEXT: ret + %out = call @llvm.aarch64.sve.index.nxv2i64(i64 -14, i64 15) + ret %out Is there a reason you're not testing for -16, 15 for all of these i

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

davezarzycki abandoned this revision. davezarzycki added a comment. I'm abandoning this due to lack of time and the problem being more involved than I thought. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74298/new/ https://reviews.llvm.org/D7429

[PATCH] D74602: Fix standalone build interaction with compiler extension

serge-sans-paille created this revision. serge-sans-paille added reviewers: Keruspe, hans, Meinersbur. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. As suggested in https://github.com/llvm/llvm-project/issues/120, don't try to generate the extens

[clang] 2bef1c0 - [OpenMP] Lower taskyield using OpenMP IR Builder

Author: Roger Ferrer Ibanez Date: 2020-02-14T11:35:17Z New Revision: 2bef1c0e5645639bda1807f7df970da97792b0c8 URL: https://github.com/llvm/llvm-project/commit/2bef1c0e5645639bda1807f7df970da97792b0c8 DIFF: https://github.com/llvm/llvm-project/commit/2bef1c0e5645639bda1807f7df970da97792b0c8.diff

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 updated this revision to Diff 244611. rogfer01 added a comment. ChangeLog: - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://reviews.llvm.org/D70799 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/taskyield_codegen.cpp llvm/include

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bef1c0e5645: [OpenMP] Lower taskyield using OpenMP IR Builder (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://revi

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

kmclaughlin updated this revision to Diff 244610. kmclaughlin added a comment. - Changed 'dl' to 'DL' as suggested by @andwar - Updated tests to address @sdesmalen's comment (changed all tests to check min & max immediate values, plus added some tests where the immediate is out of range) CHANG

[clang-tools-extra] c45fb35 - [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

Author: Kadir Cetinkaya Date: 2020-02-14T13:20:34+01:00 New Revision: c45fb35b5e0b45357a9bfae500ec5403545dbc77 URL: https://github.com/llvm/llvm-project/commit/c45fb35b5e0b45357a9bfae500ec5403545dbc77 DIFF: https://github.com/llvm/llvm-project/commit/c45fb35b5e0b45357a9bfae500ec5403545dbc77.dif

[clang-tools-extra] 84240e0 - [clang][Index] Introduce a TemplateParm SymbolKind

Author: Kadir Cetinkaya Date: 2020-02-14T13:20:34+01:00 New Revision: 84240e0db8ab85b56df11e6cee8fef5ac7ee8c33 URL: https://github.com/llvm/llvm-project/commit/84240e0db8ab85b56df11e6cee8fef5ac7ee8c33 DIFF: https://github.com/llvm/llvm-project/commit/84240e0db8ab85b56df11e6cee8fef5ac7ee8c33.dif

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45fb35b5e0b: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet updated this revision to Diff 244619. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 Files: clang-tools-ex

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; hokein wrote: > I think thes

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG84240e0db8ab: [clang][Index] Introduce a TemplateParm SymbolKind (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://re

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kbobyrev updated this revision to Diff 244618. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74555/new/ https://reviews.llvm.org/D74555 Files: clan

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Make it more convinient for the clients to select completion items by providing a set of defa

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto updated this revision to Diff 244635. CarolineConcatto added a comment. - [Clang]Rename flag and update the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951 Files: clang/include/clan

[clang] 9816e72 - [Driver][RISCV] Add RedHat Linux RISC-V triple

Author: Luís Marques Date: 2020-02-14T13:46:26Z New Revision: 9816e726e747d72e0c5ac92aa20e652031a10448 URL: https://github.com/llvm/llvm-project/commit/9816e726e747d72e0c5ac92aa20e652031a10448 DIFF: https://github.com/llvm/llvm-project/commit/9816e726e747d72e0c5ac92aa20e652031a10448.diff LOG:

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG9816e726e747: [Driver][RISCV] Add RedHat Linux RISC-V triple (authored by luismarques). Herald added a subscriber: jrtc27. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D74609: [clangd] Update the CompletionItemKind.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fix some FIXMEs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74609 Files: clang-tools-extra/clan

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, ilya-biryukov, kristof.beyls. Herald added a project: clang. We are missing the default parmeter arguments when IndexFunctionLocals is true. Fixes https://github.com/clangd/cl

[PATCH] D74609: [clangd] Update the CompletionItemKind.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106 + case SK::ConversionFunction: +return CompletionItemKind::Operator; case SK::Variable:

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. Whether or not GCC behaves the way it should behave regarding atomics, this seems like a sensible patch to make things work given the current situation. LGTM. Repository: rG LLVM

[clang-tools-extra] 1d40c41 - [clang-tools-extra] fix the check for if '-latomic' is necessary

Author: Gokturk Yuksek Date: 2020-02-14T14:16:10Z New Revision: 1d40c4150630729a9c1ce5119a8027dac93a5b2d URL: https://github.com/llvm/llvm-project/commit/1d40c4150630729a9c1ce5119a8027dac93a5b2d DIFF: https://github.com/llvm/llvm-project/commit/1d40c4150630729a9c1ce5119a8027dac93a5b2d.diff LOG

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for your patience while I thought about this more. I think the direction makes sense, so this LGTM with some extra test cases. Comment at: clang/test/Se

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d40c4150630: [clang-tools-extra] fix the check for if '-latomic' is necessary (authored by gokturk, committed by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D74591: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74591/new/ https://reviews.llvm.org/D74591 _

[PATCH] D74609: [clangd] Update the CompletionItemKind.

hokein updated this revision to Diff 244646. hokein marked 2 inline comments as done. hokein added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74609/new/ https://reviews.llvm.org/D74609 Files: clang-tools-extra/clang

[clang] 61dd060 - Move update_cc_test_checks.py tests to clang

Author: Alex Richardson Date: 2020-02-14T14:39:55Z New Revision: 61dd0603bd8afeaa0d467d19c1522b5fbcf0104c URL: https://github.com/llvm/llvm-project/commit/61dd0603bd8afeaa0d467d19c1522b5fbcf0104c DIFF: https://github.com/llvm/llvm-project/commit/61dd0603bd8afeaa0d467d19c1522b5fbcf0104c.diff LO

[clang-tools-extra] 74c97ca - [clangd] Add tracer to the rename workflow, NFC

Author: Haojian Wu Date: 2020-02-14T15:39:29+01:00 New Revision: 74c97ca1b4b7d1a7497cebc0c9c91d2764a6f4b4 URL: https://github.com/llvm/llvm-project/commit/74c97ca1b4b7d1a7497cebc0c9c91d2764a6f4b4 DIFF: https://github.com/llvm/llvm-project/commit/74c97ca1b4b7d1a7497cebc0c9c91d2764a6f4b4.diff LO

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c97ca1b4b7: [clangd] Add tracer to the rename workflow, NFC (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74395/new/ https://reviews

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dd0603bd8a: Move update_cc_test_checks.py tests to clang (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D74051?vs=243859&id=244650#toc Repository: rG LLVM Github Monor

[PATCH] D74609: [clangd] Update the CompletionItemKind.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106 + case SK::ConversionFunction: +return CompletionItemKind::Operator; case SK::Variable: kadircet wrote: > I believe `function` still captures the intend better here, a

[clang-tools-extra] 5dc2314 - [clangd] Update the CompletionItemKind.

Author: Haojian Wu Date: 2020-02-14T15:48:30+01:00 New Revision: 5dc2314d5ecf3fe246ee0134f519183844287456 URL: https://github.com/llvm/llvm-project/commit/5dc2314d5ecf3fe246ee0134f519183844287456 DIFF: https://github.com/llvm/llvm-project/commit/5dc2314d5ecf3fe246ee0134f519183844287456.diff LO

[PATCH] D74609: [clangd] Update the CompletionItemKind.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc2314d5ecf: [clangd] Update the CompletionItemKind. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74609/new/ https://reviews.llvm.or

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

thakis added a comment. Fails on windows, looks like line endings: http://45.33.8.238/win/8350/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___ c

[clang-tools-extra] 13700c3 - Revert "[clang-tools-extra] fix the check for if '-latomic' is necessary"

Author: Luís Marques Date: 2020-02-14T15:01:52Z New Revision: 13700c383fdbb172fac281bff6738a62989631c5 URL: https://github.com/llvm/llvm-project/commit/13700c383fdbb172fac281bff6738a62989631c5 DIFF: https://github.com/llvm/llvm-project/commit/13700c383fdbb172fac281bff6738a62989631c5.diff LOG:

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne added a comment. I think this was addressed by https://reviews.llvm.org/D71997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. In D74051#1876291 , @thakis wrote: > Fails on windows, looks like line endings: > http://45.33.8.238/win/8350/step_7.txt Are the other update_test_checks.py and update_llc_test_checks.py tests running on that bot? I would e

[clang] d9049e8 - [clang-scan-deps] Switch to using a ThreadPool

Author: Alexandre Ganea Date: 2020-02-14T10:24:22-05:00 New Revision: d9049e871f309199a3d8fd7d3c0f76c86af9db91 URL: https://github.com/llvm/llvm-project/commit/d9049e871f309199a3d8fd7d3c0f76c86af9db91 DIFF: https://github.com/llvm/llvm-project/commit/d9049e871f309199a3d8fd7d3c0f76c86af9db91.dif

[clang-tools-extra] 8404aeb - [Support] On Windows, ensure hardware_concurrency() extends to all CPU sockets and all NUMA groups

Author: Alexandre Ganea Date: 2020-02-14T10:24:22-05:00 New Revision: 8404aeb56a73ab24f9b295111de3b37a37f0b841 URL: https://github.com/llvm/llvm-project/commit/8404aeb56a73ab24f9b295111de3b37a37f0b841 DIFF: https://github.com/llvm/llvm-project/commit/8404aeb56a73ab24f9b295111de3b37a37f0b841.dif

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. Turns out those scripts use different code to write the updated file. The failure should hopefully be fixed in rGc29310707e9a85e70a226277657cd9d9182a5d04 Repository: rG LLVM Github Monorepo CH

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9049e871f30: [clang-scan-deps] Switch to using a ThreadPool (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

This revision was automatically updated to reflect the committed changes. Closed by commit rG8404aeb56a73: [Support] On Windows, ensure hardware_concurrency() extends to all CPU sockets… (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D71775?vs=237197&id=244664#toc Repo

[clang] 9122b92 - Revert "Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on""

Author: Melanie Blower Date: 2020-02-14T07:32:09-08:00 New Revision: 9122b92f8e046bfeabdc503d978cf098c86f6e49 URL: https://github.com/llvm/llvm-project/commit/9122b92f8e046bfeabdc503d978cf098c86f6e49 DIFF: https://github.com/llvm/llvm-project/commit/9122b92f8e046bfeabdc503d978cf098c86f6e49.diff

RE: [PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

I reverted MaskRay's "reland" since the original patch is causing trouble on PowerPC, check-all is passing on my box. Sorry for the trouble. > -Original Message- > From: Andy Kaylor via Phabricator > Sent: Thursday, February 13, 2020 9:20 PM > To: Blower, Melanie I ; lebedev...@gmail.c

[PATCH] D74615: [Analyzer] Add visitor to track iterator invalidation

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: steakhal, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. To understand the bug report issued by the `I

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 244667. baloghadamsoftware added a comment. Minor update: ignore parentheses and casts when taking the name of the expression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files: clang/lib/S

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Options.SupportsDebugEntryValues) MF.addCall

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:403 +return; + case nonloc::ConcreteIntKind: { + This check works now with concrete int values. We have a known value and a list of ranges with know

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Superseded by [[ https://reviews.llvm.org/D73720 | [Analyzer] Use note tags to track container begin and and changes ]], [[ https://reviews.llvm.org/D74541 | [Analyzer] Use note tags to track iterator increments and

[clang] 597dfb3 - [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

Author: Fangrui Song Date: 2020-02-14T08:06:37-08:00 New Revision: 597dfb3bd56cdb65a89c67775ce348f10af36aa0 URL: https://github.com/llvm/llvm-project/commit/597dfb3bd56cdb65a89c67775ce348f10af36aa0 DIFF: https://github.com/llvm/llvm-project/commit/597dfb3bd56cdb65a89c67775ce348f10af36aa0.diff

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

thakis added a comment. Yep, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. As multiple versions ofthe same Neon intrinsic can be created through the same TableGen definition with the same argument types, the existing 'call' operator is not always able to

[PATCH] D74616: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Some of the '*_laneq' intrinsics defined in arm_neon.td were missing the setting of the 'isLaneQ' attribute. This patch sets the attribute on the re lated definitions, as they will

[PATCH] D74617: [ARM] Keeping sign information on bitcasts for Neon vdot_lane intrinsics

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Sign information was being lost on Neon's vdot_lane intrinsics arguments when bitcasting explicitly to uint32 vector types. This patch introduces a new cast option to allow casting

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added a comment. Probably a better solution can be: For every "case" build a single `SVal` that contains all argument constraints for that case. It is possible using multiple `evalBinOp` calls (with <=, >=, logical or) to build such a condition (or repeated calls to other assume functi

[PATCH] D74591: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG597dfb3bd56c: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74591/new/ https://re

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

sammccall added a comment. The idea is this is an easy option for the user to work-around editors that do client-side filtering badly (everyone lets you add flags). But as mentioned offline, I don't think we actually have an example of an editor this fixes (I think it fixes neither vscode nor co

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. In D74436#1875320 , @mibintc wrote: > @jsji Will your backend tolerate -ffp-contract=on if optimizations are not > disabled, e.g. -O2? We are proposing that the default floating point model > be -ffp-model=precise, and with precise

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added a comment. Still not sure why all the tests are needed here. The first one looks fine, i.e. we test that --fortran-fe= calls to that copy. The second one appears to test the default behaviour with no option, but why does it do it via a different name for clang, why woul

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added inline comments. Comment at: clang/include/clang/Driver/Options.td:268 +def fortran_fe : Separate<["-"], "fortran-fe">, InternalDriverOpt, + HelpText<"Name for native Fortran compiler">; richard.barton.arm wrote: > This is not right. I

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto marked an inline comment as done. CarolineConcatto added inline comments. Comment at: clang/test/Driver/flang/clang-driver-2-frontend01.f90:10 +! RUN: cp %clang %t1 +! RUN: %clang --driver-mode=flang -fortran-fe %basename_t.tmp1 -### %s 2>&1 | FileCheck --check-

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. Thanks for all the comments. It makes sense to keep the warning there before any ptx65 features are added. The warning should also apply to both the CUDA and OpenMP compile paths. As a result, I will pursue to ignore the warning in the build of libomp (i.e. libomp_che

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

miyuki added a comment. I would prefer not to format the Clang test cases to avoid code churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74620/new/ https://reviews.llvm.org/D74620 ___ cfe-commits m

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1876617 , @kkwli0 wrote: > Thanks for all the comments. It makes sense to keep the warning there before > any ptx65 features are added. The warning should also apply to both the CUDA > and OpenMP compile paths. As

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits. Comment at: clang/include/clang/Basic/Attr.td:186-192 +// an OMPTraitInfo object. The structure of an OMPTraitInfo object is a +// tree as defined below: +// +// OMPTraitInfo

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

Anastasia updated this revision to Diff 244691. Anastasia added a comment. Herald added a reviewer: jdoerfert. - Switched to using `CheckAssignmentConstraints` - Duplicated all extensions and warnings as errors for C++ mode - Added `IncompatibleFunctionPointer` CHANGES SINCE LAST ACTION https:

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

Anastasia added a comment. > It looks like there's already some type analysis in > `DiagnoseAssignmentResult` to get a specialized diagnostic for certain cases > of function-pointer assignment. That could probably be easily moved into > `CheckAssignmentConstraints` by just adding a few more

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added a comment. The C diagnostic changes seem like improvements, yeah. The virtue of re-using the same infrastructure across language modes. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880 +ToType, From->getType(), From, Action); +// assert(Diagnosed &&

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not preceded by a prototype}} +// function definition with

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not preceded by a prototype}} +// function definition with

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not preceded by a prototype}} +// function definition wit

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a subscriber: scanon. andrew.w.kaylor added a comment. In D74436#1875320 , @mibintc wrote: > However you are right we don't want the frontend to create FMA when > optimizations are disabled -O0 I've been discussing this with @scano

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert marked 5 inline comments as done. aaronpuchert added a comment. Thanks! Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not pre

[clang] 2f26bc5 - Warn about zero-parameter K&R definitions in -Wstrict-prototypes

Author: Aaron Puchert Date: 2020-02-14T19:25:02+01:00 New Revision: 2f26bc5542705c390bf17af2fdfc31e056147ea9 URL: https://github.com/llvm/llvm-project/commit/2f26bc5542705c390bf17af2fdfc31e056147ea9 DIFF: https://github.com/llvm/llvm-project/commit/2f26bc5542705c390bf17af2fdfc31e056147ea9.diff

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kbobyrev abandoned this revision. kbobyrev added a comment. Okay, makes sense! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74555/new/ https://reviews.llvm.org/D74555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG2f26bc554270: Warn about zero-parameter K&R definitions in -Wstrict-prototypes (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.or

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

rjmccall added a comment. Yeah, I agree with Steve here. The great virtue of `-ffp-contract=on` over the more aggressive modes is that FMA formation is purely local to a single source expression, which means there's really no obstacle to treating it as implementation-guaranteed semantics. Suc

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty created this revision. daltenty added reviewers: stevewan, sfertile, Xiangling_L. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline XCOFF doe

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ https://reviews.llvm.org/D74631 Files: clang/test/CodeGen/xcoff-comdat.cpp llvm/include/llv

[clang] 7053065 - Fix tests after previous commit

Author: Aaron Puchert Date: 2020-02-14T19:41:01+01:00 New Revision: 705306526b5ca7eed2fa28ebf832873cbb5085ec URL: https://github.com/llvm/llvm-project/commit/705306526b5ca7eed2fa28ebf832873cbb5085ec DIFF: https://github.com/llvm/llvm-project/commit/705306526b5ca7eed2fa28ebf832873cbb5085ec.diff

[PATCH] D74572: [WIP][BPF] implement intrinsic function __builtin__btf_type_id()

yonghong-song updated this revision to Diff 244709. yonghong-song edited the summary of this revision. yonghong-song added a comment. Addressing some Alexei's comments: Change comments in clang CGBuiltin.cpp to make it easier to understand. Remove BPFMIPreserveDIType.cpp and fold into existin

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: sfertile wrote: > Xiangling_L wrote: > > sfertile wrote: > > > Here woul

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

tra added a comment. In D74571#1876647 , @jdoerfert wrote: > That sounds like the right approach for OpenMP. We require a minimal CUDA > version, based on what we use internally, but no maximal version if possible > since we don't use new features anyway

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

grokos marked 2 inline comments as done. grokos added a comment. In D74262#1867245 , @ABataev wrote: > Partial linking may lead to some incorrect results with global constructors. > How are you going to handle this? Can you give me an example of what ca

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert added a comment. Just FYI, I had to fix some tests after this in rG705306526b5ca7eed2fa28ebf832873cbb5085ec . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66919/new

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >