mboehme marked an inline comment as done.
mboehme added a comment.
Any more comments here?
https://reviews.llvm.org/D0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmolloy added a comment.
Hi Sjoerd,
These make sense - we currently lack any way to inform the backend of the
user's FP strictness requirements for exceptions and denormals which forces us
to be conservative in the backend build attribute generation.
Your new -fno-exceptions-fp-math appears to
etyurin created this revision.
etyurin added reviewers: yaxunl, bader.
etyurin added subscribers: cfe-commits, Anastasia.
Make is_valid_event overloadable like other built-ins.
https://reviews.llvm.org/D23914
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
etyurin created this revision.
etyurin added reviewers: Anastasia, bader, yaxunl.
etyurin added a subscriber: cfe-commits.
Remove access qualifiers on images in arg info metadata:
* kernel_arg_type
* kernel_arg_base_type
Image access qualifiers are inseparable from type in clang implementation,
vleschuk retitled this revision from "DebugInfo: use llvm::di_flags_t for debug
info flags" to "DebugInfo: use llvm::DIFlagsUnderlying type for debug info
flags".
vleschuk updated the summary for this revision.
vleschuk updated this revision to Diff 69332.
vleschuk added a comment.
Chnaged typed
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: hokein
Date: Fri Aug 26 06:15:38 2016
New Revision: 279814
URL: http://llvm.org/viewvc/llvm-project?rev=279814&view=rev
Log:
[clang-tidy] Some tweaks on header guard checks.
* Implement missing storeOption interfaces.
* Remove unnecessary parameter copy in isHeaderFileExtension.
* Fix doc
djasper added inline comments.
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:29
@@ +28,3 @@
+using namespace llvm;
+using namespace clang;
+using namespace clang::ast_matchers;
Put everything here into the namespace clang and remove "using namespace
cl
hokein added a subscriber: hokein.
hokein accepted this revision.
hokein added a reviewer: hokein.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D23894
___
cfe-
hokein created this revision.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/checks/google-build-namespaces.rst
docs/clang-tidy/c
hokein updated this revision to Diff 69343.
hokein added a comment.
Fix style.
https://reviews.llvm.org/D23918
Files:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst
docs/clang-tidy/checks/google-build-namespaces.rst
docs/clang-tidy/checks/google-readability-n
mayurpandey updated this revision to Diff 69354.
mayurpandey added a comment.
Hi,
Updated the patch to handle the second crash. __builtin_signbit("1") was
crashing. I am not fully sure whether the check : if
(!Ty->isRealFloatingType()) is correct. Please review and let me know whether
it is f
SjoerdMeijer updated this revision to Diff 69367.
SjoerdMeijer added a comment.
Hi James,
Thanks for the review. I got rid of that new option -fexceptions-fp-math and
now use -ftrapping-math for that which indeed was not passed through to CC1.
Cheers.
https://reviews.llvm.org/D23840
Files:
jmolloy added a comment.
Hi Sjoerd,
This still needs a docs patch. I'd also really appreciate someone else to help
sign this off - While it looks fine, I don't commit enough to clang to give the
go-ahead.
Cheers,
James
https://reviews.llvm.org/D23840
_
NoQ added a comment.
Here's some pseudo-code of the way i see it.
// This interface mimics CloneDetector's interface, hence omnipotent but
useless.
class BasicConstraint {
public:
virtual void add(const StmtSequence &S) = 0;
virtual vector findClones() = 0;
};
// This const
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie, rtrieu, friss.
aaron.ballman added a subscriber: cfe-commits.
r267338 improved the diagnostic checking for undefined behavior with
va_start(), but it had some false positives regarding enumerations. The
underly
rengolin added a comment.
Hi James,
Also looks good to me, though it need docs (in the same patch).
Is there an LLVM counter part to this patch? Where is this going to be used?
From the fact that trapping-math wasn't passed down, its documentation may be
missing/outdated/wrong, and probably no
SjoerdMeijer updated this revision to Diff 69379.
SjoerdMeijer added a comment.
Sorry, forgot to add the doc patch, but it has been included now.
This will be used in llvm to emit and appropriately set build attributes
ABI_FP_denormal and ABI_FP_exceptions. I am now trying to get a llvm patch
r
Author: hans
Date: Fri Aug 26 10:45:36 2016
New Revision: 279827
URL: http://llvm.org/viewvc/llvm-project?rev=279827&view=rev
Log:
Add support for -fdiagnostics-absolute-paths: printing absolute paths in
diagnostics
Differential Revision: https://reviews.llvm.org/D23816
Added:
cfe/trunk/tes
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D23902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
rmaprath created this revision.
rmaprath added reviewers: mclow.lists, EricWF.
rmaprath added a subscriber: cfe-commits.
`C99` math ops should not be available when compiling in `-std=c++03` mode.
https://reviews.llvm.org/D23926
Files:
include/math.h
test/std/depr/depr.c.headers/math_h.pass.
dnovillo added a comment.
In https://reviews.llvm.org/D23284#526389, @anemet wrote:
> @dnovillo or @rsmith, can you please confirm if you agree that this new
> option -Rpass-with-hotness should not be part of R_group. R_group options
> enable/disable groups of remarks whereas this one is only
anemet added a comment.
@dnovillo or @rsmith, can you please confirm if you agree that this new option
-Rpass-with-hotness should not be part of R_group. R_group options
enable/disable groups of remarks whereas this one is only modifying the text of
the remarks. Thanks!
https://reviews.llvm
majnemer added a comment.
This looks much better. Please add a test that uses a template:
template
int f(T t) { return __builtin_signbit(t); }
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7401-7403
@@ -7400,2 +7400,5 @@
+def err_builtin_signbit_wrong_argument :
jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.
LGTM.
Cheers,
James
https://reviews.llvm.org/D23840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
rSerge created this revision.
rSerge added reviewers: dberris, rengolin.
rSerge added a subscriber: cfe-commits.
Herald added subscribers: dberris, samparker, rengolin, aemerson.
Just a test for now, adapted from x86_64 tests of XRay.
https://reviews.llvm.org/D23932
Files:
test/CodeGen/xray-at
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279827: Add support for -fdiagnostics-absolute-paths:
printing absolute paths in… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D23816?vs=69304&id=69384#toc
Repository:
rL LLV
compnerd added inline comments.
Comment at: cmake/config-ix.cmake:18
@@ +17,3 @@
+if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG)
+ list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs)
+ if (LIBCXX_HAS_C_LIB)
Can we not use `CMAKE_SHARED_LINKER_FLAGS` instead of
`CMAKE
On Thu, Aug 25, 2016 at 9:52 PM, Richard Smith wrote:
> On 25 Aug 2016 7:37 p.m., "Bruno Cardoso Lopes"
> wrote:
>
> bruno created this revision.
> bruno added a reviewer: rsmith.
> bruno added subscribers: cfe-commits, eladcohen.
>
> This adds support for modules that require (no-)gnu-inline-asm
bruno updated this revision to Diff 69392.
bruno added a comment.
Update patch after Richard's comment
https://reviews.llvm.org/D23905
Files:
docs/Modules.rst
lib/Basic/Module.cpp
lib/Headers/module.modulemap
test/Modules/Inputs/GNUAsm/NeedsGNUInlineAsm.framework/Headers/NeedsGNUInline
compnerd added a subscriber: compnerd.
compnerd closed this revision.
compnerd added a comment.
SVN r279832
Repository:
rL LLVM
https://reviews.llvm.org/D23821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: mren
Date: Fri Aug 26 12:16:46 2016
New Revision: 279838
URL: http://llvm.org/viewvc/llvm-project?rev=279838&view=rev
Log:
Don't diagnose non-modular includes when we are not compiling a module.
This is triggered when we are compiling an implementation of a module,
it has relative include
Eugene.Zelenko added a comment.
General comments:
- I think //default is XYZ// is better then //XYZ by default//.
- There are discrepancies: option represent//ing// and option represent//s//.
I think will be good idea to involve native English speaker in review.
Comment at: d
Author: eugenezelenko
Date: Fri Aug 26 12:46:51 2016
New Revision: 279846
URL: http://llvm.org/viewvc/llvm-project?rev=279846&view=rev
Log:
[Clang-tidy] Fix some checks documentation style.
Differential revision: https://reviews.llvm.org/D23894
Modified:
clang-tools-extra/trunk/docs/clang-ti
alexshap added inline comments.
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:165
@@ +164,3 @@
+return;
+ assert(InitListEx->getNumInits() == NewFieldsOrder.size() &&
+ "Currently only full initialization is supported");
djasper wrote:
> Sa
zaks.anna added a comment.
In https://reviews.llvm.org/D23853#524945, @xazax.hun wrote:
> > Also: I think r270511 is unlikely to be the change that caused this -- that
> > is a change in LLVM's treatment of DebugInfo, which shouldn't affect the
> > analyzer.
>
>
> I think Peter means that, that
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Like https://reviews.llvm.org/D23807, but for execution-charset.
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
If this works without the other two patches, it's reasonably unrelated and
harmless, and should be ok as soon as the other two patches are approved.
Not because it's wrong, just because we
On Friday, August 26, 2016, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> thakis created this revision.
> thakis added a reviewer: hans.
> thakis added a subscriber: cfe-commits.
>
> Like https://reviews.llvm.org/D23807, but for execution-charset.
>
> https://reviews.llvm.org/D
thakis updated this revision to Diff 69415.
thakis added a comment.
;-;
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
===
thakis updated this revision to Diff 69416.
thakis added a comment.
!!
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279838: Don't diagnose non-modular includes when we are not
compiling a module. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23858?vs=69183&id=69397#toc
Repository:
rL LLVM
meikeb added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:4089-4090
@@ +4088,4 @@
+if (BinOp->isAdditiveOp()) {
+ bool LIsInt = BinOp->getLHS()->EvaluateAsInt(LResult, S.Context);
+ bool RIsInt = BinOp->getRHS()->EvaluateAsInt(RResult, S.Context);
+
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279846: [Clang-tidy] Fix some checks documentation style.
(authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D23894?vs=69301&id=69404#toc
Repository:
rL LLVM
https://revi
smeenai added inline comments.
Comment at: cmake/config-ix.cmake:18
@@ +17,3 @@
+if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG)
+ list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs)
+ if (LIBCXX_HAS_C_LIB)
compnerd wrote:
> Can we not use `CMAKE_SHARED_LINKER_FLAGS` i
thakis updated this revision to Diff 69419.
thakis added a comment.
Aaron's right that these are currently called "Microsoft" in the source. I
agree that that's a confusing name and we should probably rename it, but on
second thought that seems unrelated to this change. If y'all agree on a name,
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
This is useful for creating reproducible builds. Defining these via -D triggers
warnings, and can cause bugs (presently, e.g. PR29119). It makes it also
impossible to override __DATE__ and __TI
majnemer added a subscriber: majnemer.
Comment at: lib/Driver/Tools.cpp:5838-5846
@@ -5837,11 +5837,11 @@
StringRef value = inputCharset->getValue();
if (value.lower() != "utf-8")
D.Diag(diag::err_drv_invalid_value) << inputCharset->getAsString(Args)
alexshap marked 2 inline comments as done.
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:202
@@ +201,3 @@
+for (const auto *C : RD->ctors()) {
+ if (C->isImplicit() || C->isDelegatingConstructor())
+continue;
djasper wrote:
> Why are yo
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
majnemer's suggestion sounds good though, and for inputCharset too.
https://reviews.llvm.org/D23938
___
cfe-commits mailing list
cfe-commits@li
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Fri Aug 26 16:11:43 2016
New Revision: 279866
URL: http://llvm.org/viewvc/llvm-project?rev=279866&view=rev
Log:
clang-cl: Accept MSVC 2015's `/execution-charset:utf-8` flag.
Also makes -fexec-charset accept utf-8 case-insensitively.
Like https://reviews.llvm.org/D23807, but for
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
r279866, thanks!
https://reviews.llvm.org/D23938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: nico
Date: Fri Aug 26 16:26:29 2016
New Revision: 279869
URL: http://llvm.org/viewvc/llvm-project?rev=279869&view=rev
Log:
clang-cl: Accept MSVC2015's '/utf-8' flag.
Clang always behaves as if that's passed, so just ignore the flag.
Modified:
cfe/trunk/include/clang/Driver/CLCompatOp
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Clang always assumes that files are utf-8. If an invalidly encoded character is
used in an identifier, clang always errors. If it's used in a character
literal, clang warns Winvalid-source-encodi
Author: rengolin
Date: Fri Aug 26 16:45:39 2016
New Revision: 279871
URL: http://llvm.org/viewvc/llvm-project?rev=279871&view=rev
Log:
[ARM] Adding .arch directives around WMMX unwind code
Some unwind code is purposedly old enough to work on previous architecutres
and they're guaranteed to never
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: nico
Date: Fri Aug 26 16:51:14 2016
New Revision: 279872
URL: http://llvm.org/viewvc/llvm-project?rev=279872&view=rev
Log:
clang-cl: Support MSVC2015's /validate-charset flag.
Clang always assumes that files are utf-8. If an invalidly encoded character is
used in an identifier, clang alwa
thakis closed this revision.
thakis added a comment.
r279872, thanks!
https://reviews.llvm.org/D23945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap marked 4 inline comments as done.
alexshap added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D23279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: include/clang/Basic/IdentifierTable.h:103
@@ -95,1 +102,3 @@
+return getLength() == StrLen-1 &&
+ memcmp(getNameStart(), Str, StrLen-1) == 0;
}
Eugene.Zelenko wrote:
> memcpy result is three state, so
alexshap updated this revision to Diff 69445.
alexshap added a comment.
Address @djasper 's comments.
1. Try to flash out comments for helper functions / various interesting places
in my code
2. More elaborate error-handling
3. Adjust the names of the variables: I -> i, E -> e
4. Minor cleanup &
Eugene.Zelenko added inline comments.
Comment at: include/clang/Basic/IdentifierTable.h:103
@@ -95,1 +102,3 @@
+return getLength() == StrLen-1 &&
+ memcmp(getNameStart(), Str, StrLen-1) == 0;
}
mehdi_amini wrote:
> Eugene.Zelenko wrote:
> > memcpy
alexshap marked 10 inline comments as done.
alexshap added a comment.
I have marked all the inline comments as done, if i need to change/fix smth
else - pls, reopen the corresponding comment or add a new one.
**Current apporach** : correctly create all the necessary replacements
supported by thi
alexshap added a comment.
I've just rerun the tests - they are green.
Repository:
rL LLVM
https://reviews.llvm.org/D23279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets.cpp:1959
@@ -1959,1 +1958,3 @@
+GK_VOLCANIC_ISLANDS,
+GK_ARCTIC_ISLANDS
} GPU;
We're trying to move to more descriptive GPU fami
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:1959
@@ -1959,1 +1958,3 @@
+GK_VOLCANIC_ISLANDS,
+GK_ARCTIC_ISLANDS
} GPU;
tstellarAMD wrote:
> We're trying to move to more descriptive GPU family names, so this should be
> GK_GFX8 inste
bruno updated the summary for this revision.
bruno updated this revision to Diff 69456.
bruno added a comment.
Updated patch and changed approach after Doug's comment.
https://reviews.llvm.org/D23852
Files:
lib/Parse/ParseDecl.cpp
lib/Parse/ParseObjc.cpp
lib/Parse/Parser.cpp
test/SemaOb
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/BoolConversionChecker.cpp:62
@@ +61,3 @@
+ << "' to a plain boolean value: probably a forgotten "
+ << (IsObjC ? "'[boolValue]'" : "'->isTrue()'");
+BR.EmitBasicReport(
- The
Author: hiraditya
Date: Fri Aug 26 21:26:42 2016
New Revision: 279903
URL: http://llvm.org/viewvc/llvm-project?rev=279903&view=rev
Log:
Add attribute noreturn to functions that throw
Reviewers: mclow.lists, EricWF, howard.hinnant, sebpop
Subscribers: cfe-commits
Differential Revision: https://re
hiraditya closed this revision.
hiraditya added a comment.
commit fdb4f1713ece3c6f7fbf98f3ea3f8c19fa0c249e
Author: Aditya Kumar
Date: Thu Aug 25 11:52:38 2016 +
Remove trailing WS [NFC]
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@279731
91177308-0d34-0410-b5e6-96231b
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
OpenCL requires __ENDIAN_LITTLE__ be set for little endian targets.
The default for targets was also apparently big endian, so AMDGPU
was incorrectly reported as big endian. Set this from the triple
so targets don't have another
arsenm updated this revision to Diff 69465.
arsenm added a comment.
Fix typo
https://reviews.llvm.org/D23953
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/TargetInfo.cpp
lib/Basic/Targets.cpp
lib/Frontend/InitPreprocessor.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init
EricWF added a comment.
We already provide many C++11 extensions in C++03 mode, why should this be an
exception?
https://reviews.llvm.org/D23926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
75 matches
Mail list logo
