alexshap added inline comments. ================ Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:165 @@ +164,3 @@ + return; + assert(InitListEx->getNumInits() == NewFieldsOrder.size() && + "Currently only full initialization is supported"); ---------------- djasper wrote: > Same here, an assert is insufficient. here and above - you are right - i had FIXMEs in the previous versions regarding error-handling. I am aware of these issues, but wanted to postpone fixing them. Anyway - i agree with you - will update this diff today.
Repository: rL LLVM https://reviews.llvm.org/D23279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
