Follow-up Comment #2, task #16593 (group administration): Hello, Thank you for starting to review my work! While I was submitting the project, I forgot to mention some things correctly (you probably already knew about most of these, but this is just for clarification): * The mod also depends on NodeCore (Expat) (git: https://gitlab.com/sztest/nodecore.git, wiki: https://nodecore.mine.nu/) * The README has on top an advertisement for FSF's ESP campaign, which is noncommercial, so it is ok. * The README also has, in the #Licensing section, a notice about patents and other rights infringement, and how to report it. I added it because I heard of the danger of software patents (as you could already guess from the ESP ad), I think it should be ok to keep. * This mod is written in Lua, as every other Minetest/Luanti mod.
Also, I didn't realize that there's the (hidden) file .luacheckrc in the mod for luacheck (a program to check lua syntax) configuration, which doesn't have a correct licensing notice. It is based on https://rubenwardy.com/minetest_modding_book/en/quality/luacheck.html, which is licensed under CC-BY-SA-3.0/4.0 (Their repo has CC-BY-SA-3.0 as the license in the README, while the LICENSE file has the 4.0 text, so I'm not sure which one https://gitlab.com/rubenwardy/minetest_modding_book.git but it should be 3.0). I think I'll remove the file from the repo, so others can introduce their config instead. While you're still checking my mod, please remove .luacheckrc. Thank you! _______________________________________________________ Reply to this item at: <https://savannah.nongnu.org/task/?16593> _______________________________________________ Message sent via Savannah https://savannah.nongnu.org/
signature.asc
Description: PGP signature
