> > If all tests pass then any further change is either trivial (pretty much > by definition), or there is something so seriously foobared that the entire > ticket needs to be rethought (e.g. no testing). >
<grumpy>That's complete garbage and you know it. There are all sorts of things that a reviewer could have missed that doctests don't catch, and yet not all such things are "messed" up beyond recognition. Maybe that's not enough grounds to change anything in this discussion, but there are plenty of examples of this - my favorite is where there is some as-yet untouched file that needs changes because of an untested branch in the code change, and just enough change is needed that no one ends up fixing it (perhaps because the desired behavior is mathematically obscure to said reviewer? time? who knows). So it's fine if people on this thread resolve to keep the "positive review = closed" (your suggestion about the Trac plugin is very reasonable - a lot of us could create the Trac milestone, I don't know how to fix the plugin though). But don't keep on beating straw men to a pulp, or at least let us get out our magical flying monkeys if you're going to do it so we can get in on the action too.</grumpy> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
