Am 2015-05-07 um 10:27 schrieb Jeroen Demeyer: > On 2015-05-07 06:15, Clemens Heuberger wrote: >> Am 2015-05-07 um 03:42 schrieb leif: >>> I might be wrong, but isn't it trivial to check whether the branch of a >>> ticket changed (after you merged it into some preliminary release)? >> >> It is easy to check. But what if it did change? This might lead to an >> infinite >> cycle, as outlined before. > No, please read what I posted before: > > 5. If any of the merged tickets do not correspond to the tested tickets, there > are several actions I could take: > * The change is minor (for example, a typo in the documentation): assume that > buildbot tests still pass and just accept the change. > * The change is major and we want a new release soon: re-open the ticket on > Trac, make a new release without this ticket. > * The change is major but we really want the ticket in this release: keep the > tickets closed and test again on the buildbots. > > The choice between the 3 options above is made by the release manager and only > the third one can potentially lead to an infinite loop.
I do not think I understand your option 2: what do you mean with "re-open" on trac? Assume that a ticket is set to "positive_review" on saturday; the RM tries to merge a ticket on sunday, runs some tests, on monday, somebody finds an issue, sets the ticket to "needs_work", the author fixes it, sets it back to "needs_review", somebody sets it to "positive_review" again. On tuesday, the RM's tests complete, the commits do not match, what does now re-open mean? (That timeline seems to be rare, but we had such a ticket, which triggered this discussion). If "re-open" means that the ticket is simply not merged (because the commits did not match), then the same story might repeat itself one week later (I have no example of this actually happening), but I imagine that theoretically, it could lead to an infinite loop. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
