Again, this is precisely what you should point out during the review process.
But the review process has to end at one point if we ever want to merge a ticket. On Thursday, May 7, 2015 at 9:44:03 AM UTC+2, Nathann Cohen wrote: > > > Sure, in exceptional cases a positive_review / closed ticket needs to be > > unmerged. But that should be the exception, and not part of the normal > flow. > > In particular, just because you aren't finished bikeshedding / > rearranging > > the comments / fixing documentation typos is not enough of a reason; > That > > can all be done in a followup ticket. > > I disagree. Once you let things like this pass by, you end up with > guys who "will fix everything in a later ticket" and never do it. I > often get angry when somebody sets one of my tickets to `needs_work` > because there is a typo in a function that I did not even touch (but > in a *file* I touched), but on the other hand the guys who do this > kind of things accept the same comments on their tickets. And the code > is better as a result. > > Nathann > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
