On 6 Nov., 19:23, Nils Bruin <nbr...@sfu.ca> wrote: > In that case one solution would be to generate a "whitespace > correction patch". This should be scriptable: > - start from baseline version (*) > - apply all patches of a ticket (**) > - find which lines have changed between (*) and (**) > - generate a patch that fixes whitespace problems on those changed > lines and apply on top. > I'm pretty sure hg can do the heavy lifting for this (i.e., finding > which lines etc.)
Well, you can easily create a single patch from all patches of a ticket (to the Sage library), and remove newly introduced whitespace from that. But besides that you lose some commit messages (and probably also authors and reviewers), unless you create some new, cumulative commit message and meta data from all patches*, this doesn't help with "cross- ticket reviewer patches". I.e., you really have to modify previous / deleted (-) and context ( ) lines as well, as mentioned in my previous post. -leif ____ * One could of course just use this single patch to detect *finally* newly introduced whitespace, and create a whitespace-fixing patch from that, to be applied on top of all other, unmodified patches of a ticket. [But still simply rejecting patches with newly introduced trailing whitespace is the easiest solution. :-) ] -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
