On 28 Okt., 01:57, Robert Bradshaw <rober...@math.washington.edu> wrote: > On Thu, Oct 27, 2011 at 3:25 PM, Robert Bradshaw > > Ideally, when you upload a patch it would do a bunch of checks and > > present to you a "fixed" file with the option of downloading it or > > replacing the original file right there.
Obviously. Any idea how hard it is to implement such? [We should probably also reject binary attachments, and/or could even *there* provide a way to upload e.g. spkgs to a different place, just leaving a link to them on the ticket, maybe just like symbolic links work.] > An even better option would be a "submit patch to trac" command, which > could take as set of patches from your queue, clean them up, > optionally run a bunch of tests, and upload them (updating the > description to the current set and any dependencies). Same for this. [Properly updating the patches (in-place) and the description might be difficult if different people attached [previous] patches; you do not always have to update all, and not even all relevant patches of the ticket need to be in the uploader's queue.] I can imagine shell (or Python) scripts doing at least part of this. As mentioned, removing added trailing whitespace from patches is a one- liner. We could also automatically add (to) attachment comments for which repo a patch is, and on which Sage version it is based (and/or *per-patch* cross-ticket dependencies). More important than removing useless whitespace are things the merger script currently checks, such as "proper Mercurial patches" (without garbage, and including e.g. the author). Not to mention commit messages only consisting of "[mq] foo". I don't know how many people use the hg_*() commands from within Sage, but at least there one could already do some sanity checks. Shipping some Mercurial extension(s) in addition wouldn't be bad either of course. -leif -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
