On 26 Okt., 04:30, Keshav Kini <keshav.k...@gmail.com> wrote: > > Although I think checking attachments *before* they get attached is > > quite different. > > No, that's not what I meant. The listener bot would notice that a patch had > been posted, fix it, and then overwrite it by posting to the trac ticket > like a normal user, posting a comment with a diff on the patch to show what > it changed.
In realtime? That would give a nice opportunity for funny race conditions... ;-) I'd really like an unfriendly, annoying "Your attachment has been rejected - read the Sage Developer's Guide and/or the Trac Guidelines for possible reasons." XD > Trac doesn't save overwritten attachments, but the main purpose > of this listener would be to save attachments and comments on disk in a > repo per ticket (to provide better revision history of progress on a > ticket). Nice, but how much disk space would that eat up? While you're at it, auto-comments (with some delay, only if nothing else happens on the ticket) for newly attached files would also be nice, since otherwise one doesn't get a notification, unless the user in addition adds a comment or updates the description. Although maybe that's [meanwhile] configurable. [Still wonder when trac will support concurrent posting.] > Or, it could just post the diff without actually overwriting the > patch, and just call it a recommendation. I'd prefer an ante-mortem solution, which would also avoid unnecessary noise on the ticket. (Mailing the uploader would as mentioned be an alternative, but IMHO less optimal.) -leif -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
