Hi Rob,
On Sat, Mar 19, 2011 at 12:19:45AM -0700, Rob Beezer wrote:
> On Mar 18, 11:56 pm, "Nicolas M. Thiery" <nicolas.thi...@u-psud.fr>
> wrote:
> > > On the subject of pickling I just found out the hard way that the pickle
> > > jar
> > > is no longer tested by default, since trac_10712, which was merged in
> > > 4.6.2
> > > marks the following test in sage_object.pyx long time that tests the
> > > pickle jar.
> >
> > > - sage: print "x"; sage.structure.sage_object.unpickle_all()
> > > + sage: print "x"; sage.structure.sage_object.unpickle_all() # long time
> > > (4s on sage.math, 2011)
>
> I was the reviewer on that ticket. Mea culpa. The review was
> requested on sage-devel, so there was a small amount of public
> warning.
Oops, I should have reformulated my message differently. My point was
not to blame anyone on that change! Just to make sure everybody was ok
with me removing the #long time on unpickle_all.
> I don't think a reversing-patch on this test would be at all
> controversial and certainly others could look at #10712 if they want
> to see if anything else critical was over-looked. cc me on a change
> if you like.
Will do!
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
