On Fri, Mar 18, 2011 at 12:47:41PM -0700, Daniel Bump wrote:
> On the subject of pickling I just found out the hard way that the pickle jar
> is no longer tested by default, since trac_10712, which was merged in 4.6.2
> marks the following test in sage_object.pyx long time that tests the
> pickle jar.
> 
> - sage: print "x"; sage.structure.sage_object.unpickle_all()
> + sage: print "x"; sage.structure.sage_object.unpickle_all()  # long time (4s 
> on sage.math, 2011) 
> 
> Was everyone but me aware that this had been changed?

Ouch, no, I was not aware of that. And this seems a complete no-no to me!

That's one of the fundamental tests that we really want to run even if
they take a bit of time. Otherwise nobody will notice such failures
until late in the development process.

Unless someone expresses a strong counter-feeling by Monday, I'll
post a patch to revert that.

Cheers,
                                Nicolas
--
Nicolas M. ThiƩry "Isil" <nthi...@users.sf.net>
http://Nicolas.Thiery.name/

-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to